)]}'
{"update.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b388ac5ee408a9de595f1f3bbceb0cb08e0c0bd6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    install_require \u003d req.InstallRequirement.from_line(pip)"},{"line_number":99,"context_line":"    if install_require.editable:"},{"line_number":100,"context_line":"        return pip"},{"line_number":101,"context_line":"    elif hasattr(install_require, \"url\") and install_require.url:"},{"line_number":102,"context_line":"        return pip"},{"line_number":103,"context_line":"    elif hasattr(install_require, \"link\") and install_require.link:"},{"line_number":104,"context_line":"        return pip"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_f5fc1c40","line":101,"updated":"2015-04-07 09:36:32.000000000","message":"You may mention that InstallRequirement.url existed in pip \u003c 6.1, and it was replaced with InstallRequirement.link.url.","commit_id":"5a108c7ecdb396fab87c4399b988aafaaaab4fa9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b004121fc4c8da959955192d80263a47c4b60172","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    install_require \u003d req.InstallRequirement.from_line(pip)"},{"line_number":99,"context_line":"    if install_require.editable:"},{"line_number":100,"context_line":"        return pip"},{"line_number":101,"context_line":"    elif hasattr(install_require, \"url\") and install_require.url:"},{"line_number":102,"context_line":"        return pip"},{"line_number":103,"context_line":"    elif hasattr(install_require, \"link\") and install_require.link:"},{"line_number":104,"context_line":"        return pip"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_4487a00f","line":101,"updated":"2015-04-07 08:07:22.000000000","message":"elif getattr(install_require, \"url\", None):","commit_id":"5a108c7ecdb396fab87c4399b988aafaaaab4fa9"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"59653ef6a29928c7c68ea95957e57a4b90bf775a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    install_require \u003d req.InstallRequirement.from_line(pip)"},{"line_number":99,"context_line":"    if install_require.editable:"},{"line_number":100,"context_line":"        return pip"},{"line_number":101,"context_line":"    elif hasattr(install_require, \"url\") and install_require.url:"},{"line_number":102,"context_line":"        return pip"},{"line_number":103,"context_line":"    elif hasattr(install_require, \"link\") and install_require.link:"},{"line_number":104,"context_line":"        return pip"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_4a17a751","line":101,"in_reply_to":"9aa53dc9_2a5fc342","updated":"2015-04-07 09:18:41.000000000","message":"Oh, sorry, didnt see you change hasattr -\u003e getattr.","commit_id":"5a108c7ecdb396fab87c4399b988aafaaaab4fa9"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"9d8336a0a3dddaa4b0f191bf706cffee3073a639","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    install_require \u003d req.InstallRequirement.from_line(pip)"},{"line_number":99,"context_line":"    if install_require.editable:"},{"line_number":100,"context_line":"        return pip"},{"line_number":101,"context_line":"    elif hasattr(install_require, \"url\") and install_require.url:"},{"line_number":102,"context_line":"        return pip"},{"line_number":103,"context_line":"    elif hasattr(install_require, \"link\") and install_require.link:"},{"line_number":104,"context_line":"        return pip"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_2a5fc342","line":101,"in_reply_to":"9aa53dc9_4487a00f","updated":"2015-04-07 09:15:10.000000000","message":"\u003e\u003e\u003e\n \u003e\u003e\u003e hasattr(object(), \"attr\", None)\n Traceback (most recent call last):\n   File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n TypeError: hasattr expected 2 arguments, got 3\n \u003e\u003e\u003e","commit_id":"5a108c7ecdb396fab87c4399b988aafaaaab4fa9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e89af99b791f10a3c81d1d7df3b284c3a5913865","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return pip"},{"line_number":101,"context_line":"    elif hasattr(install_require, \"url\") and install_require.url:"},{"line_number":102,"context_line":"        return pip"},{"line_number":103,"context_line":"    elif hasattr(install_require, \"link\") and install_require.link:"},{"line_number":104,"context_line":"        return pip"},{"line_number":105,"context_line":"    else:"},{"line_number":106,"context_line":"        return install_require.req.key"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_78091c95","line":103,"updated":"2015-04-07 11:41:56.000000000","message":"Bad luck. pip 6.1.1 was just released with an \"url\" property, but the property has a bug. It raises an AttributeError if the link attribute is None.\n\nSo you must test the link attribute *before* testing the url attribute to support pip \u003c 6.1, pip 6.1.0 and pip 6.1.1.","commit_id":"5a108c7ecdb396fab87c4399b988aafaaaab4fa9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b004121fc4c8da959955192d80263a47c4b60172","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return pip"},{"line_number":101,"context_line":"    elif hasattr(install_require, \"url\") and install_require.url:"},{"line_number":102,"context_line":"        return pip"},{"line_number":103,"context_line":"    elif hasattr(install_require, \"link\") and install_require.link:"},{"line_number":104,"context_line":"        return pip"},{"line_number":105,"context_line":"    else:"},{"line_number":106,"context_line":"        return install_require.req.key"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_a48f8c22","line":103,"updated":"2015-04-07 08:07:22.000000000","message":"elfi getattr(install_require, \"link\", None):","commit_id":"5a108c7ecdb396fab87c4399b988aafaaaab4fa9"}]}
