)]}'
{"openstack_requirements/tests/test_update.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"392b782cf464c2f14e1247cf7d088e52479f7d78","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            \"\"\")"},{"line_number":411,"context_line":"        global_reqs \u003d update._parse_reqs(global_content)"},{"line_number":412,"context_line":"        project_reqs \u003d list(update._content_to_reqs(project_content))"},{"line_number":413,"context_line":"        actions, reqs \u003d update._sync_requirements_file("},{"line_number":414,"context_line":"            global_reqs, project_reqs, \u0027f\u0027, False, False, False)"},{"line_number":415,"context_line":"        self.assertEqual(update.Requirements(["},{"line_number":416,"context_line":"            update.Requirement(\u0027foo\u0027, \u0027\u003c2\u0027, \";python_version\u003d\u003d\u00272.7\u0027\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_97fbaf78","line":413,"updated":"2015-06-18 20:15:04.000000000","message":"so, I have to admit, the following style of a bunch of magic unnamed parameters has basically made this code unreviewable for me. It seems to work for other folks, so I won\u0027t -1 it. But I\u0027m hard pressed to feel confident reviewing the code when I have to construct that much state for every review.","commit_id":"8dcf9f3504206c08b5f217bdd0b5809b648d25b0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3291d81dd91d89135e66f5d7c0fe57e04f85368b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        update.main([\u0027--source\u0027, global_env.root, self.project.root], capture)"},{"line_number":46,"context_line":"        reqs \u003d common._file_to_list(self.project.req_file)"},{"line_number":47,"context_line":"        # ensure various updates take"},{"line_number":48,"context_line":"        self.assertIn(\"jsonschema!\u003d1.4.0,\u003c2,\u003e\u003d1.0.0\", reqs)"},{"line_number":49,"context_line":"        self.assertIn(\"python-keystoneclient\u003e\u003d0.4.1\", reqs)"},{"line_number":50,"context_line":"        self.assertIn(\"SQLAlchemy\u003c\u003d0.7.99,\u003e\u003d0.7\", reqs)"},{"line_number":51,"context_line":"        expected \u003d (\u0027Version change for: greenlet, SQLAlchemy, eventlet, PasteDeploy, routes, WebOb, wsgiref, boto, kombu, pycrypto, python-swiftclient, lxml, jsonschema, python-keystoneclient\\n\u0027  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_4b8eb428","line":48,"updated":"2015-06-19 18:19:51.000000000","message":"This feels odd. Is the order of excludes, max, min something the PEP prefers, do you find it more readable, or is it an accident of another change?","commit_id":"91f24223ea3bbb64047964281cf686ba4a9f7b93"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"63fe209868b3e68f1994380e43d81c481d17add8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        update.main([\u0027--source\u0027, global_env.root, self.project.root], capture)"},{"line_number":46,"context_line":"        reqs \u003d common._file_to_list(self.project.req_file)"},{"line_number":47,"context_line":"        # ensure various updates take"},{"line_number":48,"context_line":"        self.assertIn(\"jsonschema!\u003d1.4.0,\u003c2,\u003e\u003d1.0.0\", reqs)"},{"line_number":49,"context_line":"        self.assertIn(\"python-keystoneclient\u003e\u003d0.4.1\", reqs)"},{"line_number":50,"context_line":"        self.assertIn(\"SQLAlchemy\u003c\u003d0.7.99,\u003e\u003d0.7\", reqs)"},{"line_number":51,"context_line":"        expected \u003d (\u0027Version change for: greenlet, SQLAlchemy, eventlet, PasteDeploy, routes, WebOb, wsgiref, boto, kombu, pycrypto, python-swiftclient, lxml, jsonschema, python-keystoneclient\\n\u0027  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_611cf777","line":48,"in_reply_to":"fa32b979_4b8eb428","updated":"2015-06-19 19:24:17.000000000","message":"Its the output from reserialising the parsed specifiers that pkg_resources gives us. We need to use the reserialised form to handle setup.cfg as I mentioned on the list last week. So yeah - its an accident, but we don\u0027t need to change global-requirements, since this is now semantic comparisons, we still only propose on semantic changes.","commit_id":"91f24223ea3bbb64047964281cf686ba4a9f7b93"}]}