)]}'
{"blacklist.txt":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ca96ff03b25f5e80b59531f1d87cee7a7abb3731","unresolved":false,"context_lines":[{"line_number":1,"context_line":"argparse"},{"line_number":2,"context_line":"flake8"},{"line_number":3,"context_line":"hacking"},{"line_number":4,"context_line":"mccabe"}],"source_content_type":"text/plain","patch_set":3,"id":"3a50d1a3_fc2e89f9","line":1,"updated":"2015-07-23 19:48:04.000000000","message":"This should not be blacklisted AFAICT. Could you explain why?","commit_id":"e40bdb95e3b2667b21ef1c0d8bff5d00cafa63b5"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ca96ff03b25f5e80b59531f1d87cee7a7abb3731","unresolved":false,"context_lines":[{"line_number":3,"context_line":"hacking"},{"line_number":4,"context_line":"mccabe"},{"line_number":5,"context_line":"pep8"},{"line_number":6,"context_line":"pip"},{"line_number":7,"context_line":"pyflakes"},{"line_number":8,"context_line":"pylint"},{"line_number":9,"context_line":"pywin32"}],"source_content_type":"text/plain","patch_set":3,"id":"3a50d1a3_9c33c562","line":6,"updated":"2015-07-23 19:48:04.000000000","message":"Nor this: we have been broken by pip changes before, and we use it heavily.","commit_id":"e40bdb95e3b2667b21ef1c0d8bff5d00cafa63b5"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ca96ff03b25f5e80b59531f1d87cee7a7abb3731","unresolved":false,"context_lines":[{"line_number":6,"context_line":"pip"},{"line_number":7,"context_line":"pyflakes"},{"line_number":8,"context_line":"pylint"},{"line_number":9,"context_line":"pywin32"},{"line_number":10,"context_line":"setuptools"},{"line_number":11,"context_line":"wmi"}],"source_content_type":"text/plain","patch_set":3,"id":"3a50d1a3_bc38013f","line":9,"updated":"2015-07-23 19:48:04.000000000","message":"Why is this being blacklisted?","commit_id":"e40bdb95e3b2667b21ef1c0d8bff5d00cafa63b5"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ca96ff03b25f5e80b59531f1d87cee7a7abb3731","unresolved":false,"context_lines":[{"line_number":7,"context_line":"pyflakes"},{"line_number":8,"context_line":"pylint"},{"line_number":9,"context_line":"pywin32"},{"line_number":10,"context_line":"setuptools"},{"line_number":11,"context_line":"wmi"}],"source_content_type":"text/plain","patch_set":3,"id":"3a50d1a3_1c4815cc","line":10,"updated":"2015-07-23 19:48:04.000000000","message":"Definitely want to not blacklist this. Major source of potential trouble.","commit_id":"e40bdb95e3b2667b21ef1c0d8bff5d00cafa63b5"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ca96ff03b25f5e80b59531f1d87cee7a7abb3731","unresolved":false,"context_lines":[{"line_number":8,"context_line":"pylint"},{"line_number":9,"context_line":"pywin32"},{"line_number":10,"context_line":"setuptools"},{"line_number":11,"context_line":"wmi"}],"source_content_type":"text/plain","patch_set":3,"id":"3a50d1a3_5c3e9d2a","line":11,"updated":"2015-07-23 19:48:04.000000000","message":"And this?","commit_id":"e40bdb95e3b2667b21ef1c0d8bff5d00cafa63b5"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e0445b2d8ca241135536820b6dde6d7278f64b21","unresolved":false,"context_lines":[{"line_number":2,"context_line":"hacking"},{"line_number":3,"context_line":"mccabe"},{"line_number":4,"context_line":"pep8"},{"line_number":5,"context_line":"pip"},{"line_number":6,"context_line":"pyflakes"},{"line_number":7,"context_line":"pylint"}],"source_content_type":"text/plain","patch_set":5,"id":"3a50d1a3_fee716aa","line":5,"updated":"2015-07-25 18:20:56.000000000","message":"Is there some way we can not put pip in here? Being insulated against pip changes / downgrades etc seems like a good thing to me.","commit_id":"34d0b1653bf1e1c6516c5fa0f56137f61acc17f6"}],"openstack_requirements/cmds/validate.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"8020b6dfbe8cc7910864c3fe27d13abaccea3733","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027pywin32\u0027,"},{"line_number":81,"context_line":"    ])"},{"line_number":82,"context_line":"    to_be_constrained \u003d ("},{"line_number":83,"context_line":"        set(global_reqs.keys()) - set(blacklist.keys()) - set([\u0027\u0027])"},{"line_number":84,"context_line":"        - unconstrainable"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    constrained \u003d set(upper_constraints.keys()) - set([\u0027\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_f1db004e","line":83,"updated":"2015-07-24 04:51:34.000000000","message":"i don\u0027t like \"- set([\u0027\u0027])\", why we cannot remove all empty lines in the requirement.parse function?","commit_id":"34d0b1653bf1e1c6516c5fa0f56137f61acc17f6"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e0445b2d8ca241135536820b6dde6d7278f64b21","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027pywin32\u0027,"},{"line_number":81,"context_line":"    ])"},{"line_number":82,"context_line":"    to_be_constrained \u003d ("},{"line_number":83,"context_line":"        set(global_reqs.keys()) - set(blacklist.keys()) - set([\u0027\u0027])"},{"line_number":84,"context_line":"        - unconstrainable"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    constrained \u003d set(upper_constraints.keys()) - set([\u0027\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_7ee546a6","line":83,"in_reply_to":"3a50d1a3_f1db004e","updated":"2015-07-25 18:20:56.000000000","message":"\u0027\u0027 is the key, not the line. An empty key means we don\u0027t know the distribution / couldn\u0027t parse it/ its a comment. So this is fine - but equally, putting \u0027\u0027 in unconstrainable might be a bit easier for reading:\n\n \u0027\u0027, # comments and other lines with no distribution","commit_id":"34d0b1653bf1e1c6516c5fa0f56137f61acc17f6"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"f16e88c4351530a8425fa03657f8ed0359b139c6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027pywin32\u0027,"},{"line_number":81,"context_line":"    ])"},{"line_number":82,"context_line":"    to_be_constrained \u003d ("},{"line_number":83,"context_line":"        set(global_reqs.keys()) - set(blacklist.keys()) - set([\u0027\u0027])"},{"line_number":84,"context_line":"        - unconstrainable"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    constrained \u003d set(upper_constraints.keys()) - set([\u0027\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_4a13080e","line":83,"in_reply_to":"3a50d1a3_f1db004e","updated":"2015-07-24 14:11:04.000000000","message":"I\u0027m not 100% certain, but I think the parser retains blank lines so it can reproduce the existing file accurately when changes are made by the edit command (that is, only the line with the requirement/constraint being changed will be different in the output).","commit_id":"34d0b1653bf1e1c6516c5fa0f56137f61acc17f6"}],"openstack_requirements/tests/test_integration.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"f457d350f69e99cecd45b778985807126c6b2f0d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        unconstrained \u003d to_be_constrained - constrained"},{"line_number":111,"context_line":"        for u in sorted(unconstrained):"},{"line_number":112,"context_line":"            print(\u0027%r appears in global-requirements.txt \u0027"},{"line_number":113,"context_line":"                  \u0027but not upper-constraints.txt or blacklist.txt\u0027 % u)"},{"line_number":114,"context_line":"        self.assertEqual(set(), unconstrained)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_blacklist_not_in_constraints(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_dc938dff","line":113,"updated":"2015-07-23 19:50:24.000000000","message":"This will be printed out by the exception anyway, I\u0027m really not comfortable with print() in these tests. It makes local test runs way too noisy.","commit_id":"e40bdb95e3b2667b21ef1c0d8bff5d00cafa63b5"}]}
