)]}'
{"global-requirements.txt":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b48fb1dddaa2b5b50731efdd1d6eea534e66c9e3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"# has it\u0027s own fork of urllib3 but not all distros package that (like RHEL),"},{"line_number":175,"context_line":"# they instead opt to just have their requests package require their urllib3"},{"line_number":176,"context_line":"# package - but the supported versions need to be kept in sync."},{"line_number":177,"context_line":"requests\u003e\u003d2.5.2"},{"line_number":178,"context_line":"requests-aws\u003e\u003d0.1.4    # BSD License (3 clause)"},{"line_number":179,"context_line":"requests-kerberos\u003e\u003d0.6;python_version\u003d\u003d\u00272.7\u0027 # MIT"},{"line_number":180,"context_line":"rfc3986\u003e\u003d0.2.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1a4dcd0f_07707ea3","line":177,"updated":"2015-08-14 19:51:21.000000000","message":"would have to cap requests at 2.7.0 if we\u0027re going to cap urllib3 at 1.10.4. Else a newer version of requests could be used that needs a newer version of urllib3","commit_id":"b0fc5331b64abc7104be9a6070271e9ce4c925cb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ef2dc430961685bf206c20c28fcc4bb8e7e9c84","unresolved":false,"context_lines":[{"line_number":174,"context_line":"# has it\u0027s own fork of urllib3 but not all distros package that (like RHEL),"},{"line_number":175,"context_line":"# they instead opt to just have their requests package require their urllib3"},{"line_number":176,"context_line":"# package - but the supported versions need to be kept in sync."},{"line_number":177,"context_line":"requests\u003e\u003d2.5.2"},{"line_number":178,"context_line":"requests-aws\u003e\u003d0.1.4    # BSD License (3 clause)"},{"line_number":179,"context_line":"requests-kerberos\u003e\u003d0.6;python_version\u003d\u003d\u00272.7\u0027 # MIT"},{"line_number":180,"context_line":"rfc3986\u003e\u003d0.2.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1a4dcd0f_eddbf14d","line":177,"in_reply_to":"1a4dcd0f_07707ea3","updated":"2015-08-14 20:42:09.000000000","message":"Yeah, I thought about that.  We could also pin requests to \u003d\u003d2.7.0 and urllib3\u003d\u003d1.10.4 but that\u0027s not so great either, so capping requests is probably the way to go.  Then if someone needs to raise the cap on requests they also have to think about raising the cap on urllib3.","commit_id":"b0fc5331b64abc7104be9a6070271e9ce4c925cb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9906184794663069824d5d62bff30fcc4b62e6ae","unresolved":false,"context_lines":[{"line_number":181,"context_line":"# has it\u0027s own fork of urllib3 but not all distros package that (like RHEL),"},{"line_number":182,"context_line":"# they instead opt to just have their requests package require their urllib3"},{"line_number":183,"context_line":"# package - but the supported versions need to be kept in sync."},{"line_number":184,"context_line":"requests\u003e\u003d2.5.2,\u003c\u003d2.7.0"},{"line_number":185,"context_line":"requests-aws\u003e\u003d0.1.4    # BSD License (3 clause)"},{"line_number":186,"context_line":"requests-kerberos\u003e\u003d0.6;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 # MIT"},{"line_number":187,"context_line":"rfc3986\u003e\u003d0.2.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"7a2fa921_de37594b","line":184,"updated":"2015-10-08 15:25:02.000000000","message":"Crap this should be \u003c2.8","commit_id":"7e7ca6f9263ad91e412a22482236f30cd2ee9bc5"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"71119af72cec13cc27279513d097626a580f7e54","unresolved":false,"context_lines":[{"line_number":181,"context_line":"# has it\u0027s own fork of urllib3 but not all distros package that (like RHEL),"},{"line_number":182,"context_line":"# they instead opt to just have their requests package require their urllib3"},{"line_number":183,"context_line":"# package - but the supported versions need to be kept in sync."},{"line_number":184,"context_line":"requests\u003e\u003d2.5.2,\u003c2.8.0"},{"line_number":185,"context_line":"requests-aws\u003e\u003d0.1.4    # BSD License (3 clause)"},{"line_number":186,"context_line":"requests-kerberos\u003e\u003d0.6;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 # MIT"},{"line_number":187,"context_line":"rfc3986\u003e\u003d0.2.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"7a2fa921_b594e542","line":184,"updated":"2015-10-08 23:40:07.000000000","message":"This should be !\u003d 2.8.0, not \u003c 2.8.0, since upstream are fixing the regression vs it being a deliberate API break we need time to adjust to.","commit_id":"58ebfe9b4e7c3297170d9a2d94fa170c6f1e85e7"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"71119af72cec13cc27279513d097626a580f7e54","unresolved":false,"context_lines":[{"line_number":209,"context_line":"# NOTE(mriedem): Don\u0027t change supported version ranges for urllib3 without"},{"line_number":210,"context_line":"# first consulting the requests package to see which version of urllib3 it is"},{"line_number":211,"context_line":"# forking from, we should keep those in sync."},{"line_number":212,"context_line":"urllib3\u003e\u003d1.8.3,\u003c\u003d1.10.4"},{"line_number":213,"context_line":"unicodecsv\u003e\u003d0.8.0"},{"line_number":214,"context_line":"warlock\u003e\u003d1.0.1,\u003c2"},{"line_number":215,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 # PSF"}],"source_content_type":"text/plain","patch_set":5,"id":"7a2fa921_d5a8818e","line":212,"updated":"2015-10-08 23:40:07.000000000","message":"So this is unrelated to the 2.8.0 thing. And its complex - its literally only ever a problem when mixing distro packages + pip packages, which doesn\u0027t work - this is only a single special case of how it won\u0027t work.","commit_id":"58ebfe9b4e7c3297170d9a2d94fa170c6f1e85e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6bf3d200569cb48701cf24fcd956baafb1580412","unresolved":false,"context_lines":[{"line_number":209,"context_line":"# NOTE(mriedem): Don\u0027t change supported version ranges for urllib3 without"},{"line_number":210,"context_line":"# first consulting the requests package to see which version of urllib3 it is"},{"line_number":211,"context_line":"# forking from, we should keep those in sync."},{"line_number":212,"context_line":"urllib3\u003e\u003d1.8.3,\u003c\u003d1.10.4"},{"line_number":213,"context_line":"unicodecsv\u003e\u003d0.8.0"},{"line_number":214,"context_line":"warlock\u003e\u003d1.0.1,\u003c2"},{"line_number":215,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 # PSF"}],"source_content_type":"text/plain","patch_set":5,"id":"7a2fa921_d5416164","line":212,"in_reply_to":"7a2fa921_d5a8818e","updated":"2015-10-08 23:58:41.000000000","message":"It\u0027s not unrelated to the first bug in the commit message though.\n\nDo we move the urllib3 cap to upper-constraints then since u-c has requests capped at 2.7.0 and that bundles urllib3 1.10.4:\n\nhttps://github.com/kennethreitz/requests/blob/v2.7.0/requests/packages/urllib3/__init__.py#L7\n\nSo I\u0027d think we also cap urllib3 at 1.10.4 in upper-constraints.","commit_id":"58ebfe9b4e7c3297170d9a2d94fa170c6f1e85e7"}]}
