)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9d05ebade2fa4787feeb85b430fbc145897aff40","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- https://review.openstack.org/#/c/229865/"},{"line_number":51,"context_line":"- https://review.openstack.org/#/c/229887/"},{"line_number":52,"context_line":"- https://review.openstack.org/#/c/229898/"},{"line_number":53,"context_line":"- https://review.openstack.org/#/c/229916/"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Is the library actively maintained?"},{"line_number":56,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_72e6d8b5","line":53,"updated":"2015-10-06 20:05:59.000000000","message":"(No action required). The detail here is entirely irrelevant to the requirements process: we don\u0027t particularly care how much, or how ready a user is of a proposed depedendency. We care solely about the questions from README :). So - I hope you didn\u0027t spend much time on this \u0027consuming projects\u0027 section, and in future changes I suggest you don\u0027t bother at all. Just \u0027we want this in keystone for CI\u0027 is *more* than sufficient (when combined with the other stuff below).","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"c1d7a800e07984ea35dd4d655a5e549e63c16dd2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- https://review.openstack.org/#/c/229865/"},{"line_number":51,"context_line":"- https://review.openstack.org/#/c/229887/"},{"line_number":52,"context_line":"- https://review.openstack.org/#/c/229898/"},{"line_number":53,"context_line":"- https://review.openstack.org/#/c/229916/"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Is the library actively maintained?"},{"line_number":56,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_e5f45d88","line":53,"in_reply_to":"7a2fa921_72e6d8b5","updated":"2015-10-06 21:42:57.000000000","message":"Good to know. I assumed the intent was a judgement of \"is this library worthwhile?\" I figured I needed to demonstrate usage / benefit towards that goal. I\u0027ll leave it here - if nothing else, I\u0027ll likely point others towards this change if they want to utilize pep257 themselves.","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9d05ebade2fa4787feeb85b430fbc145897aff40","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"flake8_docstrings LICENSE:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  http://bit.ly/1MXuaM2"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"pep257 LICENSE:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_928ff4cb","line":95,"updated":"2015-10-06 20:05:59.000000000","message":"I can\u0027t tell what this is - this is essentially our audit log, so what I\u0027m looking for here is something like \u0027flake8_docstrings is MIT licensed\u0027. The URL might not be stable (not to mention that the shortner is a risk as well...), particularly if flake8 moved hosting or some such: it would be impossible to tell if the license changed in future, for instance.","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"c1d7a800e07984ea35dd4d655a5e549e63c16dd2","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"flake8_docstrings LICENSE:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  http://bit.ly/1MXuaM2"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"pep257 LICENSE:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_a54505b4","line":95,"in_reply_to":"7a2fa921_928ff4cb","updated":"2015-10-06 21:42:57.000000000","message":"I assume that means the URL is merely a convenience rather than part of the audit history, in which case, bit.ly serves as a convenience, and I\u0027ll add an explicit mention of MIT.","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9d05ebade2fa4787feeb85b430fbc145897aff40","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Is the library already packaged in the distros we target?"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"I don\u0027t believe either is packaged for Ubuntu or Fedora."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Is the function of this library already covered by other libraries?"},{"line_number":107,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_3264e020","line":104,"updated":"2015-10-06 20:05:59.000000000","message":"I think this will be fine as the transitive deps are all pure python and Python3 ready.","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9d05ebade2fa4787feeb85b430fbc145897aff40","unresolved":false,"context_lines":[{"line_number":110,"context_line":"standards and can subsequently be deprecated in favor of the more"},{"line_number":111,"context_line":"comprehensive coverage provided by pep257:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  http://bit.ly/1j54ClY"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"I don\u0027t believe any of hacking\u0027s checks assert any direct conflicts with"},{"line_number":116,"context_line":"pep257 (I\u0027ve written a file that exercises all of pep257\u0027s checks and it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_d2732ce6","line":113,"updated":"2015-10-06 20:05:59.000000000","message":"(nit) I\u0027m not sure what the url here is about? Its a link to the tip of hacking\u0027s code - but just skip the url - it doesn\u0027t add anything if one presumes(as I do) that you\u0027ve done a good faith check.. which your statement in the next paragraph makes crystal clear.","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"c1d7a800e07984ea35dd4d655a5e549e63c16dd2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"standards and can subsequently be deprecated in favor of the more"},{"line_number":111,"context_line":"comprehensive coverage provided by pep257:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  http://bit.ly/1j54ClY"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"I don\u0027t believe any of hacking\u0027s checks assert any direct conflicts with"},{"line_number":116,"context_line":"pep257 (I\u0027ve written a file that exercises all of pep257\u0027s checks and it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_854fa9bc","line":113,"in_reply_to":"7a2fa921_d2732ce6","updated":"2015-10-06 21:42:57.000000000","message":"Erm, it should have been a link to the specific (entire) module that will become redundant with pep257: hacking.checks.docstrings\n\nWill revise to eliminate any confusion.","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"}],"global-requirements.txt":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9d05ebade2fa4787feeb85b430fbc145897aff40","unresolved":false,"context_lines":[{"line_number":322,"context_line":"# next hacking release). Only these versions will be selected, because hacking"},{"line_number":323,"context_line":"# specifies the concrete version to choose."},{"line_number":324,"context_line":"flake8\u003e\u003d2.2.4,\u003c\u003d2.4.1"},{"line_number":325,"context_line":"flake8_docstrings\u003d\u003d0.2.1.post1"},{"line_number":326,"context_line":"hacking\u003e\u003d0.10.2,\u003c0.11"},{"line_number":327,"context_line":"mccabe\u003d\u003d0.2.1 # MIT License"},{"line_number":328,"context_line":"pep257\u003d\u003d0.6.0 # MIT License"}],"source_content_type":"text/plain","patch_set":7,"id":"7a2fa921_522f1cf6","line":325,"updated":"2015-10-06 20:05:59.000000000","message":"This needs to be blacklisted too.\n\n(We can\u0027t force sync *anything* that when updated instant-bugs projects, and linters are often in that category).","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"c1d7a800e07984ea35dd4d655a5e549e63c16dd2","unresolved":false,"context_lines":[{"line_number":322,"context_line":"# next hacking release). Only these versions will be selected, because hacking"},{"line_number":323,"context_line":"# specifies the concrete version to choose."},{"line_number":324,"context_line":"flake8\u003e\u003d2.2.4,\u003c\u003d2.4.1"},{"line_number":325,"context_line":"flake8_docstrings\u003d\u003d0.2.1.post1"},{"line_number":326,"context_line":"hacking\u003e\u003d0.10.2,\u003c0.11"},{"line_number":327,"context_line":"mccabe\u003d\u003d0.2.1 # MIT License"},{"line_number":328,"context_line":"pep257\u003d\u003d0.6.0 # MIT License"}],"source_content_type":"text/plain","patch_set":7,"id":"7a2fa921_e5d77dbd","line":325,"in_reply_to":"7a2fa921_522f1cf6","updated":"2015-10-06 21:42:57.000000000","message":"I excluded it from the blacklist because it implements no linting itself, but there is certainly some risk that it could suddenly require a higher version of pep257 than we\u0027re ready for someday.","commit_id":"3dc93b393d63e318a78f015b7a9beadae8051c3f"}]}