)]}'
{"openstack_requirements/requirement.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b7f95712d30c616943c0fda203a7fd789a1645af","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                         [\u0027package\u0027, \u0027location\u0027, \u0027specifiers\u0027,"},{"line_number":36,"context_line":"                                          \u0027markers\u0027, \u0027comment\u0027, \u0027extras\u0027])):"},{"line_number":37,"context_line":"    def __new__(cls, package, location, specifiers, markers, comment,"},{"line_number":38,"context_line":"                extras\u003d()):"},{"line_number":39,"context_line":"        return super(Requirement, cls).__new__(cls, package, location,"},{"line_number":40,"context_line":"                                               specifiers, markers, comment,"},{"line_number":41,"context_line":"                                               extras)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_abdc8473","line":38,"updated":"2015-10-22 02:21:33.000000000","message":"Uhm __new__? __init__ surely.\n\nAlso extras here should be None, and then","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"de15dae0e4950aa5d061aeaefac0be0ab57ca6a7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                         [\u0027package\u0027, \u0027location\u0027, \u0027specifiers\u0027,"},{"line_number":36,"context_line":"                                          \u0027markers\u0027, \u0027comment\u0027, \u0027extras\u0027])):"},{"line_number":37,"context_line":"    def __new__(cls, package, location, specifiers, markers, comment,"},{"line_number":38,"context_line":"                extras\u003d()):"},{"line_number":39,"context_line":"        return super(Requirement, cls).__new__(cls, package, location,"},{"line_number":40,"context_line":"                                               specifiers, markers, comment,"},{"line_number":41,"context_line":"                                               extras)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_e2e36fd7","line":38,"in_reply_to":"3a29b11f_abdc8473","updated":"2015-10-22 11:03:35.000000000","message":"I did not want to break all existing uses of Requirement class:\nhttp://paste.openstack.org/show/477131/","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"5b20e369881ab559ee600e30873146e9c2b261fe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                         [\u0027package\u0027, \u0027location\u0027, \u0027specifiers\u0027,"},{"line_number":36,"context_line":"                                          \u0027markers\u0027, \u0027comment\u0027, \u0027extras\u0027])):"},{"line_number":37,"context_line":"    def __new__(cls, package, location, specifiers, markers, comment,"},{"line_number":38,"context_line":"                extras\u003d()):"},{"line_number":39,"context_line":"        return super(Requirement, cls).__new__(cls, package, location,"},{"line_number":40,"context_line":"                                               specifiers, markers, comment,"},{"line_number":41,"context_line":"                                               extras)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_566450b7","line":38,"in_reply_to":"3a29b11f_e2e36fd7","updated":"2015-10-22 18:32:05.000000000","message":"Ah, sure, I\u0027d forgotten about new and immutable things.","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b7f95712d30c616943c0fda203a7fd789a1645af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                extras\u003d()):"},{"line_number":39,"context_line":"        return super(Requirement, cls).__new__(cls, package, location,"},{"line_number":40,"context_line":"                                               specifiers, markers, comment,"},{"line_number":41,"context_line":"                                               extras)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Requirements \u003d collections.namedtuple(\u0027Requirements\u0027, [\u0027reqs\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_6be2ec30","line":41,"updated":"2015-10-22 02:21:33.000000000","message":"Down here convert to frozenset() if not extras","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"de15dae0e4950aa5d061aeaefac0be0ab57ca6a7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                extras\u003d()):"},{"line_number":39,"context_line":"        return super(Requirement, cls).__new__(cls, package, location,"},{"line_number":40,"context_line":"                                               specifiers, markers, comment,"},{"line_number":41,"context_line":"                                               extras)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Requirements \u003d collections.namedtuple(\u0027Requirements\u0027, [\u0027reqs\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_224967b7","line":41,"in_reply_to":"3a29b11f_6be2ec30","updated":"2015-10-22 11:03:35.000000000","message":"Done","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b7f95712d30c616943c0fda203a7fd789a1645af","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Pulled out a requirement"},{"line_number":122,"context_line":"        parsed \u003d pkg_resources.Requirement.parse(req_line)"},{"line_number":123,"context_line":"        name \u003d parsed.project_name"},{"line_number":124,"context_line":"        extras \u003d parsed.extras"},{"line_number":125,"context_line":"        specifier \u003d str(parsed.specifier)"},{"line_number":126,"context_line":"    else:"},{"line_number":127,"context_line":"        # Comments / blank lines etc."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_2bd7144c","line":124,"updated":"2015-10-22 02:21:33.000000000","message":"extras is a set, and we\u0027re putting it in a functional data structure, so cast to frozenset please.","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b3402f682268d3fac390121a1b3e81dc941d159c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                extras\u003dNone):"},{"line_number":39,"context_line":"        return super(Requirement, cls).__new__("},{"line_number":40,"context_line":"            cls, package, location, specifiers, markers, comment,"},{"line_number":41,"context_line":"            frozenset(extras) if extras else None)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Requirements \u003d collections.namedtuple(\u0027Requirements\u0027, [\u0027reqs\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_3692f44c","line":41,"updated":"2015-10-22 18:42:11.000000000","message":"If we return an empty frozenset it won\u0027t need special casing elsewhere.\n\nfrozenset(extras) if extras else frozenset()","commit_id":"34006031ede6a14a8338b1e0b3812ccf34d4da90"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"eab8f9c75201a9d6a5eac99ddd9a4456b78229e4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                extras\u003dNone):"},{"line_number":39,"context_line":"        return super(Requirement, cls).__new__("},{"line_number":40,"context_line":"            cls, package, location, specifiers, markers, comment,"},{"line_number":41,"context_line":"            frozenset(extras) if extras else None)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Requirements \u003d collections.namedtuple(\u0027Requirements\u0027, [\u0027reqs\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_e494c68b","line":41,"in_reply_to":"3a29b11f_3692f44c","updated":"2015-10-22 19:27:11.000000000","message":"Done","commit_id":"34006031ede6a14a8338b1e0b3812ccf34d4da90"}],"openstack_requirements/tests/test_requirement.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b7f95712d30c616943c0fda203a7fd789a1645af","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":"        self.assertEqual(reqs[\u0027oslo.db\u0027][0][0].extras, ())"},{"line_number":164,"context_line":"        self.assertEqual(reqs[\u0027oslo.db\u0027][1][0].extras, (\u0027fixtures\u0027,))"},{"line_number":165,"context_line":"        self.assertEqual(reqs[\u0027oslo.db\u0027][2][0].extras, (\u0027fixtures\u0027, \u0027mysql\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class TestCanonicalName(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_2b3394ac","line":165,"updated":"2015-10-22 02:21:33.000000000","message":"So this doesn\u0027t make sense as a thing we parse - there should be one and only one entry in this situation. That said, I know why this does work, which is commit a3a3f7f57ac0afcc146bc2667abd46c76307b6d1 - and we don\u0027t disambiguate in your patch (or the system in general) as to the cause of the repetition.\n\nSo - I\u0027d like this test to use three different package names here, to match what we\u0027d actually expect to see in requirements files.\n\n oslo.db\n oslo.test[fixtures]\n oslo.logging[fixtures,test]\n\nor something like that","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"de15dae0e4950aa5d061aeaefac0be0ab57ca6a7","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":"        self.assertEqual(reqs[\u0027oslo.db\u0027][0][0].extras, ())"},{"line_number":164,"context_line":"        self.assertEqual(reqs[\u0027oslo.db\u0027][1][0].extras, (\u0027fixtures\u0027,))"},{"line_number":165,"context_line":"        self.assertEqual(reqs[\u0027oslo.db\u0027][2][0].extras, (\u0027fixtures\u0027, \u0027mysql\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class TestCanonicalName(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_821f1b5a","line":165,"in_reply_to":"3a29b11f_2b3394ac","updated":"2015-10-22 11:03:35.000000000","message":"Done","commit_id":"d67476d4ef9df8a3f7f5f8a2202a110f461d634a"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b3402f682268d3fac390121a1b3e81dc941d159c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.assertEqual("},{"line_number":160,"context_line":"            set([\u0027oslo.config\u0027, \u0027oslo.concurrency\u0027, \u0027oslo.db\u0027]),"},{"line_number":161,"context_line":"            set(reqs.keys()),"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":"        self.assertEqual(reqs[\u0027oslo.config\u0027][0][0].extras, None)"},{"line_number":164,"context_line":"        self.assertEqual(reqs[\u0027oslo.concurrency\u0027][0][0].extras,"},{"line_number":165,"context_line":"                         frozenset((\u0027fixtures\u0027,)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_160ed88b","line":162,"updated":"2015-10-22 18:42:11.000000000","message":"self.assertItemsEqual(reqs, [\u0027oslo.config\u0027, \u0027oslo.concurency\u0027, \u0027oslo.db\u0027])","commit_id":"34006031ede6a14a8338b1e0b3812ccf34d4da90"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"eab8f9c75201a9d6a5eac99ddd9a4456b78229e4","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.assertEqual("},{"line_number":160,"context_line":"            set([\u0027oslo.config\u0027, \u0027oslo.concurrency\u0027, \u0027oslo.db\u0027]),"},{"line_number":161,"context_line":"            set(reqs.keys()),"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":"        self.assertEqual(reqs[\u0027oslo.config\u0027][0][0].extras, None)"},{"line_number":164,"context_line":"        self.assertEqual(reqs[\u0027oslo.concurrency\u0027][0][0].extras,"},{"line_number":165,"context_line":"                         frozenset((\u0027fixtures\u0027,)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_646436b8","line":162,"in_reply_to":"3a29b11f_160ed88b","updated":"2015-10-22 19:27:11.000000000","message":"Done","commit_id":"34006031ede6a14a8338b1e0b3812ccf34d4da90"}]}
