)]}'
{"global-requirements.txt":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"456eff784f7f10fed4a1ffa46d47ddda3ead7c85","unresolved":false,"context_lines":[{"line_number":104,"context_line":"pycrypto\u003e\u003d2.6"},{"line_number":105,"context_line":"PyECLib\u003d\u003d1.0.7                           # BSD"},{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.3.2  # Apache 2.0 License"},{"line_number":108,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"},{"line_number":109,"context_line":"pymongo\u003e\u003d2.6.3,\u003c3.0"},{"line_number":110,"context_line":"PyMySQL\u003e\u003d0.6.2  # MIT License"}],"source_content_type":"text/plain","patch_set":1,"id":"1a7b0d38_4068f2f5","line":107,"updated":"2015-12-22 21:16:38.000000000","message":"I think \u003c0.4.0 is a better cap.  unless there is a strong reason to block 0.3.3 and any possible security releases on this.\n\nThe Kilo branch of Barbican does pass tests with 0.4.0 the actual breakage happens with 0.4.1","commit_id":"af265c4c5780b52ef5bf5058c30f77a80da5cd85"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"8d6cf10f4c6d54f6236000b1f7ffaf89e5f9790e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"pycrypto\u003e\u003d2.6"},{"line_number":105,"context_line":"PyECLib\u003d\u003d1.0.7                           # BSD"},{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.3.2  # Apache 2.0 License"},{"line_number":108,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"},{"line_number":109,"context_line":"pymongo\u003e\u003d2.6.3,\u003c3.0"},{"line_number":110,"context_line":"PyMySQL\u003e\u003d0.6.2  # MIT License"}],"source_content_type":"text/plain","patch_set":1,"id":"1a7b0d38_a30c4043","line":107,"in_reply_to":"1a7b0d38_4068f2f5","updated":"2015-12-22 21:50:30.000000000","message":"Tony, yes that makes sense.  My thinking was to cap it at the version closest to the stable kilo release, but \u003c0.4.1 makes  more sense.","commit_id":"af265c4c5780b52ef5bf5058c30f77a80da5cd85"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"296e3eebc4b485160440e493d67ff1352f3d9596","unresolved":false,"context_lines":[{"line_number":104,"context_line":"pycrypto\u003e\u003d2.6"},{"line_number":105,"context_line":"PyECLib\u003d\u003d1.0.7                           # BSD"},{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.4.1  # Apache 2.0 License"},{"line_number":108,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"},{"line_number":109,"context_line":"pymongo\u003e\u003d2.6.3,\u003c3.0"},{"line_number":110,"context_line":"PyMySQL\u003e\u003d0.6.2  # MIT License"}],"source_content_type":"text/plain","patch_set":2,"id":"1a7b0d38_a6ce8e81","line":107,"updated":"2015-12-22 22:06:44.000000000","message":"Actually I think that 0.4.0 is better. That\u0027s functionally 0.3.3 right now but if something terrible happens it allows for pykmip to provide a fix for kilo and liberty+ If we cap it with 0.4.1 then there is nowhere to go.","commit_id":"b3fd2cd9fef0c163ff017b571c79bbac87c85676"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"4dbdbde8091b3696332d4806a5b21971034da7ba","unresolved":false,"context_lines":[{"line_number":104,"context_line":"pycrypto\u003e\u003d2.6"},{"line_number":105,"context_line":"PyECLib\u003d\u003d1.0.7                           # BSD"},{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.4.1  # Apache 2.0 License"},{"line_number":108,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"},{"line_number":109,"context_line":"pymongo\u003e\u003d2.6.3,\u003c3.0"},{"line_number":110,"context_line":"PyMySQL\u003e\u003d0.6.2  # MIT License"}],"source_content_type":"text/plain","patch_set":2,"id":"1a7b0d38_468d6a30","line":107,"in_reply_to":"1a7b0d38_a6ce8e81","updated":"2015-12-22 22:08:33.000000000","message":"Oh fascinating. I see what you mean.  I didn\u0027t think about it like that.","commit_id":"b3fd2cd9fef0c163ff017b571c79bbac87c85676"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b02a64008868d1d235bee1cae54fd6769d027c67","unresolved":false,"context_lines":[{"line_number":104,"context_line":"pycrypto\u003e\u003d2.6"},{"line_number":105,"context_line":"PyECLib\u003d\u003d1.0.7                           # BSD"},{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.4.0  # Apache 2.0 License"},{"line_number":108,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"},{"line_number":109,"context_line":"pymongo\u003e\u003d2.6.3,\u003c3.0"},{"line_number":110,"context_line":"PyMySQL\u003e\u003d0.6.2  # MIT License"}],"source_content_type":"text/plain","patch_set":3,"id":"1a7b0d38_264a9e84","line":107,"updated":"2015-12-22 22:20:17.000000000","message":"Please put a NOTE in the file with this so we know what the cap is for and why (ignore git-blame, that gets messy with single line changes like this in g-r).","commit_id":"b0b5d9bc83df6af28dbdd93ceb64cbbbdfd04c8c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"660989951202f0151b3a0065b21b52c235c115d1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"PyECLib\u003d\u003d1.0.7                           # BSD"},{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.4.0  # Apache 2.0 License"},{"line_number":108,"context_line":"# NOTE(kfarr) PyKMIP 0.4.1 includes backwards incompatible changes that break"},{"line_number":109,"context_line":"# the stable/kilo branch of Barbican. Capping to 0.4.0 ensures potential"},{"line_number":110,"context_line":"# future 0.3.x bug fix releases are usable"},{"line_number":111,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"}],"source_content_type":"text/plain","patch_set":4,"id":"1a7b0d38_07bf40fc","line":108,"updated":"2015-12-23 14:45:43.000000000","message":"nit: move the NOTE above the pykmip line.","commit_id":"e12c9e116fd8dca18197ac6292632539361daff0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d17c733e23f7541a0099a9bd20cbd0c85d67940b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.4.0  # Apache 2.0 License"},{"line_number":108,"context_line":"# NOTE(kfarr) PyKMIP 0.4.1 includes backwards incompatible changes that break"},{"line_number":109,"context_line":"# the stable/kilo branch of Barbican. Capping to 0.4.0 ensures potential"},{"line_number":110,"context_line":"# future 0.3.x bug fix releases are usable"},{"line_number":111,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"},{"line_number":112,"context_line":"pymongo\u003e\u003d2.6.3,\u003c3.0"}],"source_content_type":"text/plain","patch_set":4,"id":"1a7b0d38_87f3300a","line":109,"updated":"2015-12-23 14:44:59.000000000","message":"Does it only break the unit tests? Or are there other functional failures with \u003e\u003d0.4.0 in barbican stable/kilo?  Or are we just guarding?","commit_id":"e12c9e116fd8dca18197ac6292632539361daff0"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"80d348bca36e49ac8207dede1656b47472152edd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"pyghmi\u003e\u003d0.6.11"},{"line_number":107,"context_line":"pykmip\u003e\u003d0.2.0,\u003c0.4.0  # Apache 2.0 License"},{"line_number":108,"context_line":"# NOTE(kfarr) PyKMIP 0.4.1 includes backwards incompatible changes that break"},{"line_number":109,"context_line":"# the stable/kilo branch of Barbican. Capping to 0.4.0 ensures potential"},{"line_number":110,"context_line":"# future 0.3.x bug fix releases are usable"},{"line_number":111,"context_line":"pymemcache\u003e\u003d1.2  # Apache 2.0 License"},{"line_number":112,"context_line":"pymongo\u003e\u003d2.6.3,\u003c3.0"}],"source_content_type":"text/plain","patch_set":4,"id":"1a7b0d38_ef90beee","line":109,"in_reply_to":"1a7b0d38_87f3300a","updated":"2015-12-23 21:30:55.000000000","message":"I\u0027ve only seen test failures but the issue isn\u0027t in the barbican/tests code.  Here\u0027s the summary from the PyKMIP issue:\n\n \u003e Traceback (most recent call last):\n \u003e File \"barbican/tests/plugin/test_kmip.py\", line 423, in test_store_private_key_secret_return_value\n \u003e     return_value \u003d self.secret_store.store_secret(secret_dto)\n \u003e File \"barbican/plugin/kmip_secret_store.py\", line 350, in store_secret\n \u003e     self._raise_secret_general_exception(result)\n \u003e File \"barbican/plugin/kmip_secret_store.py\", line 589, in _raise_secret_general_exception\n \u003e     raise ss.SecretGeneralException(msg)\n \u003e barbican.plugin.interface.secret_store.SecretGeneralException: Problem seen during crypto processing - Reason: Status: ResultStatus.SUCCESS, Reason: None, Message: None\n \u003e \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n \u003e FAIL: barbican.tests.plugin.test_kmip.WhenTestingKMIPSecretStore.test_store_symmetric_secret_return_value\n \u003e \n \u003e Which seems to be because result.result_status.enum is \u003cenum \u0027ResultStatus\u0027\u003e and not ResultStatus.SUCCESS as expected.\n\nSo the PyKMIP authors changed the ResultStatus object which means successful operations will be flagged as a failure with 0.4.1+.\n\nAs you can see from the comments on the review I suggested blocking the whole 0.4.x series.","commit_id":"e12c9e116fd8dca18197ac6292632539361daff0"}]}