)]}'
{"tools/publish_constraints.sh":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"93f39f35ac1afdb49f9b3ca4a1179e1943c2ba96","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(tonyb): Publish current branches.  This can be reduced as we land this"},{"line_number":28,"context_line":"# script on stable/* branches"},{"line_number":29,"context_line":"declare -a current_branches\u003d(stable/newton stable/ocata stable/pike)"},{"line_number":30,"context_line":"for branch in ${current_branches[@]} ; do"},{"line_number":31,"context_line":"    series\u003d$(basename \"$branch\")"},{"line_number":32,"context_line":"    git show origin/${branch}:upper-constraints.txt \u003e publish/${series}.txt"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bf57530f_7370ae73","line":29,"updated":"2017-09-20 19:34:51.000000000","message":"If we\u0027re going to run the job from the periodic queue, we could just run it out of master and not worry about trying to run it on the actual stable branches. If we do that, this array could be built by asking for the list of stable branches present in the repo and publishing the content from them dynamically.","commit_id":"44419d801e9b9809756209a4bb4601222701c244"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"19157da1b905197d69ef773cbd4387a1ae34f420","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(tonyb): Publish current branches.  This can be reduced as we land this"},{"line_number":28,"context_line":"# script on stable/* branches"},{"line_number":29,"context_line":"declare -a current_branches\u003d(stable/newton stable/ocata stable/pike)"},{"line_number":30,"context_line":"for branch in ${current_branches[@]} ; do"},{"line_number":31,"context_line":"    series\u003d$(basename \"$branch\")"},{"line_number":32,"context_line":"    git show origin/${branch}:upper-constraints.txt \u003e publish/${series}.txt"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f5c4f37_6d21ff9f","line":29,"in_reply_to":"bf57530f_7370ae73","updated":"2017-09-21 12:10:13.000000000","message":"Absolutely!","commit_id":"44419d801e9b9809756209a4bb4601222701c244"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5388b90a6871eaf1579fb81df50024f81f3f4f8f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Make the directory tree, don\u0027t fail if it already exists"},{"line_number":25,"context_line":"mkdir -p publish/constraints/upper || true"},{"line_number":26,"context_line":"# Clear out the directory tree, don\u0027t fail if we just created it"},{"line_number":27,"context_line":"rm publish/constraints/upper/* || true"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f515b1d_ef87bf60","line":25,"updated":"2017-09-26 17:58:59.000000000","message":"mkdir -p already doesn\u0027t fail if it already exists, the || true is not needed","commit_id":"20098f2575b0ce1bc26a30a82be1f90dfb5f97d1"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5ebe0a3859963161626b33381090296421b6be24","unresolved":false,"context_lines":[{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Make the directory tree, don\u0027t fail if it already exists"},{"line_number":25,"context_line":"mkdir -p publish/constraints/upper || true"},{"line_number":26,"context_line":"# Clear out the directory tree, don\u0027t fail if we just created it"},{"line_number":27,"context_line":"rm publish/constraints/upper/* || true"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f515b1d_f1ff9dfe","line":25,"in_reply_to":"7f515b1d_ef87bf60","updated":"2017-09-26 22:58:33.000000000","message":"Done","commit_id":"20098f2575b0ce1bc26a30a82be1f90dfb5f97d1"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5388b90a6871eaf1579fb81df50024f81f3f4f8f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Make the directory tree, don\u0027t fail if it already exists"},{"line_number":25,"context_line":"mkdir -p publish/constraints/upper || true"},{"line_number":26,"context_line":"# Clear out the directory tree, don\u0027t fail if we just created it"},{"line_number":27,"context_line":"rm publish/constraints/upper/* || true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"case \"$ZUUL_BRANCH\" in"},{"line_number":30,"context_line":"stable/*)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f515b1d_cf7e436a","line":27,"updated":"2017-09-26 17:58:59.000000000","message":"should this be rm -R (since the above comment mentions a tree)?","commit_id":"20098f2575b0ce1bc26a30a82be1f90dfb5f97d1"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5ebe0a3859963161626b33381090296421b6be24","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Make the directory tree, don\u0027t fail if it already exists"},{"line_number":25,"context_line":"mkdir -p publish/constraints/upper || true"},{"line_number":26,"context_line":"# Clear out the directory tree, don\u0027t fail if we just created it"},{"line_number":27,"context_line":"rm publish/constraints/upper/* || true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"case \"$ZUUL_BRANCH\" in"},{"line_number":30,"context_line":"stable/*)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f515b1d_510e7132","line":27,"in_reply_to":"7f515b1d_cf7e436a","updated":"2017-09-26 22:58:33.000000000","message":"The command is right the comment is misleading","commit_id":"20098f2575b0ce1bc26a30a82be1f90dfb5f97d1"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"30d8716ef2d095477d5339d0474c3bddb5b3c4ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        get_from_git $tag ${series}"},{"line_number":44,"context_line":"    done"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    for series in queens master ; do"},{"line_number":47,"context_line":"        if ! git rev-parse origin/stable/${series} ; then"},{"line_number":48,"context_line":"            get_from_git origin/master ${series}"},{"line_number":49,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f515b1d_9b864adb","line":46,"updated":"2017-09-26 21:46:56.000000000","message":"How is that supposed to work? There is no stable/master. Maybe remove the master part f from the for loop and add a separate get_from_git for master?","commit_id":"20098f2575b0ce1bc26a30a82be1f90dfb5f97d1"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5ebe0a3859963161626b33381090296421b6be24","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        get_from_git $tag ${series}"},{"line_number":44,"context_line":"    done"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    for series in queens master ; do"},{"line_number":47,"context_line":"        if ! git rev-parse origin/stable/${series} ; then"},{"line_number":48,"context_line":"            get_from_git origin/master ${series}"},{"line_number":49,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f515b1d_d1794193","line":46,"in_reply_to":"7f515b1d_9b864adb","updated":"2017-09-26 22:58:33.000000000","message":"That\u0027s kind of the point.  There *may* be a stable/queens branch depending on what stage of the development cycle we\u0027re at.  If there is one then we do not publish queens.txt from the master branch.\n\nAs you point out there will never be a stable/master so the rfe will never exist and we publish a master.txt.","commit_id":"20098f2575b0ce1bc26a30a82be1f90dfb5f97d1"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"4022b1632497d869a3c9f9b894ddcbcb505418e2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"function get_from_git()"},{"line_number":16,"context_line":"{"},{"line_number":17,"context_line":"    ref\u003d$1"},{"line_number":18,"context_line":"    series\u003d$2"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f515b1d_8c02803c","line":15,"updated":"2017-09-27 12:07:43.000000000","message":"NIT from bashate: \n[E] E020: Function declaration not in format ^function name {$: \u0027function get_from_git()\u0027","commit_id":"5a161771160af96c4bf76d00e561aaf30fb7c8c5"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"17bb770cce01f5eddf80fbf7d15b96fa3889150e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    get_from_git origin/$ZUUL_BRANCH $series"},{"line_number":33,"context_line":";;"},{"line_number":34,"context_line":"master)"},{"line_number":35,"context_line":"    # NOTE(tonyb): Publish EOL\u0027d constraints files.  We do this here as a "},{"line_number":36,"context_line":"    # quick way to publish the data.  It can be removed anytime after the first"},{"line_number":37,"context_line":"    # successful run"},{"line_number":38,"context_line":"    for tag in juno-eol kilo-eol liberty-eol mitaka-eol ; do"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f515b1d_2cc94c25","line":35,"updated":"2017-09-27 12:06:25.000000000","message":"NIT: trailing space","commit_id":"5a161771160af96c4bf76d00e561aaf30fb7c8c5"}]}
