)]}'
{"playbooks/files/project-requirements-change.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b60eee6b95ed36ebf07818822139f65094eca6b6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            branch_proj \u003d project.read(cwd)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"            # switch back to the proposed change now"},{"line_number":195,"context_line":"            output \u003d run_command(\"git checkout %s\" % head)"},{"line_number":196,"context_line":"            print(output)"},{"line_number":197,"context_line":"            # Show what we test"},{"line_number":198,"context_line":"            output \u003d run_command(\"git show\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_942545ae","line":195,"updated":"2017-10-30 16:51:28.000000000","message":"We can actually use \"\u0027get checkout %s\u0027 % branch\" here, since in zuulv3, the branch contains the change under test.  It\u0027s minor, but it\u0027s nice in that it leaves the repo in a good state rather than detached head.  It\u0027s also pontentially more compatible with local usage.","commit_id":"63738278175d73659dfb7dff52642e64e1461271"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"ab5fb1107060bbc4fb0d204d9f05214627487d43","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if not args.local:"},{"line_number":188,"context_line":"            # build a list of requirements already in the target branch,"},{"line_number":189,"context_line":"            # so that we can create a diff and identify what\u0027s being changed"},{"line_number":190,"context_line":"            run_command(\"git checkout HEAD^1\")"},{"line_number":191,"context_line":"            branch_proj \u003d project.read(cwd)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"            # switch back to the proposed change now"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_8e7531fd","line":190,"updated":"2017-10-30 20:22:59.000000000","message":"does that assumes that there is only one commit? is that a valid assumption? what if there are multiple commits chained together (e.g. via a series of depends-on or gerrit-depends?)","commit_id":"5fc7c923bf2a12078bf1585cc753d5cd6077548a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"80f99d7fb8e0ad04b71a593edf233afe8eab7a83","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if not args.local:"},{"line_number":188,"context_line":"            # build a list of requirements already in the target branch,"},{"line_number":189,"context_line":"            # so that we can create a diff and identify what\u0027s being changed"},{"line_number":190,"context_line":"            run_command(\"git checkout HEAD^1\")"},{"line_number":191,"context_line":"            branch_proj \u003d project.read(cwd)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"            # switch back to the proposed change now"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_8efc113f","line":190,"in_reply_to":"3f4b6375_8e7531fd","updated":"2017-10-30 20:24:32.000000000","message":"if it\u0027s a series of commits with than each change is checked against the previous one and thus this works.","commit_id":"5fc7c923bf2a12078bf1585cc753d5cd6077548a"}],"playbooks/requirements-check.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"826923ab48b70f84c17baf602feefbcc6d9f7742","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Run requirements check script"},{"line_number":4,"context_line":"      command: \"files/project-requirements-change.py {{ zuul.project.src_dir }} {{ zuul.branch }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_3d6435b9","line":4,"updated":"2017-10-30 18:14:25.000000000","message":"This isn\u0027t going to work because script copies the file to the remote node, but command expects it to already be there.  Fortunately, the script *is* there, it\u0027s just not at this path.  We\u0027ll need to run this as:\n\n{{ zuul._projects[\u0027git.openstack.org/openstack/requirements\u0027].src_dir }}/playbooks/files/project-requirements-change.py","commit_id":"8bd5098629a1720023eebe8c0855c3db1bbabf73"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"e4a6cc2a51110460c604e9fdd092fd36f55e7481","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Run requirements check script"},{"line_number":4,"context_line":"      # Use command instead of script since Zuul gets output with command"},{"line_number":5,"context_line":"      # into job-output.txt file."},{"line_number":6,"context_line":"      # Command expects the file to be at the other system, use proper path:"},{"line_number":7,"context_line":"      command: \"{{ zuul._projects[\u0027git.openstack.org/openstack/requirements\u0027].src_dir }}/playbooks/files/project-requirements-change.py {{ zuul.project.src_dir }} {{ zuul.branch }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_ee38253e","line":4,"updated":"2017-10-30 20:21:07.000000000","message":"this should be in the commit message than in a comment (its not clear what this means without reading the diff)","commit_id":"5fc7c923bf2a12078bf1585cc753d5cd6077548a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ebdb5416daa9c0a3076bf4935128213b7601167a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Run requirements check script"},{"line_number":4,"context_line":"      # Use command instead of script since Zuul gets output with command"},{"line_number":5,"context_line":"      # into job-output.txt file."},{"line_number":6,"context_line":"      # Command expects the file to be at the other system, use proper path:"},{"line_number":7,"context_line":"      command: \"{{ zuul._projects[\u0027git.openstack.org/openstack/requirements\u0027].src_dir }}/playbooks/files/project-requirements-change.py {{ zuul.project.src_dir }} {{ zuul.branch }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_0e6ca106","line":4,"in_reply_to":"3f4b6375_ee38253e","updated":"2017-10-30 20:26:25.000000000","message":"This is already in the commit message.","commit_id":"5fc7c923bf2a12078bf1585cc753d5cd6077548a"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"e4a6cc2a51110460c604e9fdd092fd36f55e7481","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    - name: Run requirements check script"},{"line_number":4,"context_line":"      # Use command instead of script since Zuul gets output with command"},{"line_number":5,"context_line":"      # into job-output.txt file."},{"line_number":6,"context_line":"      # Command expects the file to be at the other system, use proper path:"},{"line_number":7,"context_line":"      command: \"{{ zuul._projects[\u0027git.openstack.org/openstack/requirements\u0027].src_dir }}/playbooks/files/project-requirements-change.py {{ zuul.project.src_dir }} {{ zuul.branch }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_6e4435b8","line":6,"updated":"2017-10-30 20:21:07.000000000","message":"which other system? do you mean \"full path\" with \"proper\"?","commit_id":"5fc7c923bf2a12078bf1585cc753d5cd6077548a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ebdb5416daa9c0a3076bf4935128213b7601167a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    - name: Run requirements check script"},{"line_number":4,"context_line":"      # Use command instead of script since Zuul gets output with command"},{"line_number":5,"context_line":"      # into job-output.txt file."},{"line_number":6,"context_line":"      # Command expects the file to be at the other system, use proper path:"},{"line_number":7,"context_line":"      command: \"{{ zuul._projects[\u0027git.openstack.org/openstack/requirements\u0027].src_dir }}/playbooks/files/project-requirements-change.py {{ zuul.project.src_dir }} {{ zuul.branch }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_ae722de2","line":6,"in_reply_to":"3f4b6375_6e4435b8","updated":"2017-10-30 20:26:25.000000000","message":"fixing...","commit_id":"5fc7c923bf2a12078bf1585cc753d5cd6077548a"}]}