)]}'
{"global-requirements.txt":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d8279075fa702291de72f4fc60feca4833fe4cfd","unresolved":false,"context_lines":[{"line_number":435,"context_line":"testresources\u003e\u003d2.0.0  # Apache-2.0/BSD"},{"line_number":436,"context_line":"testscenarios\u003e\u003d0.4  # Apache-2.0/BSD"},{"line_number":437,"context_line":"testtools\u003e\u003d2.2.0  # MIT"},{"line_number":438,"context_line":"trollius\u003e\u003d1.0  # Apache-2.0"},{"line_number":439,"context_line":"ujson\u003e\u003d1.35  # BSD"},{"line_number":440,"context_line":"unittest2\u003e\u003d1.1.0  # BSD"},{"line_number":441,"context_line":"virtualbmc\u003e\u003d1.0.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_3646c823","line":438,"updated":"2018-03-19 05:43:03.000000000","message":"In lower-constraints.txt you set the minimum to 2.1  So this is incorrect now.\n\nCan you call out explicitly why you need to bump trollius[1] from 1.0 to 2.1 and then do it in both global-requirements.txt and lower-constratints.txt\n\n\n[1] You may also want to base this on: https://review.openstack.org/550740","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"6b362ce15d9602059171a2da777b973493f8106f","unresolved":false,"context_lines":[{"line_number":435,"context_line":"testresources\u003e\u003d2.0.0  # Apache-2.0/BSD"},{"line_number":436,"context_line":"testscenarios\u003e\u003d0.4  # Apache-2.0/BSD"},{"line_number":437,"context_line":"testtools\u003e\u003d2.2.0  # MIT"},{"line_number":438,"context_line":"trollius\u003e\u003d1.0  # Apache-2.0"},{"line_number":439,"context_line":"ujson\u003e\u003d1.35  # BSD"},{"line_number":440,"context_line":"unittest2\u003e\u003d1.1.0  # BSD"},{"line_number":441,"context_line":"virtualbmc\u003e\u003d1.0.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_d62c2cae","line":438,"in_reply_to":"df7087c5_3646c823","updated":"2018-03-19 06:25:34.000000000","message":"Will fix this one.\nBumping up the trollius is required by the Skydive.\nSkydive requires trollius 2.1 in Python2 and asyncio 3.4.3 on python3","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"}],"lower-constraints.txt":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d8279075fa702291de72f4fc60feca4833fe4cfd","unresolved":false,"context_lines":[{"line_number":215,"context_line":"xlwt\u003d\u003d\u003d1.3.0"},{"line_number":216,"context_line":"cliff\u003d\u003d\u003d2.8.0"},{"line_number":217,"context_line":"os-brick\u003d\u003d\u003d2.2.0"},{"line_number":218,"context_line":"trollius\u003d\u003d\u003d2.1"},{"line_number":219,"context_line":"scp\u003d\u003d\u003d0.10.2"},{"line_number":220,"context_line":"xlrd\u003d\u003d\u003d1.1.0"},{"line_number":221,"context_line":"python-zaqarclient\u003d\u003d\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_b6d5f845","line":218,"updated":"2018-03-19 05:43:03.000000000","message":"Can you explain why we need this major bump in l-c?","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"aab7049bb148d6cd131c80c838fea64a7cd1b733","unresolved":false,"context_lines":[{"line_number":215,"context_line":"xlwt\u003d\u003d\u003d1.3.0"},{"line_number":216,"context_line":"cliff\u003d\u003d\u003d2.8.0"},{"line_number":217,"context_line":"os-brick\u003d\u003d\u003d2.2.0"},{"line_number":218,"context_line":"trollius\u003d\u003d\u003d2.1"},{"line_number":219,"context_line":"scp\u003d\u003d\u003d0.10.2"},{"line_number":220,"context_line":"xlrd\u003d\u003d\u003d1.1.0"},{"line_number":221,"context_line":"python-zaqarclient\u003d\u003d\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_c1ec642b","line":218,"in_reply_to":"df7087c5_56125c64","updated":"2018-03-19 06:39:30.000000000","message":"Please see also [2]_\n\n[2] https://github.com/skydive-project/skydive/blob/master/contrib/python/api/requirements.txt","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"6b362ce15d9602059171a2da777b973493f8106f","unresolved":false,"context_lines":[{"line_number":215,"context_line":"xlwt\u003d\u003d\u003d1.3.0"},{"line_number":216,"context_line":"cliff\u003d\u003d\u003d2.8.0"},{"line_number":217,"context_line":"os-brick\u003d\u003d\u003d2.2.0"},{"line_number":218,"context_line":"trollius\u003d\u003d\u003d2.1"},{"line_number":219,"context_line":"scp\u003d\u003d\u003d0.10.2"},{"line_number":220,"context_line":"xlrd\u003d\u003d\u003d1.1.0"},{"line_number":221,"context_line":"python-zaqarclient\u003d\u003d\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_56125c64","line":218,"in_reply_to":"df7087c5_b6d5f845","updated":"2018-03-19 06:25:34.000000000","message":"This is a requirement inherited from Skydive[1]_ I got validation errors until I bumped it up to this version\n\n[1] https://github.com/skydive-project/skydive/blob/master/contrib/python/api/setup.py","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3fe1b163fa238697b19eaebe4498ae4c87c55ae9","unresolved":false,"context_lines":[{"line_number":215,"context_line":"xlwt\u003d\u003d\u003d1.3.0"},{"line_number":216,"context_line":"cliff\u003d\u003d\u003d2.8.0"},{"line_number":217,"context_line":"os-brick\u003d\u003d\u003d2.2.0"},{"line_number":218,"context_line":"trollius\u003d\u003d\u003d2.1"},{"line_number":219,"context_line":"scp\u003d\u003d\u003d0.10.2"},{"line_number":220,"context_line":"xlrd\u003d\u003d\u003d1.1.0"},{"line_number":221,"context_line":"python-zaqarclient\u003d\u003d\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":7,"id":"bf659307_e3411d0d","line":218,"in_reply_to":"df7087c5_c1ec642b","updated":"2018-03-28 04:06:19.000000000","message":"Thanks.","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d8279075fa702291de72f4fc60feca4833fe4cfd","unresolved":false,"context_lines":[{"line_number":537,"context_line":"scikit-learn\u003d\u003d\u003d0.17.1"},{"line_number":538,"context_line":"python-blazarclient\u003d\u003d\u003d1.0.1"},{"line_number":539,"context_line":"skydive-client\u003d\u003d\u003d0.4.1"},{"line_number":540,"context_line":"asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.6\u0027"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_36c1e881","line":540,"updated":"2018-03-19 05:43:03.000000000","message":"Okay ... Our tools aren\u0027t quite there  so you\u0027re going to need to specify this multiple python versions :(\n\n asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.4\u0027\n asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.5\u0027\n asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.6\u0027","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"5ba12781ca8b00201a179d9aace47e9a43c7b4f3","unresolved":false,"context_lines":[{"line_number":537,"context_line":"scikit-learn\u003d\u003d\u003d0.17.1"},{"line_number":538,"context_line":"python-blazarclient\u003d\u003d\u003d1.0.1"},{"line_number":539,"context_line":"skydive-client\u003d\u003d\u003d0.4.1"},{"line_number":540,"context_line":"asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.6\u0027"}],"source_content_type":"text/plain","patch_set":7,"id":"bf659307_b9a0db91","line":540,"in_reply_to":"bf659307_433b299b","updated":"2018-04-02 06:17:49.000000000","message":"Done","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"6b362ce15d9602059171a2da777b973493f8106f","unresolved":false,"context_lines":[{"line_number":537,"context_line":"scikit-learn\u003d\u003d\u003d0.17.1"},{"line_number":538,"context_line":"python-blazarclient\u003d\u003d\u003d1.0.1"},{"line_number":539,"context_line":"skydive-client\u003d\u003d\u003d0.4.1"},{"line_number":540,"context_line":"asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.6\u0027"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_a1fdb009","line":540,"in_reply_to":"df7087c5_36c1e881","updated":"2018-03-19 06:25:34.000000000","message":"Will do.\nI will try to use python_version\u003e\u003d\u00273.0\u0027\nIf this does not work will add versions explicitly","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3fe1b163fa238697b19eaebe4498ae4c87c55ae9","unresolved":false,"context_lines":[{"line_number":537,"context_line":"scikit-learn\u003d\u003d\u003d0.17.1"},{"line_number":538,"context_line":"python-blazarclient\u003d\u003d\u003d1.0.1"},{"line_number":539,"context_line":"skydive-client\u003d\u003d\u003d0.4.1"},{"line_number":540,"context_line":"asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.6\u0027"}],"source_content_type":"text/plain","patch_set":7,"id":"bf659307_433b299b","line":540,"in_reply_to":"df7087c5_a1fdb009","updated":"2018-03-28 04:06:19.000000000","message":"This is correct and functional for *this* review but other  tools will clobber it.  Please use the form I suggested.","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"}],"upper-constraints.txt":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d8279075fa702291de72f4fc60feca4833fe4cfd","unresolved":false,"context_lines":[{"line_number":528,"context_line":"sysv-ipc\u003d\u003d\u003d1.0.0"},{"line_number":529,"context_line":"scikit-learn\u003d\u003d\u003d0.19.1"},{"line_number":530,"context_line":"skydive-client\u003d\u003d\u003d0.4.1"},{"line_number":531,"context_line":"asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.6\u0027"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_56581cf9","line":531,"updated":"2018-03-19 05:43:03.000000000","message":"As with lower-constratints.txt you\u0027ll need to pin this for 3.4, 3.5 and 3.6 and then we\u0027ll need to make sure that doesn\u0027t get clobbered (we\u0027re not quite ready for 3.6 yet)","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"6b362ce15d9602059171a2da777b973493f8106f","unresolved":false,"context_lines":[{"line_number":528,"context_line":"sysv-ipc\u003d\u003d\u003d1.0.0"},{"line_number":529,"context_line":"scikit-learn\u003d\u003d\u003d0.19.1"},{"line_number":530,"context_line":"skydive-client\u003d\u003d\u003d0.4.1"},{"line_number":531,"context_line":"asyncio\u003d\u003d\u003d3.4.3;python_version\u003d\u003d\u00273.6\u0027"}],"source_content_type":"text/plain","patch_set":7,"id":"df7087c5_810c2c3c","line":531,"in_reply_to":"df7087c5_56581cf9","updated":"2018-03-19 06:25:34.000000000","message":"Will try python_version\u003e\u003d\u00273.0\u0027 as in lower_constraints","commit_id":"2c931d73bffedafcab5cd71ac3ab64f4fce0051b"}]}
