)]}'
{"openstack_requirements/check.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6bbff1b9b050a3232aae8cb10ae7cd1581c0814d","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            for req in reqs:"},{"line_number":224,"context_line":"                spec \u003d specifiers.SpecifierSet(req.specifiers)"},{"line_number":225,"context_line":"                version \u003d parsed_constraints[name][0][0].specifiers.lstrip(\u0027\u003d\u0027)"},{"line_number":226,"context_line":"                if not spec.contains(version):"},{"line_number":227,"context_line":"                    print(\u0027Package {!r} is constrained to {} \u0027"},{"line_number":228,"context_line":"                          \u0027which is incompatible with the settings {} \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_e6b28be6","line":225,"range":{"start_line":225,"start_character":51,"end_line":225,"end_character":52},"updated":"2018-03-28 05:55:09.000000000","message":"Is this right?  Can\u0027t we end up with multiple constraints dependant on the python version and if we always check the first in the list isn\u0027t that a mismatch?\n\n\nI think I\u0027m considering something like:\n\n reqs_list\u003d\"\"\"\n name\u003e\u003d1.0,!\u003d2.0;python_version\u003d\u003d2.7\n name\u003e\u003d2.0;python_version\u003e\u003d3.0\n \"\"\"\n constraints\u003d\"\"\"\n name\u003d\u003d\u003d1.9;python_version\u003d\u003d2.7\n name\u003d\u003d\u003d2.0;python_version\u003d\u003d3.4\n name\u003d\u003d\u003d2.0;python_version\u003d\u003d3.5\n \"\"\"","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"36ede785f4a0c18e4bd0f01040913fb8da797e83","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            for req in reqs:"},{"line_number":224,"context_line":"                spec \u003d specifiers.SpecifierSet(req.specifiers)"},{"line_number":225,"context_line":"                version \u003d parsed_constraints[name][0][0].specifiers.lstrip(\u0027\u003d\u0027)"},{"line_number":226,"context_line":"                if not spec.contains(version):"},{"line_number":227,"context_line":"                    print(\u0027Package {!r} is constrained to {} \u0027"},{"line_number":228,"context_line":"                          \u0027which is incompatible with the settings {} \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_b7dfc238","line":225,"range":{"start_line":225,"start_character":51,"end_line":225,"end_character":52},"in_reply_to":"bf659307_4e99f7c1","updated":"2018-03-28 21:37:40.000000000","message":"Done","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b6f6d3f127631aa04259e917565702c49cf37525","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            for req in reqs:"},{"line_number":224,"context_line":"                spec \u003d specifiers.SpecifierSet(req.specifiers)"},{"line_number":225,"context_line":"                version \u003d parsed_constraints[name][0][0].specifiers.lstrip(\u0027\u003d\u0027)"},{"line_number":226,"context_line":"                if not spec.contains(version):"},{"line_number":227,"context_line":"                    print(\u0027Package {!r} is constrained to {} \u0027"},{"line_number":228,"context_line":"                          \u0027which is incompatible with the settings {} \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_4e99f7c1","line":225,"range":{"start_line":225,"start_character":51,"end_line":225,"end_character":52},"in_reply_to":"bf659307_e6b28be6","updated":"2018-03-28 19:25:44.000000000","message":"Oh, I didn\u0027t realize that was supported. I\u0027ll work on that.","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"19ad44d069c07acadc18b2a2dd6c3e928057ad0a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                # specification for each version of python. I don\u0027t"},{"line_number":250,"context_line":"                # really know how smart we want this to be, because"},{"line_number":251,"context_line":"                # I\u0027m not sure we want to support extremely"},{"line_number":252,"context_line":"                # complicated dependency sets."},{"line_number":253,"context_line":"                constraint_setting \u003d _find_constraint("},{"line_number":254,"context_line":"                    req,"},{"line_number":255,"context_line":"                    parsed_constraints[name],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_ef2c8203","line":252,"updated":"2018-03-29 01:06:45.000000000","message":"In evaluating this I found a few problems clearly I\u0027m not signing you up for fixing them and I\u0027m not sure if any of them block the l-c work but it\u0027s all intertwined, much like a tangled web of onions ;D\n\n1) We\u0027re missing some (most) environment markers from lower-constraints.txt.\n\n $ git grep python_version lower-constraints.txt | wc -l\n 5\n $ git grep python_version upper-constraints.txt | wc -l\n 46\n\n\nI know that we have other lower-constraints files out there that will need fixing ... once we decide what \u0027fixed\u0027 looks like.\n\n2) Closely related to \u00271\u0027 above we have 0 coverage of any requirement that has a marker that excludes linux.\n\n $ git grep sys_platform global-requirements.txt\n global-requirements.txt:pyinotify\u003e\u003d0.9.6;sys_platform!\u003d\u0027win32\u0027 and sys_platform!\u003d\u0027darwin\u0027 and sys_platform!\u003d\u0027sunos5\u0027  # MIT\n global-requirements.txt:pyroute2\u003e\u003d0.4.21;sys_platform!\u003d\u0027win32\u0027  # Apache-2.0 (+ dual licensed GPL2)\n global-requirements.txt:PyMI\u003e\u003d1.0.0;sys_platform\u003d\u003d\u0027win32\u0027  # Apache 2.0 License\n global-requirements.txt:wmi\u003e\u003d0.5;sys_platform\u003d\u003d\u0027win32\u0027  # MIT\n\nNow I\u0027m not sure if that\u0027s a real issue as I\u0027m not sure if the hyperv team (which seems to be the only affected group) consumes constraints and clearly it doesn\u0027t impact our CI but I noticed it and wanted to at least discuss it.\n\n3) Right now we have a couple of examples like:\n\n $ git grep unicodecsv global-requirements.txt *-constraints.txt\n global-requirements.txt:unicodecsv\u003e\u003d0.8.0;python_version\u003c\u00273.0\u0027  # BSD\n lower-constraints.txt:unicodecsv\u003d\u003d\u003d0.8.0\n upper-constraints.txt:unicodecsv\u003d\u003d\u003d0.14.1;python_version\u003d\u003d\u00272.7\u0027\n\nAnd we need to support at least that level of marker.  As _find_constraint() is checking for equality this will fail.  Now we can of course alter the way we generate our constraints files to use less precise markers \u003c\u003d\u00273.0\u0027 instead of \u003d\u003d\u00272.7\u0027 but right now I\u0027m not entirely certain *how* we do that and get it right but my intuition says we\u0027d need to always use \u003c\u00273.X\u0027 or \u003e\u003d\u00273.X\u0027 in g-r and then reflect that in u-c.  It\u0027s technically incorrect but it\u0027s no worse than what we have now.\n\nSo for this patch what we have wont work with the data we currently have.  I was hoping that we can use Marker().evaluate(environment\u003d{\u0027python_version\u0027: \u0027xxx\u0027}) but that\u0027s non-trivial due to the things I\u0027ve outlined above.","commit_id":"98fb0fc4eeef21ec35c5b6861861725c4f54cf56"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"9bdcfe9859804f95a58e30763e106d43008a27b3","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                # specification for each version of python. I don\u0027t"},{"line_number":250,"context_line":"                # really know how smart we want this to be, because"},{"line_number":251,"context_line":"                # I\u0027m not sure we want to support extremely"},{"line_number":252,"context_line":"                # complicated dependency sets."},{"line_number":253,"context_line":"                constraint_setting \u003d _find_constraint("},{"line_number":254,"context_line":"                    req,"},{"line_number":255,"context_line":"                    parsed_constraints[name],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_8a7cbb83","line":252,"in_reply_to":"bf659307_b561e507","updated":"2018-03-29 21:53:43.000000000","message":"I can\u0027t say I like the use of internals but your code does what we need and you\u0027ve clearly documented that what we\u0027re doing.\n\nIt\u0027s enough to get this work merged while we discuss if/how we change our constraints implementation.\n\nThanks for being patient and tenacious Doug!","commit_id":"98fb0fc4eeef21ec35c5b6861861725c4f54cf56"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0e0c7d8dcfbab1dc82a186df75b34ec7231b6cd6","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                # specification for each version of python. I don\u0027t"},{"line_number":250,"context_line":"                # really know how smart we want this to be, because"},{"line_number":251,"context_line":"                # I\u0027m not sure we want to support extremely"},{"line_number":252,"context_line":"                # complicated dependency sets."},{"line_number":253,"context_line":"                constraint_setting \u003d _find_constraint("},{"line_number":254,"context_line":"                    req,"},{"line_number":255,"context_line":"                    parsed_constraints[name],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_b561e507","line":252,"in_reply_to":"bf659307_ef2c8203","updated":"2018-03-29 17:35:55.000000000","message":"See what you think of the new version. It\u0027s a bit more flexible, but isn\u0027t going to work in all cases. It does cover case 3 of your comment.","commit_id":"98fb0fc4eeef21ec35c5b6861861725c4f54cf56"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"19ad44d069c07acadc18b2a2dd6c3e928057ad0a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                    print(\u0027Package {!r} is constrained to {} \u0027"},{"line_number":288,"context_line":"                          \u0027which does not match \u0027"},{"line_number":289,"context_line":"                          \u0027the minimum version specifier {} in {}\u0027.format("},{"line_number":290,"context_line":"                              name, actual, expected, fname))"},{"line_number":291,"context_line":"                    failed \u003d True"},{"line_number":292,"context_line":"    return failed"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_3d02b30c","line":290,"range":{"start_line":290,"start_character":36,"end_line":290,"end_character":42},"updated":"2018-03-29 01:06:45.000000000","message":"As the pep8 job says we no longer have \u0027actual\u0027 so this should be \u0027version\u0027","commit_id":"98fb0fc4eeef21ec35c5b6861861725c4f54cf56"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"b3c79fb01cbc87be7fb143c5fe23694ab4c47f06","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                    continue"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"                expected \u003d min[0].lstrip(\u0027\u003e\u003d\u0027)"},{"line_number":302,"context_line":"                if version !\u003d expected:"},{"line_number":303,"context_line":"                    print(\u0027Package {!r} is constrained to {} \u0027"},{"line_number":304,"context_line":"                          \u0027which does not match \u0027"},{"line_number":305,"context_line":"                          \u0027the minimum version specifier {} in {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_35976a93","line":302,"range":{"start_line":302,"start_character":27,"end_line":302,"end_character":29},"updated":"2018-04-09 03:04:52.000000000","message":"Is this a mistake?\nI think that it should be other operator.\n\nAccording to this output\nZuul ID: 54f2324ae1bf4935ac4a0e3a9eeb1652\n\nhttp://logs.openstack.org/14/559014/4/check/requirements-check/ad1e3f3/ara-report/","commit_id":"1e78c974263d70cd3a15bfba779c05ab60062ae2"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6d3a7ecfaccdc0db973c7929794a4130e135924e","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                    continue"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"                expected \u003d min[0].lstrip(\u0027\u003e\u003d\u0027)"},{"line_number":302,"context_line":"                if version !\u003d expected:"},{"line_number":303,"context_line":"                    print(\u0027Package {!r} is constrained to {} \u0027"},{"line_number":304,"context_line":"                          \u0027which does not match \u0027"},{"line_number":305,"context_line":"                          \u0027the minimum version specifier {} in {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_06d79451","line":302,"range":{"start_line":302,"start_character":27,"end_line":302,"end_character":29},"in_reply_to":"bf659307_35976a93","updated":"2018-04-09 14:00:33.000000000","message":"The version number from lower-constraints.txt must match exactly the lowest version  number in the requirements.txt, test-requirements.txt, or other requirement file. Otherwise we could have a case where a project says it supports versions \u003e\u003d1.0 with a lower constraint of \u003d\u003d1.1, so it is not testing 1.0.","commit_id":"1e78c974263d70cd3a15bfba779c05ab60062ae2"}],"openstack_requirements/tests/test_check.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6bbff1b9b050a3232aae8cb10ae7cd1581c0814d","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_868e2fce","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":14},"updated":"2018-03-28 05:55:09.000000000","message":"Constraints need a \u0027\u003d\u003d\u003d\u0027 instead of \u0027\u003d\u003d\u0027  I\u0027m not certain it\u0027ll make a functional difference.","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"f01758d282f81479448d57f086a9641c4cd46a35","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_ae11b306","line":427,"updated":"2018-03-28 19:31:48.000000000","message":"Here\u0027s where the version spec is defined.  https://www.python.org/dev/peps/pep-0440/#arbitrary-equality  I\u0027m not sure we actually need or want \u003d\u003d\u003d vs using \u003d\u003d.","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"aff22340f7807d51e7e769cd4707d87d3c921b20","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_b7cee2b1","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":14},"in_reply_to":"bf659307_4ec7b797","updated":"2018-03-28 21:34:28.000000000","message":"Hmm okay it seems like \u0027\u003d\u003d\u003d\u0027 is more correct and what we want but given the way we generate out constraints to be zero padded semvers we\u0027re okay.  The only corner case I can think of is that a library has a \u00271.2\u0027 and \u00271.2.0\u0027 releases \u0027\u003d\u003d1.2\u0027 will allow both but \u0027\u003d\u003d\u003d1.2\u0027 doesn\u0027t allow the second.\n\nLike I said I think we\u0027re safe as we always emit \u00271.2.0\u0027 but given the lower-constraints.txt files are supposed to be hand edited are we introducing a new, albeit small, problem?","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b6f6d3f127631aa04259e917565702c49cf37525","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_eeefab1b","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":14},"in_reply_to":"bf659307_868e2fce","updated":"2018-03-28 19:25:44.000000000","message":"It doesn\u0027t seem to be so far (all of the lower-constraints.txt files have 2 \u003d in them). I\u0027m sure there\u0027s some subtle difference so we could go through and fix that up with another 200+ patches if we really need to. :-)","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9239333b9b2c3e7aad5085f94f94f2e8c8f27f27","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_d72fd63c","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":14},"in_reply_to":"bf659307_b7cee2b1","updated":"2018-03-28 21:36:29.000000000","message":"I think 1.2 and 1.2.0 are semantically the same.\n\nOnce we get all of this working we can go through and propose updates to all of the lower-constraints.txt files and fix them. It won\u0027t be pretty to do, but they should be easy patches to land.","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4d1a8f1889f1059e39a58051f4a162dd77a58228","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_777cca1e","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":14},"in_reply_to":"bf659307_d72fd63c","updated":"2018-03-28 21:42:37.000000000","message":"I agree that 1.2 and 1.2.0 are semantically the same but I don\u0027t think there is anything in the pypi ecosystem that stops a library from have 1.2 and 1.2.0 be different things is there?\n\nI\u0027m also very happy to concede that it\u0027s a small risk and *shouldn\u0027t* happen.\n\nI\u0027m happy to work with you to fix up the lower-constraints.txt files that are out there","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"f44e90ec6d3815a3b014d239f7e08841ca2cd71c","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_4ec7b797","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":14},"in_reply_to":"bf659307_eeefab1b","updated":"2018-03-28 19:27:26.000000000","message":"\u003d\u003d allows prefixes and wildcards https://www.python.org/dev/peps/pep-0440/#version-matching\n\n\u003d\u003d\u003d is a string match https://www.python.org/dev/peps/pep-0440/#arbitrary-equality","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"aff22340f7807d51e7e769cd4707d87d3c921b20","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_no_min(self):"},{"line_number":426,"context_line":"        constraints_content \u003d textwrap.dedent(\"\"\""},{"line_number":427,"context_line":"        name\u003d\u003d1.2"},{"line_number":428,"context_line":"        \"\"\")"},{"line_number":429,"context_line":"        project_data \u003d {"},{"line_number":430,"context_line":"            \u0027requirements\u0027: {\u0027requirements.txt\u0027: \u0027name!\u003d1.4\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_9ce425e2","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":14},"in_reply_to":"bf659307_eeefab1b","updated":"2018-03-28 21:34:28.000000000","message":"Oh rats :(\n\n [tony@thor requirements]$ wc -l lower-constraints.txt\n 535 lower-constraints.txt\n [tony@thor requirements]$ grep \u0027\u003d\u003d\u003d\u0027 lower-constraints.txt | wc -l\n 535\n [tony@thor requirements]$","commit_id":"e81b71dcd4cc3796d23b71b1b56a5e33b0b1e71d"}],"playbooks/files/project-requirements-change.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"048c4b20d945b8daa97af4d46d06146418dab78e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        failed \u003d ("},{"line_number":150,"context_line":"            check.validate_lower_constraints("},{"line_number":151,"context_line":"                head_reqs,"},{"line_number":152,"context_line":"                head_proj[\u0027lower_constraints.txt\u0027],"},{"line_number":153,"context_line":"                blacklist,"},{"line_number":154,"context_line":"            )"},{"line_number":155,"context_line":"            or failed"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_cad94157","line":152,"range":{"start_line":152,"start_character":32,"end_line":152,"end_character":33},"updated":"2018-03-30 19:32:59.000000000","message":"Is this a bug?  This dict element was created with a hyphen.","commit_id":"1e78c974263d70cd3a15bfba779c05ab60062ae2"}]}
