)]}'
{"openstack_requirements/cmds/generate.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8e0fe702bf5a213183d77e21710529c4f04c7815","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            output.append(subprocess.check_output("},{"line_number":82,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-U\u0027, \u0027pip\u0027, \u0027setuptools\u0027, \u0027wheel\u0027]))"},{"line_number":83,"context_line":"            output.append(subprocess.check_output("},{"line_number":84,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-r\u0027, requirements]))"},{"line_number":85,"context_line":"            freeze \u003d subprocess.check_output("},{"line_number":86,"context_line":"                [pip_bin, \u0027freeze\u0027]).decode(\u0027utf-8\u0027)"},{"line_number":87,"context_line":"            output.append(freeze)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_6d4c5dc7","line":84,"updated":"2018-04-17 04:47:40.000000000","message":"If we don\u0027t need to parse the output of these early commands, they could just use check_call() couldn\u0027t they? Then the output would go to the console or log or whatever but we\u0027d still get the exception if something has an error.","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b54eec4745a8916175541579240afe72d5793b0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            output.append(subprocess.check_output("},{"line_number":82,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-U\u0027, \u0027pip\u0027, \u0027setuptools\u0027, \u0027wheel\u0027]))"},{"line_number":83,"context_line":"            output.append(subprocess.check_output("},{"line_number":84,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-r\u0027, requirements]))"},{"line_number":85,"context_line":"            freeze \u003d subprocess.check_output("},{"line_number":86,"context_line":"                [pip_bin, \u0027freeze\u0027]).decode(\u0027utf-8\u0027)"},{"line_number":87,"context_line":"            output.append(freeze)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_62fd3539","line":84,"updated":"2018-04-17 19:08:19.000000000","message":"Shouldn\u0027t that be a separate review (atomic, specific commits)?","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d001c65dbec8e902f6943196037a5b416821ca6e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            output.append(subprocess.check_output("},{"line_number":82,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-U\u0027, \u0027pip\u0027, \u0027setuptools\u0027, \u0027wheel\u0027]))"},{"line_number":83,"context_line":"            output.append(subprocess.check_output("},{"line_number":84,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-r\u0027, requirements]))"},{"line_number":85,"context_line":"            freeze \u003d subprocess.check_output("},{"line_number":86,"context_line":"                [pip_bin, \u0027freeze\u0027]).decode(\u0027utf-8\u0027)"},{"line_number":87,"context_line":"            output.append(freeze)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_7f8627de","line":84,"in_reply_to":"9f6a8fd7_62fd3539","updated":"2018-04-17 22:19:02.000000000","message":"Well, I was proposing that as an alternative solution. See https://review.openstack.org/562065.","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8e0fe702bf5a213183d77e21710529c4f04c7815","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-r\u0027, requirements]))"},{"line_number":85,"context_line":"            freeze \u003d subprocess.check_output("},{"line_number":86,"context_line":"                [pip_bin, \u0027freeze\u0027]).decode(\u0027utf-8\u0027)"},{"line_number":87,"context_line":"            output.append(freeze)"},{"line_number":88,"context_line":"            return (version, _parse_freeze(freeze))"},{"line_number":89,"context_line":"    except Exception as exc:"},{"line_number":90,"context_line":"        if isinstance(exc, subprocess.CalledProcessError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_cdd009cd","line":87,"updated":"2018-04-17 04:47:40.000000000","message":"We should decode the output of any commands we do want to parse immediately so we know we have a string and not a byte sequence.","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"363644e77c50403a24abe87f3f8968d4304767cb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-r\u0027, requirements]))"},{"line_number":85,"context_line":"            freeze \u003d subprocess.check_output("},{"line_number":86,"context_line":"                [pip_bin, \u0027freeze\u0027]).decode(\u0027utf-8\u0027)"},{"line_number":87,"context_line":"            output.append(freeze)"},{"line_number":88,"context_line":"            return (version, _parse_freeze(freeze))"},{"line_number":89,"context_line":"    except Exception as exc:"},{"line_number":90,"context_line":"        if isinstance(exc, subprocess.CalledProcessError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_42c351ee","line":87,"updated":"2018-04-17 19:09:38.000000000","message":"actually, freeze is already decoded two lines above.","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b54eec4745a8916175541579240afe72d5793b0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                [pip_bin, \u0027install\u0027, \u0027-r\u0027, requirements]))"},{"line_number":85,"context_line":"            freeze \u003d subprocess.check_output("},{"line_number":86,"context_line":"                [pip_bin, \u0027freeze\u0027]).decode(\u0027utf-8\u0027)"},{"line_number":87,"context_line":"            output.append(freeze)"},{"line_number":88,"context_line":"            return (version, _parse_freeze(freeze))"},{"line_number":89,"context_line":"    except Exception as exc:"},{"line_number":90,"context_line":"        if isinstance(exc, subprocess.CalledProcessError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_82fac93f","line":87,"updated":"2018-04-17 19:08:19.000000000","message":"ok, I\u0027ll add a .decode for the freeze string","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b54eec4745a8916175541579240afe72d5793b0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            return (version, _parse_freeze(freeze))"},{"line_number":89,"context_line":"    except Exception as exc:"},{"line_number":90,"context_line":"        if isinstance(exc, subprocess.CalledProcessError):"},{"line_number":91,"context_line":"            output.append(exc.output.decode(\u0027utf-8\u0027))"},{"line_number":92,"context_line":"        raise Exception("},{"line_number":93,"context_line":"            \"Failed to generate freeze: %s %s\""},{"line_number":94,"context_line":"            % (\u0027\\n\u0027.join(output).decode(\u0027utf-8\u0027), exc))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_2295fde4","line":91,"updated":"2018-04-17 19:08:19.000000000","message":"Don\u0027t know.","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8e0fe702bf5a213183d77e21710529c4f04c7815","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            return (version, _parse_freeze(freeze))"},{"line_number":89,"context_line":"    except Exception as exc:"},{"line_number":90,"context_line":"        if isinstance(exc, subprocess.CalledProcessError):"},{"line_number":91,"context_line":"            output.append(exc.output.decode(\u0027utf-8\u0027))"},{"line_number":92,"context_line":"        raise Exception("},{"line_number":93,"context_line":"            \"Failed to generate freeze: %s %s\""},{"line_number":94,"context_line":"            % (\u0027\\n\u0027.join(output).decode(\u0027utf-8\u0027), exc))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_add7d5bf","line":91,"updated":"2018-04-17 04:47:40.000000000","message":"I wonder if we just raised the exception again here (or don\u0027t catch it in the first place) if we would see the encoding error?","commit_id":"a353c881240570f535dbe4ec906d9de04c191990"}]}
