)]}'
{"global-requirements.txt":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e167e49c7ea16d171dca6f64e8c7f141810079d6","unresolved":false,"context_lines":[{"line_number":224,"context_line":"pyzabbix  # LGPL"},{"line_number":225,"context_line":"statsd  # MIT"},{"line_number":226,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027  # PSF"},{"line_number":227,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027 or python_version\u003c\u003d\u00273.5\u0027  # Apache 2.0 License"},{"line_number":228,"context_line":"opentracing  # Apache-2.0"},{"line_number":229,"context_line":"jaeger-client  # Apache-2.0"},{"line_number":230,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_641fe608","line":227,"range":{"start_line":227,"start_character":40,"end_line":227,"end_character":42},"updated":"2018-07-19 16:18:56.000000000","message":"Doesn\u0027t this need to be \"and\"? Otherwise if platform is win32 but running \u003c\u003d 3.5 this would end up getting installed.","commit_id":"80883c25db85320084966544661c058db71201b9"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"96b1a9872e86a5c7d7bc37e70510d7a3c275c00f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"pyzabbix  # LGPL"},{"line_number":225,"context_line":"statsd  # MIT"},{"line_number":226,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027  # PSF"},{"line_number":227,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027 or python_version\u003c\u003d\u00273.5\u0027  # Apache 2.0 License"},{"line_number":228,"context_line":"opentracing  # Apache-2.0"},{"line_number":229,"context_line":"jaeger-client  # Apache-2.0"},{"line_number":230,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_c4583a8a","line":227,"updated":"2018-07-19 16:33:01.000000000","message":"with an \u0027and\u0027 if win32 and py36 it\u0027d be allowed to be installed\nwith an or if either are true it\u0027d be allowed (so this doesn\u0027t help as is)\nwe need two expressions here I think, one for !win32 and another for !py3 (since zvmsdk does not seem to support py3 at all..)\nboth expressions would be evaluated individually,\n\nI don\u0027t think markers support this :|     https://www.python.org/dev/peps/pep-0496/\n\nhttps://github.com/mfcloud/python-zvm-sdk/blob/master/setup.py#L37-L39","commit_id":"80883c25db85320084966544661c058db71201b9"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"0ca0b1086fef800eb26e8f5baca53a7b8acb98b7","unresolved":false,"context_lines":[{"line_number":224,"context_line":"pyzabbix  # LGPL"},{"line_number":225,"context_line":"statsd  # MIT"},{"line_number":226,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027  # PSF"},{"line_number":227,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027 or python_version\u003c\u003d\u00273.5\u0027  # Apache 2.0 License"},{"line_number":228,"context_line":"opentracing  # Apache-2.0"},{"line_number":229,"context_line":"jaeger-client  # Apache-2.0"},{"line_number":230,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_4adaf178","line":227,"in_reply_to":"5f7c97a3_afd95755","updated":"2018-07-19 17:36:33.000000000","message":"actually, I think the \u0027and\u0027 should work\n\nif not win32:\n  if py \u003c\u003d 3.5:\n    install\n  else:\n    pass\nelse:\n  pass","commit_id":"80883c25db85320084966544661c058db71201b9"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d74a1bbf336f5269a8fba5c7dcf225d1d86a1e62","unresolved":false,"context_lines":[{"line_number":224,"context_line":"pyzabbix  # LGPL"},{"line_number":225,"context_line":"statsd  # MIT"},{"line_number":226,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027  # PSF"},{"line_number":227,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027 or python_version\u003c\u003d\u00273.5\u0027  # Apache 2.0 License"},{"line_number":228,"context_line":"opentracing  # Apache-2.0"},{"line_number":229,"context_line":"jaeger-client  # Apache-2.0"},{"line_number":230,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_afd95755","line":227,"in_reply_to":"5f7c97a3_c4583a8a","updated":"2018-07-19 17:00:16.000000000","message":"so would adding:\n\n    and python_version\u003d\u003d2.7 \n\nsolve it then?\n\nI believe they do support py3, but just havent updated the markers yet - but we can update that later if needs be.","commit_id":"80883c25db85320084966544661c058db71201b9"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"1c1246516a52a4a084fa4f6aaf002e4150af4642","unresolved":false,"context_lines":[{"line_number":224,"context_line":"pyzabbix  # LGPL"},{"line_number":225,"context_line":"statsd  # MIT"},{"line_number":226,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027  # PSF"},{"line_number":227,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027 and python_version\u003c\u003d\u00273.5\u0027  # Apache 2.0 License"},{"line_number":228,"context_line":"opentracing  # Apache-2.0"},{"line_number":229,"context_line":"jaeger-client  # Apache-2.0"},{"line_number":230,"context_line":""}],"source_content_type":"text/plain","patch_set":2,"id":"5f7c97a3_fdedc48d","line":227,"updated":"2018-07-19 21:58:24.000000000","message":"Actually, ya, a requirements bug to track this would make me more comfortable.","commit_id":"88ef4ac94f4ac4b6c593e6c3e1a94268eb562ffc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e9c34e1d06845b0101916475756c9ae859be1a64","unresolved":false,"context_lines":[{"line_number":224,"context_line":"pyzabbix  # LGPL"},{"line_number":225,"context_line":"statsd  # MIT"},{"line_number":226,"context_line":"weakrefmethod;python_version\u003d\u003d\u00272.7\u0027  # PSF"},{"line_number":227,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027 and python_version\u003c\u003d\u00273.5\u0027  # Apache 2.0 License"},{"line_number":228,"context_line":"opentracing  # Apache-2.0"},{"line_number":229,"context_line":"jaeger-client  # Apache-2.0"},{"line_number":230,"context_line":""}],"source_content_type":"text/plain","patch_set":2,"id":"5f7c97a3_3a010208","line":227,"updated":"2018-07-19 21:20:07.000000000","message":"Could add a TODO to remove this once the fix is available in the sdk","commit_id":"88ef4ac94f4ac4b6c593e6c3e1a94268eb562ffc"}]}
