)]}'
{"openstack_requirements/constraints.py":[{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"92decc03cf144a923ad6a6842be38bff734654ff","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            spec \u003d specifiers.SpecifierSet(constraint.specifiers)"},{"line_number":95,"context_line":"            if spec.contains(version):"},{"line_number":96,"context_line":"                return True"},{"line_number":97,"context_line":"            if spec.contains(version, prereleases\u003dTrue):"},{"line_number":98,"context_line":"                failures.append(\u0027Constraint %s for %s is a prerelease\u0027 %"},{"line_number":99,"context_line":"                                (version, name))"},{"line_number":100,"context_line":"            tested.append(constraint.specifiers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_64e419e2","line":97,"updated":"2019-01-29 03:02:27.000000000","message":"I\u0027m improving the message of existing behavior (it fails already, if it passed the previous lines return would have allowed it).  To allow prereleases we\u0027d have to change line 95 to be like my proposed line 97.","commit_id":"9d6a0b546f7cd0eb0bd0abf1dcec1d4be5c001ef"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"60efae3cdf7e0d743e52a97bee1695cdaa45b3e9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            spec \u003d specifiers.SpecifierSet(constraint.specifiers)"},{"line_number":95,"context_line":"            if spec.contains(version):"},{"line_number":96,"context_line":"                return True"},{"line_number":97,"context_line":"            if spec.contains(version, prereleases\u003dTrue):"},{"line_number":98,"context_line":"                failures.append(\u0027Constraint %s for %s is a prerelease\u0027 %"},{"line_number":99,"context_line":"                                (version, name))"},{"line_number":100,"context_line":"            tested.append(constraint.specifiers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_c9dcfee5","line":97,"updated":"2019-01-29 01:59:08.000000000","message":"Why not just do this and issue a warning?  I know we don\u0027t typically want to take pre-releases but there have been cases when we have","commit_id":"9d6a0b546f7cd0eb0bd0abf1dcec1d4be5c001ef"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"dc7a4f04f7d31df64aef1b165680c1d776f0414a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            spec \u003d specifiers.SpecifierSet(constraint.specifiers)"},{"line_number":95,"context_line":"            if spec.contains(version):"},{"line_number":96,"context_line":"                return True"},{"line_number":97,"context_line":"            if spec.contains(version, prereleases\u003dTrue):"},{"line_number":98,"context_line":"                failures.append(\u0027Constraint %s for %s is a prerelease\u0027 %"},{"line_number":99,"context_line":"                                (version, name))"},{"line_number":100,"context_line":"            tested.append(constraint.specifiers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5bf52fec","line":97,"updated":"2019-01-29 06:27:24.000000000","message":"so you want me to return True as well within this (since I\u0027m already adding a warning","commit_id":"9d6a0b546f7cd0eb0bd0abf1dcec1d4be5c001ef"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"fe0d8bc22030b3ab7206eb9d044c5a4ff222bcba","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            spec \u003d specifiers.SpecifierSet(constraint.specifiers)"},{"line_number":95,"context_line":"            if spec.contains(version):"},{"line_number":96,"context_line":"                return True"},{"line_number":97,"context_line":"            if spec.contains(version, prereleases\u003dTrue):"},{"line_number":98,"context_line":"                failures.append(\u0027Constraint %s for %s is a prerelease\u0027 %"},{"line_number":99,"context_line":"                                (version, name))"},{"line_number":100,"context_line":"            tested.append(constraint.specifiers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_89cd8432","line":97,"in_reply_to":"9fdfeff1_5bf52fec","updated":"2019-01-29 21:30:01.000000000","message":"Well the code is a little confusing, adding an item to failures\u0027 will cause a ... well failure.  We don\u0027t have a mechanism to return a warning from this code.\n\nI know I originally suggested we do that but I\u0027m not certain what value it has.\n\nI suggest you just add ```prereleases\u003dTrue``` to line 95 and that\u0027d basically be the sum total of the functional change.\n\nHaving said that I\u0027m assuming that modifying this behaviour will *NOT* then make generate-constraints start updating with prereleases","commit_id":"9d6a0b546f7cd0eb0bd0abf1dcec1d4be5c001ef"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1b04c484a98e618ba100737642f2a0955b3875f5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            spec \u003d specifiers.SpecifierSet(constraint.specifiers)"},{"line_number":95,"context_line":"            if spec.contains(version):"},{"line_number":96,"context_line":"                return True"},{"line_number":97,"context_line":"            if spec.contains(version, prereleases\u003dTrue):"},{"line_number":98,"context_line":"                failures.append(\u0027Constraint %s for %s is a prerelease\u0027 %"},{"line_number":99,"context_line":"                                (version, name))"},{"line_number":100,"context_line":"            tested.append(constraint.specifiers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_7f74a0fe","line":97,"in_reply_to":"9fdfeff1_64e419e2","updated":"2019-01-29 05:22:23.000000000","message":"Yup I think that\u0027s the right think to do, well along with a comment.","commit_id":"9d6a0b546f7cd0eb0bd0abf1dcec1d4be5c001ef"}]}