)]}'
{"id":"openstack%2Frequirements~701285","triplet_id":"openstack%2Frequirements~stable%2Ftrain~I80c7f1029e7827ccb59a043a6c2bc557fb664d3f","project":"openstack/requirements","branch":"stable/train","topic":"cap_openstack_client","hashtags":[],"change_id":"I80c7f1029e7827ccb59a043a6c2bc557fb664d3f","subject":"Constraint openstackclient for stable branch","status":"ABANDONED","created":"2020-01-06 21:39:23.000000000","updated":"2020-01-06 23:04:07.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d600dbbd73327d0e5199cb217df685f08a7f987c","_number":701285,"virtual_id_number":701285,"owner":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":-1,"date":"2020-01-06 22:53:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":-1,"date":"2020-01-06 22:18:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2020-01-06 21:40:34.000000000","_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},{"date":"2020-01-06 21:40:12.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-06 21:40:12.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2020-01-06 21:40:34.000000000","updated_by":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"reviewer":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"state":"REVIEWER"},{"updated":"2020-01-06 22:18:36.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-01-06 22:53:25.000000000","updated_by":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"reviewer":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"state":"REVIEWER"}],"messages":[{"id":"ce06f7732b9575f08751ca9d186ae48d27473d5b","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-01-06 21:39:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1dca4ae2639ec95523c6e8b3e2988c8601b21fed","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-01-06 21:58:09.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nI think the issue is just adding openstackclient to upper-constraints, not necessarily that there aren\u0027t stable branches. The relevant part is that a given branch needs to have the upper constraint for the library version that was tested during that cycle so when later branches pick up a newer version (because it\u0027s an independently released deliverable) it will need to have a proposal raising the upper-constraint that is tested like we do for any of our other libraries.\n\nSo I think this is probably OK to propose directly to stable branches, but it really needs to be added to master and others as well.","accounts_in_message":[],"_revision_number":1},{"id":"870fdd5fbd4d88202122941ac72acc45baf66c1a","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2020-01-06 22:06:40.000000000","message":"Patch Set 1:\n\nya, it seems we are getting quite a few packages that are constrained on stable branches only, maybe this is a more general issue?","accounts_in_message":[],"_revision_number":1},{"id":"af26f8ac8d62b0e54d083765bf3030552dc18290","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-01-06 22:18:36.000000000","message":"Patch Set 1: Code-Review-1\n\n\u003e ya, it seems we are getting quite a few packages that are\n \u003e constrained on stable branches only, maybe this is a more general\n \u003e issue?\n\nI don\u0027t think that\u0027s the case here though. This isn\u0027t an issue of something that needs to be constrained on stable branches only. It\u0027s an issue that we are using a lib but it\u0027s not being tracked for some reason.\n\nThough looking at this more, it\u0027s not tracked in global-requirements, so I don\u0027t see how someone is using this as a dependency. I don\u0027t believe it is supposed to be used that way. openstackclient is just a convenience wrapper on getting all python-openstackclient plugins installed. If a project needs some of those, it should be pulling in the plugins directly, not using this to pull in the world. So actually, I don\u0027t think we should do this. At least until we understand the whole story here.","accounts_in_message":[],"_revision_number":1},{"id":"64b1be6a1808194f6364dfc6408396f0f4d1a3bd","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2020-01-06 22:53:25.000000000","message":"Patch Set 1: Code-Review-1\n\nmaybe it\u0027s another instance to a project being used as a lib when it shouldn\u0027t be...\n\nlike neutron and horizon\n\nthat\u0027s what my gut is telling me at least","accounts_in_message":[],"_revision_number":1},{"id":"48783c681b2ee20ca72c967813962bc6cb0e6404","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-01-06 22:57:31.000000000","message":"Abandoned\n\nThis is being resolved by better check_plugin behavior https://review.opendev.org/#/c/701293/","accounts_in_message":[],"_revision_number":1},{"id":"fd14fcab771590400978a7f697d616c1c8b1cce8","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-01-06 23:02:45.000000000","message":"Patch Set 1:\n\nFurther discussion started here:\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-requirements/%23openstack-requirements.2020-01-06.log.html#t2020-01-06T22:20:03\n\nSummary is - the python-openstackclient repo is pulling in a job template defined in openstackclient. That repo and job are branchless, so they always refer to master. This results in any stable branch repos that are using this job template getting in requirements pulled in from master. This obviously breaks because that will end up getting newer versions of libs than what is in the stable branch\u0027s upper-constraints.\n\nSo since openstackclient is branchless, and the job itself not really being able to handle it, the \"correct\" approach (as far as we can tell so far) is to limit that job to only run on master.\n\nPatch to do that is here - https://review.opendev.org/#/c/701293/","accounts_in_message":[],"_revision_number":1},{"id":"3f50d13e6c143c7c61750454a93f9059ff2bdcaa","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-01-06 23:04:07.000000000","message":"Patch Set 1:\n\nInfra portion of the conversation was here for reference too -\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2020-01-06.log.html#t2020-01-06T22:40:00","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6c99f85e1a8be3b1c21b04740c9c2d854c33168d","revisions":{"6c99f85e1a8be3b1c21b04740c9c2d854c33168d":{"kind":"REWORK","_number":1,"created":"2020-01-06 21:39:23.000000000","uploader":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"ref":"refs/changes/85/701285/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/requirements","ref":"refs/changes/85/701285/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/requirements refs/changes/85/701285/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/requirements refs/changes/85/701285/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/requirements refs/changes/85/701285/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/requirements refs/changes/85/701285/1"}}},"commit":{"parents":[{"commit":"3e54878f9c87266e1b9775f72af06de27a3dad65","subject":"Add horizon to upper-constraints","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/requirements/commit/3e54878f9c87266e1b9775f72af06de27a3dad65"}]}],"author":{"name":"KeithMnemonic","email":"kberger@suse.com","date":"2020-01-06 21:38:36.000000000","tz":-480},"committer":{"name":"KeithMnemonic","email":"kberger@suse.com","date":"2020-01-06 21:39:22.000000000","tz":-480},"subject":"Constraint openstackclient for stable branch","message":"Constraint openstackclient for stable branch\n\nOpenstackclient[1] does not have stable branches. This is problematic because\ncomponents that depends on it will break whenever it releases a newer version\nwith requirements which conflicting with its dependents in the stable branch.\n\nThis patch constraints the openstackclient version that is compatible with the\nstable branch so we can bring back sanity and world peace.\n\n1. https://github.com/openstack/openstackclient\n\nChange-Id: I80c7f1029e7827ccb59a043a6c2bc557fb664d3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/requirements/commit/6c99f85e1a8be3b1c21b04740c9c2d854c33168d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/requirements/commit/6c99f85e1a8be3b1c21b04740c9c2d854c33168d"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}