)]}'
{"update.py":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"14888f8e02eaa6b0bbd575a9d16c9fe3648c42f7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return"},{"line_number":157,"context_line":"    has_pbr \u003d \u0027pbr\u0027 in open(target_setup_py, \u0027r\u0027).read()"},{"line_number":158,"context_line":"    if has_pbr:"},{"line_number":159,"context_line":"        print(\"Syncing setup.py\")"},{"line_number":160,"context_line":"        # We only want to sync things that are up to date with pbr mechanics"},{"line_number":161,"context_line":"        with open(target_setup_py, \u0027w\u0027) as setup_file:"},{"line_number":162,"context_line":"            setup_file.write(_setup_py_text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FVIA%3D","side":"PARENT","line":159,"updated":"2014-02-13 22:34:22.000000000","message":"I see what you\u0027re doing here, but not_pbr is a confusing name.\n\nHow about calling this \u0027is_pbr\u0027 and negating the logic expression you added to the if?","commit_id":"4dc3efdce37fdbc19e135cc2841f087549d51c8f"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"16e0d3f0ce8669948f272cdf6a22f66025849040","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return"},{"line_number":157,"context_line":"    has_pbr \u003d \u0027pbr\u0027 in open(target_setup_py, \u0027r\u0027).read()"},{"line_number":158,"context_line":"    if has_pbr:"},{"line_number":159,"context_line":"        print(\"Syncing setup.py\")"},{"line_number":160,"context_line":"        # We only want to sync things that are up to date with pbr mechanics"},{"line_number":161,"context_line":"        with open(target_setup_py, \u0027w\u0027) as setup_file:"},{"line_number":162,"context_line":"            setup_file.write(_setup_py_text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FNqc%3D","side":"PARENT","line":159,"in_reply_to":"AAAAUX%2F%2FVIA%3D","updated":"2014-02-15 13:53:40.000000000","message":"Done","commit_id":"4dc3efdce37fdbc19e135cc2841f087549d51c8f"},{"author":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"change_message_id":"bf1dc93d892457a2f6ff9a439d144d4994fa74c7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if not os.path.exists(target_setup_py):"},{"line_number":157,"context_line":"        return"},{"line_number":158,"context_line":"    has_pbr \u003d \u0027pbr\u0027 in open(target_setup_py, \u0027r\u0027).read()"},{"line_number":159,"context_line":"    not_pbr \u003d \u0027name \u003d pbr\u0027 not in open(setup_cfg, \u0027r\u0027).read()"},{"line_number":160,"context_line":"    if has_pbr and not_pbr:"},{"line_number":161,"context_line":"        print(\"Syncing setup.py\")"},{"line_number":162,"context_line":"        # We only want to sync things that are up to date with pbr mechanics"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FVGw%3D","line":159,"updated":"2014-02-13 22:38:12.000000000","message":"Please use the `with open(...); ` form, using files like this emits a warning in newer pythons","commit_id":"c094a74b302523c268f15d6642ca974ddd68d564"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"16e0d3f0ce8669948f272cdf6a22f66025849040","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if not os.path.exists(target_setup_py):"},{"line_number":157,"context_line":"        return"},{"line_number":158,"context_line":"    has_pbr \u003d \u0027pbr\u0027 in open(target_setup_py, \u0027r\u0027).read()"},{"line_number":159,"context_line":"    not_pbr \u003d \u0027name \u003d pbr\u0027 not in open(setup_cfg, \u0027r\u0027).read()"},{"line_number":160,"context_line":"    if has_pbr and not_pbr:"},{"line_number":161,"context_line":"        print(\"Syncing setup.py\")"},{"line_number":162,"context_line":"        # We only want to sync things that are up to date with pbr mechanics"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FNqs%3D","line":159,"in_reply_to":"AAAAUX%2F%2FVGw%3D","updated":"2014-02-15 13:53:40.000000000","message":"Done in the separated change - https://review.openstack.org/#/c/73808/1/update.py","commit_id":"c094a74b302523c268f15d6642ca974ddd68d564"}]}