)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"e9a1c7f61a4d78297e870916d1e5a8a2bc120a00","unresolved":false,"context_lines":[{"line_number":13,"context_line":"I will update the Django version in ``upper-constraints.txt\u0027 in a"},{"line_number":14,"context_line":"separate patch because if I update the Django version in"},{"line_number":15,"context_line":"upper-constraints.txt in the same patch requirements check-uc job"},{"line_number":16,"context_line":"starts failing."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://www.djangoproject.com/download/"},{"line_number":19,"context_line":"Change-Id: I7c22d7cc8092222a91a1da2bd65958bb3a9599eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ec7fd2a_ba4dd4b4","line":16,"updated":"2021-10-11 14:44:55.000000000","message":"It\u0027s ok if the check job fails for now, I\u0027d like to know nothing else breaks first (we can back out the upper-constraints bump once we verify it passes everything else)","commit_id":"a8d4c58bc160cc7b72fe270c774b3829ad44a5fa"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"eb2683f8da64c42d42c2287058a1afd67a457dec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"I will update the Django version in ``upper-constraints.txt\u0027 in a"},{"line_number":14,"context_line":"separate patch because if I update the Django version in"},{"line_number":15,"context_line":"upper-constraints.txt in the same patch requirements check-uc job"},{"line_number":16,"context_line":"starts failing."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://www.djangoproject.com/download/"},{"line_number":19,"context_line":"Change-Id: I7c22d7cc8092222a91a1da2bd65958bb3a9599eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"85c36e25_e6a5925d","line":16,"in_reply_to":"1ec7fd2a_ba4dd4b4","updated":"2021-10-11 15:45:09.000000000","message":"Done.","commit_id":"a8d4c58bc160cc7b72fe270c774b3829ad44a5fa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7731841646da7b9a42b55b37f2ffe8a1a28be071","unresolved":true,"context_lines":[{"line_number":16,"context_line":"starts failing."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://www.djangoproject.com/download/"},{"line_number":19,"context_line":"Change-Id: I7c22d7cc8092222a91a1da2bd65958bb3a9599eb"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I600d36a842ef56dfb01d932df079a32e7f7395e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cb19f023_ed7b186e","line":19,"updated":"2021-10-11 15:35:10.000000000","message":"This looks like a stray Change-Id belonging to your earlier patch, please remove this to avoid confusion.","commit_id":"a8d4c58bc160cc7b72fe270c774b3829ad44a5fa"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"eb2683f8da64c42d42c2287058a1afd67a457dec","unresolved":false,"context_lines":[{"line_number":16,"context_line":"starts failing."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://www.djangoproject.com/download/"},{"line_number":19,"context_line":"Change-Id: I7c22d7cc8092222a91a1da2bd65958bb3a9599eb"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I600d36a842ef56dfb01d932df079a32e7f7395e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fad492f_209751ea","line":19,"in_reply_to":"cb19f023_ed7b186e","updated":"2021-10-11 15:45:09.000000000","message":"Oh my bad:(","commit_id":"a8d4c58bc160cc7b72fe270c774b3829ad44a5fa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"08bfe2fabd54a3a705f2e754a3fdb35627884711","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7f989bfc_def8f7ba","updated":"2021-10-12 05:42:07.000000000","message":"\u003e Patch Set 4:\n\u003e \n\u003e looks like there are some changes needed for horizon before this can go though\n\nyeah, What I think We should do update Django version in global-requirements.txt first\nand then Update Django version in horizon in requirements.txt. After that bump Django version\nin upper-constraints.txt in openstack/requirements and then Update lower constraints version in\nopenstack/horizon.\nPlease correct If I am wrong.","commit_id":"09944b4df2922fb73293f8e68c216457d77a0e3e"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d04f4cb5c4a623a63d8f5b436f466ab2a050ccf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"24026449_a3b135aa","updated":"2021-10-22 10:32:18.000000000","message":"\u003e Patch Set 4:\n\u003e \n\u003e not yet, what would be better is to is:\n\u003e \n\u003e 1. Use this patch as a dependant patch to work on fixing horizon\u0027s compat with 3.2 (and hopefully 2.2).\n\u003e 2. Once horizon patch is ready we merge this patch\n\u003e 3. then we merge horizon\u0027s patch\n\u003e 4. then we handle updating the global requirements.\n\u003e \n\u003e normally for a big lib jump we try and have one major version of backwards compat\n\nHi, I have pushed a depends-on patch in horizon which is passing now https://review.opendev.org/c/openstack/horizon/+/811412 , also requirements [2] CI also pass once\nwe merged horizon patch.\n\n[2] https://review.opendev.org/c/openstack/requirements/+/815096 ","commit_id":"09944b4df2922fb73293f8e68c216457d77a0e3e"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1f971ae6866aee847b5305a223a7862e3b6c43a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"342c885a_4f5e1817","in_reply_to":"24026449_a3b135aa","updated":"2021-10-22 10:35:40.000000000","message":"So Should I update this patch with \u0027global-requirements.txt\u0027 changes only and then later I can update \u0027upper-constraints.txt\u0027 once horizon patch lands.","commit_id":"09944b4df2922fb73293f8e68c216457d77a0e3e"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"4f26b82e55c7146788e1074efdc4fd1335137046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"05a0f63c_12b5cbfb","in_reply_to":"7f989bfc_def8f7ba","updated":"2021-10-12 05:44:05.000000000","message":"Also Should I revert upper-constraints.txt changes to merge this patch?","commit_id":"09944b4df2922fb73293f8e68c216457d77a0e3e"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"dbadf850d1a9205233a3413a0f00691ae8325eb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff13a534_43a5f0dc","updated":"2021-10-22 16:53:40.000000000","message":"oops now horizon job starts failing if I didn\u0027t update \u0027upper-constraints.txt\u0027 :(.\nIf I update \u0027upper-constraints.txt\u0027 then cross-horizon job start failing for this patch.\nCould you advice how can merge this change, Do I have make the horizon cross job as non-voting to get it merged and then make it voting again or there are some other ways for that?","commit_id":"1c8fe31aee60f7cf9ac8261190387b2a5302a569"}]}
