)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"fc40168db2a7bf97b18a0c2d2c77d1576fb49466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb91683c_41c634a0","updated":"2022-04-12 11:54:09.000000000","message":"recheck","commit_id":"ffd2bae8d070e572935f44f658d63ba1f031bca2"}],"global-requirements.txt":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae35d3d37487f299a673077262403fb920d6d266","unresolved":true,"context_lines":[{"line_number":352,"context_line":"tooz  # Apache-2.0"},{"line_number":353,"context_line":"tosca-parser  # Apache-2.0"},{"line_number":354,"context_line":"tripleo-common  # Apache-2.0"},{"line_number":355,"context_line":"validations-libs\u003c1.7.0  # Apache-2.0"},{"line_number":356,"context_line":"urllib3  # MIT"},{"line_number":357,"context_line":"unicodecsv;python_version\u003c\u00273.0\u0027  # BSD"},{"line_number":358,"context_line":"warlock\u003c2  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"d69adae2_89c6096f","line":355,"updated":"2022-04-26 19:21:46.000000000","message":"upper-constraints already constrains this below this version. We shouldn\u0027t need to add this constraint in global-requirements.\n\nIt is also very difficult to remove these constraints once newer versions are available, so it should be avoided as much as possible.\n\nMaybe if your commit message actually stated what/why this is being done it would help, but with upper-constraints this shouldn\u0027t be needed.","commit_id":"59097fa9cc6dcb589517307e16aaf21558cca7d0"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"9a169d9ea3336b3717cd2a46976e38df7900c7df","unresolved":true,"context_lines":[{"line_number":352,"context_line":"tooz  # Apache-2.0"},{"line_number":353,"context_line":"tosca-parser  # Apache-2.0"},{"line_number":354,"context_line":"tripleo-common  # Apache-2.0"},{"line_number":355,"context_line":"validations-libs\u003c1.7.0  # Apache-2.0"},{"line_number":356,"context_line":"urllib3  # MIT"},{"line_number":357,"context_line":"unicodecsv;python_version\u003c\u00273.0\u0027  # BSD"},{"line_number":358,"context_line":"warlock\u003c2  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"ba9942b9_7ea9561f","line":355,"in_reply_to":"d69adae2_89c6096f","updated":"2022-04-27 06:35:10.000000000","message":"That\u0027s a good point. I didn\u0027t put the constraint in upper-constraints because there were cases when upper-constraints use blocked CI. At the time one of the mitigations was to drop upper-constraints from tox environments. \nSince we need to cap validations-libs at \u003c1.7.0 setting the constraint in requirements.txt, and therefore in the globals seemed like the only approach that would cover all cases.\n\nIt\u0027s possible that the situation was resolved in the meantime, I\u0027ll look into that and change the patch accordingly if that is the case.","commit_id":"59097fa9cc6dcb589517307e16aaf21558cca7d0"}]}