)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f232fcc6e7f741a00638fc086f6b62be4358cf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a7fbc90_47d91896","updated":"2022-05-30 11:06:17.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e the way I understand the discussion at the time is that we\u0027d start using the builtin python version\n\nThat would make sense if we weren\u0027t expecting importlib-metadata to change, however, they\u0027re still introducing features into this library that we\u0027d like to use. I need access to the \u0027packages_distributions\u0027 function [1] which was only introduced in Python 3.10 [2] but which was backported to the importlib-metadata rolling backport in version 4.4 of that library. Given this, it sounds like this is now the same situation as we faced with mock (the library) and we should use the same resolution, right?\n\n[1] https://review.opendev.org/c/openstack/cliff/+/842350/\n[2] https://docs.python.org/3/library/importlib.metadata.html#package-distributions\n[3] https://github.com/python/importlib_metadata#compatibility","commit_id":"9017ffebf7af69e99dbb49d796694f5bf186cfd7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b150da32e831fb46a6cf1131c4a7939cb97b4d4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"227d414d_ca65b397","updated":"2022-05-31 05:09:04.000000000","message":"I think you\u0027ll also have to drop it from u-c, see e.g. https://zuul.opendev.org/t/openstack/build/5504f6afb3ce46fdad29afd9e0b59e19","commit_id":"9017ffebf7af69e99dbb49d796694f5bf186cfd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"02888841dda395755eefdd332f4c518df0a473fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f64e229f_1cc0702c","in_reply_to":"227d414d_ca65b397","updated":"2022-05-31 11:37:02.000000000","message":"Oh, how do I do that? Simply drop it? Do I need to add it to blacklist.txt?","commit_id":"9017ffebf7af69e99dbb49d796694f5bf186cfd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e45c73ceb170f4cb4a5ad0d374db71a6f38240d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f7bdc54_1c3ee23d","in_reply_to":"5d1c8046_ad1917e9","updated":"2022-05-31 11:52:29.000000000","message":"\u003e IIUC just drop it manually, once it is no longer in g-r, it shouldn\u0027t get re-added. But the removal also isn\u0027t automated, afaict. Or maybe the next proposal bot run would do it? But I think it is better to do it in a single patch.\n\nOkay so just delete the line? Because there\u0027s no python version specifier present on the entry in upper-constraints.txt\n\n\u003e Btw. the failure I posted is more due to running with master constraints on bionic, which no longer will work. The cleanup in this patch still seems to be sane regardless of that.\n\nAh, okay. Ignore my follow-up comment above so.","commit_id":"9017ffebf7af69e99dbb49d796694f5bf186cfd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa9eeb0767cc72dd242c92c194a4839dbeaee457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4163b819_6dc24ee5","in_reply_to":"7f7bdc54_1c3ee23d","updated":"2022-05-31 15:12:14.000000000","message":"Looks like I can\u0027t do this. I tried in [1] and got the following:\n\n  \u0027importlib-metadata\u0027 appears in global-requirements.txt but not upper-constraints.txt or blacklist.txt\n\n[1] https://review.opendev.org/c/openstack/requirements/+/844042/1","commit_id":"9017ffebf7af69e99dbb49d796694f5bf186cfd7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"29dc82c0ac97c31bee056d66e221217c826a20cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d1c8046_ad1917e9","in_reply_to":"f64e229f_1cc0702c","updated":"2022-05-31 11:50:26.000000000","message":"IIUC just drop it manually, once it is no longer in g-r, it shouldn\u0027t get re-added. But the removal also isn\u0027t automated, afaict. Or maybe the next proposal bot run would do it? But I think it is better to do it in a single patch.\n\nBtw. the failure I posted is more due to running with master constraints on bionic, which no longer will work. The cleanup in this patch still seems to be sane regardless of that.","commit_id":"9017ffebf7af69e99dbb49d796694f5bf186cfd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"78be51fabf337aed36c1beaefb63de6f463980ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ea87514_dda0a0fe","in_reply_to":"f64e229f_1cc0702c","updated":"2022-05-31 11:49:42.000000000","message":"Weird. I can\u0027t reproduce this locally. How is this happening?\n\n  $ cat requirements.txt \n  sphinx\n\n  $ cat constraints.txt \n  importlib-metadata\u003d\u003d\u003d4.11.4\n\n  $ virtualenv .venv --python\u003dpython3.8\n  $ source .venv/bin/activate\n  $ pip install -r requirements.txt -c constraints.txt\n  Collecting sphinx\n  ...\n  Successfully installed Jinja2-3.1.2 MarkupSafe-2.1.1 ...\n\nI wonder if this is the real root cause? Am I missing something?","commit_id":"9017ffebf7af69e99dbb49d796694f5bf186cfd7"}]}