)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"8d2c10067b11f7c4051279370f6462f6be5b8350","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"096b96f4_40a7cb12","updated":"2022-08-01 04:45:25.000000000","message":"I\u0027m not opposed to this but I\u0027d like to know why?\n\nI\u0027ve been away from python/OpenStack for a while but what is the advantage to doing this?\n\nIf you\u0027re going to do it then why *only* this file/instances?\n\n requirements$ (git grep -E \u0027u\"\u0027 ; git grep -E \"u\u0027\") | wc -l\n 37\n","commit_id":"2d4c76f8cef914413bf080dfa262153f487a6bf1"},{"author":{"_account_id":35058,"name":"Ke Niu","email":"niuke@inspur.com","username":"niuke"},"change_message_id":"3eef9e441826c3d5ea26c14995eac72b27d28150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"854a4ec4_a186c1f0","in_reply_to":"096b96f4_40a7cb12","updated":"2022-08-30 05:58:02.000000000","message":"Done","commit_id":"2d4c76f8cef914413bf080dfa262153f487a6bf1"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"97987771844704ca111119a5734e7eb5f6f37940","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8fb1c7a_3b14314c","updated":"2022-08-18 15:26:34.000000000","message":"I\u0027m giving this a -1 beacuse we\u0027d need answers to previous questions.\n\nIn short 1) Why are we doing this? ; and 2) Please do it over the entire repo.","commit_id":"9713d29d100c35dcce2d8d33194baae410011f51"},{"author":{"_account_id":35058,"name":"Ke Niu","email":"niuke@inspur.com","username":"niuke"},"change_message_id":"3eef9e441826c3d5ea26c14995eac72b27d28150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0d193574_a992c719","in_reply_to":"a8fb1c7a_3b14314c","updated":"2022-08-30 05:58:02.000000000","message":"Done","commit_id":"9713d29d100c35dcce2d8d33194baae410011f51"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c1f584a367b8cfd48aa11ff15d5a19308a628b11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a99670b_7f7efaaf","updated":"2022-08-26 02:27:16.000000000","message":"\u003e Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.\n\nRe-uploading the same patch again isn\u0027t helpful or productive.  Please address the feedback from my previous reviews.","commit_id":"13751fec005f01e26f734c041d5d34472f4af437"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"066a29e8e2ea322f904914ebe03decc68a3590cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5320448e_e1d58e62","updated":"2022-08-30 03:16:35.000000000","message":"Agree with Tony, thanks.","commit_id":"a7c27fba03e10b3ebef6156d79eb2850c4e2efed"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2c3247f9f5588b0b17b8d37aea5efa6a1fdbd4ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9722c26d_51881ab9","updated":"2022-08-29 18:39:41.000000000","message":"Hi Thanks again for your change.\n\nI/We do have several questions, the most important is Why?  Why shoud we remove these annotations?  Does it case any incompatibility?\n\nThe second is please make the chnages uniform, with this patset there are still several unicode strings and to my mind it doesn\u0027t make sense to only do part of the codebase.\n\n [tony@thor requirements]$ git rev-parse HEAD\n a7c27fba03e10b3ebef6156d79eb2850c4e2efed\n [tony@thor requirements]$ (git grep -E \u0027u\"\u0027 ; git grep -E \"u\u0027\") | wc -l\n 23\n","commit_id":"a7c27fba03e10b3ebef6156d79eb2850c4e2efed"},{"author":{"_account_id":35058,"name":"Ke Niu","email":"niuke@inspur.com","username":"niuke"},"change_message_id":"3eef9e441826c3d5ea26c14995eac72b27d28150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"100624fc_0285cfc6","in_reply_to":"1cae0157_d1dc7928","updated":"2022-08-30 05:58:02.000000000","message":"Thank you. I have finished the revision. Thanks again for your careful advice.","commit_id":"a7c27fba03e10b3ebef6156d79eb2850c4e2efed"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"066a29e8e2ea322f904914ebe03decc68a3590cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1cae0157_d1dc7928","in_reply_to":"85859996_ee6943a2","updated":"2022-08-30 03:16:35.000000000","message":"\u003e The second is please make the chnages uniform, with this patset there are still several unicode strings and to my mind it doesn\u0027t make sense to only do part of the codebase.\n\u003e \n\u003e  [tony@thor requirements]$ git rev-parse HEAD\n\u003e  a7c27fba03e10b3ebef6156d79eb2850c4e2efed\n\u003e  [tony@thor requirements]$ (git grep -E \u0027u\"\u0027 ; git grep -E \"u\u0027\") | wc -l\n\u003e  23\n\u003e \n\nYes, you should remove all unicode from this project ASAP, reduce the workload of repeated submission and review.","commit_id":"a7c27fba03e10b3ebef6156d79eb2850c4e2efed"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"edff3565f09006876fbbd52637df52ba00f9bdf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"85859996_ee6943a2","in_reply_to":"9722c26d_51881ab9","updated":"2022-08-30 02:59:30.000000000","message":"\u003e Hi Thanks again for your change.\n\u003e \n\u003e I/We do have several questions, the most important is Why?  Why shoud we remove these annotations?  Does it case any incompatibility?\n\u003e \n\u003e The second is please make the chnages uniform, with this patset there are still several unicode strings and to my mind it doesn\u0027t make sense to only do part of the codebase.\n\u003e \n\u003e  [tony@thor requirements]$ git rev-parse HEAD\n\u003e  a7c27fba03e10b3ebef6156d79eb2850c4e2efed\n\u003e  [tony@thor requirements]$ (git grep -E \u0027u\"\u0027 ; git grep -E \"u\u0027\") | wc -l\n\u003e  23\n\u003e \n\nAll strings are considered as unicode string from Python 3.\n\nThis patch drops the explicit unicode literal (u\u0027...\u0027)\nappearances from the unicode strings.","commit_id":"a7c27fba03e10b3ebef6156d79eb2850c4e2efed"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e402b8581388037fed595ee72fd146a96180c74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1d9712be_d0b1d9f6","updated":"2022-08-30 04:56:28.000000000","message":"I don\u0027t see why this should be done, either. While the u\u0027 prefix is redundant in python3, it is also not deprecated in any way afaict, so I don\u0027t see a reason to touch all this code, especially not the urgency.","commit_id":"dc7a81b3bf1f0bf1f8a133be3b4190e344ac63f7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"bf521ed1328bdfc7f8a07dd8854f55863a5fad59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ceb717c6_381057ef","updated":"2022-08-30 06:15:13.000000000","message":"Ke Niu is a new contributor who want to join OpenStack community, thank you for your guidance, I think he can learn more at this time.\n\nFrom Tony, you can know 1) Know what it is and what it is; and 2) Get things right once.\nFrom frickler, you can know, for uncertain things please asking project team or IRC firstly, then decide what to do or not to do.\n\nYou can spend more time digging into a favorite project, allowing yourself to be more deeply involved in the community.\n","commit_id":"dc7a81b3bf1f0bf1f8a133be3b4190e344ac63f7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"bf521ed1328bdfc7f8a07dd8854f55863a5fad59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2fed2057_db234058","in_reply_to":"1d9712be_d0b1d9f6","updated":"2022-08-30 06:15:13.000000000","message":"Agree, it\u0027s not urgency. 😊\n\nRemoval, friendly support for python3, and maintaining the consistency of the community code of each project; and keeping it will not affect anything.","commit_id":"dc7a81b3bf1f0bf1f8a133be3b4190e344ac63f7"},{"author":{"_account_id":35058,"name":"Ke Niu","email":"niuke@inspur.com","username":"niuke"},"change_message_id":"ef1640c8c1cf50fed019974bf63ba517434555d7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f4861458_4f6d6845","in_reply_to":"ba5f8470_5d2fd9fb","updated":"2022-08-30 06:27:14.000000000","message":"Ok, thank you very much for your instruction. I will pay attention to it in the future.","commit_id":"dc7a81b3bf1f0bf1f8a133be3b4190e344ac63f7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"526c6e0a12abd4efc761cb6a5e91d02ecdf95376","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ba5f8470_5d2fd9fb","in_reply_to":"ceb717c6_381057ef","updated":"2022-08-30 06:22:16.000000000","message":"Well I am part of a number of project teams and I haven\u0027t seen any discussion about this topic before. Doing mass patches without prior discussion with the project teams is neither helpful nor a good way to introduce oneself to the community. So feel welcome to join the team in #openstack-requirements and discuss this topic.","commit_id":"dc7a81b3bf1f0bf1f8a133be3b4190e344ac63f7"}]}
