)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"99b6f221d78d54374380f81e3584d910b52f0d2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89c2c60e_c951dcc6","updated":"2023-08-18 08:38:28.000000000","message":"Version 0.0.4 certainly doesn\u0027t sound mature to me. I would prefer if you could make using it in aodh optional for now. The commit message also still doesn\u0027t answer a lot of the required questions.\n\nIn addition the library doesn\u0027t claim support for python3.10, which is required now, and python3.11 very likely in a few weeks.","commit_id":"7325e5c2f960d0c34fc2818a7b006de23beaae8f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"673e1ce8196d31f75377651a3c3b734722b8c0f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64d37350_baa7a3d7","in_reply_to":"5ad756f0_3941c096","updated":"2023-08-21 08:42:15.000000000","message":"You can either make the import only happen in the code that actually needs it or wrap it in a try/except block. That will allow all existing functionality to keep working, just your new code can then raise an exception or generate an error if the module isn\u0027t availble.","commit_id":"7325e5c2f960d0c34fc2818a7b006de23beaae8f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"2fc5dacc4afbc8bb88cf83fa758499ad334f60d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f758d6e6_b10162a6","in_reply_to":"64d37350_baa7a3d7","updated":"2023-08-29 18:40:44.000000000","message":"ACK, will do it this way then and abandon this patch. I can revive this review once the project is more acceptable as dependency.","commit_id":"7325e5c2f960d0c34fc2818a7b006de23beaae8f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"e2e459a8810b19db77fb9cb11271d0fcc19385a9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5ad756f0_3941c096","in_reply_to":"89c2c60e_c951dcc6","updated":"2023-08-18 08:44:55.000000000","message":"Ok, how can I make it as aodh optional dependency?","commit_id":"7325e5c2f960d0c34fc2818a7b006de23beaae8f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"673e1ce8196d31f75377651a3c3b734722b8c0f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"947ebf20_40ee6715","updated":"2023-08-21 08:42:15.000000000","message":"Seeing that this new library is an OSC plugin, but not within OpenStack governance, I have even more concerns about making it required globally, since we have to ensure that no namespace collisions occur for OSC commands and that the common standards for OSC plugins are being followed. Adding sdks PTL to chime in on this.","commit_id":"037c15892f19ec9ddb6272f76e6d89e122898cb6"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"11ce05bf6d484eafc215b141dc61c589016be2a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e502ec4b_314803b1","updated":"2023-08-29 06:53:47.000000000","message":"The tool seems to be in the early development stages, maintenance guarantee is unclear. Having official project depend on unofficial one-man tool, which claims to be OpenStack related but not under OpenStack seems really weird. Though I am not going to block that from OSC/SDK side","commit_id":"037c15892f19ec9ddb6272f76e6d89e122898cb6"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"2fc5dacc4afbc8bb88cf83fa758499ad334f60d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09834e12_e88fcc15","in_reply_to":"e502ec4b_314803b1","updated":"2023-08-29 18:40:44.000000000","message":"Although the library is currently developed by single engineer, it is not a one-man-show project. It is a part or bigger initiative to make autoscaling work with Prometheus instead of Gnocchi. As I wrote above, I will abandon this review now and revive it once the project is more acceptable as hard dependency.","commit_id":"037c15892f19ec9ddb6272f76e6d89e122898cb6"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"794135110cb749544aa6e178aa618c4f201b448a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00f1adfc_785fe412","updated":"2023-09-08 09:27:52.000000000","message":"Restored to see if it\u0027s possible to have the dependency at least as test requirement.","commit_id":"2e6bed84e6e7d1291f7f47c9ffe33c091c1611bb"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"05a662ef7be80e3a179b5fcd10afb2a355a5c1d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"903b7b97_5aa61c61","updated":"2023-09-19 09:09:26.000000000","message":"Revived again. The project is now under OpenStack umbrella, so will add it to global requirements again.","commit_id":"2e6bed84e6e7d1291f7f47c9ffe33c091c1611bb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"442f5e95cdcf6dae0fc3a5ca0781dd704e549fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f2d784a6_99679e3d","updated":"2023-09-08 09:51:47.000000000","message":"This file is only for testing requirements of the requirements repo tooling","commit_id":"2e6bed84e6e7d1291f7f47c9ffe33c091c1611bb"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"1286d140b621bca495bd57fad8fa743d3c4b6aee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7fc0b407_525bdefb","updated":"2023-09-12 06:24:30.000000000","message":"This should be dropped in favor of https://review.opendev.org/c/openstack/project-config/+/894541","commit_id":"2e6bed84e6e7d1291f7f47c9ffe33c091c1611bb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d21a2b2ec5b5b383273e86667e045fb9aa6ccef9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b1460e2_3e9edc27","in_reply_to":"48bde1dd_8376b618","updated":"2023-09-11 05:17:53.000000000","message":"You can add a Depends-On footer from your patch to this one in order to verity.","commit_id":"2e6bed84e6e7d1291f7f47c9ffe33c091c1611bb"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3627506a14affd0530393d7c250262a5f249687b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48bde1dd_8376b618","in_reply_to":"f2d784a6_99679e3d","updated":"2023-09-08 10:36:01.000000000","message":"Is it? So the test-requirements.txt in projects are also tested by the global-requirements file? I\u0027m asking because I\u0027ve hit [1].\n\n[1] https://zuul.opendev.org/t/openstack/build/4ff1e607b06544328796362f44188179/log/job-output.txt#609","commit_id":"2e6bed84e6e7d1291f7f47c9ffe33c091c1611bb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0d8454814e3fd4670f3534d2088e013abcc7117","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8da42ffb_4afde229","updated":"2023-10-19 18:42:10.000000000","message":"Ack, just update with the latest release and fix the things you marked done but actually didn\u0027t","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"356ee8f3a1cd8d2f19f740edfdba179dbdafecdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"87d30ae8_d2dc856a","updated":"2023-10-04 17:43:54.000000000","message":"Martin, can we proceed here now?","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"99313fd36394035400ae2c0e5ed09b7eef6cd230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82aa47b3_f08bf393","updated":"2023-10-20 05:52:23.000000000","message":"Martin, you may have an updated version of this patch that didn\u0027t get pushed up for review?","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c69f776d24a369a55bc2fc97777dcb6dcbf6b2ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"831b8052_ad761b12","updated":"2023-09-20 10:03:51.000000000","message":"Technical -2 until the freeze for the current release is over.\n\nI would prefer if there could be an actual release be made from the imported project before we add it to global requirements, so that we have docs and releasnotes in place.\n\nPlease also see my comments inline.","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"b4a90efca1ccfaa95fed88cf4e9ea90c492476cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6799e9b5_4e1b505c","updated":"2023-09-19 14:12:43.000000000","message":"this one already merged https://review.opendev.org/c/openstack/project-config/+/894541","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"c087493c6c514ae3ee53253189c333fa0f16a62a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2c8f6cc_a36136e0","in_reply_to":"1fa376d0_af155360","updated":"2023-10-19 13:55:42.000000000","message":"So the release patch [1] has been merged. Can we proceed with this patch now?\n\n[1] https://review.opendev.org/c/openstack/releases/+/896910","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"98eed0ab44594f9ab5d7a0d4a2d6be1edd1387c8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1fa376d0_af155360","in_reply_to":"2a1faefa_1d0760b6","updated":"2023-09-21 18:22:53.000000000","message":"Yes, I\u0027m talking about actually tagging a new version, producing release artefacts and publishing to pypi. Since the project is under openstack governance now, it will have to follow the same process as all other telemetry projects. I think https://releases.openstack.org/reference/using.html would be the best documentation to read plus maybe https://docs.openstack.org/project-team-guide/release-management.html","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"9a91af6879688b5ffe9894d2e5496a0255d4f3f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2a1faefa_1d0760b6","in_reply_to":"831b8052_ad761b12","updated":"2023-09-21 06:54:47.000000000","message":"What do you mean by making actual release exactly? Is there anything else that needs to be done than creating release notes and docs?","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"bb927b57df500e2e44086633099e7287fd67f16b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"61796681_059ca160","in_reply_to":"87d30ae8_d2dc856a","updated":"2023-10-05 11:59:12.000000000","message":"Nope. There is still no caracal release set up in openstack/releases, so I cannot continue with [1] which is a prerequisite of this patch.\n\n[1] https://review.opendev.org/c/openstack/releases/+/896910","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"}],"test-requirements.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c69f776d24a369a55bc2fc97777dcb6dcbf6b2ef","unresolved":true,"context_lines":[{"line_number":9,"context_line":"virtualenv\u003e\u003d14.0.6 # MIT"},{"line_number":10,"context_line":"setuptools!\u003d24.0.0,!\u003d34.0.0,!\u003d34.0.1,!\u003d34.0.2,!\u003d34.0.3,!\u003d34.1.0,!\u003d34.1.1,!\u003d34.2.0,!\u003d34.3.0,!\u003d34.3.1,!\u003d34.3.2,!\u003d36.2.0,\u003e\u003d21.0.0 # PSF/ZPL"},{"line_number":11,"context_line":"bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":12,"context_line":"python-observabilityclient\u003e\u003d0.0.4 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"cbec4830_ed9a4b2f","line":12,"updated":"2023-09-20 10:03:51.000000000","message":"this still doesn\u0027t belong here","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"9a91af6879688b5ffe9894d2e5496a0255d4f3f1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"virtualenv\u003e\u003d14.0.6 # MIT"},{"line_number":10,"context_line":"setuptools!\u003d24.0.0,!\u003d34.0.0,!\u003d34.0.1,!\u003d34.0.2,!\u003d34.0.3,!\u003d34.1.0,!\u003d34.1.1,!\u003d34.2.0,!\u003d34.3.0,!\u003d34.3.1,!\u003d34.3.2,!\u003d36.2.0,\u003e\u003d21.0.0 # PSF/ZPL"},{"line_number":11,"context_line":"bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":12,"context_line":"python-observabilityclient\u003e\u003d0.0.4 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"2f1bfa38_d6930aee","line":12,"in_reply_to":"cbec4830_ed9a4b2f","updated":"2023-09-21 06:54:47.000000000","message":"Done","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"}],"upper-constraints.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c69f776d24a369a55bc2fc97777dcb6dcbf6b2ef","unresolved":true,"context_lines":[{"line_number":600,"context_line":"sysv-ipc\u003d\u003d\u003d1.1.0"},{"line_number":601,"context_line":"sphinxcontrib-applehelp\u003d\u003d\u003d1.0.4"},{"line_number":602,"context_line":"scikit-learn\u003d\u003d\u003d1.2.2"},{"line_number":603,"context_line":"python-observabilityclient\u003d\u003d\u003d0.0.4"}],"source_content_type":"text/plain","patch_set":6,"id":"8eee45f3_35d9a73e","line":603,"updated":"2023-09-20 10:03:51.000000000","message":"nit: missing newline at the end of the file","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"99313fd36394035400ae2c0e5ed09b7eef6cd230","unresolved":false,"context_lines":[{"line_number":600,"context_line":"sysv-ipc\u003d\u003d\u003d1.1.0"},{"line_number":601,"context_line":"sphinxcontrib-applehelp\u003d\u003d\u003d1.0.4"},{"line_number":602,"context_line":"scikit-learn\u003d\u003d\u003d1.2.2"},{"line_number":603,"context_line":"python-observabilityclient\u003d\u003d\u003d0.0.4"}],"source_content_type":"text/plain","patch_set":6,"id":"873a8209_c5be1efc","line":603,"in_reply_to":"27314e76_f5ab3de9","updated":"2023-10-20 05:52:23.000000000","message":"so after the release on pypi, it needs to read\npython-observabilityclient\u003d\u003d\u003d0.1.0\n\nright?","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"9a91af6879688b5ffe9894d2e5496a0255d4f3f1","unresolved":false,"context_lines":[{"line_number":600,"context_line":"sysv-ipc\u003d\u003d\u003d1.1.0"},{"line_number":601,"context_line":"sphinxcontrib-applehelp\u003d\u003d\u003d1.0.4"},{"line_number":602,"context_line":"scikit-learn\u003d\u003d\u003d1.2.2"},{"line_number":603,"context_line":"python-observabilityclient\u003d\u003d\u003d0.0.4"}],"source_content_type":"text/plain","patch_set":6,"id":"27314e76_f5ab3de9","line":603,"in_reply_to":"8eee45f3_35d9a73e","updated":"2023-09-21 06:54:47.000000000","message":"Done","commit_id":"8d359bad4ad1e02dffb9e000b75bcf31d3a87e26"}]}