)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"32671e4b45d062e8b1d9ba41a6cc071853803396","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c98c063_091acd70","updated":"2024-04-05 21:21:26.000000000","message":"These aren\u0027t installed by default, but they are tracked as part of the \"optional requirements\" of driver installations: https://opendev.org/openstack/cinder/src/branch/master/driver-requirements.txt\n\nSo it really depends on the configuration. Maybe one of the more active Cinder cores can weigh in on whether this is still tracked and tested somehow.","commit_id":"d7212e13aa564d8302c8aaba9ec8904a8cfd2056"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bdc60eb300470ac5895c6169830285951c977647","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e992e28_807fe8b6","updated":"2024-04-06 09:04:48.000000000","message":"We should also remove `dfs-sdk` (I missed that due to it being called `dfs_sdk` in cinder\u0027s `driver-requirements.txt`","commit_id":"d7212e13aa564d8302c8aaba9ec8904a8cfd2056"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0a931f0fb094d277c69c1cbb20e11627aa5aca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9fbf2e9_4a89e4c8","in_reply_to":"7c98c063_091acd70","updated":"2024-04-06 09:03:34.000000000","message":"We should, but the note in that file suggests what I\u0027m doing here is correct:\n\n```\n# Document dependencies that are only used if using\n# certain drivers.  This file is not managed by\n# requirements tools.\n# check [extras] section of setup.cfg for versions.\n```\n\nAlso, we\u0027re missing a few dependencies here that are listed there:\n\n- `python-lefthandclient`\n- `pyxcli`\n- `infi.dtypes.wwn`\n- `infi.dtypes.iqn`\n\nSo if these are to stay here, we should probably add those and start checking `driver-requirements.txt` against machinery (but I don\u0027t think we should).","commit_id":"d7212e13aa564d8302c8aaba9ec8904a8cfd2056"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6eb77d1e8f912f273cd3c3a818200e3b8e17ea32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a99f61c3_07067c06","in_reply_to":"7e992e28_807fe8b6","updated":"2024-04-06 09:09:47.000000000","message":"Done","commit_id":"d7212e13aa564d8302c8aaba9ec8904a8cfd2056"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ca11493672a999a1abe37732dcab5c869e2fea95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"07102c74_b4a967d5","updated":"2024-04-07 06:41:43.000000000","message":"shouldn\u0027t these also be dropped from u-c, then?","commit_id":"15c40d03b2178bf1db5cccb069cf608724998ac6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"877b207af4f3134b5abec4ab6106a7dd41c0959a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f14399d5_b0c2fc22","in_reply_to":"07102c74_b4a967d5","updated":"2024-04-08 11:46:02.000000000","message":"Good point. Yes, they should","commit_id":"15c40d03b2178bf1db5cccb069cf608724998ac6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3625102a111e31988e09ab41a8ac9bfb14a5ac18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"592586ab_4a198146","updated":"2024-04-08 13:26:16.000000000","message":"Brian makes a good point.","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e49c6184e10b21e304a599f01c5c5cce6c86d29a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28e2ae0d_392488c5","updated":"2024-09-27 07:45:39.000000000","message":"Dropping the -2 now since I\u0027ll be on holiday over the next weeks, but IMO best wait with approving until after the release is finished","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a71f033cee0350e39719f3535917f329b46ab04c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d1f8d8a5_3fda2907","updated":"2024-04-09 14:36:08.000000000","message":"I am having second thoughts about removing them from upper-constraints as well.  A site that uses some particular cinder backend may also use it for manila and glance_store, so we do have some co-installability concerns, plus given that openstack lags behind other libraries in terms of what versions of python they support, it would be good to have these in upper constraints.","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"645a19dcd7d3cd9a7a2f888797bd683091780c50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d0e175e2_f27d4a84","updated":"2024-04-11 02:28:56.000000000","message":"I\u0027m happy to go either way on this.\n\nfull removal from global-requirements and upper-constraints *OR* adding the drivers-requirements.txt to the check machinery. \n\nEach has pros and cons.","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b31788544fe88ea299c6289a30951368d629edd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d5b44d7f_40b9eab7","updated":"2024-04-08 13:25:16.000000000","message":"I\u0027m ok with removing these from upper constraints, but I think they should stay in global requirements.  As the dependency management docs say, \"Global requirements gives us a single place where we can evaluate these things so that we can make a global decision for OpenStack on the suitability of the library.\"[0]\n\nSome of these driver-specific requirements are used by multiple projects, e.g., cinder and glance and manila, so I think it makes sense that these should be reviewed at a higher level than just the cinder project, for example.  Additionally, the projects (cinder, for example) when proposing to use a library, benefit from some review from the requirements team, and can backstop licensing issues and other red flags.\n\n\n[0] https://docs.openstack.org/project-team-guide/dependency-management.html","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3cd0524ff1b9a1dcb03830437aee60ae29edf04c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7dc02252_db91b0ce","updated":"2025-02-21 15:23:53.000000000","message":"Might be good to refresh this.","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a40f2b96be5e17d53d510d16f8f669b751a88c77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a08c54c3_1ebcf27a","updated":"2024-04-08 13:19:56.000000000","message":"Seems right now.","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ea7872db59b42ccb9c715d7a9878bd8057681753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47558a17_e524a448","updated":"2024-04-08 13:05:50.000000000","message":"i also feel the setup.cfg file handles the installation of driver specific requirements[1] but i will add more cinder cores to the conversation.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/setup.cfg#L79-L125","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"01e2d6078486b7869ea91eb19fe6f5d5628a37a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8273d00_313b5865","updated":"2025-02-28 18:31:32.000000000","message":"next reqs freeze","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d5c469f0c6ab00cd1d0f4f860ee3d2d0e0109b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3bbe7f67_6ea402bf","updated":"2024-08-31 03:41:11.000000000","message":"procedural -2 since we are in reqs freeze now, but also asking whether you still want to move on with this for the next cycle or whether it should be abandoned?","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"963553c280ad4b43a95fcc62f78715b401e74615","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc90a2dd_46d7f91d","updated":"2025-03-28 16:35:50.000000000","message":"still needs a refresh","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b7ad43053835bde41937fcebb9659f5076e53c40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05bd0f62_5d076672","in_reply_to":"d1f8d8a5_3fda2907","updated":"2024-04-09 17:20:21.000000000","message":"This is a fair point. If this is the case, do we need to start testing those dependencies via the requirements job and do we need to add the missing dependencies noted previously?\n\n\u003e - `python-lefthandclient`\n\u003e - `pyxcli`\n\u003e - `infi.dtypes.wwn`\n\u003e - `infi.dtypes.iqn`","commit_id":"5c041106f8594211eec0c11201a3222dcdb95bdf"}]}