)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3e2bb4a63949a334f77ddf826756f05ea20e8a31","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Weininger \u003ctweining@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-15 14:30:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add and pin some more types packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The added packages are used in [1] to allow mypy do proper type checking"},{"line_number":10,"context_line":"in the Octavia project. The pinning of versions in u-c is needed in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"f7b0591d_591ec9bd","line":7,"updated":"2024-04-15 13:04:52.000000000","message":"Just to point out, this isn\u0027t what we call pinning. That would be restricting the version in the global requirements file. We _always_ put a limit in upper constraints for requirements to make sure we control which versions are used and that new releases of dependencies don\u0027t randomly break things.","commit_id":"1f97af70a0c967798920f89f4189af289cc09a32"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7582f6184b878bb173085c501441960fb2a5de8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Weininger \u003ctweining@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-15 14:30:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add and pin some more types packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The added packages are used in [1] to allow mypy do proper type checking"},{"line_number":10,"context_line":"in the Octavia project. The pinning of versions in u-c is needed in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e467c501_975d8ed3","line":7,"in_reply_to":"f7b0591d_591ec9bd","updated":"2024-04-24 16:22:46.000000000","message":"thanks. I updated the commit message.","commit_id":"1f97af70a0c967798920f89f4189af289cc09a32"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bc8394bded85f6e4f612336ba138cb624089da28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c5d1906d_12115a1b","updated":"2024-04-10 15:02:58.000000000","message":"New packages in g-r are still missing from u-c.","commit_id":"93f345cd2e6b102aaba198b2c41cf9ca9510e887"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0a842aceee64560cc0ca3081a4ad615253abc3f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"150e3ce5_85f0f40b","in_reply_to":"c5d1906d_12115a1b","updated":"2024-04-10 16:33:30.000000000","message":"Only types-setuptools was missing in u-c. types-python-dateutil is there already.","commit_id":"93f345cd2e6b102aaba198b2c41cf9ca9510e887"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"93997c00f5b25dd7b7e9ce1e6c0b6a6be7a268a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b2a8d23b_62b2372c","updated":"2024-04-29 20:45:43.000000000","message":"FWIW I wouldn\u0027t have blocked this change but I feel like it introduces a new sort of tech-debt (that needs to be tracked by the requirements team) due to the way Python has added type support.\n\nAs far as I can tell type support is ignored at runtime and is essentially a fancy linter[1].  Since Iaf6d2c4aed92f35240b393939bbf76fd7d5d9aa2 we have mypy in blacklist.txt [2],  Type packages aren\u0027t needed at runtime and do not require global coordination.\n\n\n[1] Frome: https://docs.python.org/3/library/typing.html\n    \"The Python runtime does not enforce function and variable type annotations. They can be used by third party tools such as type checkers, IDEs, linters, etc.\"\n[2] https://review.opendev.org/c/openstack/requirements/+/903751","commit_id":"f624135ca4c4ba5ea0a119ab89ef7818ea9a4c18"}],"upper-constraints.txt":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"db1a234dd89dc50b965112d138c5de035ea7d3f4","unresolved":true,"context_lines":[{"line_number":478,"context_line":"infi.dtypes.nqn\u003d\u003d\u003d0.1.0"},{"line_number":479,"context_line":"looseversion\u003d\u003d\u003d1.3.0"},{"line_number":480,"context_line":"six\u003d\u003d\u003d1.16.0"},{"line_number":481,"context_line":"types-six\u003d\u003d\u003d1.16.0"},{"line_number":482,"context_line":"dulwich\u003d\u003d\u003d0.21.7"},{"line_number":483,"context_line":"dfs-sdk\u003d\u003d\u003d1.2.27"},{"line_number":484,"context_line":"sentinels\u003d\u003d\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":3,"id":"91eee309_ba2fba76","line":481,"updated":"2024-04-10 11:49:13.000000000","message":"We really shouldn\u0027t be adding anything to do with six. Any usage in the code should really be removed at this point.","commit_id":"6feb872e47db640e38d814b50f115488fa6f42f2"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b5fcda4d8949717136bc7d896510245fbf5a5fd9","unresolved":false,"context_lines":[{"line_number":478,"context_line":"infi.dtypes.nqn\u003d\u003d\u003d0.1.0"},{"line_number":479,"context_line":"looseversion\u003d\u003d\u003d1.3.0"},{"line_number":480,"context_line":"six\u003d\u003d\u003d1.16.0"},{"line_number":481,"context_line":"types-six\u003d\u003d\u003d1.16.0"},{"line_number":482,"context_line":"dulwich\u003d\u003d\u003d0.21.7"},{"line_number":483,"context_line":"dfs-sdk\u003d\u003d\u003d1.2.27"},{"line_number":484,"context_line":"sentinels\u003d\u003d\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":3,"id":"c7fcffaa_3eb236e1","line":481,"in_reply_to":"91eee309_ba2fba76","updated":"2024-04-10 13:17:17.000000000","message":"Yeah, I agree.","commit_id":"6feb872e47db640e38d814b50f115488fa6f42f2"}]}