)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cd0860b5fc427840ef6be4f1d0a44c2dab839f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"57cdfc89_ff58510b","updated":"2024-04-30 19:50:45.000000000","message":"Seems like a reasonable idea just needs some tweaking to avoid breakage","commit_id":"afc0b1aff0484336c3c3222940dafa08073bc6f8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"77567dcf134b4077637570a186c81dcceca90f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8faa6df_8dfd4403","updated":"2024-05-01 16:25:54.000000000","message":"Looks good to me, but will leave to someone else to approve since I probably won\u0027t be around to help watch for issues.","commit_id":"0c7c5eca24f612bfb453dc9dd3c81eb7337a1f32"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7d88fd6169dac998a46667b1ad014034ac16ecda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e917d3f6_8b3d07c9","updated":"2024-05-01 14:29:53.000000000","message":"Looks good to me.\n\nThere\u0027s a small chance this will break $stuff but it it does it should be easy to locate and fix.\n\nWe will need to update the proposal tooling in project-config but this is a solid step forward.","commit_id":"0c7c5eca24f612bfb453dc9dd3c81eb7337a1f32"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a6819a279c5e9fe625955bec49c740f940396008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e943a1c_f961dd4a","in_reply_to":"e917d3f6_8b3d07c9","updated":"2024-05-01 16:18:00.000000000","message":"Ack. I have a project-config patch ready to go, as well as a project-team-guide to update the docs, should be linked here eventually.","commit_id":"0c7c5eca24f612bfb453dc9dd3c81eb7337a1f32"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"109cadc33745ea4507e1d0cc63909c4d75d49433","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"36b78b7c_e34d4a98","updated":"2024-05-14 08:08:56.000000000","message":"Just fixed merge conflict","commit_id":"ea345875cd43ef95c26e46199956c82cd8132ad2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ccf52e21b6876be1df471fe64e5bb3a08e47ff5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4655778_a8f0a532","updated":"2024-05-14 10:41:57.000000000","message":"approving using previous +2s after simple rebase","commit_id":"ea345875cd43ef95c26e46199956c82cd8132ad2"}],"openstack_requirements/cmds/check_exists.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cd0860b5fc427840ef6be4f1d0a44c2dab839f7","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \u0027-g\u0027, \u0027--global-requirements\u0027,"},{"line_number":40,"context_line":"        default\u003d\u0027global-requirements.txt\u0027,"},{"line_number":41,"context_line":"        help\u003d\u0027Path to the global-requirements.txt file\u0027)"},{"line_number":42,"context_line":"    parser.add_argument("},{"line_number":43,"context_line":"        \u0027-d\u0027, \u0027--denylist\u0027,"},{"line_number":44,"context_line":"        default\u003d\u0027denylist.txt\u0027,"},{"line_number":45,"context_line":"        help\u003d\u0027Path to the denylist.txt file\u0027)"},{"line_number":46,"context_line":"    parser.add_argument("},{"line_number":47,"context_line":"        \u0027-G\u0027, \u0027--gr-check\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":48,"context_line":"        help\u003d\u0027Do a specifier check of global-requirements\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"25ebf934_4e821044","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":45},"updated":"2024-04-30 19:50:45.000000000","message":"We\u0027ll need to keep the existing \u0027-b\u0027 as a valid commandline arg for at least the short term as we use this tool from other repos and places.\n\nPlease rework to avoid breakage.","commit_id":"afc0b1aff0484336c3c3222940dafa08073bc6f8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd07390f1f5963ac5c707a03fa1c98d907704860","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027-g\u0027, \u0027--global-requirements\u0027,"},{"line_number":40,"context_line":"        default\u003d\u0027global-requirements.txt\u0027,"},{"line_number":41,"context_line":"        help\u003d\u0027Path to the global-requirements.txt file\u0027)"},{"line_number":42,"context_line":"    parser.add_argument("},{"line_number":43,"context_line":"        \u0027-d\u0027, \u0027--denylist\u0027,"},{"line_number":44,"context_line":"        default\u003d\u0027denylist.txt\u0027,"},{"line_number":45,"context_line":"        help\u003d\u0027Path to the denylist.txt file\u0027)"},{"line_number":46,"context_line":"    parser.add_argument("},{"line_number":47,"context_line":"        \u0027-G\u0027, \u0027--gr-check\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":48,"context_line":"        help\u003d\u0027Do a specifier check of global-requirements\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb7965a4_7b985944","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":45},"in_reply_to":"25ebf934_4e821044","updated":"2024-05-01 01:40:01.000000000","message":"Ack, I figured as much. Do we need to keep the --blacklist as well? I couldn\u0027t see via codesearch where this was called.","commit_id":"afc0b1aff0484336c3c3222940dafa08073bc6f8"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"db400dd436860393309316b6df47ee149f03181e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027-g\u0027, \u0027--global-requirements\u0027,"},{"line_number":40,"context_line":"        default\u003d\u0027global-requirements.txt\u0027,"},{"line_number":41,"context_line":"        help\u003d\u0027Path to the global-requirements.txt file\u0027)"},{"line_number":42,"context_line":"    parser.add_argument("},{"line_number":43,"context_line":"        \u0027-d\u0027, \u0027--denylist\u0027,"},{"line_number":44,"context_line":"        default\u003d\u0027denylist.txt\u0027,"},{"line_number":45,"context_line":"        help\u003d\u0027Path to the denylist.txt file\u0027)"},{"line_number":46,"context_line":"    parser.add_argument("},{"line_number":47,"context_line":"        \u0027-G\u0027, \u0027--gr-check\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":48,"context_line":"        help\u003d\u0027Do a specifier check of global-requirements\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"521e900a_44c6d47d","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":45},"in_reply_to":"bb7965a4_7b985944","updated":"2024-05-01 14:22:52.000000000","message":"Actually I left that comment on the wrong file.  I meant to add it to generate which is called at here:   https://opendev.org/openstack/project-config/src/branch/master/playbooks/proposal/propose_update.sh#L39-L41\n\nso your implementation in PS2 should be fine.\n\nHaving said that I *think* check_exists is old code that isn\u0027t used anymore.  Or is used manually by some of the core team?\n\nEither way what you\u0027ve done is great.","commit_id":"afc0b1aff0484336c3c3222940dafa08073bc6f8"}]}