)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4a063ef0ea496cb7bcedea9841826dd4af76d7c5","unresolved":true,"context_lines":[{"line_number":11,"context_line":"implicitly assuming pkg_resources is available. Additionally setuptools"},{"line_number":12,"context_line":"has deprecated pkg_resources so the best plan is to use the stdlib"},{"line_number":13,"context_line":"provided solution, which is not available until Python 3.9 so we must"},{"line_number":14,"context_line":"use the backport package for Python 3.8 support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15d3a4858383d7e0acc65e62b886c584bbc363ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d9b607d2_da5b15d5","line":14,"updated":"2024-08-06 18:26:13.000000000","message":"I\u0027m not sure if all the questions from https://docs.openstack.org/project-team-guide/dependency-management.html#for-new-requirements need to be answered, but I would at least wonder how distro support does look like?","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"af53852717d97cf58ed322449a5367a27a6d77e5","unresolved":true,"context_lines":[{"line_number":11,"context_line":"implicitly assuming pkg_resources is available. Additionally setuptools"},{"line_number":12,"context_line":"has deprecated pkg_resources so the best plan is to use the stdlib"},{"line_number":13,"context_line":"provided solution, which is not available until Python 3.9 so we must"},{"line_number":14,"context_line":"use the backport package for Python 3.8 support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15d3a4858383d7e0acc65e62b886c584bbc363ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d7fb9cde_4294e692","line":14,"in_reply_to":"bc7efd94_ad3362a7","updated":"2024-08-08 05:27:52.000000000","message":"Ok, that sounds good","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"0738a4e1e83727ee8d3082839e2434601addcaae","unresolved":false,"context_lines":[{"line_number":11,"context_line":"implicitly assuming pkg_resources is available. Additionally setuptools"},{"line_number":12,"context_line":"has deprecated pkg_resources so the best plan is to use the stdlib"},{"line_number":13,"context_line":"provided solution, which is not available until Python 3.9 so we must"},{"line_number":14,"context_line":"use the backport package for Python 3.8 support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15d3a4858383d7e0acc65e62b886c584bbc363ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bdbe7293_c374f759","line":14,"in_reply_to":"d7fb9cde_4294e692","updated":"2024-08-09 17:48:07.000000000","message":"Done","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"66abef9bfc245ccf84dd9d7bc195aacf6570d1ca","unresolved":true,"context_lines":[{"line_number":11,"context_line":"implicitly assuming pkg_resources is available. Additionally setuptools"},{"line_number":12,"context_line":"has deprecated pkg_resources so the best plan is to use the stdlib"},{"line_number":13,"context_line":"provided solution, which is not available until Python 3.9 so we must"},{"line_number":14,"context_line":"use the backport package for Python 3.8 support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I15d3a4858383d7e0acc65e62b886c584bbc363ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bc7efd94_ad3362a7","line":14,"in_reply_to":"d9b607d2_da5b15d5","updated":"2024-08-06 18:35:58.000000000","message":"Ubuntu: https://packages.ubuntu.com/focal/python3-importlib-metadata It\u0027s available in all versions supported by packages.ubuntu.com and the oldest version they have is 1.5 which is newer than what shipped with Python 3.9\n\nFedora: https://packages.fedoraproject.org/pkgs/python-importlib-metadata/python3-importlib-metadata/ It\u0027s in the 6.x series. But they even have it backported down to their Python 3.6.\n\nGentoo has it as well but they\u0027ve dropped Python\u0027s older than 3.10 so it\u0027s not a problem.\n\nSUSE: It\u0027s in the same state as Fedora.","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"a64ac41fef1870756c4d7b2459fb7ae4204ca6b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9635054_43f79660","updated":"2024-07-30 23:41:31.000000000","message":"Doing this for https://review.opendev.org/c/openstack/sushy/+/925304","commit_id":"a8b08f66e4229a00da57dddc7c310da827b95b12"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4a063ef0ea496cb7bcedea9841826dd4af76d7c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b029aedb_d387afd0","updated":"2024-08-06 18:26:13.000000000","message":"-1 just for visibility of my questions","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"0738a4e1e83727ee8d3082839e2434601addcaae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ce259100_d7943da5","updated":"2024-08-09 17:48:07.000000000","message":"Happy to make any changes needed. Ultimately looking to utilize this to fix Python 3.12 support in Ironic. To be clear this dependency is only pulled in and used on Python 3.8 which is still supported by the Ironic project. From Python 3.9 and newer the necessary bits are in stdlib","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"af53852717d97cf58ed322449a5367a27a6d77e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ee344aa_a05b797f","updated":"2024-08-08 05:27:52.000000000","message":"I\u0027m still not sure what the best option to proceed would be, adding more reviewers that may have some better idea","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"929af22f45f522a19d9640fe349a85f5990cbe9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b54e6fff_98dda996","updated":"2024-08-05 16:15:26.000000000","message":"Thank you.","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"}],"global-requirements.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4a063ef0ea496cb7bcedea9841826dd4af76d7c5","unresolved":true,"context_lines":[{"line_number":64,"context_line":"# Do not make importlib-metadata conditional on Python version: we depend on"},{"line_number":65,"context_line":"# newer code than in [most] releases of the Python std library."},{"line_number":66,"context_line":"importlib-metadata  # Apache-2.0"},{"line_number":67,"context_line":"importlib-resources;python_version\u003c\u00273.9\u0027  # Apache-2.0"},{"line_number":68,"context_line":"infinisdk  # BSD-3"},{"line_number":69,"context_line":"influxdb!\u003d5.3.0  # MIT"},{"line_number":70,"context_line":"influxdb-client  # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"ac6be6b3_03cb3140","line":67,"updated":"2024-08-06 18:26:13.000000000","message":"I wonder whether the comment above applies in a similar way here, too and we should not restrict this to being included only for py3.8?\n\nor maybe cap to some older version? the current 6.x versions seem to correspond to what is available in py3.13, so this might lead to inconsistencies for intermediate python versions?","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7623ee28f858579ccd633a901a72f24f5aec5dad","unresolved":true,"context_lines":[{"line_number":64,"context_line":"# Do not make importlib-metadata conditional on Python version: we depend on"},{"line_number":65,"context_line":"# newer code than in [most] releases of the Python std library."},{"line_number":66,"context_line":"importlib-metadata  # Apache-2.0"},{"line_number":67,"context_line":"importlib-resources;python_version\u003c\u00273.9\u0027  # Apache-2.0"},{"line_number":68,"context_line":"infinisdk  # BSD-3"},{"line_number":69,"context_line":"influxdb!\u003d5.3.0  # MIT"},{"line_number":70,"context_line":"influxdb-client  # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"72edd157_9a4e75af","line":67,"in_reply_to":"15de17e3_dd9f68c0","updated":"2024-08-22 14:52:46.000000000","message":"So the tests don\u0027t seem to want me to put a limit in the global-requirements.txt. Do you have a suggestion on how I can achieve that Jens?","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"12d6f9b9b4964ecdb467ea3795b6b0b582f7f4dd","unresolved":true,"context_lines":[{"line_number":64,"context_line":"# Do not make importlib-metadata conditional on Python version: we depend on"},{"line_number":65,"context_line":"# newer code than in [most] releases of the Python std library."},{"line_number":66,"context_line":"importlib-metadata  # Apache-2.0"},{"line_number":67,"context_line":"importlib-resources;python_version\u003c\u00273.9\u0027  # Apache-2.0"},{"line_number":68,"context_line":"infinisdk  # BSD-3"},{"line_number":69,"context_line":"influxdb!\u003d5.3.0  # MIT"},{"line_number":70,"context_line":"influxdb-client  # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"a316af8b_e22a3b8a","line":67,"in_reply_to":"6917fc4d_3f74b879","updated":"2024-08-26 15:25:54.000000000","message":"So if I limit the upper version to what shipped with Python 3.9, that means the distro packages won\u0027t be compatible. They\u0027re all shipping newer versions then that and don\u0027t have the Python 3.9 versions in their package repo.\n\nJens, your original request was to make sure I was compatible with the distro packaged versions so I\u0027m holding off on a change. I\u0027m happy to make whatever change you\u0027d prefer.","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9de2d248f191fe08e9a784dae00d78117d458584","unresolved":true,"context_lines":[{"line_number":64,"context_line":"# Do not make importlib-metadata conditional on Python version: we depend on"},{"line_number":65,"context_line":"# newer code than in [most] releases of the Python std library."},{"line_number":66,"context_line":"importlib-metadata  # Apache-2.0"},{"line_number":67,"context_line":"importlib-resources;python_version\u003c\u00273.9\u0027  # Apache-2.0"},{"line_number":68,"context_line":"infinisdk  # BSD-3"},{"line_number":69,"context_line":"influxdb!\u003d5.3.0  # MIT"},{"line_number":70,"context_line":"influxdb-client  # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"6917fc4d_3f74b879","line":67,"in_reply_to":"72edd157_9a4e75af","updated":"2024-08-22 15:28:20.000000000","message":"I think you\u0027d just leave this unversioned and have the version limit in upper-constraints.","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6c9006080bf11e0ef92d0be21f4e838fae70b1b2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# Do not make importlib-metadata conditional on Python version: we depend on"},{"line_number":65,"context_line":"# newer code than in [most] releases of the Python std library."},{"line_number":66,"context_line":"importlib-metadata  # Apache-2.0"},{"line_number":67,"context_line":"importlib-resources;python_version\u003c\u00273.9\u0027  # Apache-2.0"},{"line_number":68,"context_line":"infinisdk  # BSD-3"},{"line_number":69,"context_line":"influxdb!\u003d5.3.0  # MIT"},{"line_number":70,"context_line":"influxdb-client  # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"5a27ef7c_98454dcb","line":67,"in_reply_to":"a316af8b_e22a3b8a","updated":"2024-08-28 08:36:18.000000000","message":"Yeah, so maybe just go with this. I don\u0027t feel confident enough though to approve this myself, hoping other cores can take a look, too.","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"66abef9bfc245ccf84dd9d7bc195aacf6570d1ca","unresolved":true,"context_lines":[{"line_number":64,"context_line":"# Do not make importlib-metadata conditional on Python version: we depend on"},{"line_number":65,"context_line":"# newer code than in [most] releases of the Python std library."},{"line_number":66,"context_line":"importlib-metadata  # Apache-2.0"},{"line_number":67,"context_line":"importlib-resources;python_version\u003c\u00273.9\u0027  # Apache-2.0"},{"line_number":68,"context_line":"infinisdk  # BSD-3"},{"line_number":69,"context_line":"influxdb!\u003d5.3.0  # MIT"},{"line_number":70,"context_line":"influxdb-client  # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"15de17e3_dd9f68c0","line":67,"in_reply_to":"ac6be6b3_03cb3140","updated":"2024-08-06 18:35:58.000000000","message":"So you\u0027ll see it is restricted to just Python 3.8 (well technically versions of Python less than 3.9).\n\nI\u0027m happy to add the upper-constraint to what\u0027s in Python 3.9 which is all that\u0027s really needed.","commit_id":"ed046c41533a13e6acccbf8f4409ba23a71cfd6d"}]}