)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4fcce6f56894dcc16b126dd4ff781de5be4c6c94","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Downgrading XStatic-Font-Awesome version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix sets correct upper-constraint requirement which should"},{"line_number":10,"context_line":"allow install horizon from source preventing problems with version requirement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In follow of:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4480528a_43627b4f","line":9,"updated":"2025-01-24 19:41:48.000000000","message":"This change doesn\u0027t touch upper-constraints.txt at all?","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"bbdf4b8c85d033abc7ab034e1ab51f49412a8381","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Downgrading XStatic-Font-Awesome version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix sets correct upper-constraint requirement which should"},{"line_number":10,"context_line":"allow install horizon from source preventing problems with version requirement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In follow of:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4fdf40f2_c06bab44","line":9,"in_reply_to":"4480528a_43627b4f","updated":"2025-01-24 22:50:57.000000000","message":"@frickler@offenerstapel.de\n\nFull details about MR ;)\n\nAfter start investigating case https://bugs.launchpad.net/horizon/+bug/2095374\n\nI founded little error in requirements.txt (https://opendev.org/openstack/horizon/src/branch/master/requirements.txt)\n\nXStatic-Font-Awesome\u003e\u003d4.7.0.0 # SIL OFL 1.1 License, MIT License\n\nIf we do:\npip3 install XStatic-Font-Awesome\u003e\u003d4.7.0.0 - installed version:\nSuccessfully installed XStatic-Font-Awesome-6.2.1.1\n\nHorizon not work (and another errors):\nError: File to import not found or unreadable: /horizon/lib/font_awesome/scss/font-awesome.scss.\n\nIf we changed line to:\nXStatic-Font-Awesome\u003c\u003d4.7.0.0 # SIL OFL 1.1 License, MIT License\n\nAll working without problem.\n\nI commit fix for Horizon only:\nhttps://review.opendev.org/c/openstack/horizon/+/940064\n\nAnd received error:\nERROR: Requirement for package XStatic-Font-Awesome excludes a version not excluded in the global list.\n  Local settings : {\u0027\u003c\u003d4.7.0.0\u0027}\n  Global settings: {\u0027\u003c4.8.0\u0027}\n  Unexpected     : {\u0027\u003c\u003d4.7.0.0\u0027}\n \n \n After it I created current MR for fix global-requirements.txt \n \n If I\u0027m wrong, please tell me.","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19b0cd2d2b805679e63a7fd48093e1fb8e727442","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Downgrading XStatic-Font-Awesome version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix sets correct upper-constraint requirement which should"},{"line_number":10,"context_line":"allow install horizon from source preventing problems with version requirement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In follow of:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a236273e_92e2e8e4","line":9,"in_reply_to":"4fdf40f2_c06bab44","updated":"2025-01-29 08:56:49.000000000","message":"So installing requirements without a constraint is an error that can lead to failures in a lot of circumstances and thus should be avoided. IMHO it is not necessary to guard against that in horizon requirements because it will make later upgrades that fix those issues more difficult. So the solution for the bug you cite is simply \"use upper-constraints.txt or something similar\" and your patch for horizon should not be needed, just like this one.","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"000f6eb97bd18d891b408e0d66bf3fb01054b5b4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Downgrading XStatic-Font-Awesome version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix sets correct upper-constraint requirement which should"},{"line_number":10,"context_line":"allow install horizon from source preventing problems with version requirement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In follow of:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"69dc7f27_7e972891","line":9,"in_reply_to":"63b611ba_3b19d83e","updated":"2025-02-06 06:12:10.000000000","message":"this is getting kind of out of scope for this review, maybe discussing in the horizon bug might be better, but essentially I think if you install horizon from source, you need to drop it from upper-constraints.txt in a local copy","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"e11b0b910ba7c015831fcb38944485327d520ab2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Downgrading XStatic-Font-Awesome version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix sets correct upper-constraint requirement which should"},{"line_number":10,"context_line":"allow install horizon from source preventing problems with version requirement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In follow of:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"cf43d4bf_e6de3ce6","line":9,"in_reply_to":"69dc7f27_7e972891","updated":"2025-02-11 10:03:27.000000000","message":"@frickler@offenerstapel.de your right, thanks you.","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"10ddac93b8d768c9269c5233586842c99b48c246","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Downgrading XStatic-Font-Awesome version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix sets correct upper-constraint requirement which should"},{"line_number":10,"context_line":"allow install horizon from source preventing problems with version requirement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In follow of:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"63b611ba_3b19d83e","line":9,"in_reply_to":"a236273e_92e2e8e4","updated":"2025-01-31 16:41:38.000000000","message":"@frickler@offenerstapel.de\n\nHmm, I decided to check it out and noticed:\n\ngit clone https://opendev.org/openstack/horizon -b stable/2024.2 --depth\u003d1\n\ncd horizon\n\npython3 -m pip install -c https://opendev.org/openstack/requirements/raw/branch/stable/2024.2/upper-constraints.txt .\nProcessing /root/horizon\n  Preparing metadata (setup.py) ... done\nERROR: Cannot install horizon 0.0.0 (from /root/horizon) because these package versions have conflicting dependencies.\n\nThe conflict is caused by:\n    The user requested horizon 0.0.0 (from /root/horizon)\n    The user requested (constraint) horizon\u003d\u003d\u003d25.0.0\n\nTo fix this you could try to:\n1. loosen the range of package versions you\u0027ve specified\n2. remove package versions to allow pip attempt to solve the dependency conflict\n\nERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts\n\nMaybe I\u0027m wrong? Thank you.","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4fcce6f56894dcc16b126dd4ff781de5be4c6c94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"713a3b00_200b0557","updated":"2025-01-24 19:41:48.000000000","message":"I don\u0027t think that this is better and I still do not understand what the expected effect of this change should be","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7ec270e006478aabcd1bfaca45389f2b90d6ad9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f73ecf7b_026db04e","updated":"2025-01-24 13:45:23.000000000","message":"Updated.","commit_id":"a097fd5fabd436909045c2b11be188bfc9ed3902"}],"global-requirements.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f6109251c7cdb0159320014eff1a5f3ba6a38810","unresolved":true,"context_lines":[{"line_number":188,"context_line":"XStatic-Dagre  # MIT License"},{"line_number":189,"context_line":"XStatic-Dagre-D3  # MIT License"},{"line_number":190,"context_line":"xstatic-filesaver  # MIT License"},{"line_number":191,"context_line":"XStatic-Font-Awesome\u003c\u003d4.7.0.0  # SIL OFL 1.1 License, MIT License"},{"line_number":192,"context_line":"XStatic-Graphlib  # MIT License"},{"line_number":193,"context_line":"XStatic-Hogan  # Apache 2.0 License"},{"line_number":194,"context_line":"XStatic-Jasmine  # MIT License"}],"source_content_type":"text/plain","patch_set":5,"id":"5d76590f_86037ce8","line":191,"updated":"2025-01-24 13:28:23.000000000","message":"There is no release between 4.7.0.0 and 4.8.0, so I don\u0027t see where this would make any difference?\n\nSide note: it would be really great if horizon could finally adapt to some of the newer versions, those are a couple of years old by now. 4.7.0.0 is from 2016.","commit_id":"ca186055821b7b67f9ded1bdaa1a1e07bc272996"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"c0ec68e253059b28f1eec4d40ba3d1f86264d4c7","unresolved":true,"context_lines":[{"line_number":188,"context_line":"XStatic-Dagre  # MIT License"},{"line_number":189,"context_line":"XStatic-Dagre-D3  # MIT License"},{"line_number":190,"context_line":"xstatic-filesaver  # MIT License"},{"line_number":191,"context_line":"XStatic-Font-Awesome\u003c\u003d4.7.0.0  # SIL OFL 1.1 License, MIT License"},{"line_number":192,"context_line":"XStatic-Graphlib  # MIT License"},{"line_number":193,"context_line":"XStatic-Hogan  # Apache 2.0 License"},{"line_number":194,"context_line":"XStatic-Jasmine  # MIT License"}],"source_content_type":"text/plain","patch_set":5,"id":"97d6829f_1c3e08e6","line":191,"in_reply_to":"5d76590f_86037ce8","updated":"2025-01-24 13:34:15.000000000","message":"@frickler@offenerstapel.de you right, more better solution in upper-constraints.txt\n\nXStatic-Font-Awesome\u003d\u003d\u003d4.7.0.0\n\n\nMay be we can use it in global-requirements.txt with \u003d\u003d for pinned?","commit_id":"ca186055821b7b67f9ded1bdaa1a1e07bc272996"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7ec270e006478aabcd1bfaca45389f2b90d6ad9b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"XStatic-Dagre  # MIT License"},{"line_number":189,"context_line":"XStatic-Dagre-D3  # MIT License"},{"line_number":190,"context_line":"xstatic-filesaver  # MIT License"},{"line_number":191,"context_line":"XStatic-Font-Awesome\u003c\u003d4.7.0.0  # SIL OFL 1.1 License, MIT License"},{"line_number":192,"context_line":"XStatic-Graphlib  # MIT License"},{"line_number":193,"context_line":"XStatic-Hogan  # Apache 2.0 License"},{"line_number":194,"context_line":"XStatic-Jasmine  # MIT License"}],"source_content_type":"text/plain","patch_set":5,"id":"c6a43382_8987d5df","line":191,"in_reply_to":"97d6829f_1c3e08e6","updated":"2025-01-24 13:45:23.000000000","message":"Done","commit_id":"ca186055821b7b67f9ded1bdaa1a1e07bc272996"}]}
