)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e3fdc3d83f3db22957c7e9dff6c0ef303179967","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  Yes, it\u0027s BSD licensed."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Is the library already packaged in the distros we target (Ubuntu"},{"line_number":27,"context_line":"latest / Fedora latest)?"},{"line_number":28,"context_line":"  Yes."},{"line_number":29,"context_line":"  https://packages.ubuntu.com/oracular/python3-cheroot"},{"line_number":30,"context_line":"  https://packages.fedoraproject.org/pkgs/python-cheroot/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fdfd2a5c_5f59cb83","line":27,"updated":"2025-04-24 09:51:43.000000000","message":"not your fault, but we really need to amend these questions. Ubuntu LTS+Debian stable is what really matters these days. but don\u0027t amend your answer for this","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bee073963d1449896becf0f5bf016d7792a9291d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  Yes, it\u0027s BSD licensed."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Is the library already packaged in the distros we target (Ubuntu"},{"line_number":27,"context_line":"latest / Fedora latest)?"},{"line_number":28,"context_line":"  Yes."},{"line_number":29,"context_line":"  https://packages.ubuntu.com/oracular/python3-cheroot"},{"line_number":30,"context_line":"  https://packages.fedoraproject.org/pkgs/python-cheroot/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c74f79f1_8d595b63","line":27,"in_reply_to":"fdfd2a5c_5f59cb83","updated":"2025-04-26 13:41:09.000000000","message":"Done","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e3fdc3d83f3db22957c7e9dff6c0ef303179967","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  We\u0027re specifically replacing eventlet\u0027s WSGI server functionality with"},{"line_number":36,"context_line":"  cheroot, which provides a similar thread-based server model"},{"line_number":37,"context_line":"  but without eventlet\u0027s dependencies. Also, cheroot is already part of"},{"line_number":38,"context_line":"  the upper-constraints file as a transitive dependency."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Is the library required for OpenStack project or related dev or"},{"line_number":41,"context_line":"infrastructure setup? (Answer to this should be Yes, of course) Which?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3b3c7bf4_d58046b6","line":38,"updated":"2025-04-24 09:51:43.000000000","message":"Do you happen to know where this dependency comes from? Else I can do some digging myself","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2299aa955f36bc6e28d307d4104240794dfba833","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  We\u0027re specifically replacing eventlet\u0027s WSGI server functionality with"},{"line_number":36,"context_line":"  cheroot, which provides a similar thread-based server model"},{"line_number":37,"context_line":"  but without eventlet\u0027s dependencies. Also, cheroot is already part of"},{"line_number":38,"context_line":"  the upper-constraints file as a transitive dependency."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Is the library required for OpenStack project or related dev or"},{"line_number":41,"context_line":"infrastructure setup? (Answer to this should be Yes, of course) Which?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4f9d08c6_704548be","line":38,"in_reply_to":"3b3c7bf4_d58046b6","updated":"2025-04-24 12:24:49.000000000","message":"So, cheroot was added to constraints in https://review.opendev.org/c/openstack/requirements/+/915548. I couldn\u0027t find this as a direct dep in the packages as of today. Second opinion needed.","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"98d71a9ec69dba79ed37c1462665ec3e30af3953","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  We\u0027re specifically replacing eventlet\u0027s WSGI server functionality with"},{"line_number":36,"context_line":"  cheroot, which provides a similar thread-based server model"},{"line_number":37,"context_line":"  but without eventlet\u0027s dependencies. Also, cheroot is already part of"},{"line_number":38,"context_line":"  the upper-constraints file as a transitive dependency."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Is the library required for OpenStack project or related dev or"},{"line_number":41,"context_line":"infrastructure setup? (Answer to this should be Yes, of course) Which?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4c3f6441_6fd9f89b","line":38,"in_reply_to":"4f9d08c6_704548be","updated":"2025-04-24 16:36:28.000000000","message":"so it looks like it is pulled in via cherrypy, but I did not yet find where the latter comes from. anyway this isn\u0027t a blocker","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1c74b9bcda26498ce6260f8148ad40e655369480","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Is the library required for OpenStack project or related dev or"},{"line_number":41,"context_line":"infrastructure setup? (Answer to this should be Yes, of course) Which?"},{"line_number":42,"context_line":"  Yes, it\u0027s needed for ironic-python-agent (IPA)."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* If the library release is managed by the Openstack release process does it use the cycle-with-intermediary release type?"},{"line_number":45,"context_line":"  It\u0027s not managed by OpenStack."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6d6d20ea_e9ae29a4","line":42,"updated":"2025-04-23 21:04:40.000000000","message":"Note: we\u0027ll almost certainly need this for Ironic as well (although you don\u0027t have to mention it here, just letting reviewers know).","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bee073963d1449896becf0f5bf016d7792a9291d","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Is the library required for OpenStack project or related dev or"},{"line_number":41,"context_line":"infrastructure setup? (Answer to this should be Yes, of course) Which?"},{"line_number":42,"context_line":"  Yes, it\u0027s needed for ironic-python-agent (IPA)."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* If the library release is managed by the Openstack release process does it use the cycle-with-intermediary release type?"},{"line_number":45,"context_line":"  It\u0027s not managed by OpenStack."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"afddcaaf_f74c4785","line":42,"in_reply_to":"6d6d20ea_e9ae29a4","updated":"2025-04-26 13:41:09.000000000","message":"Acknowledged","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"adf5bee96dc29b9e8d08dbe4e13aa0282b94bde4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae53b68a_6001973f","updated":"2025-04-21 03:56:52.000000000","message":"CherryPy https://cherrypy.dev/ is a BSD licensed library https://github.com/cherrypy/cherrypy\n\nIt looks relatively well supported. \n\nI think it\u0027d be wise to WIP this change until we have consensus in Ironic around the IPA change, but in general I\u0027m in favor of this.","commit_id":"860228dea49e112155591331cad6bc9004b97aea"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4b6095a820ece865038bb0c285e91d538f0d6043","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60f59d25_0eba26c7","updated":"2025-04-21 06:13:46.000000000","message":"When this is ready and needed, please update to include answers to the items under Review Criteria here: https://wiki.openstack.org/wiki/Requirements","commit_id":"860228dea49e112155591331cad6bc9004b97aea"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d6c4c69dd2c62a3d2bade9e6a1dd39cf4e2c8468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55076c3f_30ccb9ee","in_reply_to":"4694c2f4_38d90542","updated":"2025-04-26 15:37:16.000000000","message":"It was me who suggested both CherryPy and later cheroot, so count another +2","commit_id":"860228dea49e112155591331cad6bc9004b97aea"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0c16ca1cbfefff87ce16f9446bbee567d121efb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4694c2f4_38d90542","in_reply_to":"55bef518_b9b5a5d9","updated":"2025-04-26 15:32:39.000000000","message":"Absolutely! We have pretty strong consensus among engaged cores in IRC.","commit_id":"860228dea49e112155591331cad6bc9004b97aea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bee073963d1449896becf0f5bf016d7792a9291d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55bef518_b9b5a5d9","in_reply_to":"ae53b68a_6001973f","updated":"2025-04-26 13:41:09.000000000","message":"this is referring to https://review.opendev.org/c/openstack/ironic-python-agent/+/946091 iiuc, is one +2 enough to consider this comment resolved?","commit_id":"860228dea49e112155591331cad6bc9004b97aea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e3fdc3d83f3db22957c7e9dff6c0ef303179967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4f257078_7fa16fcb","updated":"2025-04-24 09:51:43.000000000","message":"I\u0027m +2 on the addition in general, just a nit inline","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"146b49cd2be5d730111ffb96eef2820c47ac53b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"027eeeaf_d1e3e41d","updated":"2025-04-26 20:56:24.000000000","message":"let\u0027s go for it, then","commit_id":"0165429148bae695e62013c7ffd38b6310fac489"}],"global-requirements.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d68dc2ae14e293b62d3077c677ef420fac819d0","unresolved":true,"context_lines":[{"line_number":498,"context_line":"simplejson  # MIT"},{"line_number":499,"context_line":"six  # MIT"},{"line_number":500,"context_line":"zake  # Apache-2.0"},{"line_number":501,"context_line":"cheroot  # BSD"}],"source_content_type":"text/plain","patch_set":2,"id":"3928e090_456d7041","line":501,"updated":"2025-04-22 15:20:13.000000000","message":"Wrong section: this is deprecated stuff. This one should go to section:general","commit_id":"5607e79c2c2176019317f9c37f5d2124e9f77daa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e3fdc3d83f3db22957c7e9dff6c0ef303179967","unresolved":false,"context_lines":[{"line_number":498,"context_line":"simplejson  # MIT"},{"line_number":499,"context_line":"six  # MIT"},{"line_number":500,"context_line":"zake  # Apache-2.0"},{"line_number":501,"context_line":"cheroot  # BSD"}],"source_content_type":"text/plain","patch_set":2,"id":"ad808d62_87ba232b","line":501,"in_reply_to":"3928e090_456d7041","updated":"2025-04-24 09:51:43.000000000","message":"Done","commit_id":"5607e79c2c2176019317f9c37f5d2124e9f77daa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e3fdc3d83f3db22957c7e9dff6c0ef303179967","unresolved":true,"context_lines":[{"line_number":217,"context_line":"zipp  # MIT"},{"line_number":218,"context_line":"zstd  # BSD License (2 clause)"},{"line_number":219,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027  # Apache 2.0 License"},{"line_number":220,"context_line":"cheroot  # BSD"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"## section:testing"},{"line_number":223,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"904f7da4_f0ea6e60","line":220,"updated":"2025-04-24 09:51:43.000000000","message":"sorry to keep bumping you around, but please keep this list alphabetically sorted. maybe it would help to add some comment about this at the top? I can also amend the patch myself if you prefer","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bee073963d1449896becf0f5bf016d7792a9291d","unresolved":false,"context_lines":[{"line_number":217,"context_line":"zipp  # MIT"},{"line_number":218,"context_line":"zstd  # BSD License (2 clause)"},{"line_number":219,"context_line":"zVMCloudConnector;sys_platform!\u003d\u0027win32\u0027  # Apache 2.0 License"},{"line_number":220,"context_line":"cheroot  # BSD"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"## section:testing"},{"line_number":223,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"92bb1852_4b113697","line":220,"in_reply_to":"904f7da4_f0ea6e60","updated":"2025-04-26 13:41:09.000000000","message":"Done","commit_id":"7a775cb922144200d699f78e5e6d7309f6509250"}]}