)]}'
{"tox.ini":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"226d1e2a3d93ab60857c8e0392668314443357ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1.0"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,docs"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"# this allows tox to infer the base python from the environment name"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_16bc9669","line":2,"updated":"2020-01-20 14:16:15.000000000","message":"You need to also update the minversion  3.1.0 uses ``pip``, 3.2.0 is the first release that defaults to ``python -m pip``\n\nhttps://github.com/tox-dev/tox/blame/master/docs/changelog.rst#L653","commit_id":"bcd6f79ad75ee263a5725ac8fd0d38c0a546b3f6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dbe3561aa11b199f3b3e276dd260450b1e8f2291","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1.0"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,docs"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"# this allows tox to infer the base python from the environment name"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_faa17ff7","line":2,"in_reply_to":"3fa7e38b_16bc9669","updated":"2020-01-22 01:12:01.000000000","message":"Is that necessary for this change? It should be functionally the same whether it ends up calling pip install versus python -m pip install.","commit_id":"bcd6f79ad75ee263a5725ac8fd0d38c0a546b3f6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"0dd7c3645c0dbec13303f2f5e3e8fcc151c8e624","unresolved":false,"context_lines":[{"line_number":10,"context_line":"usedevelop \u003d True"},{"line_number":11,"context_line":"basepython \u003d python3"},{"line_number":12,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d"},{"line_number":14,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"commands \u003d stestr run --slowest {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"bf51134e_78a86876","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":23},"updated":"2020-06-19 19:08:02.000000000","message":"Do we need to remove these lines too?","commit_id":"7be58d6af84f44c4f6eb9a26ccfc2be253b94a8d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6327bf24eaaf13371e9a2ad4ccc4cb557a52d4db","unresolved":false,"context_lines":[{"line_number":10,"context_line":"usedevelop \u003d True"},{"line_number":11,"context_line":"basepython \u003d python3"},{"line_number":12,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d"},{"line_number":14,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"commands \u003d stestr run --slowest {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"bf51134e_f8ed988b","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":23},"in_reply_to":"bf51134e_78a86876","updated":"2020-06-19 19:25:51.000000000","message":"If I understand this correct, this is just a redundant statement. The {envdir} would refer to the virtual environment (so something like .tox/pep), which is automatically set by tox to the virtual environment. tox activates the environment, which would set the VIRTUAL_ENV variable. So this isn\u0027t really needed.","commit_id":"7be58d6af84f44c4f6eb9a26ccfc2be253b94a8d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"048776b0c4e22555378fe182362821f786255eaa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"usedevelop \u003d True"},{"line_number":11,"context_line":"basepython \u003d python3"},{"line_number":12,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d"},{"line_number":14,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"commands \u003d stestr run --slowest {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"bf51134e_7855081d","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":23},"in_reply_to":"bf51134e_f8ed988b","updated":"2020-06-19 19:31:38.000000000","message":"Thanks for the explanation, Sean.","commit_id":"7be58d6af84f44c4f6eb9a26ccfc2be253b94a8d"}]}