)]}'
{"tools/rpm-packaging-status.py":[{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"2864b310bac2e5a347e3239f8a435fb31cc78f74","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        v_new \u003d version.parse(r[\u0027version\u0027])"},{"line_number":62,"context_line":"        if v_new \u003e v_highest:"},{"line_number":63,"context_line":"            v_highest \u003d v_new"},{"line_number":64,"context_line":"    return v_highest"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def find_pkg_version(pkg_project_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_036389dd","line":64,"updated":"2016-03-07 20:18:05.000000000","message":"Not tested, but:\n\n```\nversions \u003d (version.parse(r) for r in releases)\nreturn max(versions)\n```","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"060b731359de9b93004ded194c5df6e7ae340ff2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        v_new \u003d version.parse(r[\u0027version\u0027])"},{"line_number":62,"context_line":"        if v_new \u003e v_highest:"},{"line_number":63,"context_line":"            v_highest \u003d v_new"},{"line_number":64,"context_line":"    return v_highest"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def find_pkg_version(pkg_project_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_124e1596","line":64,"in_reply_to":"5aef4532_036389dd","updated":"2016-03-08 12:08:48.000000000","message":"Could work but I didn\u0027t test it, too","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"8a8fee497cab0043c2f26b97cf106dbb71abd223","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        v_new \u003d version.parse(r[\u0027version\u0027])"},{"line_number":62,"context_line":"        if v_new \u003e v_highest:"},{"line_number":63,"context_line":"            v_highest \u003d v_new"},{"line_number":64,"context_line":"    return v_highest"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def find_pkg_version(pkg_project_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_cda9ac7d","line":64,"in_reply_to":"5aef4532_124e1596","updated":"2016-03-08 12:21:13.000000000","message":"Tested:\n\n\u003e\u003e\u003e from packaging import version\n\u003e\u003e\u003e vers \u003d [\u00271.2\u0027, \u00275.3.1\u0027, \u00274.3\u0027, \u00272.2\u0027]\n\u003e\u003e\u003e max(version.parse(r) for r in vers)\n\u003cVersion(\u00275.3.1\u0027)\u003e","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"dc7f8678f49fda5105a6a20277a64fe08b20c688","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        v_new \u003d version.parse(r[\u0027version\u0027])"},{"line_number":62,"context_line":"        if v_new \u003e v_highest:"},{"line_number":63,"context_line":"            v_highest \u003d v_new"},{"line_number":64,"context_line":"    return v_highest"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def find_pkg_version(pkg_project_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_fa822e93","line":64,"in_reply_to":"5aef4532_cda9ac7d","updated":"2016-03-09 09:02:37.000000000","message":"Done","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"2864b310bac2e5a347e3239f8a435fb31cc78f74","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"\"\"get a spec.j2 template and get the version\"\"\""},{"line_number":69,"context_line":"    if os.path.exists(pkg_project_spec):"},{"line_number":70,"context_line":"        with open(pkg_project_spec) as f:"},{"line_number":71,"context_line":"            for l in f.readlines():"},{"line_number":72,"context_line":"                m \u003d re.search(\u0027^Version:\\s*(?P\u003cversion\u003e.*)\\s*$\u0027, l)"},{"line_number":73,"context_line":"                if m:"},{"line_number":74,"context_line":"                    return version.parse(m.group(\u0027version\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_43e9111a","line":71,"updated":"2016-03-07 20:18:05.000000000","message":"I think that you can skip the readlines()","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"060b731359de9b93004ded194c5df6e7ae340ff2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"\"\"get a spec.j2 template and get the version\"\"\""},{"line_number":69,"context_line":"    if os.path.exists(pkg_project_spec):"},{"line_number":70,"context_line":"        with open(pkg_project_spec) as f:"},{"line_number":71,"context_line":"            for l in f.readlines():"},{"line_number":72,"context_line":"                m \u003d re.search(\u0027^Version:\\s*(?P\u003cversion\u003e.*)\\s*$\u0027, l)"},{"line_number":73,"context_line":"                if m:"},{"line_number":74,"context_line":"                    return version.parse(m.group(\u0027version\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_92ace536","line":71,"in_reply_to":"5aef4532_43e9111a","updated":"2016-03-08 12:08:48.000000000","message":"I like it to be explicit here.","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"8a8fee497cab0043c2f26b97cf106dbb71abd223","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"\"\"get a spec.j2 template and get the version\"\"\""},{"line_number":69,"context_line":"    if os.path.exists(pkg_project_spec):"},{"line_number":70,"context_line":"        with open(pkg_project_spec) as f:"},{"line_number":71,"context_line":"            for l in f.readlines():"},{"line_number":72,"context_line":"                m \u003d re.search(\u0027^Version:\\s*(?P\u003cversion\u003e.*)\\s*$\u0027, l)"},{"line_number":73,"context_line":"                if m:"},{"line_number":74,"context_line":"                    return version.parse(m.group(\u0027version\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_edc9087a","line":71,"in_reply_to":"5aef4532_92ace536","updated":"2016-03-08 12:21:13.000000000","message":"Actually I think that readlines() is not correct. `file` objects in Python are iterators, so is expected to be iterated. Is the correct idiom here.","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"dc7f8678f49fda5105a6a20277a64fe08b20c688","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"\"\"get a spec.j2 template and get the version\"\"\""},{"line_number":69,"context_line":"    if os.path.exists(pkg_project_spec):"},{"line_number":70,"context_line":"        with open(pkg_project_spec) as f:"},{"line_number":71,"context_line":"            for l in f.readlines():"},{"line_number":72,"context_line":"                m \u003d re.search(\u0027^Version:\\s*(?P\u003cversion\u003e.*)\\s*$\u0027, l)"},{"line_number":73,"context_line":"                if m:"},{"line_number":74,"context_line":"                    return version.parse(m.group(\u0027version\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1a1c3a76","line":71,"in_reply_to":"5aef4532_edc9087a","updated":"2016-03-09 09:02:37.000000000","message":"Hm. It works. But I think without readlines() it\u0027s more efficient because afaiu readlines() reads the whole file into memory first and then interates.\nAnyway fixed. Thanks!","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"2864b310bac2e5a347e3239f8a435fb31cc78f74","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # no version in spec found"},{"line_number":76,"context_line":"        print(\u0027ERROR: no version in %s found\u0027 % pkg_project_spec)"},{"line_number":77,"context_line":"        return version.parse(\u00270\u0027)"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        return version.parse(\u00270\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_233cc592","line":78,"updated":"2016-03-07 20:18:05.000000000","message":"you can remove the else and put the return outside the `if`","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"060b731359de9b93004ded194c5df6e7ae340ff2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # no version in spec found"},{"line_number":76,"context_line":"        print(\u0027ERROR: no version in %s found\u0027 % pkg_project_spec)"},{"line_number":77,"context_line":"        return version.parse(\u00270\u0027)"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        return version.parse(\u00270\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_f2828993","line":78,"in_reply_to":"5aef4532_233cc592","updated":"2016-03-08 12:08:48.000000000","message":"Done","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"219b74aa81a129cb38a9f73efd218b4b3f174616","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    releases_yaml_dir \u003d os.path.join(args[\u0027releases-git-dir\u0027], \u0027deliverables\u0027,"},{"line_number":138,"context_line":"                            args[\u0027release\u0027])"},{"line_number":139,"context_line":"    for yaml_file in os.listdir(releases_yaml_dir):"},{"line_number":140,"context_line":"        project_name \u003d yaml_file.rstrip(\u0027.yaml\u0027)"},{"line_number":141,"context_line":"        with open(os.path.join(releases_yaml_dir, yaml_file)) as f:"},{"line_number":142,"context_line":"            data \u003d yaml.load(f.read())"},{"line_number":143,"context_line":"            v_release \u003d find_highest_release_version(data[\u0027releases\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b2e801e4","line":140,"updated":"2016-03-08 11:55:59.000000000","message":"`rstrip()` remove a set of chars, not a string. Alternatives:\n\n```\nproject_name \u003d yaml_file.replace(\u0027.yaml\u0027, \u0027\u0027)\n```\n\n```\nproject_name \u003d yaml_file[:-5]\n```\n\n```\nimport re\nproject_name \u003d re.sub(r\u0027.yaml$\u0027, \u0027\u0027, yaml_file)\n```","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"060b731359de9b93004ded194c5df6e7ae340ff2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    releases_yaml_dir \u003d os.path.join(args[\u0027releases-git-dir\u0027], \u0027deliverables\u0027,"},{"line_number":138,"context_line":"                            args[\u0027release\u0027])"},{"line_number":139,"context_line":"    for yaml_file in os.listdir(releases_yaml_dir):"},{"line_number":140,"context_line":"        project_name \u003d yaml_file.rstrip(\u0027.yaml\u0027)"},{"line_number":141,"context_line":"        with open(os.path.join(releases_yaml_dir, yaml_file)) as f:"},{"line_number":142,"context_line":"            data \u003d yaml.load(f.read())"},{"line_number":143,"context_line":"            v_release \u003d find_highest_release_version(data[\u0027releases\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_8d3684e5","line":140,"in_reply_to":"5aef4532_b2e801e4","updated":"2016-03-08 12:08:48.000000000","message":"Done","commit_id":"cb3fc3f3cbfd295b57f0409d60662789614ec83f"}]}
