)]}'
{"openstack/swift/openstack-swift-account-auditor.service":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOpenStack Swift Account Auditor"},{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":"After\u003dmysql.service postgresql.service rabbitmq-server.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003dsimple"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da36d5c6_8bbaf621","line":4,"updated":"2017-02-21 19:54:50.000000000","message":"Do we want these? We do not have them in mistral...","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOpenStack Swift Account Auditor"},{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":"After\u003dmysql.service postgresql.service rabbitmq-server.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003dsimple"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da36d5c6_374c0d42","line":4,"in_reply_to":"da36d5c6_8bbaf621","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"}],"openstack/swift/openstack-swift.conf":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"d /var/run/swift 0700 swift swift -"},{"line_number":2,"context_line":"d /var/run/swift/account-server 0700 swift swift -"},{"line_number":3,"context_line":"d /var/run/swift/container-server 0700 swift swift -"},{"line_number":4,"context_line":"d /var/run/swift/object-server 0700 swift swift -"}],"source_content_type":"text/plain","patch_set":2,"id":"da36d5c6_2b802a46","line":1,"updated":"2017-02-21 19:54:50.000000000","message":"just /run","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"d /var/run/swift 0700 swift swift -"},{"line_number":2,"context_line":"d /var/run/swift/account-server 0700 swift swift -"},{"line_number":3,"context_line":"d /var/run/swift/container-server 0700 swift swift -"},{"line_number":4,"context_line":"d /var/run/swift/object-server 0700 swift swift -"}],"source_content_type":"text/plain","patch_set":2,"id":"da36d5c6_d761f1a9","line":1,"in_reply_to":"da36d5c6_2b802a46","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"}],"openstack/swift/openstack-swift.logrotate":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"/var/log/swift/*.log {"},{"line_number":3,"context_line":"    compress"},{"line_number":4,"context_line":"    rotate 15"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da36d5c6_0bf446f0","line":1,"updated":"2017-02-21 19:54:50.000000000","message":"empty line","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"/var/log/swift/*.log {"},{"line_number":3,"context_line":"    compress"},{"line_number":4,"context_line":"    rotate 15"},{"line_number":5,"context_line":"    size 1M"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da36d5c6_cbd06e56","line":2,"updated":"2017-02-21 19:54:50.000000000","message":"can you copy from keystone to be consistent?","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"/var/log/swift/*.log {"},{"line_number":3,"context_line":"    compress"},{"line_number":4,"context_line":"    rotate 15"},{"line_number":5,"context_line":"    size 1M"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da36d5c6_f7dd1543","line":2,"in_reply_to":"da36d5c6_cbd06e56","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"c6e85c88a63651059c81c02d9ea660bca02249d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    compress"},{"line_number":8,"context_line":"    notifempty"},{"line_number":9,"context_line":"    copytruncate"},{"line_number":10,"context_line":"    su keystone keystone"},{"line_number":11,"context_line":"    minsize 100k"},{"line_number":12,"context_line":"    sharedscripts"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"da36d5c6_599d1309","line":10,"updated":"2017-02-22 19:03:34.000000000","message":"should be swift","commit_id":"f3a8c09d4f5707192bf466410dfd3186c8f983cb"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"8b624438db600b33e7605a5bb4b6abecc686845e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    compress"},{"line_number":8,"context_line":"    notifempty"},{"line_number":9,"context_line":"    copytruncate"},{"line_number":10,"context_line":"    su keystone keystone"},{"line_number":11,"context_line":"    minsize 100k"},{"line_number":12,"context_line":"    sharedscripts"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"da36d5c6_046b15b8","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":24},"updated":"2017-02-23 11:11:23.000000000","message":"Copy/paste error :)","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    compress"},{"line_number":8,"context_line":"    notifempty"},{"line_number":9,"context_line":"    copytruncate"},{"line_number":10,"context_line":"    su keystone keystone"},{"line_number":11,"context_line":"    minsize 100k"},{"line_number":12,"context_line":"    sharedscripts"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ba2be162_09b6578a","line":10,"in_reply_to":"da36d5c6_046b15b8","updated":"2017-02-28 21:49:30.000000000","message":"Done","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"803ec56aeb7eba8fae138b2f0be5ff6057398c17","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    compress"},{"line_number":8,"context_line":"    notifempty"},{"line_number":9,"context_line":"    copytruncate"},{"line_number":10,"context_line":"    su keystone keystone"},{"line_number":11,"context_line":"    minsize 100k"},{"line_number":12,"context_line":"    sharedscripts"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3fa7e38b_b1df530b","line":10,"updated":"2019-09-30 11:41:03.000000000","message":"keystone looks wrong","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"630e74733fd5f55fb99826c851cd75654278ae48","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    compress"},{"line_number":8,"context_line":"    notifempty"},{"line_number":9,"context_line":"    copytruncate"},{"line_number":10,"context_line":"    su keystone keystone"},{"line_number":11,"context_line":"    minsize 100k"},{"line_number":12,"context_line":"    sharedscripts"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3fa7e38b_8c0fa086","line":10,"in_reply_to":"3fa7e38b_b1df530b","updated":"2019-09-30 13:11:02.000000000","message":"Done","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"}],"openstack/swift/swift.spec.j2":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":2,"context_line":"%define groupname %{component}"},{"line_number":3,"context_line":"%define username %{component}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"%define version_unconverted 2.13.0"},{"line_number":6,"context_line":"%if ! %{defined _rundir}"},{"line_number":7,"context_line":"%define _rundir %{_localstatedir}/run"},{"line_number":8,"context_line":"%endif"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_8b6d969a","line":5,"updated":"2017-02-21 19:54:50.000000000","message":"please use the renderspec vars for versioning","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Version:        2.13.0"},{"line_number":11,"context_line":"Release:        0"},{"line_number":12,"context_line":"Summary:        OpenStack Storage (Swift)"},{"line_number":13,"context_line":"License:        Apache-2.0"},{"line_number":14,"context_line":"Group:          Development/Languages/Python"},{"line_number":15,"context_line":"Url:            http://launchpad.net/swift"},{"line_number":16,"context_line":"Source:         http://tarballs.openstack.org/swift/swift-%{version}.tar.gz"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_0b10c600","line":13,"updated":"2017-02-21 19:54:50.000000000","message":"{{ lincense() }}","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Source22:       %{name}.logrotate"},{"line_number":34,"context_line":"Source30:       %{name}.conf"},{"line_number":35,"context_line":"BuildArch:      noarch"},{"line_number":36,"context_line":"BuildRequires:  crudini"},{"line_number":37,"context_line":"BuildRequires:  fdupes"},{"line_number":38,"context_line":"BuildRequires:  openstack-macros"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_6b1ce213","line":36,"updated":"2017-02-21 19:54:50.000000000","message":"We ship defaultconf files and do not use crudini . See keystone","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Requires:       logrotate"},{"line_number":44,"context_line":"Requires:       python-swift \u003d %{version}"},{"line_number":45,"context_line":"Requires:       rsync"},{"line_number":46,"context_line":"Requires(post): %insserv_prereq"},{"line_number":47,"context_line":"%{?systemd_requires}"},{"line_number":48,"context_line":"Requires(pre):  pwdutils"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_0bde063f","line":46,"updated":"2017-02-21 19:54:50.000000000","message":"insserv?","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Requires:       logrotate"},{"line_number":44,"context_line":"Requires:       python-swift \u003d %{version}"},{"line_number":45,"context_line":"Requires:       rsync"},{"line_number":46,"context_line":"Requires(post): %insserv_prereq"},{"line_number":47,"context_line":"%{?systemd_requires}"},{"line_number":48,"context_line":"Requires(pre):  pwdutils"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_77f205d4","line":46,"in_reply_to":"da36d5c6_0bde063f","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":154,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/cache/%{component}"},{"line_number":155,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/lib/%{component}"},{"line_number":156,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/log/%{component}"},{"line_number":157,"context_line":"install -d -m 755 %{buildroot}%{_rundir}/swift"},{"line_number":158,"context_line":"install -D -m 644 %{SOURCE30} %{buildroot}/%{_tmpfilesdir}/%{name}.conf"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# systemd unit files"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_6bca2270","line":157,"updated":"2017-02-21 19:54:50.000000000","message":"This will be generated in the %post via systemd\u0027s tmpfile generator","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":196,"context_line":"for c in account-server container-server object-expirer object-server proxy-server ; do"},{"line_number":197,"context_line":"    crudini --set %{buildroot}%{_sysconfdir}/swift/$c.conf DEFAULT user %{username}"},{"line_number":198,"context_line":"done"},{"line_number":199,"context_line":"crudini --set %{buildroot}%{_sysconfdir}/swift/dispersion.conf dispersion auth_user %{username}"},{"line_number":200,"context_line":"# NOTE(saschpe): dispersion checks for localhost:8080/auth... by default..."},{"line_number":201,"context_line":"crudini --set %{buildroot}%{_sysconfdir}/swift/proxy-server.conf DEFAULT bind_port 8080"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_2baf4a95","line":199,"updated":"2017-02-21 19:54:50.000000000","message":"Let\u0027s use a defaultconf file instead of crudini","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":224,"context_line":"%tmpfiles_create %{_tmpfilesdir}/%{name}.conf"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"%pre account"},{"line_number":227,"context_line":"%service_add_pre %{name}-account.service"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"%post account"},{"line_number":230,"context_line":"%service_add_post %{name}-account.service"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_0b836605","line":227,"updated":"2017-02-21 19:54:50.000000000","message":"we use the %systemd_XXX macros","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":276,"context_line":"%service_del_postun %{name}-proxy.service"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"%files"},{"line_number":279,"context_line":"%doc README.rst"},{"line_number":280,"context_line":"%{_tmpfilesdir}/%{name}.conf"},{"line_number":281,"context_line":"%dir %attr(0750, %{username}, %{groupname}) %{_localstatedir}/log/%{component}"},{"line_number":282,"context_line":"%dir %attr(0755, %{username}, %{groupname}) %{_sysconfdir}/%{component}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_4b7d5e1b","line":279,"updated":"2017-02-21 19:54:50.000000000","message":"license missing","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":276,"context_line":"%service_del_postun %{name}-proxy.service"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"%files"},{"line_number":279,"context_line":"%doc README.rst"},{"line_number":280,"context_line":"%{_tmpfilesdir}/%{name}.conf"},{"line_number":281,"context_line":"%dir %attr(0750, %{username}, %{groupname}) %{_localstatedir}/log/%{component}"},{"line_number":282,"context_line":"%dir %attr(0755, %{username}, %{groupname}) %{_sysconfdir}/%{component}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_d78bb11c","line":279,"in_reply_to":"da36d5c6_4b7d5e1b","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":319,"context_line":"%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"%files -n python-swift"},{"line_number":322,"context_line":"%doc AUTHORS LICENSE"},{"line_number":323,"context_line":"%{python_sitelib}/swift"},{"line_number":324,"context_line":"%{python_sitelib}/swift-2.*.egg-info"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_4ba47ea5","line":322,"updated":"2017-02-21 19:54:50.000000000","message":"%license","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":319,"context_line":"%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"%files -n python-swift"},{"line_number":322,"context_line":"%doc AUTHORS LICENSE"},{"line_number":323,"context_line":"%{python_sitelib}/swift"},{"line_number":324,"context_line":"%{python_sitelib}/swift-2.*.egg-info"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_979bf971","line":322,"in_reply_to":"da36d5c6_4ba47ea5","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":340,"context_line":"%{_mandir}/man5/account-server.conf.5%{ext_man}"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"%files container"},{"line_number":343,"context_line":"%{_unitdir}/%{name}-container*.service"},{"line_number":344,"context_line":"%{_sbindir}/rc%{name}-container*"},{"line_number":345,"context_line":"%config(noreplace) %{_sysconfdir}/swift/container-server.conf"},{"line_number":346,"context_line":"%{_bindir}/swift-container-auditor"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_4bcb9e53","line":343,"updated":"2017-02-21 19:54:50.000000000","message":"license missing","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":340,"context_line":"%{_mandir}/man5/account-server.conf.5%{ext_man}"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"%files container"},{"line_number":343,"context_line":"%{_unitdir}/%{name}-container*.service"},{"line_number":344,"context_line":"%{_sbindir}/rc%{name}-container*"},{"line_number":345,"context_line":"%config(noreplace) %{_sysconfdir}/swift/container-server.conf"},{"line_number":346,"context_line":"%{_bindir}/swift-container-auditor"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_d7a491ba","line":343,"in_reply_to":"da36d5c6_4bcb9e53","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":362,"context_line":"%{_mandir}/man5/container-server.conf.5%{ext_man}"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"%files object"},{"line_number":365,"context_line":"%doc etc/rsyncd.conf-sample"},{"line_number":366,"context_line":"%{_unitdir}/%{name}-object*.service"},{"line_number":367,"context_line":"%{_sbindir}/rc%{name}-object*"},{"line_number":368,"context_line":"%config(noreplace) %{_sysconfdir}/swift/object-server.conf"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_8bc5963d","line":365,"updated":"2017-02-21 19:54:50.000000000","message":"license missing","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":362,"context_line":"%{_mandir}/man5/container-server.conf.5%{ext_man}"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"%files object"},{"line_number":365,"context_line":"%doc etc/rsyncd.conf-sample"},{"line_number":366,"context_line":"%{_unitdir}/%{name}-object*.service"},{"line_number":367,"context_line":"%{_sbindir}/rc%{name}-object*"},{"line_number":368,"context_line":"%config(noreplace) %{_sysconfdir}/swift/object-server.conf"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_17af0995","line":365,"in_reply_to":"da36d5c6_8bc5963d","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":384,"context_line":"%{_mandir}/man5/object-expirer.conf.5%{ext_man}"},{"line_number":385,"context_line":"%{_mandir}/man5/object-server.conf.5%{ext_man}"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"%files proxy"},{"line_number":388,"context_line":"%{_unitdir}/%{name}-proxy.service"},{"line_number":389,"context_line":"%{_sbindir}/rc%{name}-proxy"},{"line_number":390,"context_line":"%config(noreplace) %{_sysconfdir}/swift/proxy-server.conf"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_ebe0d2ce","line":387,"updated":"2017-02-21 19:54:50.000000000","message":"license missing","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":384,"context_line":"%{_mandir}/man5/object-expirer.conf.5%{ext_man}"},{"line_number":385,"context_line":"%{_mandir}/man5/object-server.conf.5%{ext_man}"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"%files proxy"},{"line_number":388,"context_line":"%{_unitdir}/%{name}-proxy.service"},{"line_number":389,"context_line":"%{_sbindir}/rc%{name}-proxy"},{"line_number":390,"context_line":"%config(noreplace) %{_sysconfdir}/swift/proxy-server.conf"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_3796cd4c","line":387,"in_reply_to":"da36d5c6_ebe0d2ce","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"95a727814a09c665279a672adea632750295fe70","unresolved":false,"context_lines":[{"line_number":392,"context_line":"%{_mandir}/man1/swift-proxy-server.1%{ext_man}"},{"line_number":393,"context_line":"%{_mandir}/man5/proxy-server.conf.5%{ext_man}"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"%files test"},{"line_number":396,"context_line":"%dir %{_localstatedir}/lib/openstack-swift-test"},{"line_number":397,"context_line":"%{_localstatedir}/lib/openstack-swift-test/*"},{"line_number":398,"context_line":"%{_localstatedir}/lib/openstack-swift-test/.alltests"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_4bd2be01","line":395,"updated":"2017-02-21 19:54:50.000000000","message":"license missing","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5de7e9e9fbef5e031e3bbd47485182668d1701d2","unresolved":false,"context_lines":[{"line_number":392,"context_line":"%{_mandir}/man1/swift-proxy-server.1%{ext_man}"},{"line_number":393,"context_line":"%{_mandir}/man5/proxy-server.conf.5%{ext_man}"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"%files test"},{"line_number":396,"context_line":"%dir %{_localstatedir}/lib/openstack-swift-test"},{"line_number":397,"context_line":"%{_localstatedir}/lib/openstack-swift-test/*"},{"line_number":398,"context_line":"%{_localstatedir}/lib/openstack-swift-test/.alltests"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da36d5c6_77a045a0","line":395,"in_reply_to":"da36d5c6_4bd2be01","updated":"2017-02-21 21:38:58.000000000","message":"Done","commit_id":"52ec475d1e2c730dcd4c42e6358d4e0b2998fd5f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"c6e85c88a63651059c81c02d9ea660bca02249d8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"%define groupname %{component}"},{"line_number":3,"context_line":"%define username %{component}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"%define version_unconverted 2.13.0"},{"line_number":6,"context_line":"%if ! %{defined _rundir}"},{"line_number":7,"context_line":"%define _rundir %{_localstatedir}/run"},{"line_number":8,"context_line":"%endif"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da36d5c6_d9a82323","line":5,"updated":"2017-02-22 19:03:34.000000000","message":"please use py2rpmversion and rpm_release. See https://docs.openstack.org/developer/renderspec/usage.html#context-function-py2rpmversion","commit_id":"f3a8c09d4f5707192bf466410dfd3186c8f983cb"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"c6e85c88a63651059c81c02d9ea660bca02249d8","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"%define version_unconverted 2.13.0"},{"line_number":6,"context_line":"%if ! %{defined _rundir}"},{"line_number":7,"context_line":"%define _rundir %{_localstatedir}/run"},{"line_number":8,"context_line":"%endif"},{"line_number":9,"context_line":"Name:           openstack-%{component}"},{"line_number":10,"context_line":"Version:        2.13.0"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da36d5c6_79a2d74c","line":7,"updated":"2017-02-22 19:03:34.000000000","message":"not needed","commit_id":"f3a8c09d4f5707192bf466410dfd3186c8f983cb"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"c6e85c88a63651059c81c02d9ea660bca02249d8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Version:        2.13.0"},{"line_number":11,"context_line":"Release:        0"},{"line_number":12,"context_line":"Summary:        OpenStack Storage (Swift)"},{"line_number":13,"context_line":"License:        Apache-2.0"},{"line_number":14,"context_line":"Group:          Development/Languages/Python"},{"line_number":15,"context_line":"Url:            http://launchpad.net/swift"},{"line_number":16,"context_line":"Source0:        http://tarballs.openstack.org/swift/swift-%{version}.tar.gz"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da36d5c6_d97f43a9","line":13,"updated":"2017-02-22 19:03:34.000000000","message":"Use {{ license(\u0027Apache-2.0\u0027) }}","commit_id":"f3a8c09d4f5707192bf466410dfd3186c8f983cb"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d5bf00c2a8c5cbb79991b01288b92fe1246cae04","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Source22:       %{name}.logrotate"},{"line_number":34,"context_line":"Source30:       %{name}.conf"},{"line_number":35,"context_line":"BuildArch:      noarch"},{"line_number":36,"context_line":"BuildRequires:  crudini"},{"line_number":37,"context_line":"BuildRequires:  fdupes"},{"line_number":38,"context_line":"BuildRequires:  openstack-macros"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_d1ece694","line":36,"updated":"2017-02-27 23:22:29.000000000","message":"How exactly is crudini required to build Swift?","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"e63425e4cc5165dc5d1a539b5edf381652de057d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Source22:       %{name}.logrotate"},{"line_number":34,"context_line":"Source30:       %{name}.conf"},{"line_number":35,"context_line":"BuildArch:      noarch"},{"line_number":36,"context_line":"BuildRequires:  crudini"},{"line_number":37,"context_line":"BuildRequires:  fdupes"},{"line_number":38,"context_line":"BuildRequires:  openstack-macros"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_18c21134","line":36,"in_reply_to":"ba2be162_49b04f8c","updated":"2017-03-01 07:16:58.000000000","message":"but we don\u0027t update config files in rpm-packaging. we use default config files. see the keystone package.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Source22:       %{name}.logrotate"},{"line_number":34,"context_line":"Source30:       %{name}.conf"},{"line_number":35,"context_line":"BuildArch:      noarch"},{"line_number":36,"context_line":"BuildRequires:  crudini"},{"line_number":37,"context_line":"BuildRequires:  fdupes"},{"line_number":38,"context_line":"BuildRequires:  openstack-macros"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_49b04f8c","line":36,"in_reply_to":"da36d5c6_d1ece694","updated":"2017-02-28 21:49:30.000000000","message":"its only needed to update the config file templates iirc.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d5bf00c2a8c5cbb79991b01288b92fe1246cae04","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Requires:       {{ py2pkg(\u0027greenlet\u0027) }}"},{"line_number":69,"context_line":"Requires:       {{ py2pkg(\u0027netifaces\u0027) }}"},{"line_number":70,"context_line":"Requires:       {{ py2pkg(\u0027pbr\u0027) }}"},{"line_number":71,"context_line":"Requires:       {{ py2pkg(\u0027simplejson\u0027) }}"},{"line_number":72,"context_line":"Requires:       {{ py2pkg(\u0027python-swiftclient\u0027) }}"},{"line_number":73,"context_line":"Requires:       {{ py2pkg(\u0027xattr\u0027) }}"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_315e2277","line":71,"updated":"2017-02-27 23:22:29.000000000","message":"We replaced simplejson with json upstream (not even six) in version 2.7.0. This was necessary to support py3.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Requires:       {{ py2pkg(\u0027greenlet\u0027) }}"},{"line_number":69,"context_line":"Requires:       {{ py2pkg(\u0027netifaces\u0027) }}"},{"line_number":70,"context_line":"Requires:       {{ py2pkg(\u0027pbr\u0027) }}"},{"line_number":71,"context_line":"Requires:       {{ py2pkg(\u0027simplejson\u0027) }}"},{"line_number":72,"context_line":"Requires:       {{ py2pkg(\u0027python-swiftclient\u0027) }}"},{"line_number":73,"context_line":"Requires:       {{ py2pkg(\u0027xattr\u0027) }}"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_e9674323","line":71,"in_reply_to":"da36d5c6_315e2277","updated":"2017-02-28 21:49:30.000000000","message":"Done","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d5bf00c2a8c5cbb79991b01288b92fe1246cae04","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Requires:       {{ py2pkg(\u0027netifaces\u0027) }}"},{"line_number":70,"context_line":"Requires:       {{ py2pkg(\u0027pbr\u0027) }}"},{"line_number":71,"context_line":"Requires:       {{ py2pkg(\u0027simplejson\u0027) }}"},{"line_number":72,"context_line":"Requires:       {{ py2pkg(\u0027python-swiftclient\u0027) }}"},{"line_number":73,"context_line":"Requires:       {{ py2pkg(\u0027xattr\u0027) }}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"%description -n python-swift"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_71509a5f","line":72,"updated":"2017-02-27 23:22:29.000000000","message":"What is swiftclient for? Upstream specifies it for functional tests. If we don\u0027t run functests in CI, this is not needed.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Requires:       {{ py2pkg(\u0027netifaces\u0027) }}"},{"line_number":70,"context_line":"Requires:       {{ py2pkg(\u0027pbr\u0027) }}"},{"line_number":71,"context_line":"Requires:       {{ py2pkg(\u0027simplejson\u0027) }}"},{"line_number":72,"context_line":"Requires:       {{ py2pkg(\u0027python-swiftclient\u0027) }}"},{"line_number":73,"context_line":"Requires:       {{ py2pkg(\u0027xattr\u0027) }}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"%description -n python-swift"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_c9627f16","line":72,"in_reply_to":"da36d5c6_71509a5f","updated":"2017-02-28 21:49:30.000000000","message":"Done","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d5bf00c2a8c5cbb79991b01288b92fe1246cae04","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Summary:        OpenStack Storage (Swift) - Proxy Server"},{"line_number":116,"context_line":"Group:          Productivity/Clustering/Computing"},{"line_number":117,"context_line":"Requires:       %{name} \u003d %{version}"},{"line_number":118,"context_line":"Requires:       memcached"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"%description proxy"},{"line_number":121,"context_line":"OpenStack Object Storage (swift) aggregates commodity servers to work"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_1182fec8","line":118,"updated":"2017-02-27 23:22:29.000000000","message":"Honestly, I\u0027m somewhat dubious about requiring memcached. Yes, it\u0027s required... But it may be installed elsewhere.\n\nThis brings up keystoneclient. I don\u0027t see that one required.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Summary:        OpenStack Storage (Swift) - Proxy Server"},{"line_number":116,"context_line":"Group:          Productivity/Clustering/Computing"},{"line_number":117,"context_line":"Requires:       %{name} \u003d %{version}"},{"line_number":118,"context_line":"Requires:       memcached"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"%description proxy"},{"line_number":121,"context_line":"OpenStack Object Storage (swift) aggregates commodity servers to work"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_c930bf0a","line":118,"in_reply_to":"da36d5c6_1182fec8","updated":"2017-02-28 21:49:30.000000000","message":"Done","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"8b624438db600b33e7605a5bb4b6abecc686845e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"install -p -D -m 444 %{SOURCE16} %{buildroot}%{_unitdir}/%{name}-object-reconstructor.service"},{"line_number":161,"context_line":"install -p -D -m 444 %{SOURCE17} %{buildroot}%{_unitdir}/%{name}-proxy.service"},{"line_number":162,"context_line":"mkdir -p %{buildroot}%{_sbindir}"},{"line_number":163,"context_line":"for server in account account-auditor account-reaper account-replicator container container-auditor container-replicator container-updater container-sync object object-replicator object-expirer object-updater object-auditor object-reconstructor proxy; do"},{"line_number":164,"context_line":"    ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-$server"},{"line_number":165,"context_line":"done"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Install manpages"},{"line_number":168,"context_line":"install -d %{buildroot}%{_mandir}/man{1,5}/"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_a45409ff","line":165,"range":{"start_line":163,"start_character":0,"end_line":165,"end_character":4},"updated":"2017-02-23 11:11:23.000000000","message":"These symlinks are not used at all in CentOS, are they used for compat with older SUSE releases?","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"mkdir -p %{buildroot}%{_sbindir}"},{"line_number":163,"context_line":"for server in account account-auditor account-reaper account-replicator container container-auditor container-replicator container-updater container-sync object object-replicator object-expirer object-updater object-auditor object-reconstructor proxy; do"},{"line_number":164,"context_line":"    ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-$server"},{"line_number":165,"context_line":"done"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Install manpages"},{"line_number":168,"context_line":"install -d %{buildroot}%{_mandir}/man{1,5}/"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_0912d762","line":165,"in_reply_to":"da36d5c6_a45409ff","updated":"2017-02-28 21:49:30.000000000","message":"yeah, good point, thats a good old suse tradition to have a service -\u003e rcX link. should I slam it into a suse_version section?","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"8b624438db600b33e7605a5bb4b6abecc686845e","unresolved":false,"context_lines":[{"line_number":252,"context_line":"%{_bindir}/swift-recon-cron"},{"line_number":253,"context_line":"%{_bindir}/swift-ring-builder"},{"line_number":254,"context_line":"%{_bindir}/swift-ring-builder-analyzer"},{"line_number":255,"context_line":"%{_bindir}/swift-temp-url"},{"line_number":256,"context_line":"%{_mandir}/man1/swift-account-audit.1%{ext_man}"},{"line_number":257,"context_line":"%{_mandir}/man1/swift-config.1%{ext_man}"},{"line_number":258,"context_line":"%{_mandir}/man1/swift-dispersion-populate.1%{ext_man}"},{"line_number":259,"context_line":"%{_mandir}/man1/swift-dispersion-report.1%{ext_man}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_c41e5d5e","line":256,"range":{"start_line":255,"start_character":25,"end_line":256,"end_character":37},"updated":"2017-02-23 11:11:23.000000000","message":"%{ext_man} seems to be undefined for RDO, causing the CI job to fail.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":253,"context_line":"%{_bindir}/swift-ring-builder"},{"line_number":254,"context_line":"%{_bindir}/swift-ring-builder-analyzer"},{"line_number":255,"context_line":"%{_bindir}/swift-temp-url"},{"line_number":256,"context_line":"%{_mandir}/man1/swift-account-audit.1%{ext_man}"},{"line_number":257,"context_line":"%{_mandir}/man1/swift-config.1%{ext_man}"},{"line_number":258,"context_line":"%{_mandir}/man1/swift-dispersion-populate.1%{ext_man}"},{"line_number":259,"context_line":"%{_mandir}/man1/swift-dispersion-report.1%{ext_man}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_7410864f","line":256,"in_reply_to":"da36d5c6_c41e5d5e","updated":"2017-02-28 21:49:30.000000000","message":"Done","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"8b624438db600b33e7605a5bb4b6abecc686845e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"%files -n python-swift"},{"line_number":278,"context_line":"%license LICENSE"},{"line_number":279,"context_line":"%{python_sitelib}/swift"},{"line_number":280,"context_line":"%{python_sitelib}/swift-2.*.egg-info"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"%files account"},{"line_number":283,"context_line":"%license LICENSE"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_64193179","line":280,"range":{"start_line":280,"start_character":24,"end_line":280,"end_character":26},"updated":"2017-02-23 11:11:23.000000000","message":"Is the package name swift-2? If not, this could fail once we get version 3.x","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":277,"context_line":"%files -n python-swift"},{"line_number":278,"context_line":"%license LICENSE"},{"line_number":279,"context_line":"%{python_sitelib}/swift"},{"line_number":280,"context_line":"%{python_sitelib}/swift-2.*.egg-info"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"%files account"},{"line_number":283,"context_line":"%license LICENSE"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_14202a9b","line":280,"in_reply_to":"da36d5c6_4c95b986","updated":"2017-02-28 21:49:30.000000000","message":"Done","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d5bf00c2a8c5cbb79991b01288b92fe1246cae04","unresolved":false,"context_lines":[{"line_number":277,"context_line":"%files -n python-swift"},{"line_number":278,"context_line":"%license LICENSE"},{"line_number":279,"context_line":"%{python_sitelib}/swift"},{"line_number":280,"context_line":"%{python_sitelib}/swift-2.*.egg-info"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"%files account"},{"line_number":283,"context_line":"%license LICENSE"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_4c95b986","line":280,"range":{"start_line":280,"start_character":24,"end_line":280,"end_character":26},"in_reply_to":"da36d5c6_64193179","updated":"2017-02-27 23:22:29.000000000","message":"It may use %{version_unconverted} here.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d5bf00c2a8c5cbb79991b01288b92fe1246cae04","unresolved":false,"context_lines":[{"line_number":351,"context_line":"%{_bindir}/swift-proxy-server"},{"line_number":352,"context_line":"%{_mandir}/man1/swift-proxy-server.1%{ext_man}"},{"line_number":353,"context_line":"%{_mandir}/man5/proxy-server.conf.5%{ext_man}"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"%changelog"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da36d5c6_510b962b","line":354,"updated":"2017-02-27 23:22:29.000000000","message":"The object expirer and container reconciler are attached lexicographically, which is just random and defeats the point of separating object/account/container services from proxy. In RDO we place them in proxy, because this is where they belong.","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9068bae865a9cf780dde1b44b9e862734b6b6d1b","unresolved":false,"context_lines":[{"line_number":351,"context_line":"%{_bindir}/swift-proxy-server"},{"line_number":352,"context_line":"%{_mandir}/man1/swift-proxy-server.1%{ext_man}"},{"line_number":353,"context_line":"%{_mandir}/man5/proxy-server.conf.5%{ext_man}"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"%changelog"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba2be162_b48d9e7d","line":354,"in_reply_to":"da36d5c6_510b962b","updated":"2017-02-28 21:49:30.000000000","message":"Done","commit_id":"9468df15ddea1eae1f1b83e85d4eec7e7a0a3702"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"42121892d2db8dd6622a7f438b15d6dd5b304c7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%define component swift"},{"line_number":2,"context_line":"%define groupname %{component}"},{"line_number":3,"context_line":"%define username %{component}"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_f8db7d19","line":1,"updated":"2017-03-01 07:20:35.000000000","message":"nit: can you use sname as we do in other spec.j2 templates?","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"74cae5d3636918e45f427789b8be68ec0d7e701a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%define component swift"},{"line_number":2,"context_line":"%define groupname %{component}"},{"line_number":3,"context_line":"%define username %{component}"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_59d56b41","line":1,"in_reply_to":"ba2be162_f8db7d19","updated":"2017-03-01 08:35:50.000000000","message":"Done","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"42121892d2db8dd6622a7f438b15d6dd5b304c7a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"%define groupname %{component}"},{"line_number":3,"context_line":"%define username %{component}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"%define version_unconverted 2.13.0"},{"line_number":6,"context_line":"%if ! %{defined _rundir}"},{"line_number":7,"context_line":"%define _rundir %{_localstatedir}/run"},{"line_number":8,"context_line":"%endif"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_58300957","line":5,"updated":"2017-03-01 07:20:35.000000000","message":"please use the macros. I already added this comment 3x iirc...","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"74cae5d3636918e45f427789b8be68ec0d7e701a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"%define groupname %{component}"},{"line_number":3,"context_line":"%define username %{component}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"%define version_unconverted 2.13.0"},{"line_number":6,"context_line":"%if ! %{defined _rundir}"},{"line_number":7,"context_line":"%define _rundir %{_localstatedir}/run"},{"line_number":8,"context_line":"%endif"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_79ca2fa3","line":5,"in_reply_to":"ba2be162_58300957","updated":"2017-03-01 08:35:50.000000000","message":"Done","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"42121892d2db8dd6622a7f438b15d6dd5b304c7a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"%define version_unconverted 2.13.0"},{"line_number":6,"context_line":"%if ! %{defined _rundir}"},{"line_number":7,"context_line":"%define _rundir %{_localstatedir}/run"},{"line_number":8,"context_line":"%endif"},{"line_number":9,"context_line":"Name:           openstack-%{component}"},{"line_number":10,"context_line":"Version:        2.13.0"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_d83cf931","line":7,"updated":"2017-03-01 07:20:35.000000000","message":"not needed","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"74cae5d3636918e45f427789b8be68ec0d7e701a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"%define version_unconverted 2.13.0"},{"line_number":6,"context_line":"%if ! %{defined _rundir}"},{"line_number":7,"context_line":"%define _rundir %{_localstatedir}/run"},{"line_number":8,"context_line":"%endif"},{"line_number":9,"context_line":"Name:           openstack-%{component}"},{"line_number":10,"context_line":"Version:        2.13.0"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_99cfe3af","line":7,"in_reply_to":"ba2be162_d83cf931","updated":"2017-03-01 08:35:50.000000000","message":"Done","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"42121892d2db8dd6622a7f438b15d6dd5b304c7a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Version:        2.13.0"},{"line_number":11,"context_line":"Release:        0"},{"line_number":12,"context_line":"Summary:        OpenStack Storage (Swift)"},{"line_number":13,"context_line":"License:        Apache-2.0"},{"line_number":14,"context_line":"Group:          Development/Languages/Python"},{"line_number":15,"context_line":"Url:            http://launchpad.net/swift"},{"line_number":16,"context_line":"Source0:        http://tarballs.openstack.org/swift/swift-%{version}.tar.gz"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_587e49e5","line":13,"updated":"2017-03-01 07:20:35.000000000","message":"I already commented on that as well. stopping here to review...","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"74cae5d3636918e45f427789b8be68ec0d7e701a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Version:        2.13.0"},{"line_number":11,"context_line":"Release:        0"},{"line_number":12,"context_line":"Summary:        OpenStack Storage (Swift)"},{"line_number":13,"context_line":"License:        Apache-2.0"},{"line_number":14,"context_line":"Group:          Development/Languages/Python"},{"line_number":15,"context_line":"Url:            http://launchpad.net/swift"},{"line_number":16,"context_line":"Source0:        http://tarballs.openstack.org/swift/swift-%{version}.tar.gz"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_b9c4a792","line":13,"in_reply_to":"ba2be162_587e49e5","updated":"2017-03-01 08:35:50.000000000","message":"Done","commit_id":"ff7cdc2c28ed4015e4f9894eed7b020bfe9a34c7"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"643e8b0b6b31273c4771d714dd905da3a5e0e9ab","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Requires:       python-swift \u003d %{version}"},{"line_number":43,"context_line":"Requires:       rsync"},{"line_number":44,"context_line":"%{?systemd_requires}"},{"line_number":45,"context_line":"Requires(pre):  pwdutils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"%description"},{"line_number":48,"context_line":"OpenStack Object Storage (swift) aggregates commodity servers to work"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba2be162_d7bcf8dd","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":24},"updated":"2017-03-06 11:51:52.000000000","message":"I think this should be shadow-utils for Fedora/CentOS","commit_id":"9c08a16f72ccae99e27e7f5d99ef4191bc17db0a"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"643e8b0b6b31273c4771d714dd905da3a5e0e9ab","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Group:          Development/Languages/Python"},{"line_number":63,"context_line":"Requires:       {{ py2pkg(\u0027PasteDeploy\u0027) }}"},{"line_number":64,"context_line":"Requires:       {{ py2pkg(\u0027PyECLib\u0027) }}"},{"line_number":65,"context_line":"Requires:       {{ py2pkg(\u0027dnspython\u0027) }}"},{"line_number":66,"context_line":"Requires:       {{ py2pkg(\u0027eventlet\u0027) }}"},{"line_number":67,"context_line":"Requires:       {{ py2pkg(\u0027greenlet\u0027) }}"},{"line_number":68,"context_line":"Requires:       {{ py2pkg(\u0027netifaces\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba2be162_17aa1085","line":65,"updated":"2017-03-06 11:51:52.000000000","message":"https://review.openstack.org/441903","commit_id":"9c08a16f72ccae99e27e7f5d99ef4191bc17db0a"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"643e8b0b6b31273c4771d714dd905da3a5e0e9ab","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Requires:       {{ py2pkg(\u0027greenlet\u0027) }}"},{"line_number":68,"context_line":"Requires:       {{ py2pkg(\u0027netifaces\u0027) }}"},{"line_number":69,"context_line":"Requires:       {{ py2pkg(\u0027pbr\u0027) }}"},{"line_number":70,"context_line":"Requires:       {{ py2pkg(\u0027xattr\u0027) }}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"%description -n python-swift"},{"line_number":73,"context_line":"This package contains the core Python module of OpenStack Swift."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba2be162_f7a65cbf","line":70,"updated":"2017-03-06 11:51:52.000000000","message":"https://review.openstack.org/441903","commit_id":"9c08a16f72ccae99e27e7f5d99ef4191bc17db0a"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"643e8b0b6b31273c4771d714dd905da3a5e0e9ab","unresolved":false,"context_lines":[{"line_number":75,"context_line":"%package account"},{"line_number":76,"context_line":"Summary:        OpenStack Storage (Swift) - Account Server"},{"line_number":77,"context_line":"Requires:       %{name} \u003d %{version}"},{"line_number":78,"context_line":"Requires:       sqlite3"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"%description account"},{"line_number":81,"context_line":"OpenStack Object Storage (swift) aggregates commodity servers to work"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba2be162_d41a367c","line":78,"updated":"2017-03-06 11:51:52.000000000","message":"There is no sqlite3 package in Fedora/CentOS, it is named sqlite (same for other subpackages)","commit_id":"9c08a16f72ccae99e27e7f5d99ef4191bc17db0a"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"03e559f56663b872006fcc6347b69fd3c95c7a73","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Requires:       python-swift \u003d %{version}"},{"line_number":43,"context_line":"Requires:       rsync"},{"line_number":44,"context_line":"%{?systemd_requires}"},{"line_number":45,"context_line":"Requires(pre):  pwdutils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"%description"},{"line_number":48,"context_line":"OpenStack Object Storage (swift) aggregates commodity servers to work"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ffe62b97_66734d82","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":24},"updated":"2017-03-24 11:21:09.000000000","message":"This still needs to be changed for Fedora/CentOS. There is no pwdutils package, we probably need shadow-utils.","commit_id":"3bb7c8dd104a34d9a97aa1fa7690b3e068d5c1a9"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"b997f87f0a52cbb8b0545426516ccb0505ca5506","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Requires:       python-swift \u003d %{version}"},{"line_number":43,"context_line":"Requires:       rsync"},{"line_number":44,"context_line":"%{?systemd_requires}"},{"line_number":45,"context_line":"Requires(pre):  pwdutils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"%description"},{"line_number":48,"context_line":"OpenStack Object Storage (swift) aggregates commodity servers to work"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ffe62b97_046596b5","line":45,"in_reply_to":"ffe62b97_66734d82","updated":"2017-03-24 13:19:23.000000000","message":"Done","commit_id":"3bb7c8dd104a34d9a97aa1fa7690b3e068d5c1a9"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"03e559f56663b872006fcc6347b69fd3c95c7a73","unresolved":false,"context_lines":[{"line_number":167,"context_line":"install -p -D -m 444 %{SOURCE16} %{buildroot}%{_unitdir}/%{name}-object-reconstructor.service"},{"line_number":168,"context_line":"install -p -D -m 444 %{SOURCE17} %{buildroot}%{_unitdir}/%{name}-proxy.service"},{"line_number":169,"context_line":"mkdir -p %{buildroot}%{_sbindir}"},{"line_number":170,"context_line":"for server in account account-auditor account-reaper account-replicator container container-auditor container-replicator container-updater container-sync object object-replicator object-expirer object-updater object-auditor object-reconstructor proxy; do"},{"line_number":171,"context_line":"    ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-$server"},{"line_number":172,"context_line":"done"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Install manpages"},{"line_number":175,"context_line":"install -d %{buildroot}%{_mandir}/man{1,5}/"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ffe62b97_261b051c","line":172,"range":{"start_line":170,"start_character":0,"end_line":172,"end_character":4},"updated":"2017-03-24 11:21:09.000000000","message":"What is this needed for?","commit_id":"3bb7c8dd104a34d9a97aa1fa7690b3e068d5c1a9"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"b997f87f0a52cbb8b0545426516ccb0505ca5506","unresolved":false,"context_lines":[{"line_number":169,"context_line":"mkdir -p %{buildroot}%{_sbindir}"},{"line_number":170,"context_line":"for server in account account-auditor account-reaper account-replicator container container-auditor container-replicator container-updater container-sync object object-replicator object-expirer object-updater object-auditor object-reconstructor proxy; do"},{"line_number":171,"context_line":"    ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-$server"},{"line_number":172,"context_line":"done"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Install manpages"},{"line_number":175,"context_line":"install -d %{buildroot}%{_mandir}/man{1,5}/"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ffe62b97_646d8297","line":172,"in_reply_to":"ffe62b97_261b051c","updated":"2017-03-24 13:19:23.000000000","message":"SUSEism, we always have that. I\u0027m fine with removing it for now.","commit_id":"3bb7c8dd104a34d9a97aa1fa7690b3e068d5c1a9"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"93b98a1b91958910ce1c49ccca94c718dca5b47a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% set upstream_version \u003d \u00272.13.0\u0027 %}"},{"line_number":5,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"%define version_unconverted 2.13.0"},{"line_number":8,"context_line":"Name:           openstack-%{sname}"},{"line_number":9,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":10,"context_line":"Release:        {{ py2rpmrelease() }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_b41291b0","line":7,"updated":"2017-03-24 17:08:26.000000000","message":"version_unconverted is not needed.","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"153ed5e727320219f61303185ff3a98041e7b4db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% set upstream_version \u003d \u00272.13.0\u0027 %}"},{"line_number":5,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"%define version_unconverted 2.13.0"},{"line_number":8,"context_line":"Name:           openstack-%{sname}"},{"line_number":9,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":10,"context_line":"Release:        {{ py2rpmrelease() }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_ef99621f","line":7,"in_reply_to":"ffe62b97_b41291b0","updated":"2017-03-24 17:28:03.000000000","message":"It is used in %prep, but yes, we could simply use upstream_version.","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"93b98a1b91958910ce1c49ccca94c718dca5b47a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"%define version_unconverted 2.13.0"},{"line_number":8,"context_line":"Name:           openstack-%{sname}"},{"line_number":9,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":10,"context_line":"Release:        {{ py2rpmrelease() }}"},{"line_number":11,"context_line":"Summary:        OpenStack Storage (Swift)"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_344c41c6","line":8,"updated":"2017-03-24 17:08:26.000000000","message":"This should be Name: {{ py2name(\u0027swift\u0027) }}","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"93b98a1b91958910ce1c49ccca94c718dca5b47a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Source22:       %{name}.logrotate"},{"line_number":33,"context_line":"Source30:       %{name}.conf"},{"line_number":34,"context_line":"BuildArch:      noarch"},{"line_number":35,"context_line":"BuildRequires:  crudini"},{"line_number":36,"context_line":"BuildRequires:  fdupes"},{"line_number":37,"context_line":"BuildRequires:  openstack-macros"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_d4d075cc","line":35,"updated":"2017-03-24 17:08:26.000000000","message":"crudini is not used/needed","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"153ed5e727320219f61303185ff3a98041e7b4db","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Source22:       %{name}.logrotate"},{"line_number":33,"context_line":"Source30:       %{name}.conf"},{"line_number":34,"context_line":"BuildArch:      noarch"},{"line_number":35,"context_line":"BuildRequires:  crudini"},{"line_number":36,"context_line":"BuildRequires:  fdupes"},{"line_number":37,"context_line":"BuildRequires:  openstack-macros"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_2fe18a9b","line":35,"in_reply_to":"ffe62b97_d4d075cc","updated":"2017-03-24 17:28:03.000000000","message":"it is used in %install","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"93b98a1b91958910ce1c49ccca94c718dca5b47a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Source30:       %{name}.conf"},{"line_number":34,"context_line":"BuildArch:      noarch"},{"line_number":35,"context_line":"BuildRequires:  crudini"},{"line_number":36,"context_line":"BuildRequires:  fdupes"},{"line_number":37,"context_line":"BuildRequires:  openstack-macros"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027pbr\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_34e1e19b","line":36,"updated":"2017-03-24 17:08:26.000000000","message":"same for fdupes","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"153ed5e727320219f61303185ff3a98041e7b4db","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Source30:       %{name}.conf"},{"line_number":34,"context_line":"BuildArch:      noarch"},{"line_number":35,"context_line":"BuildRequires:  crudini"},{"line_number":36,"context_line":"BuildRequires:  fdupes"},{"line_number":37,"context_line":"BuildRequires:  openstack-macros"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027pbr\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_afeeba85","line":36,"in_reply_to":"ffe62b97_34e1e19b","updated":"2017-03-24 17:28:03.000000000","message":"Also used there :-?","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"93b98a1b91958910ce1c49ccca94c718dca5b47a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"BuildRequires:  openstack-macros"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027pbr\u0027) }}"},{"line_number":40,"context_line":"BuildRequires:  systemd"},{"line_number":41,"context_line":"Requires:       logrotate"},{"line_number":42,"context_line":"Requires:       python-swift \u003d %{version}"},{"line_number":43,"context_line":"Requires:       rsync"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ffe62b97_348fa1cd","line":40,"updated":"2017-03-24 17:08:26.000000000","message":"that seems wrong. Should be:\n\n%if 0%{?suse_version}\nBuildRequires:  systemd-rpm-macros\n%{?systemd_requires}\n%else\nBuildRequires:  systemd\nRequires(post): systemd\nRequires(postun): systemd\nRequires(preun): systemd\n%endif\n\n\nSee https://github.com/openstack/rpm-packaging/blob/master/openstack/neutron/neutron.spec.j2#L50","commit_id":"401b1fd7e582addc679253d48f37011fe52e4d1e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"ce9f299da055a3c33c6768ef28ef3098bbf4f591","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% set upstream_version \u003d \u00272.13.0\u0027 %}"},{"line_number":5,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Name:           openstack-%{sname}"},{"line_number":8,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":9,"context_line":"Release:        {{ py2rpmrelease() }}"},{"line_number":10,"context_line":"Summary:        OpenStack Storage (Swift)"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"bff0334d_7c04a04a","line":7,"updated":"2017-04-08 08:42:59.000000000","message":"This is wrong. Should be using py2name() and ideally with setting the upstream_version variable. See the monasca services as example","commit_id":"b76fad57bcb7d52d1431e56076401083e0282cde"},{"author":{"_account_id":7613,"name":"Igor Yozhikov","email":"medput@gmail.com","username":"iyozhikov"},"change_message_id":"870799e30a9aba6363674a71ef7055268035e996","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Source22:       %{name}.logrotate"},{"line_number":32,"context_line":"Source30:       %{name}.conf"},{"line_number":33,"context_line":"BuildArch:      noarch"},{"line_number":34,"context_line":"BuildRequires:  crudini"},{"line_number":35,"context_line":"BuildRequires:  fdupes"},{"line_number":36,"context_line":"BuildRequires:  openstack-macros"},{"line_number":37,"context_line":"BuildRequires:  {{ py2pkg(\u0027devel\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9ff52f3f_45a28c9c","line":34,"updated":"2017-04-13 12:32:01.000000000","message":"missed BuildRequires setuptools\nDEBUG util.py:417:  + /usr/bin/python2 setup.py build \u0027--executable\u003d/usr/bin/python2 -s\u0027\nDEBUG util.py:417:  Traceback (most recent call last):\nDEBUG util.py:417:    File \"setup.py\", line 18, in \u003cmodule\u003e\nDEBUG util.py:417:      import setuptools\nDEBUG util.py:417:  ImportError: No module named setuptools\nDEBUG util.py:417:  error: Bad exit status from /var/tmp/rpm-tmp.v1ENV1 (%build)\nDEBUG util.py:417:      Bad exit status from /var/tmp/rpm-tmp.v1ENV1 (%build)\nDEBUG util.py:417:  RPM build errors:\nDEBUG util.py:542:  Child return code was: 1","commit_id":"b76fad57bcb7d52d1431e56076401083e0282cde"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"6b6a7fdf507fc70f16c6123fbc150b0cfedb0bfc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set pypi_name \u003d \u0027swift\u0027 %}"},{"line_number":2,"context_line":"{% set upstream_version \u003d upstream_version(\u00272.13.0\u0027) %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"%define component swift"},{"line_number":5,"context_line":"%define groupname %{component}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f044301_33640c22","line":2,"updated":"2017-05-09 09:48:14.000000000","message":"We\u0027re missing the following line: \n\n{% set rpm_release \u003d \u00271\u0027 %}","commit_id":"601d7f38b37522a5407417c1d8e184c1f3f38ebe"},{"author":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"change_message_id":"de97b9d32f433c051e4f8b33ffc15a850acb59b2","unresolved":false,"context_lines":[{"line_number":315,"context_line":"%{_bindir}/swift-container-updater"},{"line_number":316,"context_line":"%{_bindir}/swift-container-sync"},{"line_number":317,"context_line":"%{_bindir}/swift-reconciler-enqueue"},{"line_number":318,"context_line":"%{_mandir}/man1/swift-container-auditor.1%{ext_man}"},{"line_number":319,"context_line":"%{_mandir}/man1/swift-container-info.1%{ext_man}"},{"line_number":320,"context_line":"%{_mandir}/man1/swift-container-server.1%{ext_man}"},{"line_number":321,"context_line":"%{_mandir}/man1/swift-container-sync.1%{ext_man}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7f231b9d_d345b2b5","line":318,"updated":"2017-06-15 12:47:03.000000000","message":"-1 %ext_man is not being expanded on RDO/RHEL/Fedora","commit_id":"b96783016518c3d1fe7adb8e9c4989ab75bc17f6"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"3f1aa25dd1be2e84085cd6441fdfa79ecfb3b47e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Requires:       logrotate"},{"line_number":46,"context_line":"Requires:       python-swift \u003d %{version}"},{"line_number":47,"context_line":"Requires:       rsync"},{"line_number":48,"context_line":"Requires(pre):  pwdutils"},{"line_number":49,"context_line":"BuildArch:      noarch"},{"line_number":50,"context_line":"%{?systemd_requires}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"7f231b9d_399ba766","line":48,"range":{"start_line":48,"start_character":14,"end_line":48,"end_character":20},"updated":"2017-06-15 13:34:16.000000000","message":"This should be shadow-utils for Fedora/CentOS","commit_id":"6dd691da5919a40b993c490c43e316ef42c248a8"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"3f1aa25dd1be2e84085cd6441fdfa79ecfb3b47e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"%package account"},{"line_number":83,"context_line":"Summary:        OpenStack Storage (Swift) - Account Server"},{"line_number":84,"context_line":"Requires:       %{name} \u003d %{version}"},{"line_number":85,"context_line":"Requires:       sqlite3"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"%description account"},{"line_number":88,"context_line":"OpenStack Object Storage (swift) aggregates commodity servers to work"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"7f231b9d_d974b338","line":85,"range":{"start_line":85,"start_character":15,"end_line":85,"end_character":23},"updated":"2017-06-15 13:34:16.000000000","message":"There is no sqlite3 package in Fedora/CentOS, it is named sqlite","commit_id":"6dd691da5919a40b993c490c43e316ef42c248a8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"803ec56aeb7eba8fae138b2f0be5ff6057398c17","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Source15:       %{name}-object-reconstructor.service"},{"line_number":29,"context_line":"Source16:       %{name}-proxy.service"},{"line_number":30,"context_line":"Source20:       %{name}.logrotate"},{"line_number":31,"context_line":"Source30:       %{name}.conf"},{"line_number":32,"context_line":"BuildRequires:  crudini"},{"line_number":33,"context_line":"BuildRequires:  fdupes"},{"line_number":34,"context_line":"BuildRequires:  openstack-macros"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_f1d86b1e","line":31,"updated":"2019-09-30 11:41:03.000000000","message":"can we rename this to .tmpfiles to be consistent?","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a8f9d0ae227b96ed149c3789cab6325c401d06b4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Source15:       %{name}-object-reconstructor.service"},{"line_number":29,"context_line":"Source16:       %{name}-proxy.service"},{"line_number":30,"context_line":"Source20:       %{name}.logrotate"},{"line_number":31,"context_line":"Source30:       %{name}.conf"},{"line_number":32,"context_line":"BuildRequires:  crudini"},{"line_number":33,"context_line":"BuildRequires:  fdupes"},{"line_number":34,"context_line":"BuildRequires:  openstack-macros"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_f54db43a","line":31,"in_reply_to":"3fa7e38b_2c6f8c2b","updated":"2019-09-30 14:26:53.000000000","message":"*.tmpfs in RDO","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"630e74733fd5f55fb99826c851cd75654278ae48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Source15:       %{name}-object-reconstructor.service"},{"line_number":29,"context_line":"Source16:       %{name}-proxy.service"},{"line_number":30,"context_line":"Source20:       %{name}.logrotate"},{"line_number":31,"context_line":"Source30:       %{name}.conf"},{"line_number":32,"context_line":"BuildRequires:  crudini"},{"line_number":33,"context_line":"BuildRequires:  fdupes"},{"line_number":34,"context_line":"BuildRequires:  openstack-macros"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_2c6f8c2b","line":31,"in_reply_to":"3fa7e38b_f1d86b1e","updated":"2019-09-30 13:11:02.000000000","message":"Done","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"bb60fbc0e2ebf23bdcf47d5b8f250c827187d4c4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Source15:       %{name}-object-reconstructor.service"},{"line_number":29,"context_line":"Source16:       %{name}-proxy.service"},{"line_number":30,"context_line":"Source20:       %{name}.logrotate"},{"line_number":31,"context_line":"Source30:       %{name}.conf"},{"line_number":32,"context_line":"BuildRequires:  crudini"},{"line_number":33,"context_line":"BuildRequires:  fdupes"},{"line_number":34,"context_line":"BuildRequires:  openstack-macros"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_f57934c4","line":31,"in_reply_to":"3fa7e38b_f54db43a","updated":"2019-09-30 14:43:20.000000000","message":"Not sure what this is referring to, but all packages in openstack/rpm-packaging seem to have settled on the .tmpfiles name here.","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"803ec56aeb7eba8fae138b2f0be5ff6057398c17","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Source16:       %{name}-proxy.service"},{"line_number":30,"context_line":"Source20:       %{name}.logrotate"},{"line_number":31,"context_line":"Source30:       %{name}.conf"},{"line_number":32,"context_line":"BuildRequires:  crudini"},{"line_number":33,"context_line":"BuildRequires:  fdupes"},{"line_number":34,"context_line":"BuildRequires:  openstack-macros"},{"line_number":35,"context_line":"BuildRequires:  {{ py3(\u0027pbr\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_31d36306","line":32,"updated":"2019-09-30 11:41:03.000000000","message":"can we have a .defaultconf instead of using crudini?","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"630e74733fd5f55fb99826c851cd75654278ae48","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Source16:       %{name}-proxy.service"},{"line_number":30,"context_line":"Source20:       %{name}.logrotate"},{"line_number":31,"context_line":"Source30:       %{name}.conf"},{"line_number":32,"context_line":"BuildRequires:  crudini"},{"line_number":33,"context_line":"BuildRequires:  fdupes"},{"line_number":34,"context_line":"BuildRequires:  openstack-macros"},{"line_number":35,"context_line":"BuildRequires:  {{ py3(\u0027pbr\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_4cd8c8ed","line":32,"in_reply_to":"3fa7e38b_31d36306","updated":"2019-09-30 13:11:02.000000000","message":"I can do that. But actually that would be 7 different .defaultconfs (See line 183 and following)\n\nDo you really think that\u0027s better then the crudini calls?","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"803ec56aeb7eba8fae138b2f0be5ff6057398c17","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Requires:       {{ py3(\u0027pbr\u0027) }}"},{"line_number":76,"context_line":"Requires:       {{ py3(\u0027simplejson\u0027) }}"},{"line_number":77,"context_line":"Requires:       {{ py3(\u0027six\u0027) }}"},{"line_number":78,"context_line":"Requires:       {{ py3(\u0027swiftclient\u0027) }}"},{"line_number":79,"context_line":"Requires:       {{ py3(\u0027xattr\u0027) }}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"%description -n python3-swift"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_71febb6b","line":78,"updated":"2019-09-30 11:41:03.000000000","message":"it\u0027s python-swiftclient","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"630e74733fd5f55fb99826c851cd75654278ae48","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Requires:       {{ py3(\u0027pbr\u0027) }}"},{"line_number":76,"context_line":"Requires:       {{ py3(\u0027simplejson\u0027) }}"},{"line_number":77,"context_line":"Requires:       {{ py3(\u0027six\u0027) }}"},{"line_number":78,"context_line":"Requires:       {{ py3(\u0027swiftclient\u0027) }}"},{"line_number":79,"context_line":"Requires:       {{ py3(\u0027xattr\u0027) }}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"%description -n python3-swift"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_acf29c6e","line":78,"in_reply_to":"3fa7e38b_71febb6b","updated":"2019-09-30 13:11:02.000000000","message":"Done","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"803ec56aeb7eba8fae138b2f0be5ff6057398c17","unresolved":false,"context_lines":[{"line_number":144,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/cache/{{ pypi_name }}"},{"line_number":145,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/lib/{{ pypi_name }}"},{"line_number":146,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/log/{{ pypi_name }}"},{"line_number":147,"context_line":"install -d -m 755 %{buildroot}%{_rundir}/{{ pypi_name }}"},{"line_number":148,"context_line":"install -D -m 644 %{SOURCE30} %{buildroot}/%_tmpfilesdir/%{name}.conf"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# systemd unit files"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_11ed07b6","line":147,"updated":"2019-09-30 11:41:03.000000000","message":"rundir is created via tmpfiles.","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"630e74733fd5f55fb99826c851cd75654278ae48","unresolved":false,"context_lines":[{"line_number":144,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/cache/{{ pypi_name }}"},{"line_number":145,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/lib/{{ pypi_name }}"},{"line_number":146,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/log/{{ pypi_name }}"},{"line_number":147,"context_line":"install -d -m 755 %{buildroot}%{_rundir}/{{ pypi_name }}"},{"line_number":148,"context_line":"install -D -m 644 %{SOURCE30} %{buildroot}/%_tmpfilesdir/%{name}.conf"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# systemd unit files"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_6ce8247b","line":147,"in_reply_to":"3fa7e38b_11ed07b6","updated":"2019-09-30 13:11:02.000000000","message":"Done","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a8f9d0ae227b96ed149c3789cab6325c401d06b4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/cache/{{ pypi_name }}"},{"line_number":145,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/lib/{{ pypi_name }}"},{"line_number":146,"context_line":"install -d -m 750 %{buildroot}%{_localstatedir}/log/{{ pypi_name }}"},{"line_number":147,"context_line":"install -d -m 755 %{buildroot}%{_rundir}/{{ pypi_name }}"},{"line_number":148,"context_line":"install -D -m 644 %{SOURCE30} %{buildroot}/%_tmpfilesdir/%{name}.conf"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# systemd unit files"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_b50adcce","line":147,"in_reply_to":"3fa7e38b_6ce8247b","updated":"2019-09-30 14:26:53.000000000","message":"Even on the first run? I thought the tmpfiles only were re-created at boot.","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"803ec56aeb7eba8fae138b2f0be5ff6057398c17","unresolved":false,"context_lines":[{"line_number":165,"context_line":"install -p -D -m 444 %{SOURCE14} %{buildroot}%{_unitdir}/%{name}-object-auditor.service"},{"line_number":166,"context_line":"install -p -D -m 444 %{SOURCE15} %{buildroot}%{_unitdir}/%{name}-object-reconstructor.service"},{"line_number":167,"context_line":"install -p -D -m 444 %{SOURCE16} %{buildroot}%{_unitdir}/%{name}-proxy.service"},{"line_number":168,"context_line":"mkdir -p %{buildroot}%{_sbindir}"},{"line_number":169,"context_line":"for server in account account-auditor account-reaper account-replicator container container-auditor container-replicator container-updater container-sync object object-replicator object-expirer object-updater object-auditor object-reconstructor proxy; do"},{"line_number":170,"context_line":"    ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-$server"},{"line_number":171,"context_line":"done"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_314123aa","line":168,"updated":"2019-09-30 11:41:03.000000000","message":"this should be in s %if suse_version","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"630e74733fd5f55fb99826c851cd75654278ae48","unresolved":false,"context_lines":[{"line_number":165,"context_line":"install -p -D -m 444 %{SOURCE14} %{buildroot}%{_unitdir}/%{name}-object-auditor.service"},{"line_number":166,"context_line":"install -p -D -m 444 %{SOURCE15} %{buildroot}%{_unitdir}/%{name}-object-reconstructor.service"},{"line_number":167,"context_line":"install -p -D -m 444 %{SOURCE16} %{buildroot}%{_unitdir}/%{name}-proxy.service"},{"line_number":168,"context_line":"mkdir -p %{buildroot}%{_sbindir}"},{"line_number":169,"context_line":"for server in account account-auditor account-reaper account-replicator container container-auditor container-replicator container-updater container-sync object object-replicator object-expirer object-updater object-auditor object-reconstructor proxy; do"},{"line_number":170,"context_line":"    ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-$server"},{"line_number":171,"context_line":"done"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_2c8b0cc3","line":168,"in_reply_to":"3fa7e38b_314123aa","updated":"2019-09-30 13:11:02.000000000","message":"Done","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"803ec56aeb7eba8fae138b2f0be5ff6057398c17","unresolved":false,"context_lines":[{"line_number":233,"context_line":"%preun proxy"},{"line_number":234,"context_line":"%systemd_preun %{name}-proxy.service"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"%postun proxy"},{"line_number":237,"context_line":"%systemd_postun_with_restart %{name}-proxy.service"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"%files"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_b11673a7","line":236,"updated":"2019-09-30 11:41:03.000000000","message":"The list of %post/%preun/%postun seems to be incomplete. There are a lot more .services files. Or %systemd_... needs to be called more often?","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a8f9d0ae227b96ed149c3789cab6325c401d06b4","unresolved":false,"context_lines":[{"line_number":233,"context_line":"%preun proxy"},{"line_number":234,"context_line":"%systemd_preun %{name}-proxy.service"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"%postun proxy"},{"line_number":237,"context_line":"%systemd_postun_with_restart %{name}-proxy.service"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"%files"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_f514d4ea","line":236,"in_reply_to":"3fa7e38b_6c44a474","updated":"2019-09-30 14:26:53.000000000","message":"Proxy service only runs proxy, duh. Why would a %postun for proxy do anything else?","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"630e74733fd5f55fb99826c851cd75654278ae48","unresolved":false,"context_lines":[{"line_number":233,"context_line":"%preun proxy"},{"line_number":234,"context_line":"%systemd_preun %{name}-proxy.service"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"%postun proxy"},{"line_number":237,"context_line":"%systemd_postun_with_restart %{name}-proxy.service"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"%files"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_6c44a474","line":236,"in_reply_to":"3fa7e38b_b11673a7","updated":"2019-09-30 13:11:02.000000000","message":"Done","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"bb60fbc0e2ebf23bdcf47d5b8f250c827187d4c4","unresolved":false,"context_lines":[{"line_number":233,"context_line":"%preun proxy"},{"line_number":234,"context_line":"%systemd_preun %{name}-proxy.service"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"%postun proxy"},{"line_number":237,"context_line":"%systemd_postun_with_restart %{name}-proxy.service"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"%files"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3fa7e38b_b5f5fc58","line":236,"in_reply_to":"3fa7e38b_f514d4ea","updated":"2019-09-30 14:43:20.000000000","message":"I think the comment was about the other subpackages.\n\nE.g. the account subpackage contains 4 different service files. And the old patch set didn\u0027t call the %systemd macros for all those pacakges.\n\nThat\u0027s fixed meanwhile.","commit_id":"2fab8d9bd873f80a4737724b4f17a5b85676ebbf"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9db0b0ec8c632d5740d092d7c69b2376e124e541","unresolved":false,"context_lines":[{"line_number":400,"context_line":"%files proxy"},{"line_number":401,"context_line":"%license LICENSE"},{"line_number":402,"context_line":"%{_unitdir}/%{name}-proxy.service"},{"line_number":403,"context_line":"%{_sbindir}/rc%{name}-proxy"},{"line_number":404,"context_line":"%config(noreplace) %{_sysconfdir}/swift/proxy-server.conf"},{"line_number":405,"context_line":"%{_bindir}/swift-proxy-server"},{"line_number":406,"context_line":"%{_mandir}/man1/swift-proxy-server.1*"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"3fa7e38b_b27bd289","line":403,"updated":"2019-09-30 13:19:48.000000000","message":"all theses rc%{name} need to be in a %if suse_version","commit_id":"38d494747f860f1ec08e1211e1b9e5689a4e97a9"}]}