)]}'
{"openstack/python-tempestconf/python-tempestconf.spec.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d3b903494641def73d9fef764c153da151bbfda3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set upstream_version \u003d upstream_version(\u00272.0.0\u0027) %}"},{"line_number":2,"context_line":"%global sname tempestconf"},{"line_number":3,"context_line":"Name:           i{{ py2name(\u0027python-tempestconf\u0027) }}"},{"line_number":4,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":5,"context_line":"Release:        0"},{"line_number":6,"context_line":"Summary:        OpenStack Tempest Config generator"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_b0289333","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":17},"updated":"2018-09-24 14:51:29.000000000","message":"is that a typo?","commit_id":"8844fd57d424238275b0a469a862b854c500f83e"},{"author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"change_message_id":"99e4da385ac5992e803588e6277476d49df2294c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"BuildArch:      noarch"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"%description"},{"line_number":33,"context_line":"python-tempestconf will automatically generates the tempest \\"},{"line_number":34,"context_line":"configuration based on your cloud."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"%package doc"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_f8b7cdf7","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":47},"updated":"2018-09-24 20:18:58.000000000","message":"Just a grammar nit - don\u0027t need to have an \u0027s\u0027 with the word \u0027will\u0027 in the sentence.","commit_id":"8844fd57d424238275b0a469a862b854c500f83e"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"d8087c1d9d758fb57c5f160cb3a7a9ace0e34be5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027openstackdocstheme\u0027) }}"},{"line_number":40,"context_line":"BuildRequires:  {{ py2pkg(\u0027oslosphinx\u0027) }}"},{"line_number":41,"context_line":"BuildRequires:  {{ py2pkg(\u0027sphinx\u0027) }}"},{"line_number":42,"context_line":"BuildRequires:  {{ py2pkg(\u0027sphinxargparse\u0027, (\u0027\u003e\u003d\u0027, \u00270.2.2\u0027)) }}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"%description doc"},{"line_number":45,"context_line":"Documentation for python-tempestconf"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_50681f21","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":42},"updated":"2018-09-24 15:00:15.000000000","message":"Should be sphinx-argparse, see https://pypi.org/project/sphinx-argparse/","commit_id":"8844fd57d424238275b0a469a862b854c500f83e"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"d8087c1d9d758fb57c5f160cb3a7a9ace0e34be5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027openstackdocstheme\u0027) }}"},{"line_number":40,"context_line":"BuildRequires:  {{ py2pkg(\u0027oslosphinx\u0027) }}"},{"line_number":41,"context_line":"BuildRequires:  {{ py2pkg(\u0027sphinx\u0027) }}"},{"line_number":42,"context_line":"BuildRequires:  {{ py2pkg(\u0027sphinxargparse\u0027, (\u0027\u003e\u003d\u0027, \u00270.2.0\u0027)) }}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"%description doc"},{"line_number":45,"context_line":"Documentation for python-tempestconf"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_5051ff62","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":41},"updated":"2018-09-24 15:00:15.000000000","message":"This should be sphinx-argparse, see https://pypi.org/project/sphinx-argparse/","commit_id":"fe8181721c0c4e4644a60cec41e0c381042a894d"},{"author":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"change_message_id":"804c9543d5819b437783cd0ac23950f30a2912e8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"%endif"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"%prep"},{"line_number":63,"context_line":"%autosetup -p1 -n {{ pypi_name }}-{{ upstream_version }}"},{"line_number":64,"context_line":"# Remove pbr\u003e\u003d1.8.0 version as it needs higher version for doc"},{"line_number":65,"context_line":"# building"},{"line_number":66,"context_line":"sed -i \u0027s/pbr\u003e\u003d1.8.0/pbr/g\u0027 setup.py"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3f79a3b5_15e48adf","line":63,"updated":"2018-09-27 13:28:37.000000000","message":"-S git may help solve some issues if not all\nBR: git would be needed","commit_id":"3563f91a49000946979085e2692527a36a5614bc"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"ba9a0bb94d0ef3fdb66a018a5d71e3ff2623d4cd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"%endif"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"%prep"},{"line_number":63,"context_line":"%autosetup -p1 -n {{ pypi_name }}-{{ upstream_version }}"},{"line_number":64,"context_line":"# Remove pbr\u003e\u003d1.8.0 version as it needs higher version for doc"},{"line_number":65,"context_line":"# building"},{"line_number":66,"context_line":"sed -i \u0027s/pbr\u003e\u003d1.8.0/pbr/g\u0027 setup.py"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3f79a3b5_f54d4ec5","line":63,"in_reply_to":"3f79a3b5_15e48adf","updated":"2018-09-27 13:34:31.000000000","message":"Note we are usually avoiding -S git in rpm-packaging specs, since this is not used by SUSE specs. In some cases, we have seen patches created to fix this (I can\u0027t find any at the moment, Dirk?).","commit_id":"3563f91a49000946979085e2692527a36a5614bc"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"c93cd55eb5931e6b6a6fc5866b0867aa4f12c20a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"URL:            http://git.openstack.org/cgit/openstack/{{ pypi_name }}"},{"line_number":19,"context_line":"Source0:        {{ source }}"},{"line_number":20,"context_line":"BuildRequires: openstack-macros"},{"line_number":21,"context_line":"BuildRequires: {{ py2pkg(\u0027Tempest\u0027) }}"},{"line_number":22,"context_line":"BuildRequires: {{ py2pkg(\u0027devel\u0027) }}"},{"line_number":23,"context_line":"BuildRequires: {{ py2pkg(\u0027os-client-config\u0027) }}"},{"line_number":24,"context_line":"BuildRequires: {{ py2pkg(\u0027oslotest\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f79a3b5_23f90d81","line":21,"updated":"2018-10-01 13:24:11.000000000","message":"Since we are using singlespec to build python2 and python3 versions of the spec, we should set py_versions for build requires, see https://github.com/openstack/rpm-packaging/blob/master/openstack/oslo.service/oslo.service.spec.j2#L18-L37 for an example","commit_id":"28281fb9e25bac7d6b0c10baa42f80dd2bdd809b"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"c93cd55eb5931e6b6a6fc5866b0867aa4f12c20a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"BuildRequires: {{ py2pkg(\u0027pbr\u0027) }}"},{"line_number":26,"context_line":"BuildRequires: {{ py2pkg(\u0027setuptools\u0027) }}"},{"line_number":27,"context_line":"BuildRequires: {{ py2pkg(\u0027stestr\u0027) }}"},{"line_number":28,"context_line":"BuildRequires: {{ py2pkg(\u0027subunit\u0027) }}"},{"line_number":29,"context_line":"BuildRequires: {{ py2pkg(\u0027testscenarios\u0027) }}"},{"line_number":30,"context_line":"BuildRequires: {{ py2pkg(\u0027testtools\u0027) }}"},{"line_number":31,"context_line":"Requires:      {{ py2pkg(\u0027Tempest\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f79a3b5_a3be7dac","line":28,"range":{"start_line":28,"start_character":25,"end_line":28,"end_character":33},"updated":"2018-10-01 13:24:11.000000000","message":"I think we can remove this build requirement, it not present in the SUSE CI.","commit_id":"28281fb9e25bac7d6b0c10baa42f80dd2bdd809b"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"c93cd55eb5931e6b6a6fc5866b0867aa4f12c20a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# remove the sphinx-build leftovers"},{"line_number":79,"context_line":"rm -rf doc/build/html/.{doctrees,buildinfo}"},{"line_number":80,"context_line":"%endif"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"%install"},{"line_number":83,"context_line":"%{python_install}"},{"line_number":84,"context_line":"%python_clone -a %{buildroot}%{_bindir}/discover-tempest-config"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f79a3b5_83ba61bd","line":81,"updated":"2018-10-01 13:24:11.000000000","message":"There is no %check section, and this is strongly recommended for rpm-packaging specs, see https://wiki.openstack.org/wiki/Rpm-packaging/ReviewGuidelines","commit_id":"28281fb9e25bac7d6b0c10baa42f80dd2bdd809b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2face5b118dcea51a3c62ad185ed8a80e7b9acd6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"%{python_install}"},{"line_number":82,"context_line":"%python_clone -a %{buildroot}%{_bindir}/discover-tempest-config"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#%check"},{"line_number":85,"context_line":"#export PYTHONPATH\u003d."},{"line_number":86,"context_line":"#export OS_TEST_PATH\u003d./config_tempest/tests"},{"line_number":87,"context_line":"#ostestr"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"3f79a3b5_bbd75622","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":7},"updated":"2018-10-03 08:47:51.000000000","message":"I think we can add a reason here why %check section is commented so that other people can know it.","commit_id":"3fc2cd39567ac7a6579e6c0e4c2023a9b34800b8"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2b455a0f74eea01ca757151f998321361dd8901d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"%{python_install}"},{"line_number":82,"context_line":"%python_clone -a %{buildroot}%{_bindir}/discover-tempest-config"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#%check"},{"line_number":85,"context_line":"#export PYTHONPATH\u003d."},{"line_number":86,"context_line":"#export OS_TEST_PATH\u003d./config_tempest/tests"},{"line_number":87,"context_line":"#ostestr"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"3f79a3b5_9bc5ba3f","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":7},"in_reply_to":"3f79a3b5_3b990679","updated":"2018-10-03 08:53:40.000000000","message":"Tests are failing and we don\u0027t know the reason, this is the initial spec file, once we have the rpm package being created, we can work on fix this, but if we don\u0027t have it we are blocking all our work on os_tempest.","commit_id":"3fc2cd39567ac7a6579e6c0e4c2023a9b34800b8"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b9f34414982430b420141d53d761e20071acb94d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"%{python_install}"},{"line_number":82,"context_line":"%python_clone -a %{buildroot}%{_bindir}/discover-tempest-config"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#%check"},{"line_number":85,"context_line":"#export PYTHONPATH\u003d."},{"line_number":86,"context_line":"#export OS_TEST_PATH\u003d./config_tempest/tests"},{"line_number":87,"context_line":"#ostestr"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"3f79a3b5_3b990679","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":7},"in_reply_to":"3f79a3b5_bbd75622","updated":"2018-10-03 08:50:13.000000000","message":"Or better we can add something like this:\nhttps://wiki.openstack.org/wiki/Rpm-packaging/ReviewGuidelines#Tests in order to skip the tests.","commit_id":"3fc2cd39567ac7a6579e6c0e4c2023a9b34800b8"}]}