)]}'
{"openstack/watcher/openstack-watcher-api.service":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f14363e424a594f060621e2eca68e883b6511e44","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dnotify"},{"line_number":7,"context_line":"User\u003dwatcher"},{"line_number":8,"context_line":"Group\u003dwatcher"},{"line_number":9,"context_line":"ExecStart\u003d/usr/bin/watcher-api"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9fb8cfa7_4d2e32a6","line":6,"updated":"2019-06-05 05:19:45.000000000","message":"Are you sure that watcher API support SD_NOTIFY? I couldn\u0027t find it in the source.","commit_id":"6410c198f18d5f176a05424f5aee0c0eebfd15f4"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"af69cc062b29e5d5ace69cbf1b85a4bdd8ca4cfe","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dnotify"},{"line_number":7,"context_line":"User\u003dwatcher"},{"line_number":8,"context_line":"Group\u003dwatcher"},{"line_number":9,"context_line":"ExecStart\u003d/usr/bin/watcher-api"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7faddb67_566932f5","line":6,"in_reply_to":"9fb8cfa7_4d2e32a6","updated":"2019-08-21 17:32:44.000000000","message":"Looks liek it does.\n\nWatcher uses oslo_service.\n\nhttps://opendev.org/openstack/watcher/src/branch/master/watcher/cmd/api.py#L26\nhttps://opendev.org/openstack/watcher/src/branch/master/watcher/common/service.py\n\nAnd oslo_service support SD_NOTIFY.\n\nhttps://opendev.org/openstack/oslo.service/src/branch/master/oslo_service/systemd.py","commit_id":"6410c198f18d5f176a05424f5aee0c0eebfd15f4"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9e7ac55e40a6355fdd39ba80d5f981cffd1e79f0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_42dfda37","line":15,"updated":"2019-08-27 04:15:35.000000000","message":"This needs to be in the [Service] section","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9a294af94a2d136981290e6ad80db56c5978adcd","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_825cf27d","line":15,"in_reply_to":"7faddb67_42dfda37","updated":"2019-08-27 05:08:17.000000000","message":"Done. Good catch!","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0dcd229de28ef451057184edd6b183c8942a1fc6","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_c2318a0c","line":15,"in_reply_to":"7faddb67_825cf27d","updated":"2019-08-27 05:17:38.000000000","message":"On a second thought, I think we should remove it from the unit file. Reason is watchter-db-manage is depending on the DB configuration in watcher-api.conf, which we don\u0027t have at the time of package installation. We should let configuration management (i.e. chef, ansible, etc) to handle to that.","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"18eb41732f8755133c469f52dd20313fac6246ff","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_3d81a3a1","line":15,"in_reply_to":"7faddb67_c2318a0c","updated":"2019-08-27 07:02:55.000000000","message":"I would like to keep it because:\n- We also have it in other packages (if we decide to remove it, let\u0027s remove it everywhere)\n- it does not hurt if it fails because of the \u003d-\n- it\u0027s not about package installation. you can install the package, configure the DB connection and then start the systemd service. That\u0027s totally valid and you don\u0027t need any chef/ansible/salt","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"}],"openstack/watcher/openstack-watcher-applier.service":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f14363e424a594f060621e2eca68e883b6511e44","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dnotify"},{"line_number":7,"context_line":"User\u003dwatcher"},{"line_number":8,"context_line":"Group\u003dwatcher"},{"line_number":9,"context_line":"ExecStart\u003d/usr/bin/watcher-applier"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9fb8cfa7_6d2bf693","line":6,"updated":"2019-06-05 05:19:45.000000000","message":"does it support SD_NOTIFY?","commit_id":"6410c198f18d5f176a05424f5aee0c0eebfd15f4"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9e7ac55e40a6355fdd39ba80d5f981cffd1e79f0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_c2bc2add","line":15,"updated":"2019-08-27 04:15:35.000000000","message":"I think having it in the openstack-watcher-api.service is enough.","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9a294af94a2d136981290e6ad80db56c5978adcd","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_e24cc6c9","line":15,"in_reply_to":"7faddb67_c2bc2add","updated":"2019-08-27 05:08:17.000000000","message":"Yes. Make sense. Seem like it has a soft dependency on openstack-watcher-api.service. I\u0027ll add that.","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"}],"openstack/watcher/openstack-watcher-decision-engine.service":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1707fd91d5a2ba487047c904c8a50bb7aa5e2b5d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"},{"line_number":16,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_72b35c0b","line":15,"updated":"2019-05-14 14:57:27.000000000","message":"Do all of these services all need to run the db upgrade? For cinder, glance, and nova we only run it for the API service. If all of these services are trying to run the db upgrade at startup there could be a db lock.","commit_id":"9241311d9ebdcf62d43eced7a195414910cf264d"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e8c0c5cab4f474921da834236b79a7d064c1b634","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"},{"line_number":16,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_83c46d41","line":15,"in_reply_to":"dfbec78f_4a0befd4","updated":"2019-05-15 16:40:31.000000000","message":"I tend to agree, I find it strange that nova, glance and cinder do this.","commit_id":"9241311d9ebdcf62d43eced7a195414910cf264d"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"68ce4c17e47fc6b4520910c69bdf575ab04c2104","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"},{"line_number":16,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_4a0befd4","line":15,"in_reply_to":"dfbec78f_72b35c0b","updated":"2019-05-15 08:53:45.000000000","message":"I\u0027d hate to spoil a +2, but should we really run the db upgrade in a service file at all? After all people usually go to great lengths to only run that sort of thing on exactly one controller node in multi controller environments. Having that step hardwired in a service file sounds like a surefire recipe for setting people who run multi controller deployments up for a well hidden race condition.","commit_id":"9241311d9ebdcf62d43eced7a195414910cf264d"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f14363e424a594f060621e2eca68e883b6511e44","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dnotify"},{"line_number":7,"context_line":"User\u003dwatcher"},{"line_number":8,"context_line":"Group\u003dwatcher"},{"line_number":9,"context_line":"ExecStart\u003d/usr/bin/watcher-decision-engine"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9fb8cfa7_0d1a7a7c","line":6,"updated":"2019-06-05 05:19:45.000000000","message":"does it support SD_NOTIFY?","commit_id":"6410c198f18d5f176a05424f5aee0c0eebfd15f4"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9e7ac55e40a6355fdd39ba80d5f981cffd1e79f0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"},{"line_number":16,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_82b632f9","line":15,"updated":"2019-08-27 04:15:35.000000000","message":"Already in openstack-watcher-api.service","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9a294af94a2d136981290e6ad80db56c5978adcd","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":15,"context_line":"ExecStartPre\u003d-/usr/bin/watcher-db-manage upgrade"},{"line_number":16,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_62ce962e","line":15,"in_reply_to":"7faddb67_82b632f9","updated":"2019-08-27 05:08:17.000000000","message":"Done","commit_id":"f10ed74dab278c8f78e626d96262a61e3ad1e346"}],"openstack/watcher/watcher.spec.j2":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"909157611fe2940211cca37c84edc7a22313c7bb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"BuildRequires:  {{ py2pkg(\u0027stevedore\u0027, py_versions\u003dbuild_py_versions) }}"},{"line_number":73,"context_line":"BuildRequires:  {{ py2pkg(\u0027taskflow\u0027, py_versions\u003dbuild_py_versions) }}"},{"line_number":74,"context_line":"Requires:       python-{{ pypi_name }} \u003d %{epoch}:%{version}-%{release}"},{"line_number":75,"context_line":"Provides:      openstack-watcher-decision-engine \u003d %{epoch}:%{version}-%{release}"},{"line_number":76,"context_line":"Provides:      openstack-watcher-applier \u003d %{epoch}:%{version}-%{release}"},{"line_number":77,"context_line":"Provides:      openstack-watcher-api \u003d %{epoch}:%{version}-%{release}"},{"line_number":78,"context_line":"BuildArch:      noarch"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfb3d3c7_1d2415c6","line":75,"updated":"2019-05-17 16:00:25.000000000","message":"whats the point of this? it shouldn\u0027t provide that, there are subpackages of it already?","commit_id":"9241311d9ebdcf62d43eced7a195414910cf264d"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"909157611fe2940211cca37c84edc7a22313c7bb","unresolved":false,"context_lines":[{"line_number":245,"context_line":"%pre"},{"line_number":246,"context_line":"%openstack_pre_user_group_create watcher watcher /sbin/nologin"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"%post"},{"line_number":249,"context_line":"%systemd_post openstack-watcher-applier.service"},{"line_number":250,"context_line":"%systemd_post openstack-watcher-decision-engine.service"},{"line_number":251,"context_line":"%systemd_post openstack-watcher-api.service"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfb3d3c7_9d30050a","line":248,"updated":"2019-05-17 16:00:25.000000000","message":"this section should be removed, it is already done by the subpackages","commit_id":"9241311d9ebdcf62d43eced7a195414910cf264d"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"909157611fe2940211cca37c84edc7a22313c7bb","unresolved":false,"context_lines":[{"line_number":250,"context_line":"%systemd_post openstack-watcher-decision-engine.service"},{"line_number":251,"context_line":"%systemd_post openstack-watcher-api.service"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"%preun"},{"line_number":254,"context_line":"%systemd_preun openstack-watcher-applier.service"},{"line_number":255,"context_line":"%systemd_preun openstack-watcher-decision-engine.service"},{"line_number":256,"context_line":"%systemd_preun openstack-watcher-api.service"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfb3d3c7_fd55811e","line":253,"updated":"2019-05-17 16:00:25.000000000","message":"this section should be removed, it is already done by the subpackages","commit_id":"9241311d9ebdcf62d43eced7a195414910cf264d"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"909157611fe2940211cca37c84edc7a22313c7bb","unresolved":false,"context_lines":[{"line_number":256,"context_line":"%systemd_preun openstack-watcher-api.service"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"%postun"},{"line_number":259,"context_line":"%systemd_postun_with_restart openstack-watcher-applier.service"},{"line_number":260,"context_line":"%systemd_postun_with_restart openstack-watcher-decision-engine.service"},{"line_number":261,"context_line":"%systemd_postun_with_restart openstack-watcher-api.service"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfb3d3c7_dd58bd57","line":259,"updated":"2019-05-17 16:00:25.000000000","message":"this section should be removed, it is already done by the subpackages","commit_id":"9241311d9ebdcf62d43eced7a195414910cf264d"}]}