)]}'
{"openstack/openstacksdk/openstacksdk.spec.j2":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"31444d27814d007464b21ae141ac445fd77893f5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BuildRequires:  {{ py2pkg(\u0027python-subunit\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":37,"context_line":"BuildRequires:  {{ py2pkg(\u0027requests-mock\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027requestsexceptions\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027setuptools\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":40,"context_line":"BuildRequires:  {{ py2pkg(\u0027six\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":41,"context_line":"BuildRequires:  {{ py2pkg(\u0027statsd\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":42,"context_line":"BuildRequires:  {{ py2pkg(\u0027stestr\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5faad753_7d02690d","line":39,"updated":"2019-09-13 04:36:07.000000000","message":"pbr requires already setuptools (see https://opendev.org/openstack/rpm-packaging/src/branch/master/openstack/pbr/pbr.spec.j2#L16 ). why do we need it here then?","commit_id":"7235fc8348182a462b007bd6fa4948f1f0a1d34f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"fbfd38a8862c5295ebd9900f387f52ac49beffbb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BuildRequires:  {{ py2pkg(\u0027python-subunit\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":37,"context_line":"BuildRequires:  {{ py2pkg(\u0027requests-mock\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027requestsexceptions\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027setuptools\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":40,"context_line":"BuildRequires:  {{ py2pkg(\u0027six\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":41,"context_line":"BuildRequires:  {{ py2pkg(\u0027statsd\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":42,"context_line":"BuildRequires:  {{ py2pkg(\u0027stestr\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_b7e7bce4","line":39,"in_reply_to":"3fa7e38b_7c241dc7","updated":"2019-09-23 12:38:46.000000000","message":"Ah. I thought pbr does require setuptools upstream.","commit_id":"7235fc8348182a462b007bd6fa4948f1f0a1d34f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"ce276f1ed63d6415bbd88cd6653fd120a5d78f1f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BuildRequires:  {{ py2pkg(\u0027python-subunit\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":37,"context_line":"BuildRequires:  {{ py2pkg(\u0027requests-mock\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027requestsexceptions\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027setuptools\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":40,"context_line":"BuildRequires:  {{ py2pkg(\u0027six\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":41,"context_line":"BuildRequires:  {{ py2pkg(\u0027statsd\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":42,"context_line":"BuildRequires:  {{ py2pkg(\u0027stestr\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_7c241dc7","line":39,"in_reply_to":"5faad753_22bb6972","updated":"2019-09-18 08:36:20.000000000","message":"I don\u0027t understand this comment. pbr does not have a hard dependency on setuptools upstream (it is in our packaging though).","commit_id":"7235fc8348182a462b007bd6fa4948f1f0a1d34f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"0ff9e0e14d6099fc434ce96d8667d5c0c99b8895","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BuildRequires:  {{ py2pkg(\u0027python-subunit\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":37,"context_line":"BuildRequires:  {{ py2pkg(\u0027requests-mock\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027requestsexceptions\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027setuptools\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":40,"context_line":"BuildRequires:  {{ py2pkg(\u0027six\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":41,"context_line":"BuildRequires:  {{ py2pkg(\u0027statsd\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":42,"context_line":"BuildRequires:  {{ py2pkg(\u0027stestr\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5faad753_82fb3d45","line":39,"in_reply_to":"5faad753_7d02690d","updated":"2019-09-13 08:50:47.000000000","message":"we don\u0027t need it if it comes via some other dependency already. I prefer explicit over implicit, and with teh similar reason you could argue that we don\"t \"need\" devel because it comes also via some other dependency. \n\nIMHO our packaging should always buildrequire setuptools. we could however also say that we always require pbr and rely on pbr to pull in setuptools. \n\nwhich way would be the way to move forward?","commit_id":"7235fc8348182a462b007bd6fa4948f1f0a1d34f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"5281a181c8de96e4131006e489b1b4dd45a0e31d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"BuildRequires:  {{ py2pkg(\u0027python-subunit\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":37,"context_line":"BuildRequires:  {{ py2pkg(\u0027requests-mock\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":38,"context_line":"BuildRequires:  {{ py2pkg(\u0027requestsexceptions\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":39,"context_line":"BuildRequires:  {{ py2pkg(\u0027setuptools\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":40,"context_line":"BuildRequires:  {{ py2pkg(\u0027six\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":41,"context_line":"BuildRequires:  {{ py2pkg(\u0027statsd\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"},{"line_number":42,"context_line":"BuildRequires:  {{ py2pkg(\u0027stestr\u0027, py_versions\u003d[\u0027py2\u0027, \u0027py3\u0027]) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5faad753_22bb6972","line":39,"in_reply_to":"5faad753_82fb3d45","updated":"2019-09-13 08:53:44.000000000","message":"I would prefer to BuildRequire pbr. That\u0027s what is in requirements.txt/setup.cfg .","commit_id":"7235fc8348182a462b007bd6fa4948f1f0a1d34f"}]}