)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"4bd3ba3958b43955c703071f148c8e804f873589","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  there)"},{"line_number":13,"context_line":"- Fix Requires for openstack-nova-compute package. It was not"},{"line_number":14,"context_line":"  installable on (open)SUSE systems"},{"line_number":15,"context_line":"- Set WorkingDir, Group and PrivateTmp in .service files."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icbab616a65b40252a7c00cfed8e0cfad0d20ac60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_c061a9aa","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":57},"updated":"2019-08-23 15:43:41.000000000","message":"Can you explain why this was needed?","commit_id":"d666bc54cc3d9d062ac94f61655f9dd800be510f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3aef8f898f52891119d5fdff6b151e503e37c993","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  there)"},{"line_number":13,"context_line":"- Fix Requires for openstack-nova-compute package. It was not"},{"line_number":14,"context_line":"  installable on (open)SUSE systems"},{"line_number":15,"context_line":"- Set WorkingDir, Group and PrivateTmp in .service files."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icbab616a65b40252a7c00cfed8e0cfad0d20ac60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_21b42ed1","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":57},"in_reply_to":"7faddb67_c061a9aa","updated":"2019-08-26 09:09:32.000000000","message":"It\u0027s basically copied from what we have in SUSE. I dropped now WorkingDir and Group (for both the defaults are ok imo) and explained a bit why PrivateTmp is useful","commit_id":"d666bc54cc3d9d062ac94f61655f9dd800be510f"}],"openstack/nova/nova.spec.j2":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"6531f0db42e95ce66b9d8d6f324ee19e399cc884","unresolved":false,"context_lines":[{"line_number":696,"context_line":"%license LICENSE"},{"line_number":697,"context_line":"%{_bindir}/nova-compute"},{"line_number":698,"context_line":"%config %{_sysconfdir}/nova/rootwrap.d/compute.filters"},{"line_number":699,"context_line":"%if 0%{?rdo}"},{"line_number":700,"context_line":"%config(noreplace) %{_sysconfdir}/polkit-1/localauthority/50-local.d/50-nova.pkla"},{"line_number":701,"context_line":"%endif"},{"line_number":702,"context_line":"%{_datadir}/polkit-1/rules.d/10-openstack-nova-compute.rules"},{"line_number":703,"context_line":"%{_libexecdir}/modules-load.d/openstack-nova-compute.conf"},{"line_number":704,"context_line":"%{_sysconfdir}/modprobe.d/openstack-nova-compute"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_54c5833c","line":701,"range":{"start_line":699,"start_character":0,"end_line":701,"end_character":6},"updated":"2019-08-23 12:35:18.000000000","message":"This file has been removed from the repo, so we need to delete these lines","commit_id":"980801cad7f98acfdd7d661b0a53d74de97ee6f1"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"6c59c0cee2d4a0ea434ba505140aee79bf16a44a","unresolved":false,"context_lines":[{"line_number":696,"context_line":"%license LICENSE"},{"line_number":697,"context_line":"%{_bindir}/nova-compute"},{"line_number":698,"context_line":"%config %{_sysconfdir}/nova/rootwrap.d/compute.filters"},{"line_number":699,"context_line":"%if 0%{?rdo}"},{"line_number":700,"context_line":"%config(noreplace) %{_sysconfdir}/polkit-1/localauthority/50-local.d/50-nova.pkla"},{"line_number":701,"context_line":"%endif"},{"line_number":702,"context_line":"%{_datadir}/polkit-1/rules.d/10-openstack-nova-compute.rules"},{"line_number":703,"context_line":"%{_libexecdir}/modules-load.d/openstack-nova-compute.conf"},{"line_number":704,"context_line":"%{_sysconfdir}/modprobe.d/openstack-nova-compute"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_548263a7","line":701,"range":{"start_line":699,"start_character":0,"end_line":701,"end_character":6},"in_reply_to":"7faddb67_54c5833c","updated":"2019-08-23 13:01:23.000000000","message":"Done","commit_id":"980801cad7f98acfdd7d661b0a53d74de97ee6f1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"4bd3ba3958b43955c703071f148c8e804f873589","unresolved":false,"context_lines":[{"line_number":522,"context_line":"%if 0%{?rdo}"},{"line_number":523,"context_line":"install -d -m 755 %{buildroot}%{_sysconfdir}/polkit-1/localauthority/50-local.d"},{"line_number":524,"context_line":"install -p -D -m 644 %{SOURCE4} %{buildroot}%{_sysconfdir}/polkit-1/localauthority/50-local.d/50-nova.pkla"},{"line_number":525,"context_line":"%endif"},{"line_number":526,"context_line":"install -D -m 644 %{SOURCE6} %{buildroot}%{_datadir}/polkit-1/rules.d/10-openstack-nova-compute.rules"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"# install modules/modprobe"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_c00689ce","side":"PARENT","line":525,"updated":"2019-08-23 15:43:41.000000000","message":"Why is this not needed anymore?","commit_id":"a61469b6082c0cefe26ba8bce93be5e075db73ab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ec347decc5a76189ebefe1f32ffe478bf362f6de","unresolved":false,"context_lines":[{"line_number":522,"context_line":"%if 0%{?rdo}"},{"line_number":523,"context_line":"install -d -m 755 %{buildroot}%{_sysconfdir}/polkit-1/localauthority/50-local.d"},{"line_number":524,"context_line":"install -p -D -m 644 %{SOURCE4} %{buildroot}%{_sysconfdir}/polkit-1/localauthority/50-local.d/50-nova.pkla"},{"line_number":525,"context_line":"%endif"},{"line_number":526,"context_line":"install -D -m 644 %{SOURCE6} %{buildroot}%{_datadir}/polkit-1/rules.d/10-openstack-nova-compute.rules"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"# install modules/modprobe"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_5e082b90","side":"PARENT","line":525,"in_reply_to":"7faddb67_c00689ce","updated":"2019-08-26 07:45:34.000000000","message":"This was RDO-only so I looked at https://github.com/rdo-packages/nova-distgit/blob/rpm-master/openstack-nova.spec and didn\u0027t found it. So I assumed that it can be removed.\nI think (not 100% sure) that it\u0027s replaced by the polkit-1/rules.d/10-openstack-nova-compute.rules file","commit_id":"a61469b6082c0cefe26ba8bce93be5e075db73ab"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"15e9fdae075b9bd8cbd73143ba880e522e67ebae","unresolved":false,"context_lines":[{"line_number":586,"context_line":"%post"},{"line_number":587,"context_line":"%tmpfiles_create %{_tmpfilesdir}/%{name}.conf"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"%pre compute"},{"line_number":590,"context_line":"usermod -a -G qemu nova"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#POST actions"},{"line_number":593,"context_line":"%post api"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_25476f21","side":"PARENT","line":590,"range":{"start_line":589,"start_character":0,"end_line":590,"end_character":23},"updated":"2019-08-23 14:56:04.000000000","message":"Why are we removing this? Is it no longer necessary?","commit_id":"a61469b6082c0cefe26ba8bce93be5e075db73ab"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"c6058020e804be150ee7228e79b5f290d1477f0f","unresolved":false,"context_lines":[{"line_number":586,"context_line":"%post"},{"line_number":587,"context_line":"%tmpfiles_create %{_tmpfilesdir}/%{name}.conf"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"%pre compute"},{"line_number":590,"context_line":"usermod -a -G qemu nova"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#POST actions"},{"line_number":593,"context_line":"%post api"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_8501836d","side":"PARENT","line":590,"range":{"start_line":589,"start_character":0,"end_line":590,"end_character":23},"in_reply_to":"7faddb67_25476f21","updated":"2019-08-23 15:14:06.000000000","message":"The -compute subpackage dropped the dependency on qemu-kvm. (Which seems to be right, since nova-compute doesn\u0027t really depend on that)\n\nSo I guess this means that the \"qemu\" group might not be present when installing nova-compute.","commit_id":"a61469b6082c0cefe26ba8bce93be5e075db73ab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ec347decc5a76189ebefe1f32ffe478bf362f6de","unresolved":false,"context_lines":[{"line_number":586,"context_line":"%post"},{"line_number":587,"context_line":"%tmpfiles_create %{_tmpfilesdir}/%{name}.conf"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"%pre compute"},{"line_number":590,"context_line":"usermod -a -G qemu nova"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#POST actions"},{"line_number":593,"context_line":"%post api"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_7ef08792","side":"PARENT","line":590,"range":{"start_line":589,"start_character":0,"end_line":590,"end_character":23},"in_reply_to":"7faddb67_8501836d","updated":"2019-08-26 07:45:34.000000000","message":"yes. Ralf\u0027s explanation is correct","commit_id":"a61469b6082c0cefe26ba8bce93be5e075db73ab"}],"openstack/nova/openstack-nova-compute.service":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"4bd3ba3958b43955c703071f148c8e804f873589","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOpenStack Nova Compute Server"},{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":"After\u003drabbitmq-server.service libvirtd.service libvirt-guests.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Environment\u003dLIBGUESTFS_ATTACH_METHOD\u003dappliance"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7faddb67_a0ceedb4","line":4,"updated":"2019-08-23 15:43:41.000000000","message":"The compute service usually isn\u0027t on the same machine as the rabbitmq server service","commit_id":"d666bc54cc3d9d062ac94f61655f9dd800be510f"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3aef8f898f52891119d5fdff6b151e503e37c993","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOpenStack Nova Compute Server"},{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":"After\u003drabbitmq-server.service libvirtd.service libvirt-guests.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Environment\u003dLIBGUESTFS_ATTACH_METHOD\u003dappliance"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7faddb67_a1bfbea8","line":4,"in_reply_to":"7faddb67_a0ceedb4","updated":"2019-08-26 09:09:32.000000000","message":"Done","commit_id":"d666bc54cc3d9d062ac94f61655f9dd800be510f"}],"openstack/nova/openstack-nova-novncproxy.service":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"4bd3ba3958b43955c703071f148c8e804f873589","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Type\u003dsimple"},{"line_number":7,"context_line":"User\u003dnova"},{"line_number":8,"context_line":"EnvironmentFile\u003d-/etc/sysconfig/openstack-nova-novncproxy"},{"line_number":9,"context_line":"ExecStart\u003d/usr/bin/nova-novncproxy --web /usr/share/novnc/ $OPTIONS"},{"line_number":10,"context_line":"Restart\u003don-failure"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[Install]"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7faddb67_2070bd73","side":"PARENT","line":9,"updated":"2019-08-23 15:43:41.000000000","message":"Why were these removed?","commit_id":"a61469b6082c0cefe26ba8bce93be5e075db73ab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3aef8f898f52891119d5fdff6b151e503e37c993","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Type\u003dsimple"},{"line_number":7,"context_line":"User\u003dnova"},{"line_number":8,"context_line":"EnvironmentFile\u003d-/etc/sysconfig/openstack-nova-novncproxy"},{"line_number":9,"context_line":"ExecStart\u003d/usr/bin/nova-novncproxy --web /usr/share/novnc/ $OPTIONS"},{"line_number":10,"context_line":"Restart\u003don-failure"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[Install]"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7faddb67_01fd726d","side":"PARENT","line":9,"in_reply_to":"7faddb67_2070bd73","updated":"2019-08-26 09:09:32.000000000","message":"You can override options with the standard systemd mechanism (placing fies into /etc/systemd/system/openstack-nova-novncproxy.service) . I see no reason to keep the /etc/sysconfig approach","commit_id":"a61469b6082c0cefe26ba8bce93be5e075db73ab"}]}