)]}'
{"openstack/neutron-dynamic-routing/neutron-dynamic-routing.spec.j2":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"021d201930b4a8d8b32331c9d8d5700618fda73c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"BuildRequires:  {{ py3(\u0027Sphinx\u0027) }}"},{"line_number":56,"context_line":"BuildRequires:  {{ py3(\u0027mock\u0027) }}"},{"line_number":57,"context_line":"BuildRequires:  {{ py3(\u0027openstackdocstheme\u0027) }}"},{"line_number":58,"context_line":"BuildRequires:  {{ py3(\u0027sphinxcontrib-rsvgconverter\u0027) }}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"%description doc"},{"line_number":61,"context_line":"Neutron is a virtual network service for Openstack."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3fa7e38b_b34370af","line":58,"updated":"2019-09-20 13:53:14.000000000","message":"this should be\n\nBuildRequires:  {{ py3(\u0027sphinxcontrib-svg2pdfconverter\u0027) }}","commit_id":"f20a578313919a5c33147c6f69aff98ad4d6eec2"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3ff1d324a2f2f7711428be95b477b85dccbace2a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% set upstream_version \u003d upstream_version() %}"},{"line_number":4,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":5,"context_line":"Name:           {{ py2name() }}"},{"line_number":6,"context_line":"Epoch:          {{ epoch(\u0027neutron\u0027) }}"},{"line_number":7,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":8,"context_line":"Release:        {{ py2rpmrelease() }}"},{"line_number":9,"context_line":"Summary:        OpenStack Neutron Dynamic Routing Service"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_97e2c000","line":6,"updated":"2019-09-23 12:36:47.000000000","message":"I don\u0027t think we want to have an epoch here. Also not the one from neutron.","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e7eb174186eee958b382d6c55e014d770349414c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% set upstream_version \u003d upstream_version() %}"},{"line_number":4,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":5,"context_line":"Name:           {{ py2name() }}"},{"line_number":6,"context_line":"Epoch:          {{ epoch(\u0027neutron\u0027) }}"},{"line_number":7,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":8,"context_line":"Release:        {{ py2rpmrelease() }}"},{"line_number":9,"context_line":"Summary:        OpenStack Neutron Dynamic Routing Service"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_3e81d94b","line":6,"in_reply_to":"3fa7e38b_97e2c000","updated":"2019-10-01 14:53:09.000000000","message":"Done","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3ff1d324a2f2f7711428be95b477b85dccbace2a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"%py3_install"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"### configuration files"},{"line_number":82,"context_line":"for x in `ls etc/oslo-config-generator/*`; do"},{"line_number":83,"context_line":"    PYTHONPATH\u003d. oslo-config-generator --config-file $x"},{"line_number":84,"context_line":"done"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_97cba070","line":82,"updated":"2019-09-23 12:36:47.000000000","message":"nit: you could remove the loop given that you only have a single file here...","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e7eb174186eee958b382d6c55e014d770349414c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"%py3_install"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"### configuration files"},{"line_number":82,"context_line":"for x in `ls etc/oslo-config-generator/*`; do"},{"line_number":83,"context_line":"    PYTHONPATH\u003d. oslo-config-generator --config-file $x"},{"line_number":84,"context_line":"done"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_fe92619f","line":82,"in_reply_to":"3fa7e38b_97cba070","updated":"2019-10-01 14:53:09.000000000","message":"Done","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3ff1d324a2f2f7711428be95b477b85dccbace2a","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"install -p -D -m 644 etc/bgp_dragent.ini.sample %{buildroot}%{_sysconfdir}/neutron/bgp_dragent.ini"},{"line_number":87,"context_line":"install -p -D -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/openstack-neutron-bgp-dragent.service"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"%post"},{"line_number":90,"context_line":"%systemd_post openstack-neutron-bgp-dragent.service"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_57c5285a","line":88,"updated":"2019-09-23 12:36:47.000000000","message":"Can you add the rcopenstack.... link in the SUSE case? See other spec files.","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e7eb174186eee958b382d6c55e014d770349414c","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"install -p -D -m 644 etc/bgp_dragent.ini.sample %{buildroot}%{_sysconfdir}/neutron/bgp_dragent.ini"},{"line_number":87,"context_line":"install -p -D -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/openstack-neutron-bgp-dragent.service"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"%post"},{"line_number":90,"context_line":"%systemd_post openstack-neutron-bgp-dragent.service"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_9e8fad74","line":88,"in_reply_to":"3fa7e38b_57c5285a","updated":"2019-10-01 14:53:09.000000000","message":"Done","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3ff1d324a2f2f7711428be95b477b85dccbace2a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"%license LICENSE"},{"line_number":105,"context_line":"%{python3_sitelib}/neutron_dynamic_routing"},{"line_number":106,"context_line":"%{python3_sitelib}/neutron_dynamic_routing-*.egg-info"},{"line_number":107,"context_line":"%{_bindir}/neutron-bgp-dragent"},{"line_number":108,"context_line":"%{_unitdir}/openstack-neutron-bgp-dragent.service"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"%files doc"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_5773e84d","line":107,"updated":"2019-09-23 12:36:47.000000000","message":"Can we add the binary and systemd unit into an extra subpackage like we do for other agents (eg. vpnaas)?","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e7eb174186eee958b382d6c55e014d770349414c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"%license LICENSE"},{"line_number":105,"context_line":"%{python3_sitelib}/neutron_dynamic_routing"},{"line_number":106,"context_line":"%{python3_sitelib}/neutron_dynamic_routing-*.egg-info"},{"line_number":107,"context_line":"%{_bindir}/neutron-bgp-dragent"},{"line_number":108,"context_line":"%{_unitdir}/openstack-neutron-bgp-dragent.service"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"%files doc"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_be8ce97f","line":107,"in_reply_to":"3fa7e38b_5773e84d","updated":"2019-10-01 14:53:09.000000000","message":"Done","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"6e7a87c1f01124da855f0f58c81177ffac2ef313","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"%files bgp-dragent"},{"line_number":117,"context_line":"%license LICENSE"},{"line_number":118,"context_line":"%{_bindir}/openstack-neutron-bgp-dragent"},{"line_number":119,"context_line":"%{_unitdir}/openstack-neutron-bgp-dragent.service"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"%files doc"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"3fa7e38b_01d556b7","line":118,"updated":"2019-10-07 06:58:07.000000000","message":"Failing with:\n\nFile not found: /home/abuild/rpmbuild/BUILDROOT/python-neutron-dynamic-routing-15.1.0~dev1-1.1.x86_64/usr/bin/openstack-neutron-bgp-dragent\n\n\nI guess it\u0027s neutron-bgp-dragent ?","commit_id":"61dfc00a422f7ff58d0b6da836eba2effd402962"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"17e7ef1126325d6239c1414e2987b7701d57ca08","unresolved":false,"context_lines":[{"line_number":52,"context_line":"%package bgp-dragent"},{"line_number":53,"context_line":"Summary:        Neutron Dynamic Routing Agent"},{"line_number":54,"context_line":"Requires:       {{ py2name() }} \u003d %{epoch}:%{version}-%{release}"},{"line_number":55,"context_line":"Provides:       {{ py2name(\u0027neutron\u0027) }}-bgp-dragent \u003d %{epoch}:%{version}-%{release}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"%description bgp-dragent"},{"line_number":58,"context_line":"Provides BGP dynamic routing services for Neutron."}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3fa7e38b_a8ebfe0f","line":55,"updated":"2019-10-07 15:14:57.000000000","message":"Why is that needed? Is there already a user for openstack-neutron-bgp-dragent?","commit_id":"08f25f27986c109a9b6739030f4505aaac833111"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"865d8ed52a068391fee9c5179b2c098b00ee453c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"%package bgp-dragent"},{"line_number":53,"context_line":"Summary:        Neutron Dynamic Routing Agent"},{"line_number":54,"context_line":"Requires:       {{ py2name() }} \u003d %{epoch}:%{version}-%{release}"},{"line_number":55,"context_line":"Provides:       {{ py2name(\u0027neutron\u0027) }}-bgp-dragent \u003d %{epoch}:%{version}-%{release}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"%description bgp-dragent"},{"line_number":58,"context_line":"Provides BGP dynamic routing services for Neutron."}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3fa7e38b_a4547e22","line":55,"in_reply_to":"3fa7e38b_48b5aaed","updated":"2019-10-08 04:07:38.000000000","message":"it\u0027s not strictly needed. but we can keep it.","commit_id":"08f25f27986c109a9b6739030f4505aaac833111"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"8e6d801d3d3920ff1b3bc183ef1acce6dad0d6d4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"%package bgp-dragent"},{"line_number":53,"context_line":"Summary:        Neutron Dynamic Routing Agent"},{"line_number":54,"context_line":"Requires:       {{ py2name() }} \u003d %{epoch}:%{version}-%{release}"},{"line_number":55,"context_line":"Provides:       {{ py2name(\u0027neutron\u0027) }}-bgp-dragent \u003d %{epoch}:%{version}-%{release}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"%description bgp-dragent"},{"line_number":58,"context_line":"Provides BGP dynamic routing services for Neutron."}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3fa7e38b_48b5aaed","line":55,"in_reply_to":"3fa7e38b_a8ebfe0f","updated":"2019-10-07 15:21:12.000000000","message":"I was just seeing this done for other neutron agents. Is \"Provides\" not needed?","commit_id":"08f25f27986c109a9b6739030f4505aaac833111"}],"openstack/neutron-dynamic-routing/openstack-neutron-bgp-dragent.service":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3ff1d324a2f2f7711428be95b477b85dccbace2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOpenStack Neutron BGP Dynamic Routing Agent"},{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dsimple"},{"line_number":7,"context_line":"User\u003dneutron"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3fa7e38b_d7e038fd","line":4,"updated":"2019-09-23 12:36:47.000000000","message":"After\u003dmariadb.service postgresql.service rabbitmq-server.service (assuming it talks to the message bus and needs access to the DB)","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e7eb174186eee958b382d6c55e014d770349414c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOpenStack Neutron BGP Dynamic Routing Agent"},{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dsimple"},{"line_number":7,"context_line":"User\u003dneutron"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3fa7e38b_9e61edd6","line":4,"in_reply_to":"3fa7e38b_d7e038fd","updated":"2019-10-01 14:53:09.000000000","message":"Done","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3ff1d324a2f2f7711428be95b477b85dccbace2a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dsimple"},{"line_number":7,"context_line":"User\u003dneutron"},{"line_number":8,"context_line":"Group\u003dneutron"},{"line_number":9,"context_line":"WorkingDirectory\u003d/var/lib/neutron"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3fa7e38b_f72e9441","line":6,"updated":"2019-09-23 12:36:47.000000000","message":"does it support SD_NOTIFY?","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e7eb174186eee958b382d6c55e014d770349414c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dsyslog.target network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dsimple"},{"line_number":7,"context_line":"User\u003dneutron"},{"line_number":8,"context_line":"Group\u003dneutron"},{"line_number":9,"context_line":"WorkingDirectory\u003d/var/lib/neutron"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3fa7e38b_beb3894d","line":6,"in_reply_to":"3fa7e38b_f72e9441","updated":"2019-10-01 14:53:09.000000000","message":"I\u0027m not sure what needs to be done here. This looks like the other neutron agent services...","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3ff1d324a2f2f7711428be95b477b85dccbace2a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"User\u003dneutron"},{"line_number":8,"context_line":"Group\u003dneutron"},{"line_number":9,"context_line":"WorkingDirectory\u003d/var/lib/neutron"},{"line_number":10,"context_line":"ExecStart\u003d/usr/bin/neutron-bgp-dragent --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/bgp_dragent.ini --log-file /var/log/neutron/bgp-dragent.log"},{"line_number":11,"context_line":"PrivateTmp\u003dfalse"},{"line_number":12,"context_line":"KillMode\u003dprocess"},{"line_number":13,"context_line":"Restart\u003don-failure"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3fa7e38b_3703ccba","line":10,"updated":"2019-09-23 12:36:47.000000000","message":"log-file not needed I think","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e7eb174186eee958b382d6c55e014d770349414c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"User\u003dneutron"},{"line_number":8,"context_line":"Group\u003dneutron"},{"line_number":9,"context_line":"WorkingDirectory\u003d/var/lib/neutron"},{"line_number":10,"context_line":"ExecStart\u003d/usr/bin/neutron-bgp-dragent --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/bgp_dragent.ini --log-file /var/log/neutron/bgp-dragent.log"},{"line_number":11,"context_line":"PrivateTmp\u003dfalse"},{"line_number":12,"context_line":"KillMode\u003dprocess"},{"line_number":13,"context_line":"Restart\u003don-failure"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3fa7e38b_1e7c1d71","line":10,"in_reply_to":"3fa7e38b_3703ccba","updated":"2019-10-01 14:53:09.000000000","message":"Done","commit_id":"73925099c230fcec59747febe1ccfd0427499b94"}]}