)]}'
{"openstack/networking-l2gw-tempest-plugin/networking-l2gw-tempest-plugin.spec.j2":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% set upstream_version \u003d upstream_version() %}"},{"line_number":4,"context_line":"{% set rpm_release \u003d \u00270\u0027 %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"%global sname networking_l2gw_tempest_plugin"},{"line_number":7,"context_line":"%global with_doc 0"},{"line_number":8,"context_line":"%global common_desc \\"},{"line_number":9,"context_line":"This package contains Tempest tests to cover the networking-l2gw project. \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_91689021","line":6,"updated":"2019-09-23 11:56:20.000000000","message":"sname seems to be unused.","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% set rpm_release \u003d \u00270\u0027 %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"%global sname networking_l2gw_tempest_plugin"},{"line_number":7,"context_line":"%global with_doc 0"},{"line_number":8,"context_line":"%global common_desc \\"},{"line_number":9,"context_line":"This package contains Tempest tests to cover the networking-l2gw project. \\"},{"line_number":10,"context_line":"Additionally it provides a plugin to automatically load these tests into Tempest."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_7156345f","line":7,"updated":"2019-09-23 11:56:20.000000000","message":"can you remove the doc package and with_doc ? docs seem to be useless.","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Source0:       {{ source|basename }}"},{"line_number":19,"context_line":"BuildRequires: fdupes"},{"line_number":20,"context_line":"BuildRequires: openstack-macros"},{"line_number":21,"context_line":"BuildRequires: {{ py2pkg(\u0027Tempest\u0027) }}"},{"line_number":22,"context_line":"BuildRequires: {{ py3(\u0027PyMySQL\u0027) }}"},{"line_number":23,"context_line":"BuildRequires: {{ py3(\u0027coverage\u0027) }}"},{"line_number":24,"context_line":"BuildRequires: {{ py3(\u0027ddt\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_71db94ec","line":21,"updated":"2019-09-23 11:56:20.000000000","message":"lower case tempest.","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":20,"context_line":"BuildRequires: openstack-macros"},{"line_number":21,"context_line":"BuildRequires: {{ py2pkg(\u0027Tempest\u0027) }}"},{"line_number":22,"context_line":"BuildRequires: {{ py3(\u0027PyMySQL\u0027) }}"},{"line_number":23,"context_line":"BuildRequires: {{ py3(\u0027coverage\u0027) }}"},{"line_number":24,"context_line":"BuildRequires: {{ py3(\u0027ddt\u0027) }}"},{"line_number":25,"context_line":"BuildRequires: {{ py3(\u0027mock\u0027) }}"},{"line_number":26,"context_line":"BuildRequires: {{ py3(\u0027oslotest\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_91d650c3","line":23,"updated":"2019-09-23 11:56:20.000000000","message":"no coverage please","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":32,"context_line":"BuildRequires: {{ py3(\u0027testresources\u0027) }}"},{"line_number":33,"context_line":"BuildRequires: {{ py3(\u0027testscenarios\u0027) }}"},{"line_number":34,"context_line":"BuildRequires: {{ py3(\u0027testtools\u0027) }}"},{"line_number":35,"context_line":"Requires:      {{ py3(\u0027babel\u0027) }}"},{"line_number":36,"context_line":"Requires:      {{ py3(\u0027neutron-lib\u0027) }}"},{"line_number":37,"context_line":"Requires:      {{ py3(\u0027neutronclient\u0027) }}"},{"line_number":38,"context_line":"Requires:      {{ py3(\u0027ovsdbapp\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_11f4a05a","line":35,"updated":"2019-09-23 11:56:20.000000000","message":"Babel, not babel","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":34,"context_line":"BuildRequires: {{ py3(\u0027testtools\u0027) }}"},{"line_number":35,"context_line":"Requires:      {{ py3(\u0027babel\u0027) }}"},{"line_number":36,"context_line":"Requires:      {{ py3(\u0027neutron-lib\u0027) }}"},{"line_number":37,"context_line":"Requires:      {{ py3(\u0027neutronclient\u0027) }}"},{"line_number":38,"context_line":"Requires:      {{ py3(\u0027ovsdbapp\u0027) }}"},{"line_number":39,"context_line":"Requires:      {{ py3(\u0027pbr\u0027) }}"},{"line_number":40,"context_line":"BuildArch:     noarch"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_31fe7c37","line":37,"updated":"2019-09-23 11:56:20.000000000","message":"python-neutronclient, not neutronclient","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":54,"context_line":"%endif"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"%prep"},{"line_number":57,"context_line":"%autosetup -n {{ pypi_name }}-{{ upstream_version }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# Let\u0027s handle dependencies ourseleves"},{"line_number":60,"context_line":"%py_req_cleanup"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_718954c8","line":57,"updated":"2019-09-23 11:56:20.000000000","message":"-p1","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# Let\u0027s handle dependencies ourseleves"},{"line_number":60,"context_line":"%py_req_cleanup"},{"line_number":61,"context_line":"# Remove bundled egg-info"},{"line_number":62,"context_line":"rm -rf %{module}.egg-info"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"%build"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_71b2b496","line":61,"updated":"2019-09-23 11:56:20.000000000","message":"not needed. done by %py_req_cleanup","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f42ce4f62709462cef53ddc03583984a3ffdbd43","unresolved":false,"context_lines":[{"line_number":74,"context_line":"%install"},{"line_number":75,"context_line":"%{py3_install}"},{"line_number":76,"context_line":"%fdupes %{buildroot}%{python3_sitelib}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"%files"},{"line_number":79,"context_line":"%license LICENSE"},{"line_number":80,"context_line":"%doc README.rst"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_517c58b4","line":77,"updated":"2019-09-23 11:56:20.000000000","message":"Can you add a %check section and run the unittests if there are any?","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"c7de098ce091e3e915771050e6acdfac75f3322c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"%install"},{"line_number":75,"context_line":"%{py3_install}"},{"line_number":76,"context_line":"%fdupes %{buildroot}%{python3_sitelib}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"%files"},{"line_number":79,"context_line":"%license LICENSE"},{"line_number":80,"context_line":"%doc README.rst"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_a2dd3943","line":77,"in_reply_to":"3fa7e38b_1fca666c","updated":"2019-09-23 15:30:47.000000000","message":"ok. then you can remove all the BuildRequires that are not needed. I guess mock, oslotest, test*, python-subunit, ...","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"51ac41e7a23f7e5e50551fd95ffdf98b4b894874","unresolved":false,"context_lines":[{"line_number":74,"context_line":"%install"},{"line_number":75,"context_line":"%{py3_install}"},{"line_number":76,"context_line":"%fdupes %{buildroot}%{python3_sitelib}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"%files"},{"line_number":79,"context_line":"%license LICENSE"},{"line_number":80,"context_line":"%doc README.rst"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_1fca666c","line":77,"in_reply_to":"3fa7e38b_517c58b4","updated":"2019-09-23 15:09:28.000000000","message":"There is no networking_l2gw_tempest_plugin/tests/unit/ directory in networking-l2gw-tempest-plugin repo. So no unit tests even though thests is a py27 tox entry in tox.ini.  Furthermore, none of the *-tempest-plugin packages have %check sections.","commit_id":"36757c6f97242b98f7ad785105cf4d6f3a3eeb42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"c13836b330aa075eadef4a1c89f93345529a0978","unresolved":false,"context_lines":[{"line_number":17,"context_line":"BuildRequires: fdupes"},{"line_number":18,"context_line":"BuildRequires: openstack-macros"},{"line_number":19,"context_line":"BuildRequires: {{ py3(\u0027pbr\u0027) }}"},{"line_number":20,"context_line":"Requires:      {{ py3(\u0027Babel\u0027) }}"},{"line_number":21,"context_line":"Requires:      {{ py3(\u0027neutron-lib\u0027) }}"},{"line_number":22,"context_line":"Requires:      {{ py3(\u0027python-neutronclient\u0027) }}"},{"line_number":23,"context_line":"Requires:      {{ py3(\u0027ovsdbapp\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3fa7e38b_ab2aadd7","line":20,"updated":"2019-09-26 17:51:49.000000000","message":"Doesn\u0027t it require tempest itself?","commit_id":"737420e793e1808067f0eb93022dd698b547ba71"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"003ba99a9f45a46c27bf9ca83302c170d3bbf29f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"BuildRequires: fdupes"},{"line_number":18,"context_line":"BuildRequires: openstack-macros"},{"line_number":19,"context_line":"BuildRequires: {{ py3(\u0027pbr\u0027) }}"},{"line_number":20,"context_line":"Requires:      {{ py3(\u0027Babel\u0027) }}"},{"line_number":21,"context_line":"Requires:      {{ py3(\u0027neutron-lib\u0027) }}"},{"line_number":22,"context_line":"Requires:      {{ py3(\u0027python-neutronclient\u0027) }}"},{"line_number":23,"context_line":"Requires:      {{ py3(\u0027ovsdbapp\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3fa7e38b_2b66bd2b","line":20,"in_reply_to":"3fa7e38b_6b4ef5c1","updated":"2019-09-26 17:59:19.000000000","message":"Nevermind, I will add it. Tempest is found in other *-tempest-plugin packages.","commit_id":"737420e793e1808067f0eb93022dd698b547ba71"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"8f9f1a19f346be49e282a0de4b8b4819fd47b43f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"BuildRequires: fdupes"},{"line_number":18,"context_line":"BuildRequires: openstack-macros"},{"line_number":19,"context_line":"BuildRequires: {{ py3(\u0027pbr\u0027) }}"},{"line_number":20,"context_line":"Requires:      {{ py3(\u0027Babel\u0027) }}"},{"line_number":21,"context_line":"Requires:      {{ py3(\u0027neutron-lib\u0027) }}"},{"line_number":22,"context_line":"Requires:      {{ py3(\u0027python-neutronclient\u0027) }}"},{"line_number":23,"context_line":"Requires:      {{ py3(\u0027ovsdbapp\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3fa7e38b_6b4ef5c1","line":20,"in_reply_to":"3fa7e38b_ab2aadd7","updated":"2019-09-26 17:54:45.000000000","message":"I didn\u0027t include tempest  because it is not in requirements.txt.","commit_id":"737420e793e1808067f0eb93022dd698b547ba71"}]}