)]}'
{"openstack/python-openstackclient/python-openstackclient.spec.j2":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"9270cd3475db527e1251922f03e91a113a78048b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"%{python_install}"},{"line_number":104,"context_line":"# man page"},{"line_number":105,"context_line":"install -p -D -m 644 doc/build/man/openstack.1 %{buildroot}%{_mandir}/man1/openstack.1"},{"line_number":106,"context_line":"%python_clone -a %{buildroot}%{_bindir}/openstack"},{"line_number":107,"context_line":"%python_clone -a %{buildroot}%{_mandir}/man1/openstack.1"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"%post"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_7894f7e7","side":"PARENT","line":106,"updated":"2019-12-03 09:33:27.000000000","message":"so now we\u0027r ein a chicken and egg situation - the individual service clients still require py2+py3 packages, however with the removal of the update-alternatives we\u0027re causing a fileconflict between \"old py2 openstackclient\" and \"new py3 only openstackclient\". \n\ncan we maybe postpone the removal of the update alternatives? then we should be able to merge this incrementally.","commit_id":"8925204a83d7bf4fd3676a5effe6732b8fe8119a"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"7958a600664b65c367b3b52acd52d68c1a0938d4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"%{python_install}"},{"line_number":104,"context_line":"# man page"},{"line_number":105,"context_line":"install -p -D -m 644 doc/build/man/openstack.1 %{buildroot}%{_mandir}/man1/openstack.1"},{"line_number":106,"context_line":"%python_clone -a %{buildroot}%{_bindir}/openstack"},{"line_number":107,"context_line":"%python_clone -a %{buildroot}%{_mandir}/man1/openstack.1"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"%post"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_0521dbb5","side":"PARENT","line":106,"in_reply_to":"3fa7e38b_7894f7e7","updated":"2019-12-03 11:43:54.000000000","message":"So you\u0027re basically proposing to keep the %python_clone and %python_*alternative parts? I\u0027m fine with it, we can always prepare a follow-up patch removing all that.","commit_id":"8925204a83d7bf4fd3676a5effe6732b8fe8119a"},{"author":{"_account_id":22595,"name":"Stefan Nica","email":"snica@suse.com","username":"stefan.nica"},"change_message_id":"6e38616006fe54ffff14a6def96039b2b53feddd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"It is a thin wrapper to the stock python-*client modules that implement the"},{"line_number":39,"context_line":"actual REST API client actions."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"%package -n python3-openstackclient"},{"line_number":42,"context_line":"Summary:        OpenStack Command-line Client"},{"line_number":43,"context_line":"Requires:       {{ py3(\u0027Babel\u0027) }}"},{"line_number":44,"context_line":"Requires:       {{ py3(\u0027python-cinderclient\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3fa7e38b_9bc918ac","line":41,"updated":"2019-12-12 18:57:48.000000000","message":"Same question here as for the barbican-client package: why do you need two separate packages, python-openstackclient and python3-openstackclient ?","commit_id":"d86ccb5d09fe76f732a4dd2eae9565b2f52ebfb9"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"966498c7abff368d0c03b6fce67e88758c9f3600","unresolved":false,"context_lines":[{"line_number":38,"context_line":"It is a thin wrapper to the stock python-*client modules that implement the"},{"line_number":39,"context_line":"actual REST API client actions."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"%package -n python3-openstackclient"},{"line_number":42,"context_line":"Summary:        OpenStack Command-line Client"},{"line_number":43,"context_line":"Requires:       {{ py3(\u0027Babel\u0027) }}"},{"line_number":44,"context_line":"Requires:       {{ py3(\u0027python-cinderclient\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3fa7e38b_211b0e1c","line":41,"in_reply_to":"3fa7e38b_9bc918ac","updated":"2019-12-13 09:14:26.000000000","message":"Actually, if you check the generated artifacts, there is no python-openstackclient binary rpm, only python3-openstackclient.\n\nThe reason to keep python-openstackclient as the \"base\" name in the spec is to keep consistency with the Python packaging. \n\nAll packages are named after their PyPi name, python-openstackclient in this case. To distinguish Python 3 modules from Python 2 ones (which used to carry the python-* names), they are always named python3-*.\n\nIf we created a python3-openstackclient.spec, we\u0027d be breaking the same name rule, and if we just deployed python3 bits using python-openstackclient as the name, we\u0027d be creating a lot of confusion, since it would not be clear which python version is targeted.","commit_id":"d86ccb5d09fe76f732a4dd2eae9565b2f52ebfb9"}]}
