)]}'
{"openstack/ironic-inspector/ironic-inspector.spec.j2":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"a7bb38bd549d15dc06fa002833a0250099b5e120","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Ironic Inspector is an auxiliary service for discovering hardware properties"},{"line_number":78,"context_line":"for a node managed by OpenStack Ironic. Hardware introspection or hardware"},{"line_number":79,"context_line":"properties discovery is a process of getting hardware parameters required for"},{"line_number":80,"context_line":"scheduling from a bare metal node, given it’s power management credentials"},{"line_number":81,"context_line":"(e.g. IPMI address, user name and password)."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"This package contains Python modules and an ironic-inspector service combining"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_bbc8f81f","line":80,"range":{"start_line":80,"start_character":43,"end_line":80,"end_character":44},"updated":"2020-01-21 14:58:45.000000000","message":"Let\u0027s remove this.","commit_id":"aa09b9d3f94d2dffd4d1d0b42a50424831084e77"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ade8ff754045b5bfbd1b231a8dc898114685c1eb","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Ironic Inspector is an auxiliary service for discovering hardware properties"},{"line_number":78,"context_line":"for a node managed by OpenStack Ironic. Hardware introspection or hardware"},{"line_number":79,"context_line":"properties discovery is a process of getting hardware parameters required for"},{"line_number":80,"context_line":"scheduling from a bare metal node, given it’s power management credentials"},{"line_number":81,"context_line":"(e.g. IPMI address, user name and password)."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"This package contains Python modules and an ironic-inspector service combining"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_be19c676","line":80,"range":{"start_line":80,"start_character":43,"end_line":80,"end_character":44},"in_reply_to":"3fa7e38b_bbc8f81f","updated":"2020-01-21 15:09:41.000000000","message":"yeah, I think I put the latest-1 version up, since the last description is correct! :D","commit_id":"aa09b9d3f94d2dffd4d1d0b42a50424831084e77"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"a7bb38bd549d15dc06fa002833a0250099b5e120","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Ironic Inspector is an auxiliary service for discovering hardware properties"},{"line_number":128,"context_line":"for a node managed by OpenStack Ironic. Hardware introspection or hardware"},{"line_number":129,"context_line":"properties discovery is a process of getting hardware parameters required for"},{"line_number":130,"context_line":"scheduling from a bare metal node, given it’s power management credentials"},{"line_number":131,"context_line":"(e.g. IPMI address, user name and password)."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"This package contains Python modules and an ironic-inspector service combining"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_bb53186e","line":130,"range":{"start_line":130,"start_character":43,"end_line":130,"end_character":44},"updated":"2020-01-21 14:58:45.000000000","message":"I think renderspec doesn\u0027t like this apostrophe (plus, I think it\u0027s a typo)","commit_id":"aa09b9d3f94d2dffd4d1d0b42a50424831084e77"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"a7bb38bd549d15dc06fa002833a0250099b5e120","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Ironic Inspector is an auxiliary service for discovering hardware properties"},{"line_number":155,"context_line":"for a node managed by OpenStack Ironic. Hardware introspection or hardware"},{"line_number":156,"context_line":"properties discovery is a process of getting hardware parameters required for"},{"line_number":157,"context_line":"scheduling from a bare metal node, given it’s power management credentials"},{"line_number":158,"context_line":"(e.g. IPMI address, user name and password)."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"This package contains a dnsmasq service pre-configured for using with"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_db58548a","line":157,"range":{"start_line":157,"start_character":43,"end_line":157,"end_character":44},"updated":"2020-01-21 14:58:45.000000000","message":"Same here","commit_id":"aa09b9d3f94d2dffd4d1d0b42a50424831084e77"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"a7bb38bd549d15dc06fa002833a0250099b5e120","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Ironic Inspector is an auxiliary service for discovering hardware properties"},{"line_number":169,"context_line":"for a node managed by OpenStack Ironic. Hardware introspection or hardware"},{"line_number":170,"context_line":"properties discovery is a process of getting hardware parameters required for"},{"line_number":171,"context_line":"scheduling from a bare metal node, given its power management credentials"},{"line_number":172,"context_line":"(e.g. IPMI address, user name and password)."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"This package contains an ironic-inspector conductor service, which can be used"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_9b4e5cc0","line":171,"range":{"start_line":171,"start_character":41,"end_line":171,"end_character":44},"updated":"2020-01-21 14:58:45.000000000","message":"And it is correct here :)","commit_id":"aa09b9d3f94d2dffd4d1d0b42a50424831084e77"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"00ed23bd249b72cba89c5006cf3e452bc1a04b9d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Requires:     {{ py3(\u0027automaton\u0027) }}"},{"line_number":94,"context_line":"Requires:     {{ py3(\u0027construct\u0027) }}"},{"line_number":95,"context_line":"Requires:     {{ py3(\u0027eventlet\u0027) }}"},{"line_number":96,"context_line":"Requires:     {{ py3(\u0027flask\u0027) }}"},{"line_number":97,"context_line":"Requires:     {{ py3(\u0027futurist\u0027) }}"},{"line_number":98,"context_line":"Requires:     {{ py3(\u0027ironic-lib\u0027) }}"},{"line_number":99,"context_line":"Requires:     {{ py3(\u0027python-ironicclient\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3fa7e38b_aa8d0036","line":96,"range":{"start_line":96,"start_character":22,"end_line":96,"end_character":27},"updated":"2020-01-21 18:33:57.000000000","message":"The PyPi name is Flask, let\u0027s use that or the SUSE CI will complain.","commit_id":"3daf06c71eb2ae0203186d43d67a011109c46ad6"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"00ed23bd249b72cba89c5006cf3e452bc1a04b9d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Group:      Documentation/HTML"},{"line_number":140,"context_line":"BuildRequires:  {{ py3(\u0027Sphinx\u0027) }}"},{"line_number":141,"context_line":"BuildRequires:  {{ py3(\u0027openstackdocstheme\u0027) }}"},{"line_number":142,"context_line":"BuildRequires:  {{ py3(\u0027sphinxcontrib-rsvgconverter\u0027) }}"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"%description doc"},{"line_number":145,"context_line":"Documentation for Ironic Inspector."}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3fa7e38b_6abe28cf","line":142,"range":{"start_line":142,"start_character":24,"end_line":142,"end_character":51},"updated":"2020-01-21 18:33:57.000000000","message":"We should use sphinxcontrib-svg2pdfconverter here, instead. That\u0027s the pypi name","commit_id":"3daf06c71eb2ae0203186d43d67a011109c46ad6"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"38d4dba981b5b24fe67ef288243afbf577a788dc","unresolved":false,"context_lines":[{"line_number":289,"context_line":"%dir %{_sysconfdir}/ironic-inspector"},{"line_number":290,"context_line":"%config(noreplace) %{_sysconfdir}/logrotate.d/openstack-ironic-inspector"},{"line_number":291,"context_line":"%config(noreplace) %{_sysconfdir}/sudoers.d/openstack-ironic-inspector"},{"line_number":292,"context_line":"%config(noreplace) %attr(0640, root, ironic-inspector) %{_sysconfdir}/ironic-inspector"},{"line_number":293,"context_line":"%config %{_sysconfdir}/ironic-inspector/rootwrap.conf"},{"line_number":294,"context_line":"%dir %{_sysconfdir}/ironic-inspector/rootwrap.d"},{"line_number":295,"context_line":"%config(noreplace) %{_sysconfdir}/ironic-inspector/rootwrap.d/ironic-inspector.filters"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3fa7e38b_a1e51709","line":292,"range":{"start_line":292,"start_character":0,"end_line":292,"end_character":86},"updated":"2020-01-22 13:32:03.000000000","message":"This is creating the conflict with line 289. Is it ironic-inspector/ironic-inspector.conf ?","commit_id":"8b86f5a5ef54d250044f9b436b489d44e5db6dc3"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"de9e4d550895270f077ca9cb320fa0af560b7e37","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"%files -n python3-ironic-inspector"},{"line_number":305,"context_line":"%license LICENSE"},{"line_number":306,"context_line":"%{python3_sitelib}/ironic-inspector/"},{"line_number":307,"context_line":"%{python3_sitelib}/ironic-inspector*.egg-info"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"%files doc"},{"line_number":310,"context_line":"%license LICENSE"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"3fa7e38b_a17517cb","line":307,"range":{"start_line":306,"start_character":0,"end_line":307,"end_character":45},"updated":"2020-01-22 13:59:04.000000000","message":"Aaaand this could be the last issue :). The directory name under site-packages is \"ironic_inspector\", it seems.","commit_id":"d505cb8ce3d1b383dc71ec1624448118153d9e07"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"9b1a1906878db8a3696f4b4d374da2a308ac809d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"%{python3_sitelib}/ironic_inspector/"},{"line_number":308,"context_line":"%{python3_sitelib}/ironic_inspector*.egg-info"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"%files doc"},{"line_number":311,"context_line":"%license LICENSE"},{"line_number":312,"context_line":"%doc doc/build/html"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"%files dnsmasq"},{"line_number":315,"context_line":"%license LICENSE"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3fa7e38b_5824515f","line":312,"range":{"start_line":310,"start_character":0,"end_line":312,"end_character":19},"updated":"2020-01-22 16:55:19.000000000","message":"This should be included in an %if 0%{?with_doc} clause, but we can add that as a follow-up patch.","commit_id":"042ef555f8e648f33e9b46ba673aa5edb1adcea8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"%if 0%{?with_doc}"},{"line_number":137,"context_line":"%package doc"},{"line_number":138,"context_line":"Summary:    Documentation for Ironic Inspector."},{"line_number":139,"context_line":"Group:      Documentation/HTML"},{"line_number":140,"context_line":"BuildRequires:  {{ py3(\u0027Sphinx\u0027) }}"},{"line_number":141,"context_line":"BuildRequires:  {{ py3(\u0027openstackdocstheme\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"3fa7e38b_5bd3ce36","line":138,"updated":"2020-02-12 04:51:00.000000000","message":"can you remove the dot at the end to make rpmlint happy?","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":161,"context_line":"ironic-inspector."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"%package -n openstack-ironic-inspector-conductor"},{"line_number":164,"context_line":"Summary:    Conductor service for Ironic Inspector."},{"line_number":165,"context_line":"Requires:   openstack-{{ pypi_name }} \u003d %{epoch}:%{version}-%{release}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"%description -n openstack-ironic-inspector-conductor"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"3fa7e38b_7bd80a50","line":164,"updated":"2020-02-12 04:51:00.000000000","message":"can you remove the dot at the end to make rpmlint happy?","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":175,"context_line":"to split ironic-inspector into API and conductor processes."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"%package -n openstack-ironic-inspector-api"},{"line_number":178,"context_line":"Summary:    WSGI service service for Ironic Inspector."},{"line_number":179,"context_line":"Requires:   openstack-{{ pypi_name }} \u003d %{epoch}:%{version}-%{release}"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"%description -n openstack-ironic-inspector-api"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"3fa7e38b_1be1d6fd","line":178,"updated":"2020-02-12 04:51:00.000000000","message":"can you remove the dot at the end to make rpmlint happy?","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":237,"context_line":"%if 0%{?suse_version}"},{"line_number":238,"context_line":"mkdir -p %{buildroot}%{_sbindir}"},{"line_number":239,"context_line":"ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-api"},{"line_number":240,"context_line":"ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rc%{name}-conductor"},{"line_number":241,"context_line":"%endif"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"### man pages"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"3fa7e38b_3bde123c","line":240,"updated":"2020-02-12 04:51:00.000000000","message":"Can you also add the rclink for dnsmasq service please?","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"}],"openstack/ironic-inspector/openstack-ironic-inspector-conductor.service":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dHardware introspection service for OpenStack Ironic - Conductor"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"ExecStart\u003d/usr/bin/ironic-inspector-conductor --config-file /etc/ironic-inspector/ironic-inspector.conf"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_7bb1eaff","line":3,"updated":"2020-02-12 04:51:00.000000000","message":"After\u003dsyslog.target network.target\n\nas we do in other service files","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"ExecStart\u003d/usr/bin/ironic-inspector-conductor --config-file /etc/ironic-inspector/ironic-inspector.conf"},{"line_number":7,"context_line":"User\u003dironic-inspector"},{"line_number":8,"context_line":"Restart\u003don-failure"},{"line_number":9,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_bb89a225","line":6,"updated":"2020-02-12 04:51:00.000000000","message":"I think the --config-file should be removed. that\u0027s automatically used","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"}],"openstack/ironic-inspector/openstack-ironic-inspector-dnsmasq.service":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dPXE boot dnsmasq service for Ironic Inspector"},{"line_number":3,"context_line":"After\u003dopenvswitch.service network.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"Type\u003dforking"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_1b78f629","line":3,"updated":"2020-02-12 04:51:00.000000000","message":"syslog.target missing","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"}],"openstack/ironic-inspector/openstack-ironic-inspector.logrotate":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    missingok"},{"line_number":5,"context_line":"    compress"},{"line_number":6,"context_line":"    copytruncate"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_9b89461f","line":7,"updated":"2020-02-12 04:51:00.000000000","message":"can you add \"su ironic-inspector ironic-inspector\" (see other logrotate files)","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"}],"openstack/ironic-inspector/openstack-ironic-inspector.service":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dHardware introspection service for OpenStack Ironic"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"ExecStart\u003d/usr/bin/ironic-inspector --config-file /etc/ironic-inspector/ironic-inspector.conf"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_bb8e8223","line":3,"updated":"2020-02-12 04:51:00.000000000","message":"syslog.target missing","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"097d3fbb8eaa698517b74a387de7e0756c6de787","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"ExecStart\u003d/usr/bin/ironic-inspector --config-file /etc/ironic-inspector/ironic-inspector.conf"},{"line_number":7,"context_line":"User\u003dironic-inspector"},{"line_number":8,"context_line":"Restart\u003don-failure"},{"line_number":9,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_5b8f4e20","line":6,"updated":"2020-02-12 04:51:00.000000000","message":"please drop --config-file","commit_id":"b563303ff4fa63d97c8af9590d312ff704acb604"}]}