)]}'
{"id":"openstack%2Frpm-packaging~726426","triplet_id":"openstack%2Frpm-packaging~stable%2Fstein~Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e","project":"openstack/rpm-packaging","branch":"stable/stein","hashtags":[],"change_id":"Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e","subject":"Lockdown /bin/ip permissions for the monasca-agent","status":"MERGED","created":"2020-05-08 16:04:56.000000000","updated":"2020-05-25 13:21:46.000000000","submitted":"2020-05-25 13:21:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"726426-1590412906837-40f284a4","meta_rev_id":"db5ec72e9bbc5d59cc9172f92006500772740c0b","_number":726426,"virtual_id_number":726426,"owner":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"recommended":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2020-05-18 21:54:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-25 13:21:46.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-05-15 14:34:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"all":[{"value":0,"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-05-18 21:02:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-05-19 13:19:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":2,"date":"2020-05-25 13:15:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"all":[{"value":0,"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":1,"date":"2020-05-25 13:15:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-15 14:34:05.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-18 21:02:01.000000000","updated_by":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"reviewer":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"state":"REVIEWER"},{"updated":"2020-05-18 21:54:45.000000000","updated_by":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-19 13:19:54.000000000","updated_by":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"reviewer":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"state":"REVIEWER"},{"updated":"2020-05-25 13:15:54.000000000","updated_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"reviewer":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"state":"REVIEWER"},{"updated":"2020-05-25 13:21:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"639864a307cd2c8e70fbd0a39fc96929d1c6d5f4","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-05-08 16:04:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"113e8367d8ebe2c2fc00204e316d56bbcb57de13","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-05-08 16:07:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- DLRN-rpmbuild-rpm-packaging-centos https://review.rdoproject.org/zuul/build/e66d360daa134f208907571e53f8dfa7 : POST_FAILURE in 1m 34s","accounts_in_message":[],"_revision_number":1},{"id":"87ae8f65f22902a02399d0866e5f68aaa1838cee","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-08 16:14:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/3759816141374467ae197415893370b2 : SUCCESS in 4m 22s","accounts_in_message":[],"_revision_number":1},{"id":"c678af182c06836e03fa74b32e1f4c2f51a9521e","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-08 16:33:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (rpm-packaging).\n\n- openstack-rpm-packaging-sles15-Stein https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles15-Stein-80b37520de335b84ec611d2931d5cbc8caa5a413 : SUCCESS in 28m 37s","accounts_in_message":[],"_revision_number":1},{"id":"02908298971cc86d56b3e388f7bfac0fb8cbf5dd","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-15 12:37:44.000000000","message":"Patch Set 1: Code-Review-1\n\nplease update with the latest version from master","accounts_in_message":[],"_revision_number":1},{"id":"f593d29cfa11314b40c39f2d36e1b58f0f6668ec","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-05-15 14:31:23.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"108b71b40827821cc322a3d674e65c04d086f530","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-15 14:33:25.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (rpm-packaging).\n\n- openstack-rpm-packaging-sles15-Stein https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles15-Stein-d87fbece01e43508e130d9317b3318018d6a4e76 : FAILURE in 1m 35s","accounts_in_message":[],"_revision_number":2},{"id":"1cf4d4d4ade335b017b353f04bfe6ef3df7128a1","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-05-15 14:34:05.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- DLRN-rpmbuild-rpm-packaging-centos https://review.rdoproject.org/zuul/build/7c00b4e538d54b0b821db69ec599dfbd : POST_FAILURE in 2m 07s","accounts_in_message":[],"_revision_number":2},{"id":"a36d1b5928ad7b1c4c1362958728eb1364cf51e3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-15 14:43:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/66100f03a024406098efd96eedb079bc : SUCCESS in 6m 13s","accounts_in_message":[],"_revision_number":2},{"id":"6080a7f09a68323889b2353ad9926bda559030fb","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-18 21:01:54.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"25a82e53a3d4e8c912ec4fc7d6a77f08e07b8a29","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-18 21:02:01.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ff2bfc5d7aa466944eb7886d1d04ec39cdd9be76","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-05-18 21:04:18.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- DLRN-rpmbuild-rpm-packaging-centos https://review.rdoproject.org/zuul/build/b57706a74bef4d259054f8aa3255bfaf : POST_FAILURE in 1m 35s","accounts_in_message":[],"_revision_number":2},{"id":"72d261cb2c92f8f6f02493fb2221452d5ff573ed","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-18 21:08:09.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/ef66603352514c13a39d64f6e6fbc82e : SUCCESS in 5m 14s","accounts_in_message":[],"_revision_number":2},{"id":"ec6062cd0499e7c072764bb0dcedd5742cd00876","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-18 21:54:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (rpm-packaging).\n\n- openstack-rpm-packaging-sles15-Stein https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles15-Stein-7b78abf3128e62363d7ff26632df419a69fc5c2b : SUCCESS in 52m 31s","accounts_in_message":[],"_revision_number":2},{"id":"e0130e5e2e92ca93ac9566cf5655c9c31120c812","author":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"date":"2020-05-19 13:19:54.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"060c5df978ffdce95bef3f32e8349468fd8d8510","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2020-05-25 13:15:54.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3c284e54eff83772227b1bf218fe6ed54ae401e9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:16:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a4101707ab9430493a754e52b51eeadb97398d77","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:21:46.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"db5ec72e9bbc5d59cc9172f92006500772740c0b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:21:46.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/fe3e0a1a07454f80b40575dc9735a1b5 : SUCCESS in 4m 41s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8148d6d581e4435cc0012010c0071f5186dff1dc","revisions":{"80b37520de335b84ec611d2931d5cbc8caa5a413":{"kind":"REWORK","_number":1,"created":"2020-05-08 16:04:56.000000000","uploader":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"ref":"refs/changes/26/726426/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rpm-packaging","ref":"refs/changes/26/726426/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/1"}}},"commit":{"parents":[{"commit":"640f195b3c66e20f4c8e4b7963f3f9c5cb23e0e6","subject":"Fix sudoers entry used by the monasca-agent checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/640f195b3c66e20f4c8e4b7963f3f9c5cb23e0e6"}]}],"author":{"name":"git","email":"keith.berger@suse.com","date":"2020-05-08 14:43:04.000000000","tz":-240},"committer":{"name":"KeithMnemonic","email":"keith.berger@suse.com","date":"2020-05-08 16:04:53.000000000","tz":-240},"subject":"Lockdown /bin/ip permissions for the monasca-agent","message":"Lockdown /bin/ip permissions for the monasca-agent\n\nThis patch adds addtional arguments to the sudoers entry for\nthe /bin/ip command. It restricts access to only \u0027ip netns exec\u0027.\n\nChange-Id: Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e\n(cherry picked from commit 00077266ae8d70e5d79eb65fdb8081150cbc7842)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/80b37520de335b84ec611d2931d5cbc8caa5a413"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/80b37520de335b84ec611d2931d5cbc8caa5a413"}]},"branch":"refs/heads/stable/stein"},"8148d6d581e4435cc0012010c0071f5186dff1dc":{"kind":"REWORK","_number":2,"created":"2020-05-15 14:31:23.000000000","uploader":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"ref":"refs/changes/26/726426/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rpm-packaging","ref":"refs/changes/26/726426/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rpm-packaging refs/changes/26/726426/2"}}},"commit":{"parents":[{"commit":"640f195b3c66e20f4c8e4b7963f3f9c5cb23e0e6","subject":"Fix sudoers entry used by the monasca-agent checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/640f195b3c66e20f4c8e4b7963f3f9c5cb23e0e6"}]}],"author":{"name":"git","email":"keith.berger@suse.com","date":"2020-05-08 14:43:04.000000000","tz":-240},"committer":{"name":"Keith Berger","email":"keith.berger@suse.com","date":"2020-05-15 14:31:21.000000000","tz":0},"subject":"Lockdown /bin/ip permissions for the monasca-agent","message":"Lockdown /bin/ip permissions for the monasca-agent\n\nThis patch adds addtional arguments to the sudoers entry for\nthe /bin/ip command. It restricts access to only \u0027ip netns exec\u0027.\n\nChange-Id: Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e\n(cherry picked from commit 00077266ae8d70e5d79eb65fdb8081150cbc7842)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/8148d6d581e4435cc0012010c0071f5186dff1dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/8148d6d581e4435cc0012010c0071f5186dff1dc"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
