)]}'
{"id":"openstack%2Frpm-packaging~726428","triplet_id":"openstack%2Frpm-packaging~stable%2Fqueens~Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e","project":"openstack/rpm-packaging","branch":"stable/queens","hashtags":[],"change_id":"Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e","subject":"Lockdown /bin/ip permissions for the monasca-agent","status":"MERGED","created":"2020-05-08 16:05:21.000000000","updated":"2020-05-25 13:21:48.000000000","submitted":"2020-05-25 13:21:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"726428-1590412908647-48d602ed","meta_rev_id":"8795a1a58dfbcbca73614336190da6dcd089ebc6","_number":726428,"virtual_id_number":726428,"owner":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"disliked":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2020-05-15 14:53:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-25 13:21:48.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-05-15 14:34:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"all":[{"value":0,"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-05-18 21:01:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-05-19 13:20:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":2,"date":"2020-05-25 13:16:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"all":[{"value":0,"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":1,"date":"2020-05-25 13:16:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-15 14:34:27.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-15 14:53:29.000000000","updated_by":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-18 21:01:08.000000000","updated_by":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"reviewer":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"state":"REVIEWER"},{"updated":"2020-05-19 13:20:28.000000000","updated_by":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"reviewer":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"state":"REVIEWER"},{"updated":"2020-05-25 13:16:10.000000000","updated_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"reviewer":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"state":"REVIEWER"},{"updated":"2020-05-25 13:21:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"84755b43ef0a624baa51093f369b0a6023eb1d14","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-05-08 16:05:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c0db820b61eac4d83756d53a996842e417cfe327","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-05-08 16:08:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- DLRN-rpmbuild-rpm-packaging-centos https://review.rdoproject.org/zuul/build/e4ca2a9b159e4b03be58c76ee9b84cee : POST_FAILURE in 1m 34s","accounts_in_message":[],"_revision_number":1},{"id":"8b9ef1af953d9ae89e90ef3dbd4ff729f7272b71","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-08 16:19:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/6c555fc6254f4d0ab87f83933cfa9958 : SUCCESS in 8m 49s","accounts_in_message":[],"_revision_number":1},{"id":"1bcf776659d587f82d435db4e435877da5ad0dd4","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-08 16:30:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (rpm-packaging).\n\n- openstack-rpm-packaging-sles12-Queens https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles12-Queens-93ac17f9264c32d09ed9cbf9da291d9899ff6417 : SUCCESS in 24m 31s","accounts_in_message":[],"_revision_number":1},{"id":"1d0ae5104adc9f3571c2d1ea68ed7ed8b1f9ee9e","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-15 12:37:58.000000000","message":"Patch Set 1: Code-Review-1\n\nplease update with the latest version from master","accounts_in_message":[],"_revision_number":1},{"id":"e3fb99ada1ec2c2603c83f1317c0f1a143104e3e","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-05-15 14:32:18.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"55be0c110607170d6945f6623de236bb1f1aae03","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-05-15 14:34:27.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- DLRN-rpmbuild-rpm-packaging-centos https://review.rdoproject.org/zuul/build/f3d4c27cb5974e1faf7e74af97d02f48 : POST_FAILURE in 1m 33s","accounts_in_message":[],"_revision_number":2},{"id":"dd9c6b5000b9c45d17fe96d1d96a4c38034a0ace","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-15 14:43:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/6ad24d90b2dd4f54b58f3c56064f4976 : SUCCESS in 5m 40s","accounts_in_message":[],"_revision_number":2},{"id":"01015386691022d832344ed0b78df32cd9c6f31e","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-15 14:53:29.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (rpm-packaging).\n\n- openstack-rpm-packaging-sles12-Queens https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles12-Queens-b0185726774f9d128190c90fadd6d76b2f16556e : FAILURE in 20m 47s","accounts_in_message":[],"_revision_number":2},{"id":"c8c8b00980b38d4dac98f76b8f316d3e0ee60904","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-18 21:01:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"6fb9694ca518c5cdc306313569e3cd0534760cb5","author":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"date":"2020-05-19 13:20:28.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"af681f5cf13a2f1d0189883402b823076ad914a1","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2020-05-25 13:16:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"dc6f686c48e9bba2e4abda2066f36774401e82dd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:16:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"8e577e9a4fbb3f455b0c63ded2395340b2feeb2e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:21:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/3ea4cf81c4c04749aa95f969715ee277 : SUCCESS in 4m 24s","accounts_in_message":[],"_revision_number":2},{"id":"d39a28bf1ecb465dbfb3c050b7aa6d41b406aa71","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:21:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b0185726774f9d128190c90fadd6d76b2f16556e","revisions":{"93ac17f9264c32d09ed9cbf9da291d9899ff6417":{"kind":"REWORK","_number":1,"created":"2020-05-08 16:05:21.000000000","uploader":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"ref":"refs/changes/28/726428/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rpm-packaging","ref":"refs/changes/28/726428/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/1"}}},"commit":{"parents":[{"commit":"eae9482c6397545ab0dd8fe46f9db3ae9e00e37e","subject":"Fix sudoers entry used by the monasca-agent checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/eae9482c6397545ab0dd8fe46f9db3ae9e00e37e"}]}],"author":{"name":"git","email":"keith.berger@suse.com","date":"2020-05-08 14:43:04.000000000","tz":-240},"committer":{"name":"KeithMnemonic","email":"keith.berger@suse.com","date":"2020-05-08 16:05:17.000000000","tz":-240},"subject":"Lockdown /bin/ip permissions for the monasca-agent","message":"Lockdown /bin/ip permissions for the monasca-agent\n\nThis patch adds addtional arguments to the sudoers entry for\nthe /bin/ip command. It restricts access to only \u0027ip netns exec\u0027.\n\nChange-Id: Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e\n(cherry picked from commit 00077266ae8d70e5d79eb65fdb8081150cbc7842)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/93ac17f9264c32d09ed9cbf9da291d9899ff6417"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/93ac17f9264c32d09ed9cbf9da291d9899ff6417"}]},"branch":"refs/heads/stable/queens"},"b0185726774f9d128190c90fadd6d76b2f16556e":{"kind":"REWORK","_number":2,"created":"2020-05-15 14:32:18.000000000","uploader":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"ref":"refs/changes/28/726428/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rpm-packaging","ref":"refs/changes/28/726428/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rpm-packaging refs/changes/28/726428/2"}}},"commit":{"parents":[{"commit":"eae9482c6397545ab0dd8fe46f9db3ae9e00e37e","subject":"Fix sudoers entry used by the monasca-agent checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/eae9482c6397545ab0dd8fe46f9db3ae9e00e37e"}]}],"author":{"name":"git","email":"keith.berger@suse.com","date":"2020-05-08 14:43:04.000000000","tz":-240},"committer":{"name":"Keith Berger","email":"keith.berger@suse.com","date":"2020-05-15 14:32:14.000000000","tz":0},"subject":"Lockdown /bin/ip permissions for the monasca-agent","message":"Lockdown /bin/ip permissions for the monasca-agent\n\nThis patch adds addtional arguments to the sudoers entry for\nthe /bin/ip command. It restricts access to only \u0027ip netns exec\u0027.\n\nChange-Id: Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e\n(cherry picked from commit 00077266ae8d70e5d79eb65fdb8081150cbc7842)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/b0185726774f9d128190c90fadd6d76b2f16556e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/b0185726774f9d128190c90fadd6d76b2f16556e"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}