)]}'
{"id":"openstack%2Frpm-packaging~726430","triplet_id":"openstack%2Frpm-packaging~stable%2Fpike~Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e","project":"openstack/rpm-packaging","branch":"stable/pike","hashtags":[],"change_id":"Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e","subject":"Lockdown /bin/ip permissions for the monasca-agent","status":"MERGED","created":"2020-05-08 16:05:39.000000000","updated":"2020-05-25 13:22:14.000000000","submitted":"2020-05-25 13:22:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"726430-1590412934492-a134e064","meta_rev_id":"0848e490c1e311a95fe4ac1466413147353b46ae","_number":726430,"virtual_id_number":726430,"owner":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"recommended":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2020-05-18 21:12:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-25 13:22:14.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"value":0,"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"all":[{"value":0,"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-05-18 21:01:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"value":1,"date":"2020-05-19 13:20:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":2,"date":"2020-05-25 13:16:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"all":[{"value":0,"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"value":0,"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"value":1,"date":"2020-05-25 13:16:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-08 16:14:03.000000000","updated_by":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"reviewer":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"state":"REVIEWER"},{"updated":"2020-05-08 16:14:16.000000000","updated_by":{"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},"reviewer":{"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},"state":"REVIEWER"},{"updated":"2020-05-18 21:01:33.000000000","updated_by":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"reviewer":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"state":"REVIEWER"},{"updated":"2020-05-18 21:12:56.000000000","updated_by":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-19 13:20:09.000000000","updated_by":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"reviewer":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"state":"REVIEWER"},{"updated":"2020-05-25 13:16:18.000000000","updated_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"reviewer":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"state":"REVIEWER"},{"updated":"2020-05-25 13:22:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4767d434aca0979c15feb017efb83ce27485146a","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-05-08 16:05:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d331475d34806dfa731b0530da60ce562d368a6c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-08 16:11:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/1663cbef3ab34aa79548db903bb225a3 : SUCCESS in 4m 37s","accounts_in_message":[],"_revision_number":1},{"id":"f87f3d24649e3e481d1ff9ee3f1fd399539a8351","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-08 16:29:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (rpm-packaging).\n\n- openstack-rpm-packaging-sles12-Pike https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles12-Pike-4e21b2bf6e4ceb9a8535bfdd7af716997ab319fe : SUCCESS in 23m 50s","accounts_in_message":[],"_revision_number":1},{"id":"4aaea366701339be8f3a62946753b6ae035ec91c","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-15 12:38:10.000000000","message":"Patch Set 1: Code-Review-1\n\nplease update with the latest version from master","accounts_in_message":[],"_revision_number":1},{"id":"788cda19a8255c71fed8eb129cba6b82c7b7e9e0","author":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"date":"2020-05-15 14:32:40.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"736640fef16021d8ae81667766b0a6f62db7b075","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-15 14:41:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/ff1f8f0ef7ef4c5786e20f6b35b36cae : SUCCESS in 4m 22s","accounts_in_message":[],"_revision_number":2},{"id":"09f8b1a2d9edeb0fc81d0f05b6deadad025ca05f","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-15 14:49:30.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (rpm-packaging).\n\n- openstack-rpm-packaging-sles12-Pike https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles12-Pike-43b9b3d7267479d42865dbdedc1f70ab7883a6e2 : FAILURE in 16m 27s","accounts_in_message":[],"_revision_number":2},{"id":"5545e3a21dfb672f9b966e2c1635fd6af63824af","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-18 21:01:30.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"93f5b2f8cb580fc084d3c572a24b368594ffe1d1","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-05-18 21:01:33.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b0db9e8640e03439147ad0544171b009730695fc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-18 21:10:25.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/c1c6184594e943398df8a4c04eb85486 : SUCCESS in 4m 18s","accounts_in_message":[],"_revision_number":2},{"id":"6a2cee4438c05bb2906959a467fa2952deacfd86","author":{"_account_id":19648,"name":"SUSE Cloud CI","email":"dmueller+suse-cloud-ci@suse.de","username":"suse-ci","tags":["SERVICE_USER"]},"date":"2020-05-18 21:12:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (rpm-packaging).\n\n- openstack-rpm-packaging-sles12-Pike https://build.opensuse.org/project/show/home:suse-cloud-ci:rpm-packaging-sles12-Pike-26cdf6501814c000db120f6d2de9b144f8ec6439 : SUCCESS in 11m 07s","accounts_in_message":[],"_revision_number":2},{"id":"a4433657ad2a400debff91df663cdd04eabbe454","author":{"_account_id":17246,"name":"EB","email":"esampson@suse.com","username":"sampsone"},"date":"2020-05-19 13:20:09.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ac19e590fa34f43a431a9a8776b11c078e6e4985","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2020-05-25 13:16:18.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7195217cc43af16680ddc2c71a2d2c679ead42e7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:16:30.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b4496e3f9bb0e20874e198c1d68ba6b89235f4cb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:22:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"0848e490c1e311a95fe4ac1466413147353b46ae","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-25 13:22:14.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/6be89c06084f4af9bd5d5dcdb58580a4 : SUCCESS in 5m 01s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"92cc4829f1fd08ecffcdd01ab9c76e51541d8ad1","revisions":{"4e21b2bf6e4ceb9a8535bfdd7af716997ab319fe":{"kind":"REWORK","_number":1,"created":"2020-05-08 16:05:39.000000000","uploader":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"ref":"refs/changes/30/726430/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rpm-packaging","ref":"refs/changes/30/726430/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/1"}}},"commit":{"parents":[{"commit":"fdffcc1b6d698d0238868defb19014cfc097cd2f","subject":"Merge \"Fix sudoers entry used by the monasca-agent checks\" into stable/pike","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/fdffcc1b6d698d0238868defb19014cfc097cd2f"}]}],"author":{"name":"git","email":"keith.berger@suse.com","date":"2020-05-08 14:43:04.000000000","tz":-240},"committer":{"name":"KeithMnemonic","email":"keith.berger@suse.com","date":"2020-05-08 16:05:29.000000000","tz":-240},"subject":"Lockdown /bin/ip permissions for the monasca-agent","message":"Lockdown /bin/ip permissions for the monasca-agent\n\nThis patch adds addtional arguments to the sudoers entry for\nthe /bin/ip command. It restricts access to only \u0027ip netns exec\u0027.\n\nChange-Id: Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e\n(cherry picked from commit 00077266ae8d70e5d79eb65fdb8081150cbc7842)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/4e21b2bf6e4ceb9a8535bfdd7af716997ab319fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/4e21b2bf6e4ceb9a8535bfdd7af716997ab319fe"}]},"branch":"refs/heads/stable/pike"},"92cc4829f1fd08ecffcdd01ab9c76e51541d8ad1":{"kind":"REWORK","_number":2,"created":"2020-05-15 14:32:40.000000000","uploader":{"_account_id":14892,"name":"Keith Berger","email":"keith.berger@suse.com","username":"kberger"},"ref":"refs/changes/30/726430/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rpm-packaging","ref":"refs/changes/30/726430/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rpm-packaging refs/changes/30/726430/2"}}},"commit":{"parents":[{"commit":"fdffcc1b6d698d0238868defb19014cfc097cd2f","subject":"Merge \"Fix sudoers entry used by the monasca-agent checks\" into stable/pike","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/fdffcc1b6d698d0238868defb19014cfc097cd2f"}]}],"author":{"name":"git","email":"keith.berger@suse.com","date":"2020-05-08 14:43:04.000000000","tz":-240},"committer":{"name":"Keith Berger","email":"keith.berger@suse.com","date":"2020-05-15 14:32:38.000000000","tz":0},"subject":"Lockdown /bin/ip permissions for the monasca-agent","message":"Lockdown /bin/ip permissions for the monasca-agent\n\nThis patch adds addtional arguments to the sudoers entry for\nthe /bin/ip command. It restricts access to only \u0027ip netns exec\u0027.\n\nChange-Id: Ie80c8fbdc851cbace8c82f8c47f490898f5c4d6e\n(cherry picked from commit 00077266ae8d70e5d79eb65fdb8081150cbc7842)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/92cc4829f1fd08ecffcdd01ab9c76e51541d8ad1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rpm-packaging/commit/92cc4829f1fd08ecffcdd01ab9c76e51541d8ad1"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}