)]}'
{"openstack/validations-libs/validations-libs.spec.j2":[{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"d57f645045134f8fd0fb109698e9d66c1ed0c1d9","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":90,"context_line":"%license LICENSE"},{"line_number":91,"context_line":"%doc README.rst ChangeLog"},{"line_number":92,"context_line":"%{_mandir}/man1/validations-libs.1*"},{"line_number":93,"context_line":"%{python3_sitelib}/validations_libs"},{"line_number":94,"context_line":"%{python3_sitelib}/*.egg-info"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_e224cab4","line":91,"updated":"2020-10-06 15:06:10.000000000","message":"missing here:\n%{_datadir}/ansible","commit_id":"87ad02ee22d96b834ecb4e633efe3ecd3fab433b"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"7a8ac5c0d76670c79d3bd179a1452ef8eb7f52fd","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":90,"context_line":"%license LICENSE"},{"line_number":91,"context_line":"%doc README.rst ChangeLog"},{"line_number":92,"context_line":"%{_mandir}/man1/validations-libs.1*"},{"line_number":93,"context_line":"%{python3_sitelib}/validations_libs"},{"line_number":94,"context_line":"%{python3_sitelib}/*.egg-info"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_62aefa2f","line":91,"in_reply_to":"9f560f44_228082bf","updated":"2020-10-06 16:25:40.000000000","message":"Yes we need this as it\u0027s using in CI and installed with python setup.cfg","commit_id":"87ad02ee22d96b834ecb4e633efe3ecd3fab433b"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"88a8308510615cadefdbfc82d437cda8faf80e9b","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":90,"context_line":"%license LICENSE"},{"line_number":91,"context_line":"%doc README.rst ChangeLog"},{"line_number":92,"context_line":"%{_mandir}/man1/validations-libs.1*"},{"line_number":93,"context_line":"%{python3_sitelib}/validations_libs"},{"line_number":94,"context_line":"%{python3_sitelib}/*.egg-info"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_99c62068","line":91,"in_reply_to":"9f560f44_62aefa2f","updated":"2020-10-06 17:02:36.000000000","message":"Actually I made several tests but this is not installed by setup.cfg since latest tag is 1.0.4. \nIn 1.0.4 setup.py is not managing these roles.\nIt comes with commit : 96a5d4142234effc5cde2145fa5608e51bdee7a9","commit_id":"87ad02ee22d96b834ecb4e633efe3ecd3fab433b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"61775d95af52371e6c33f57848ad9e7230bc161b","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":90,"context_line":"%license LICENSE"},{"line_number":91,"context_line":"%doc README.rst ChangeLog"},{"line_number":92,"context_line":"%{_mandir}/man1/validations-libs.1*"},{"line_number":93,"context_line":"%{python3_sitelib}/validations_libs"},{"line_number":94,"context_line":"%{python3_sitelib}/*.egg-info"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_0cce502c","line":91,"in_reply_to":"9f560f44_99c62068","updated":"2020-10-06 18:40:35.000000000","message":"Agreed these changes aren\u0027t yet released [1][2], so we can ignore this part for now.\n\nHEAD of 1.0.4 is 20b0b65c6d8fca32b700e496589332b2d535290a [2]\n\nIt should be released first to allow us to pull the right version here and then it would allow to us to add this part.\n\n[1] https://opendev.org/openstack/releases/src/branch/master/deliverables/_independent/validations-libs.yaml#L26\n[2] https://opendev.org/openstack/validations-libs/commit/20b0b65c6d8fca32b700e496589332b2d535290a","commit_id":"87ad02ee22d96b834ecb4e633efe3ecd3fab433b"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"d6e76b55f79c3e7be3ac5dd8b52f9e92ff913cfc","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":90,"context_line":"%license LICENSE"},{"line_number":91,"context_line":"%doc README.rst ChangeLog"},{"line_number":92,"context_line":"%{_mandir}/man1/validations-libs.1*"},{"line_number":93,"context_line":"%{python3_sitelib}/validations_libs"},{"line_number":94,"context_line":"%{python3_sitelib}/*.egg-info"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_228082bf","line":91,"in_reply_to":"9f560f44_e224cab4","updated":"2020-10-06 15:27:06.000000000","message":"\u003e missing here:\n \u003e %{_datadir}/ansible\n\nThis have to be installed, what do you expect to have here ? \nthe two roles inside %{_datadir}/ansible/roles ?","commit_id":"87ad02ee22d96b834ecb4e633efe3ecd3fab433b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7f495fae1a3b2d54140cdcbb56a2936a7bb8c466","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#man pages"},{"line_number":90,"context_line":"install -p -D -m 644 doc/build/man/validations-libs.1 \\"},{"line_number":91,"context_line":"                     %{buildroot}%{_mandir}/man1/validations-libs.1"},{"line_number":92,"context_line":"# Temporary install of ansible roles"},{"line_number":93,"context_line":"# will be performed on the next release directly through setup.py"},{"line_number":94,"context_line":"# To be removed"},{"line_number":95,"context_line":"install -p -D -m 755 -d %{buildroot}%{_datadir}/ansible/roles/validations/defaults"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"install -p -D -m 644 roles/validations/defaults/main.yaml \\"},{"line_number":98,"context_line":"                     %{buildroot}%{_datadir}/ansible/roles/validations/defaults/"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"install -p -D -m 755 -d %{buildroot}%{_datadir}/ansible/roles/validations/tasks"},{"line_number":101,"context_line":"install -p -D -m 644 roles/validations/tasks/main.yaml  \\"},{"line_number":102,"context_line":"                     roles/validations/tasks/validations.yaml \\"},{"line_number":103,"context_line":"                     %{buildroot}%{_datadir}/ansible/roles/validations/tasks/"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"install -p -D -m 755 -d %{buildroot}%{_datadir}/ansible/roles/fetch-validations/defaults"},{"line_number":106,"context_line":"install -p -D -m 644 roles/fetch-validations/defaults/main.yaml \\"},{"line_number":107,"context_line":"                     %{buildroot}%{_datadir}/ansible/roles/fetch-validations/defaults/"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"%check"},{"line_number":110,"context_line":"python3 -m stestr.cli run"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"9f560f44_101f7a70","line":107,"range":{"start_line":92,"start_character":0,"end_line":107,"end_character":86},"updated":"2020-10-07 10:32:03.000000000","message":"Well done","commit_id":"9684a234bbb283812be5cabd94c3f9a3b83dc1ea"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"870856f1a4e2bdea5cad6032ea3cf45bd0085010","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":4,"context_line":"{% set source \u003d url_pypi() %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Name:           {{ py2name() }}"},{"line_number":7,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":8,"context_line":"Release:        {{ py2rpmrelease() }}"},{"line_number":9,"context_line":"Epoch:          {{ epoch(\u0027validations-libs\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_5bbc73b4","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"updated":"2020-10-07 11:22:40.000000000","message":"Why do all these command called py2 ? is there a py3 version of them to use or is it a \"python to name\" ?","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1649038f37c9619bb1f7d6f7dab69cd197934452","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":4,"context_line":"{% set source \u003d url_pypi() %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Name:           {{ py2name() }}"},{"line_number":7,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":8,"context_line":"Release:        {{ py2rpmrelease() }}"},{"line_number":9,"context_line":"Epoch:          {{ epoch(\u0027validations-libs\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_bb766f0b","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"in_reply_to":"9f560f44_5bbc73b4","updated":"2020-10-07 11:32:33.000000000","message":"I think that `python to name` is behind the name of this function","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"b3785bba356399ef5f6eb1e6b384406492e5a708","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% set rpm_release \u003d \u00271\u0027 %}"},{"line_number":4,"context_line":"{% set source \u003d url_pypi() %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Name:           {{ py2name() }}"},{"line_number":7,"context_line":"Version:        {{ py2rpmversion() }}"},{"line_number":8,"context_line":"Release:        {{ py2rpmrelease() }}"},{"line_number":9,"context_line":"Epoch:          {{ epoch(\u0027validations-libs\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_5b2593be","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"in_reply_to":"9f560f44_bb766f0b","updated":"2020-10-07 11:54:42.000000000","message":"I find it super confusing... \n\nShould be better to have pyname, pyrpmversion, pyrpmrelease instead","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"870856f1a4e2bdea5cad6032ea3cf45bd0085010","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This is a collection of python libraries for the Validation Framework."},{"line_number":64,"context_line":"This package contains auto-generated documentation."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"%package -n ansible-role-{{ py2name() }}"},{"line_number":67,"context_line":"Summary:        Ansible role for the Validation Framework."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"%description -n ansible-role-{{ py2name() }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_5b95933c","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":40},"updated":"2020-10-07 11:22:40.000000000","message":"should I use this name here : ansible-role-{{ py2name() }}\nwhich is extended to ansible-role-python-validations-libs or  directly ansible-role-%{pypi_name} (to use the variable set) or ansible-role-validations-libs ?","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1649038f37c9619bb1f7d6f7dab69cd197934452","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This is a collection of python libraries for the Validation Framework."},{"line_number":64,"context_line":"This package contains auto-generated documentation."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"%package -n ansible-role-{{ py2name() }}"},{"line_number":67,"context_line":"Summary:        Ansible role for the Validation Framework."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"%description -n ansible-role-{{ py2name() }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_fb558753","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":40},"in_reply_to":"9f560f44_5b95933c","updated":"2020-10-07 11:32:33.000000000","message":"I think we need:\n\n```\n%package -n ansible-role-{{ py2name() }}-\n```\n\nc.f ./openstack/metalsmith/metalsmith.spec.j2","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c3163a90ce7785d36c4ba8f98f94c7c5d67da887","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This is a collection of python libraries for the Validation Framework."},{"line_number":64,"context_line":"This package contains auto-generated documentation."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"%package -n ansible-role-{{ py2name() }}"},{"line_number":67,"context_line":"Summary:        Ansible role for the Validation Framework."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"%description -n ansible-role-{{ py2name() }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_5b4633a9","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":40},"in_reply_to":"9f560f44_fb558753","updated":"2020-10-07 11:33:45.000000000","message":"Errata:\n\n%package -n ansible-role-{{ py2name() }}","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"870856f1a4e2bdea5cad6032ea3cf45bd0085010","unresolved":false,"context_lines":[{"line_number":109,"context_line":"%check"},{"line_number":110,"context_line":"python3 -m stestr.cli run"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":113,"context_line":"%license LICENSE"},{"line_number":114,"context_line":"%doc README.rst ChangeLog"},{"line_number":115,"context_line":"%{_datadir}/ansible"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_1bcafb6c","line":112,"range":{"start_line":112,"start_character":10,"end_line":112,"end_character":42},"updated":"2020-10-07 11:22:40.000000000","message":"Should we use {{ py2name(py_versions\u003d\u0027py3\u0027) }} or {{ py2name() }} ?\n\nBoth are replaced by : python-validation-libs","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1649038f37c9619bb1f7d6f7dab69cd197934452","unresolved":false,"context_lines":[{"line_number":109,"context_line":"%check"},{"line_number":110,"context_line":"python3 -m stestr.cli run"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":113,"context_line":"%license LICENSE"},{"line_number":114,"context_line":"%doc README.rst ChangeLog"},{"line_number":115,"context_line":"%{_datadir}/ansible"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_3b537f6e","line":112,"range":{"start_line":112,"start_character":10,"end_line":112,"end_character":42},"in_reply_to":"9f560f44_1bcafb6c","updated":"2020-10-07 11:32:33.000000000","message":"I think that py2name fit your needs","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"870856f1a4e2bdea5cad6032ea3cf45bd0085010","unresolved":false,"context_lines":[{"line_number":112,"context_line":"%files -n {{ py2name(py_versions\u003d\u0027py3\u0027) }}"},{"line_number":113,"context_line":"%license LICENSE"},{"line_number":114,"context_line":"%doc README.rst ChangeLog"},{"line_number":115,"context_line":"%{_datadir}/ansible"},{"line_number":116,"context_line":"%{_mandir}/man1/validations-libs.1*"},{"line_number":117,"context_line":"%{python3_sitelib}/validations_libs"},{"line_number":118,"context_line":"%{python3_sitelib}/*.egg-info"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_bb8caf2e","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":19},"updated":"2020-10-07 11:22:40.000000000","message":"This is a mistake, I\u0027ll remove it from here, nothing to do on this RPM","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"870856f1a4e2bdea5cad6032ea3cf45bd0085010","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"%files -n ansible-role-{{ py2name() }}"},{"line_number":125,"context_line":"%license LICENSE"},{"line_number":126,"context_line":"%{_datadir}/ansible/roles"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"%changelog"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_dbb083df","line":126,"updated":"2020-10-07 11:22:40.000000000","message":"This have to be changed to %{_datadir}/ansible otherwise /usr/share/ansible is not owned by any package but won\u0027t it broke other rpm packages that are using this folder ?","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"fdcd696c701b44cea2c132a9910b67e238955a20","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"%files -n ansible-role-{{ py2name() }}"},{"line_number":125,"context_line":"%license LICENSE"},{"line_number":126,"context_line":"%{_datadir}/ansible/roles"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"%changelog"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_9bc9eb26","line":126,"in_reply_to":"9f560f44_3b6a5f1a","updated":"2020-10-07 11:34:20.000000000","message":"adding ansible as a dep makes sense - the dependency tree is more on tripleo side for that piece of software (tripleoclient depends on ansible and validations-common + so many other things). Not sure of the overhead, but it should be OK.","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"0b47c137a56a35c8c5f9cb7e60345c3f9e5a0b9a","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"%files -n ansible-role-{{ py2name() }}"},{"line_number":125,"context_line":"%license LICENSE"},{"line_number":126,"context_line":"%{_datadir}/ansible/roles"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"%changelog"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_bbbb0f73","line":126,"in_reply_to":"9f560f44_9bc9eb26","updated":"2020-10-07 11:45:38.000000000","message":"validations-common is not yet packaged, that\u0027s my next stuff I think.","commit_id":"954f5b8f895783305b853156450daca9a883364e"},{"author":{"_account_id":27380,"name":"Boyron Sébastien","email":"sboyron@redhat.com","username":"sboyron"},"change_message_id":"c801b1df30f64df3f7afd53f2d042a64118c7bd3","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"%files -n ansible-role-{{ py2name() }}"},{"line_number":125,"context_line":"%license LICENSE"},{"line_number":126,"context_line":"%{_datadir}/ansible/roles"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"%changelog"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9f560f44_3b6a5f1a","line":126,"in_reply_to":"9f560f44_dbb083df","updated":"2020-10-07 11:31:02.000000000","message":"This is owned by ansible package (like /usr/share/ansible/roles), are we supposed to add ansible as dependency (it could makes sense)\n\n\u003d\u003e this broke the SUSE CI.","commit_id":"954f5b8f895783305b853156450daca9a883364e"}]}