)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":12693,"name":"Artem Osadchiy","email":"aosadchiy@maprtech.com","username":"aosadchiy"},"change_message_id":"21d7a1371fe894e776eca82a4b26bf9e9811897d","unresolved":false,"context_lines":[{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        plain_image_name\u003d${plain_centos_image_name:-plain_centos}"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"        disk-image-create $centos_elements_sequence -o $plain_image_name"},{"line_number":709,"context_line":"        mv $plain_image_name.qcow2 ../"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        unset BASE_IMAGE_FILE DIB_CLOUD_IMAGES"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9aa53dc9_99cb8fa5","line":708,"updated":"2015-04-08 12:34:57.000000000","message":"HDP elements should contain yum and $JAVA_ELEMENT elements. MapR also requires base element. Such changes have to be carefully tested with respective plugins.","commit_id":"f5754cf60f3190a8ccff7830d09b1165777e19c0"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"ac3ae62b45976a93aa87f3f0514623f2aff178d1","unresolved":false,"context_lines":[{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        plain_image_name\u003d${plain_centos_image_name:-plain_centos}"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"        disk-image-create $centos_elements_sequence -o $plain_image_name"},{"line_number":709,"context_line":"        mv $plain_image_name.qcow2 ../"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        unset BASE_IMAGE_FILE DIB_CLOUD_IMAGES"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9aa53dc9_d9c8f724","line":708,"in_reply_to":"9aa53dc9_99cb8fa5","updated":"2015-04-08 12:47:28.000000000","message":"- yum is implicitly pulled by fedora/centos/etc (based on yum). it isn\u0027t like you are pulling dpkg explicitly either\n- $JAVA_ELEMENT was included in hdp, but not in your mapr version\n- the base element is automatically included by disk-image-create, unless you pass -n to it (which is not used here); the fact that when generating mapr images you ask to not use base (passing -n), but then including base explicitly, is rather puzzling to me","commit_id":"f5754cf60f3190a8ccff7830d09b1165777e19c0"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"6e18f3a61f64e4838d1283bfae885a90fa2683e5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    echo \"   \u0027-j\u0027 is java distribution (default: openjdk)\""},{"line_number":47,"context_line":"    echo \"   \u0027-x\u0027 turns on tracing\""},{"line_number":48,"context_line":"    echo"},{"line_number":49,"context_line":"    echo \"You shouldn\u0027t specify hadoop version and image type for spark plugin\""},{"line_number":50,"context_line":"    echo \"You shouldn\u0027t specify image type for hdp plugin\""},{"line_number":51,"context_line":"    echo \"Debug mode should only be enabled for local debugging purposes, not for production systems\""},{"line_number":52,"context_line":"    echo \"By default all images for all plugins will be created\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7ad32947_95bcb76d","line":49,"updated":"2015-04-28 13:39:29.000000000","message":"I think that we need to have a note about building plain images.","commit_id":"48ee915747cada7905ee3908a9650a7f4402db31"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"125ddbcda1f20980a41364f4214a9c489eefb9ad","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    fi"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    if [ -z \"$BASE_IMAGE_OS\" -o \"$BASE_IMAGE_OS\" \u003d \"ubuntu\" ]; then"},{"line_number":696,"context_line":"        plain_image_name\u003d${plain_ubuntu_image_name:-plain_ubuntu}"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        disk-image-create $TRACING $ubuntu_elements_sequence -o $plain_image_name"},{"line_number":699,"context_line":"        mv $plain_image_name.qcow2 ../"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7ad32947_75f35b74","line":696,"updated":"2015-04-28 13:39:00.000000000","message":"Due to the naming of other images, it\u0027ll be better IMO to use default name \"ubuntu_plain\" for image.","commit_id":"48ee915747cada7905ee3908a9650a7f4402db31"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"125ddbcda1f20980a41364f4214a9c489eefb9ad","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    fi"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    if [ -z \"$BASE_IMAGE_OS\" -o \"$BASE_IMAGE_OS\" \u003d \"fedora\" ]; then"},{"line_number":703,"context_line":"        plain_image_name\u003d${plain_fedora_image_name:-plain_fedora}"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"        disk-image-create $TRACING $fedora_elements_sequence -o $plain_image_name"},{"line_number":706,"context_line":"        mv $plain_image_name.qcow2 ../"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7ad32947_15030744","line":703,"updated":"2015-04-28 13:39:00.000000000","message":"ditto: fedora_plain","commit_id":"48ee915747cada7905ee3908a9650a7f4402db31"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"125ddbcda1f20980a41364f4214a9c489eefb9ad","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        # Workaround for https://review.openstack.org/#/c/162239/"},{"line_number":715,"context_line":"        export REG_HALT_UNREGISTER\u003d1"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        plain_image_name\u003d${plain_centos_image_name:-plain_centos}"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        disk-image-create $TRACING $centos_elements_sequence -o $plain_image_name"},{"line_number":720,"context_line":"        mv $plain_image_name.qcow2 ../"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7ad32947_d5fc6f40","line":717,"updated":"2015-04-28 13:39:00.000000000","message":"ditto: centos_plain","commit_id":"48ee915747cada7905ee3908a9650a7f4402db31"}]}