)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"8acba9edc938dc2d8c8a2bede7edbbddc7ed7cc5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DIB_DEFAULT_SPARK_VERSION\u003d\"2.2.0\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The default version for Storm plugin"},{"line_number":19,"context_line":"DIB_DEFAULT_STORM_VERSION\u003d\"1.1.0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Bare metal image generation is enabled with the -b flag, it is off by default"},{"line_number":22,"context_line":"SIE_BAREMETAL\u003d\"false\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_8a181276","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":33},"updated":"2018-06-25 17:05:50.000000000","message":"any thoughts on changing this?","commit_id":"aeb9cccac237a1dceff47127378f0cddf8411586"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"976681f7665302b9ba76b6c0598028c003527578","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DIB_DEFAULT_SPARK_VERSION\u003d\"2.2.0\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The default version for Storm plugin"},{"line_number":19,"context_line":"DIB_DEFAULT_STORM_VERSION\u003d\"1.1.0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Bare metal image generation is enabled with the -b flag, it is off by default"},{"line_number":22,"context_line":"SIE_BAREMETAL\u003d\"false\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_a2fcc03f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":33},"in_reply_to":"5f7c97a3_8a181276","updated":"2018-06-28 17:09:33.000000000","message":"seconded","commit_id":"aeb9cccac237a1dceff47127378f0cddf8411586"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"92f397ffb3936ee65856de4d7c8739231f2f35b9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DIB_DEFAULT_SPARK_VERSION\u003d\"2.2.0\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The default version for Storm plugin"},{"line_number":19,"context_line":"DIB_DEFAULT_STORM_VERSION\u003d\"1.1.0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Bare metal image generation is enabled with the -b flag, it is off by default"},{"line_number":22,"context_line":"SIE_BAREMETAL\u003d\"false\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_02481488","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":33},"in_reply_to":"5f7c97a3_a2fcc03f","updated":"2018-06-28 17:12:12.000000000","message":"or at least change tools/gate/build-images so that one 1.1.x and one 1.2.x image are both built by the job (right now it\u0027s only the default one, so 1.1.0).","commit_id":"aeb9cccac237a1dceff47127378f0cddf8411586"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"df71a1523f31aa1f0e7b4da9d3b4610028f210df","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DIB_DEFAULT_SPARK_VERSION\u003d\"2.2.0\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The default version for Storm plugin"},{"line_number":19,"context_line":"DIB_DEFAULT_STORM_VERSION\u003d\"1.2.0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Bare metal image generation is enabled with the -b flag, it is off by default"},{"line_number":22,"context_line":"SIE_BAREMETAL\u003d\"false\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_cdeecd20","line":19,"updated":"2018-06-28 17:24:18.000000000","message":"sorry to nitpick, but why not 1.2.1 at this point? :)","commit_id":"b6261db75078bb9e21337408ead9a9a65d4d8c2c"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"05c90294307cd2ef69615338ddc48878e17b3acd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DIB_DEFAULT_SPARK_VERSION\u003d\"2.3.0\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The default version for Storm plugin"},{"line_number":19,"context_line":"DIB_DEFAULT_STORM_VERSION\u003d\"1.2.0\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Bare metal image generation is enabled with the -b flag, it is off by default"},{"line_number":22,"context_line":"SIE_BAREMETAL\u003d\"false\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f7c97a3_10ab6b88","line":19,"range":{"start_line":19,"start_character":31,"end_line":19,"end_character":32},"updated":"2018-07-12 18:19:03.000000000","message":"you lost the 1.2.1 when resolving the conflicts, i guess","commit_id":"29250987c036327e92a2ef9de5cd6eafba7bb2ca"}]}