)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"13f828a14c3b55726e340b613a875918e4222340","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if [ \"$platform\" \u003d \u0027ubuntu\u0027 ]; then"},{"line_number":331,"context_line":"        dpkg -s \"$1\" \u0026\u003e /dev/null"},{"line_number":332,"context_line":"    else"},{"line_number":333,"context_line":"        # centos, fedora, opensuse, or rhel"},{"line_number":334,"context_line":"        if ! rpm -q \"$1\" \u0026\u003e /dev/null; then"},{"line_number":335,"context_line":"            rpm -q \"$(rpm -q --whatprovides \"$1\")\""},{"line_number":336,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_7e4ad127","side":"PARENT","line":333,"range":{"start_line":333,"start_character":7,"end_line":333,"end_character":43},"updated":"2019-09-08 23:25:07.000000000","message":"why remove this comment?","commit_id":"36d2edc24dcdc08deafeaea91d69daece26c0699"},{"author":{"_account_id":30661,"name":"Jorge Franco","email":"jorgefrancoibanez@gmail.com","username":"JorgeFrancoIbanez"},"change_message_id":"37e71599680f5b5de42d50b4c5e9ff11cbd775a3","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if [ \"$platform\" \u003d \u0027ubuntu\u0027 ]; then"},{"line_number":331,"context_line":"        dpkg -s \"$1\" \u0026\u003e /dev/null"},{"line_number":332,"context_line":"    else"},{"line_number":333,"context_line":"        # centos, fedora, opensuse, or rhel"},{"line_number":334,"context_line":"        if ! rpm -q \"$1\" \u0026\u003e /dev/null; then"},{"line_number":335,"context_line":"            rpm -q \"$(rpm -q --whatprovides \"$1\")\""},{"line_number":336,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_d04aa425","side":"PARENT","line":333,"range":{"start_line":333,"start_character":7,"end_line":333,"end_character":43},"in_reply_to":"5faad753_7e4ad127","updated":"2019-09-10 20:26:37.000000000","message":"It was a mistake. Adding it back. thanks","commit_id":"36d2edc24dcdc08deafeaea91d69daece26c0699"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"13f828a14c3b55726e340b613a875918e4222340","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"need_required_packages() {"},{"line_number":346,"context_line":"    case \"$platform\" in"},{"line_number":347,"context_line":"        \"ubuntu\" | \"debian\")"},{"line_number":348,"context_line":"            package_list\u003d\"qemu kpartx git\""},{"line_number":349,"context_line":"            ;;"},{"line_number":350,"context_line":"        \"fedora\")"},{"line_number":351,"context_line":"            package_list\u003d\"qemu-img kpartx git\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_9e70ed74","line":348,"range":{"start_line":347,"start_character":28,"end_line":348,"end_character":13},"updated":"2019-09-08 23:25:07.000000000","message":"maybe we could just do an ubuntu/debian version check here to directly determine the package list? (rather than guess later within is_installed)","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"},{"author":{"_account_id":30661,"name":"Jorge Franco","email":"jorgefrancoibanez@gmail.com","username":"JorgeFrancoIbanez"},"change_message_id":"37e71599680f5b5de42d50b4c5e9ff11cbd775a3","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"need_required_packages() {"},{"line_number":346,"context_line":"    case \"$platform\" in"},{"line_number":347,"context_line":"        \"ubuntu\" | \"debian\")"},{"line_number":348,"context_line":"            package_list\u003d\"qemu kpartx git\""},{"line_number":349,"context_line":"            ;;"},{"line_number":350,"context_line":"        \"fedora\")"},{"line_number":351,"context_line":"            package_list\u003d\"qemu-img kpartx git\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_90542ccc","line":348,"range":{"start_line":347,"start_character":28,"end_line":348,"end_character":13},"in_reply_to":"5faad753_9e70ed74","updated":"2019-09-10 20:26:37.000000000","message":"For this line, it is not required to add a separate check. The idea of the commit is to allow users that already have \"qemu-utils\" package installed can use it instead of the \"qemu\" core package. This scenario can be applied to both, Debian and Ubuntu.","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"13f828a14c3b55726e340b613a875918e4222340","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    return 1"},{"line_number":372,"context_line":"}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"if  need_required_packages ; then"},{"line_number":375,"context_line":"    # install required packages if requested"},{"line_number":376,"context_line":"    if [ -n \"$DIB_UPDATE_REQUESTED\" ]; then"},{"line_number":377,"context_line":"        case \"$platform\" in"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_de450519","line":374,"range":{"start_line":374,"start_character":4,"end_line":374,"end_character":26},"updated":"2019-09-08 23:25:07.000000000","message":"unnecessary whitespace change","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"},{"author":{"_account_id":30661,"name":"Jorge Franco","email":"jorgefrancoibanez@gmail.com","username":"JorgeFrancoIbanez"},"change_message_id":"37e71599680f5b5de42d50b4c5e9ff11cbd775a3","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    return 1"},{"line_number":372,"context_line":"}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"if  need_required_packages ; then"},{"line_number":375,"context_line":"    # install required packages if requested"},{"line_number":376,"context_line":"    if [ -n \"$DIB_UPDATE_REQUESTED\" ]; then"},{"line_number":377,"context_line":"        case \"$platform\" in"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_906d0c9a","line":374,"range":{"start_line":374,"start_character":4,"end_line":374,"end_character":26},"in_reply_to":"5faad753_de450519","updated":"2019-09-10 20:26:37.000000000","message":"Removing the whitespace. It was caused by adding negation during tests.","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"13f828a14c3b55726e340b613a875918e4222340","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        case \"$platform\" in"},{"line_number":378,"context_line":"            \"ubuntu\" | \"debian\")"},{"line_number":379,"context_line":"                sudo apt-get update"},{"line_number":380,"context_line":"                sudo apt-get install $package_list -y"},{"line_number":381,"context_line":"                ;;"},{"line_number":382,"context_line":"            \"opensuse\")"},{"line_number":383,"context_line":"                sudo zypper --non-interactive --gpg-auto-import-keys in $package_list"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_5e5115d8","line":380,"range":{"start_line":380,"start_character":37,"end_line":380,"end_character":50},"updated":"2019-09-08 23:25:07.000000000","message":"but here $package_list will still always contain \"qemu\" even when it should be \"qemu-utils\"","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"},{"author":{"_account_id":30661,"name":"Jorge Franco","email":"jorgefrancoibanez@gmail.com","username":"JorgeFrancoIbanez"},"change_message_id":"37e71599680f5b5de42d50b4c5e9ff11cbd775a3","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        case \"$platform\" in"},{"line_number":378,"context_line":"            \"ubuntu\" | \"debian\")"},{"line_number":379,"context_line":"                sudo apt-get update"},{"line_number":380,"context_line":"                sudo apt-get install $package_list -y"},{"line_number":381,"context_line":"                ;;"},{"line_number":382,"context_line":"            \"opensuse\")"},{"line_number":383,"context_line":"                sudo zypper --non-interactive --gpg-auto-import-keys in $package_list"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_f01c8014","line":380,"range":{"start_line":380,"start_character":37,"end_line":380,"end_character":50},"in_reply_to":"5faad753_5e5115d8","updated":"2019-09-10 20:26:37.000000000","message":"if the user doesn\u0027t have either \"qemu\" / \"qemu-utils\" installed on his Debian or Ubuntu system, the script can proceed and install by default \"qemu\" package as it\u0027s being used in the past.\n\nIt can be either of them. The idea is to provide more flexibility and options to avoid confusions","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"13f828a14c3b55726e340b613a875918e4222340","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                ;;"},{"line_number":389,"context_line":"        esac"},{"line_number":390,"context_line":"    else"},{"line_number":391,"context_line":"        echo \"Missing one of the following packages: $package_list\""},{"line_number":392,"context_line":"        echo \"Please install manually or rerun with the update option (-u).\""},{"line_number":393,"context_line":"        exit 1"},{"line_number":394,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_be5929ff","line":391,"range":{"start_line":391,"start_character":53,"end_line":391,"end_character":66},"updated":"2019-09-08 23:25:07.000000000","message":"but here $package_list will still always contain \"qemu\" even when it should be \"qemu-utils\"","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"},{"author":{"_account_id":30661,"name":"Jorge Franco","email":"jorgefrancoibanez@gmail.com","username":"JorgeFrancoIbanez"},"change_message_id":"37e71599680f5b5de42d50b4c5e9ff11cbd775a3","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                ;;"},{"line_number":389,"context_line":"        esac"},{"line_number":390,"context_line":"    else"},{"line_number":391,"context_line":"        echo \"Missing one of the following packages: $package_list\""},{"line_number":392,"context_line":"        echo \"Please install manually or rerun with the update option (-u).\""},{"line_number":393,"context_line":"        exit 1"},{"line_number":394,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_901bcc19","line":391,"range":{"start_line":391,"start_character":53,"end_line":391,"end_character":66},"in_reply_to":"5faad753_be5929ff","updated":"2019-09-10 20:26:37.000000000","message":"if the user doesn\u0027t have either \"qemu\" / \"qemu-utils\" installed on his Debian or Ubuntu system, the script can proceed and install by default \"qemu\" package as it\u0027s being used in the past.\n\nIt can be either of them. The idea is to provide more flexibility and options to avoid confusions","commit_id":"72173a32b00b00130055bbeb99d435a2d4b3f99a"}]}