)]}'
{"elements/java/README.md":[{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"6c4c2da44684b77ecd1c8ed2f4368b4e77e4eae3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"variable in order to customize the top-level directory that will"},{"line_number":18,"context_line":"contain the JDK install.  By default, this variable is set to \"/usr/java\"."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note: setting the install location will currently only work for .bin install types.  "}],"source_content_type":"text/x-gfm","patch_set":2,"id":"7adec928_40a76e0c","line":20,"range":{"start_line":20,"start_character":83,"end_line":20,"end_character":85},"updated":"2014-05-13 06:05:35.000000000","message":"Remove whitespaces","commit_id":"1a422fed0c552367ec839e8e8f81d2b3319fe4bb"},{"author":{"_account_id":9499,"name":"Robert Nettleton","email":"rnettleton@hortonworks.com","username":"rnettleton"},"change_message_id":"195b131dd3e00241647b231b05c50ec5a64457b6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"variable in order to customize the top-level directory that will"},{"line_number":18,"context_line":"contain the JDK install.  By default, this variable is set to \"/usr/java\"."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note: setting the install location will currently only work for .bin install types.  "}],"source_content_type":"text/x-gfm","patch_set":2,"id":"7adec928_1462083e","line":20,"in_reply_to":"7adec928_40a76e0c","updated":"2014-05-13 12:23:26.000000000","message":"Done.  Fixed in Patch #3.","commit_id":"1a422fed0c552367ec839e8e8f81d2b3319fe4bb"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"7a3002c7a7d5a497d4c91d4920c85de54971e6e3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"install the natively packaged JVM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Provide JAVA_FILE via the environment, it should be a .tar.gz or"},{"line_number":10,"context_line":".bin and will be install under /usr/java"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Provide JAVA_DOWNLOAD_URL via the environment, it should be a url"},{"line_number":13,"context_line":"pointing to a file that will be placed in JAVA_FILE (see 1.)"}],"source_content_type":"text/x-gfm","patch_set":3,"id":"7adec928_2637cf4f","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":35},"updated":"2014-05-13 21:21:03.000000000","message":"This is not fixed.","commit_id":"f4ec2b6ad1ff8d586ca94ef41eb329574d527514"},{"author":{"_account_id":9499,"name":"Robert Nettleton","email":"rnettleton@hortonworks.com","username":"rnettleton"},"change_message_id":"0ada8380d11ec91a3a94b72be896969b34065979","unresolved":false,"context_lines":[{"line_number":7,"context_line":"install the natively packaged JVM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Provide JAVA_FILE via the environment, it should be a .tar.gz or"},{"line_number":10,"context_line":".bin and will be install under /usr/java"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Provide JAVA_DOWNLOAD_URL via the environment, it should be a url"},{"line_number":13,"context_line":"pointing to a file that will be placed in JAVA_FILE (see 1.)"}],"source_content_type":"text/x-gfm","patch_set":3,"id":"7adec928_7d07a11c","line":10,"in_reply_to":"7adec928_2637cf4f","updated":"2014-05-14 13:58:50.000000000","message":"I\u0027ll fix this in the next patch submission for this review.","commit_id":"f4ec2b6ad1ff8d586ca94ef41eb329574d527514"},{"author":{"_account_id":9499,"name":"Robert Nettleton","email":"rnettleton@hortonworks.com","username":"rnettleton"},"change_message_id":"5a1710b3e4b3e5518e93b3debe8ec9170d22a079","unresolved":false,"context_lines":[{"line_number":7,"context_line":"install the natively packaged JVM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Provide JAVA_FILE via the environment, it should be a .tar.gz or"},{"line_number":10,"context_line":".bin and will be install under /usr/java"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Provide JAVA_DOWNLOAD_URL via the environment, it should be a url"},{"line_number":13,"context_line":"pointing to a file that will be placed in JAVA_FILE (see 1.)"}],"source_content_type":"text/x-gfm","patch_set":3,"id":"7adec928_4fab08d6","line":10,"in_reply_to":"7adec928_7d07a11c","updated":"2014-05-14 14:08:08.000000000","message":"Done, Fixed in Patch Set 4.","commit_id":"f4ec2b6ad1ff8d586ca94ef41eb329574d527514"}],"elements/java/install.d/33-java":[{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"7a3002c7a7d5a497d4c91d4920c85de54971e6e3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   if [[ $JAVA_FILE \u003d\u003d *.tar.gz ]]; then"},{"line_number":35,"context_line":"      echo \"Decompressing Java archive\""},{"line_number":36,"context_line":"      echo -e \"\\n\" | tar -zxf $JAVA_FILE"},{"line_number":37,"context_line":"      JAVA_NAME\u003d`ls -1 /usr/java/ | grep -v tar.gz`"},{"line_number":38,"context_line":"      echo \"Setting up $JAVA_NAME\""},{"line_number":39,"context_line":"      chown -R root:root $JAVA_HOME"},{"line_number":40,"context_line":"      cat \u003e\u003e /etc/profile.d/java.sh \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7adec928_c6ee2bb4","line":37,"range":{"start_line":37,"start_character":28,"end_line":37,"end_character":32},"updated":"2014-05-13 21:21:03.000000000","message":"Introduced change will completely break java element if different JAVA_TARGET_LOCATION is provided. I see other patch that probably fixes that. But I would prefer to see it as one patch to not follow \"break now, fix later\" pattern.","commit_id":"f4ec2b6ad1ff8d586ca94ef41eb329574d527514"},{"author":{"_account_id":9499,"name":"Robert Nettleton","email":"rnettleton@hortonworks.com","username":"rnettleton"},"change_message_id":"0ada8380d11ec91a3a94b72be896969b34065979","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   if [[ $JAVA_FILE \u003d\u003d *.tar.gz ]]; then"},{"line_number":35,"context_line":"      echo \"Decompressing Java archive\""},{"line_number":36,"context_line":"      echo -e \"\\n\" | tar -zxf $JAVA_FILE"},{"line_number":37,"context_line":"      JAVA_NAME\u003d`ls -1 /usr/java/ | grep -v tar.gz`"},{"line_number":38,"context_line":"      echo \"Setting up $JAVA_NAME\""},{"line_number":39,"context_line":"      chown -R root:root $JAVA_HOME"},{"line_number":40,"context_line":"      cat \u003e\u003e /etc/profile.d/java.sh \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7adec928_dd1c357a","line":37,"in_reply_to":"7adec928_c6ee2bb4","updated":"2014-05-14 13:58:50.000000000","message":"I think there is a misunderstanding regarding what my patch does.  This patch introduces the JAVA_TARGET_LOCATION variable, which isn\u0027t currently being used by any scripts yet.  Since nothing uses this new variable yet, nothing is broken in the java element by this change. \n\nMy intent with this patch was to add support for a target location variable for .bin install types first, then add support for .tar install types in a separate patch.  \n\nWith this patch, if JAVA_TARGET_LOCATION is used with a .bin install type, things will work fine. \n\nYou are correct in that setting the JAVA_TARGET_LOCATION will not work properly for the .tar.gz install type, but my intent was to address this in a separate patch.\n\nApologies, I should have made this clearer in my commit notes.  It may have been better to add an error check to this change, so that any attempt to use the target location with a .tar.gz install would fail cleanly.  \n\nSince Ivan has already created a patch to address this second part, I don\u0027t think it makes sense to address this in my original patch, since Ivan\u0027s patch is now dependent upon my patch. \n\nI\u0027ll fix the README note issue in a subsequent patch update. \n\nThanks.","commit_id":"f4ec2b6ad1ff8d586ca94ef41eb329574d527514"}]}