)]}'
{"sahara_plugin_cdh/plugins/cdh/db_helper.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"08d37fc3b95a4548f52d3d055ba8a75388d5e6f3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    db_password \u003d get_hive_db_password(cluster)"},{"line_number":107,"context_line":"    create_db_script \u003d utils.try_get_file_text("},{"line_number":108,"context_line":"        \u0027plugins/cdh/db_resources/create_hive_db.sql\u0027, \u0027sahara_plugin_cdh\u0027)"},{"line_number":109,"context_line":"    create_db_script \u003d create_db_script % db_password.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"    remote_execute_db_script(remote, create_db_script)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e40bf679","line":109,"updated":"2019-08-28 14:03:52.000000000","message":"From my quick tests, if you open(..., \u0027rb\u0027).read(), this instruction fails on python2 when the file contains non-ascii characters.","commit_id":"1d522cc173cc9cee9d628285ce677a4b5e35564b"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"bf5d0efbc845bb78a8c0dad6db8f43628b9ff50a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    db_password \u003d get_hive_db_password(cluster)"},{"line_number":107,"context_line":"    create_db_script \u003d utils.try_get_file_text("},{"line_number":108,"context_line":"        \u0027plugins/cdh/db_resources/create_hive_db.sql\u0027, \u0027sahara_plugin_cdh\u0027)"},{"line_number":109,"context_line":"    create_db_script \u003d create_db_script % db_password.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"    remote_execute_db_script(remote, create_db_script)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fa6ec3c7","line":109,"in_reply_to":"3fa7e38b_028ee226","updated":"2019-10-03 19:01:38.000000000","message":"Is there a case when the password has special cases like this?","commit_id":"1d522cc173cc9cee9d628285ce677a4b5e35564b"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"6fec0c57f1a8ed894fba863725cdd2d65de92f9c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    db_password \u003d get_hive_db_password(cluster)"},{"line_number":107,"context_line":"    create_db_script \u003d utils.try_get_file_text("},{"line_number":108,"context_line":"        \u0027plugins/cdh/db_resources/create_hive_db.sql\u0027, \u0027sahara_plugin_cdh\u0027)"},{"line_number":109,"context_line":"    create_db_script \u003d create_db_script % db_password.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"    remote_execute_db_script(remote, create_db_script)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ba960b94","line":109,"in_reply_to":"3fa7e38b_7ab7333c","updated":"2019-10-03 19:04:21.000000000","message":"I believe so, and being so encode should do the trick here.","commit_id":"1d522cc173cc9cee9d628285ce677a4b5e35564b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"caacf973e0f1633310955860923a57772e0482cc","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    db_password \u003d get_hive_db_password(cluster)"},{"line_number":107,"context_line":"    create_db_script \u003d utils.try_get_file_text("},{"line_number":108,"context_line":"        \u0027plugins/cdh/db_resources/create_hive_db.sql\u0027, \u0027sahara_plugin_cdh\u0027)"},{"line_number":109,"context_line":"    create_db_script \u003d create_db_script % db_password.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"    remote_execute_db_script(remote, create_db_script)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7ab7333c","line":109,"in_reply_to":"3fa7e38b_fa6ec3c7","updated":"2019-10-03 19:03:16.000000000","message":"i\u0027m pretty sure the db password is just a uuid","commit_id":"1d522cc173cc9cee9d628285ce677a4b5e35564b"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"9c9b49f961465b0c4f316b5f0df23d8799532502","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    db_password \u003d get_hive_db_password(cluster)"},{"line_number":107,"context_line":"    create_db_script \u003d utils.try_get_file_text("},{"line_number":108,"context_line":"        \u0027plugins/cdh/db_resources/create_hive_db.sql\u0027, \u0027sahara_plugin_cdh\u0027)"},{"line_number":109,"context_line":"    create_db_script \u003d create_db_script % db_password.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"    remote_execute_db_script(remote, create_db_script)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_42454f43","line":109,"in_reply_to":"7faddb67_270aa589","updated":"2019-08-30 14:40:35.000000000","message":"Yes, you are enconding the wrong thing. The encode is on the db_password which is a string.","commit_id":"1d522cc173cc9cee9d628285ce677a4b5e35564b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ff215138ca27e634606f54a03ae1f2fb8617641b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    db_password \u003d get_hive_db_password(cluster)"},{"line_number":107,"context_line":"    create_db_script \u003d utils.try_get_file_text("},{"line_number":108,"context_line":"        \u0027plugins/cdh/db_resources/create_hive_db.sql\u0027, \u0027sahara_plugin_cdh\u0027)"},{"line_number":109,"context_line":"    create_db_script \u003d create_db_script % db_password.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"    remote_execute_db_script(remote, create_db_script)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_028ee226","line":109,"in_reply_to":"7faddb67_42454f43","updated":"2019-10-03 09:31:40.000000000","message":"But on python2:\n\n\u003e\u003e\u003e foo\u003d\u0027ébc\u0027\n\u003e\u003e\u003e foo.encode(\u0027UTF-8\u0027)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nUnicodeDecodeError: \u0027ascii\u0027 codec can\u0027t decode byte 0xc3 in position 0: ordinal not in range(128)","commit_id":"1d522cc173cc9cee9d628285ce677a4b5e35564b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"73ecb5a49c9d992ead94c3e4a7ca3f89dfcde98e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    db_password \u003d get_hive_db_password(cluster)"},{"line_number":107,"context_line":"    create_db_script \u003d utils.try_get_file_text("},{"line_number":108,"context_line":"        \u0027plugins/cdh/db_resources/create_hive_db.sql\u0027, \u0027sahara_plugin_cdh\u0027)"},{"line_number":109,"context_line":"    create_db_script \u003d create_db_script % db_password.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"    remote_execute_db_script(remote, create_db_script)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_270aa589","line":109,"in_reply_to":"7faddb67_e40bf679","updated":"2019-08-30 14:22:15.000000000","message":"does it ever work? (possible i am just confused)\n\nhttp://paste.openstack.org/show/767644/","commit_id":"1d522cc173cc9cee9d628285ce677a4b5e35564b"}]}
