)]}'
{"sahara_plugin_mapr/plugins/mapr/resources/images/centos/configure_hue":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b480ff1081b33000ec7cec81306c4383ff66d7d1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"echo \"Installing mysql compat\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"MARIADB_VERSION\u003d$(rpm -qa mariadb | cut -d- -f2)"},{"line_number":6,"context_line":"INSTALLED\u003d$(rpm -qa | grep MariaDB-compat-$MARIADB_VERSION-1.el7.centos.x86_64)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [[ -z \"$INSTALLED\" ]]; then"},{"line_number":9,"context_line":"    rpm -ivh --nodeps http://yum.mariadb.org/$MARIADB_VERSION/rhel7-amd64/rpms/MariaDB-$MARIADB_VERSION-centos73-x86_64-compat.rpm"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_d193885b","line":6,"updated":"2019-07-26 12:25:22.000000000","message":"not only py3; so this should either go to a separate commit, or be documented","commit_id":"af9494ada285d83c87268a666bcb5f65b797a275"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"3f41e0668d59821f9d1c00610bd1d2d045180cd0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"echo \"Installing mysql compat\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"MARIADB_VERSION\u003d$(rpm -qa mariadb | cut -d- -f2)"},{"line_number":6,"context_line":"INSTALLED\u003d$(rpm -qa | grep MariaDB-compat-$MARIADB_VERSION-1.el7.centos.x86_64)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [[ -z \"$INSTALLED\" ]]; then"},{"line_number":9,"context_line":"    rpm -ivh --nodeps http://yum.mariadb.org/$MARIADB_VERSION/rhel7-amd64/rpms/MariaDB-$MARIADB_VERSION-centos73-x86_64-compat.rpm"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_3783e906","line":6,"in_reply_to":"7faddb67_17a90ddc","updated":"2019-07-26 17:43:24.000000000","message":"Sure, I will send it in a separate patch","commit_id":"af9494ada285d83c87268a666bcb5f65b797a275"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"2e692e699bbdee8ffdd489e7b385823ec216e087","unresolved":false,"context_lines":[{"line_number":3,"context_line":"echo \"Installing mysql compat\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"MARIADB_VERSION\u003d$(rpm -qa mariadb | cut -d- -f2)"},{"line_number":6,"context_line":"INSTALLED\u003d$(rpm -qa | grep MariaDB-compat-$MARIADB_VERSION-1.el7.centos.x86_64)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [[ -z \"$INSTALLED\" ]]; then"},{"line_number":9,"context_line":"    rpm -ivh --nodeps http://yum.mariadb.org/$MARIADB_VERSION/rhel7-amd64/rpms/MariaDB-$MARIADB_VERSION-centos73-x86_64-compat.rpm"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_17a90ddc","line":6,"in_reply_to":"7faddb67_d193885b","updated":"2019-07-26 17:21:39.000000000","message":"agree","commit_id":"af9494ada285d83c87268a666bcb5f65b797a275"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9653258912be860c8a1ee856bdd4ea9ccc0f3b2c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"echo \"Installing mysql compat\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"MARIADB_VERSION\u003d$(rpm -qa mariadb | cut -d- -f2)"},{"line_number":6,"context_line":"INSTALLED\u003d$(rpm -qa | grep -i mariadb-compat-${MARIADB_VERSION}-)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [[ -z \"$INSTALLED\" ]]; then"},{"line_number":9,"context_line":"    rpm -ivh --nodeps http://yum.mariadb.org/$MARIADB_VERSION/rhel7-amd64/rpms/MariaDB-$MARIADB_VERSION-centos73-x86_64-compat.rpm"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7faddb67_84bec2ab","line":6,"updated":"2019-08-05 12:36:44.000000000","message":"I think this is part of another review","commit_id":"f6527169051eba3f3326c2d112ca7c49254aebdc"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7c86cd9642e808b3c159f70aa91254429da8d41c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"echo \"Installing mysql compat\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"MARIADB_VERSION\u003d$(rpm -qa mariadb | cut -d- -f2)"},{"line_number":6,"context_line":"INSTALLED\u003d$(rpm -qa | grep -i mariadb-compat-${MARIADB_VERSION}-)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [[ -z \"$INSTALLED\" ]]; then"},{"line_number":9,"context_line":"    rpm -ivh --nodeps http://yum.mariadb.org/$MARIADB_VERSION/rhel7-amd64/rpms/MariaDB-$MARIADB_VERSION-centos73-x86_64-compat.rpm"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7faddb67_b0f09593","line":6,"updated":"2019-08-07 14:56:34.000000000","message":"This change is still not part of this review; which should depend on https://review.opendev.org/#/c/673036/","commit_id":"a39b9fc09836522a5650f2c215f95101ec9b43ee"}],"sahara_plugin_mapr/plugins/mapr/services/swift/swift.py":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"2e692e699bbdee8ffdd489e7b385823ec216e087","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @el.provision_step(\"Install Swift service\")"},{"line_number":47,"context_line":"    def _install_swift_jar(self, cluster_context, instances):"},{"line_number":48,"context_line":"        LOG.debug(\u0027Installing Swift jar\u0027)"},{"line_number":49,"context_line":"        jar \u003d u.try_get_file_text(Swift.HADOOP_SWIFT_JAR, \u0027sahara_plugin_mapr\u0027)"},{"line_number":50,"context_line":"        path \u003d \u0027%s/swift.jar\u0027 % cluster_context.hadoop_lib"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        @el.provision_event()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b7903997","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"updated":"2019-07-26 17:21:39.000000000","message":"sure it\u0027s necessary?","commit_id":"af9494ada285d83c87268a666bcb5f65b797a275"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"d6206af0eb75755b29217a0765e50ba81b51a120","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @el.provision_step(\"Install Swift service\")"},{"line_number":47,"context_line":"    def _install_swift_jar(self, cluster_context, instances):"},{"line_number":48,"context_line":"        LOG.debug(\u0027Installing Swift jar\u0027)"},{"line_number":49,"context_line":"        jar \u003d u.try_get_file_text(Swift.HADOOP_SWIFT_JAR, \u0027sahara_plugin_mapr\u0027)"},{"line_number":50,"context_line":"        path \u003d \u0027%s/swift.jar\u0027 % cluster_context.hadoop_lib"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        @el.provision_event()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5748e585","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"in_reply_to":"7faddb67_17782d29","updated":"2019-07-26 17:59:40.000000000","message":"hmm, maybe I am looking in the wrong place but I thought that try_get_file_text is doing a check that file exists before trying to open it. not a check related to string/bytes.","commit_id":"af9494ada285d83c87268a666bcb5f65b797a275"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"f987fc06abf3f3145fd8f099e75e023c15161f60","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @el.provision_step(\"Install Swift service\")"},{"line_number":47,"context_line":"    def _install_swift_jar(self, cluster_context, instances):"},{"line_number":48,"context_line":"        LOG.debug(\u0027Installing Swift jar\u0027)"},{"line_number":49,"context_line":"        jar \u003d u.try_get_file_text(Swift.HADOOP_SWIFT_JAR, \u0027sahara_plugin_mapr\u0027)"},{"line_number":50,"context_line":"        path \u003d \u0027%s/swift.jar\u0027 % cluster_context.hadoop_lib"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        @el.provision_event()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d2e06329","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"in_reply_to":"7faddb67_5748e585","updated":"2019-07-26 18:13:25.000000000","message":"Actually I think you are right, I can change that to get_file_binary, but we need to double check on a python 2 environment","commit_id":"af9494ada285d83c87268a666bcb5f65b797a275"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"3f41e0668d59821f9d1c00610bd1d2d045180cd0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @el.provision_step(\"Install Swift service\")"},{"line_number":47,"context_line":"    def _install_swift_jar(self, cluster_context, instances):"},{"line_number":48,"context_line":"        LOG.debug(\u0027Installing Swift jar\u0027)"},{"line_number":49,"context_line":"        jar \u003d u.try_get_file_text(Swift.HADOOP_SWIFT_JAR, \u0027sahara_plugin_mapr\u0027)"},{"line_number":50,"context_line":"        path \u003d \u0027%s/swift.jar\u0027 % cluster_context.hadoop_lib"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        @el.provision_event()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_17782d29","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"in_reply_to":"7faddb67_b7903997","updated":"2019-07-26 17:43:24.000000000","message":"yes. The try method tries to read as string and if fails it read as bytes. This needs to be done for support on python2 and python3. Once python2 is out we can revisit some of these to make it cleaner.","commit_id":"af9494ada285d83c87268a666bcb5f65b797a275"}],"sahara_plugin_mapr/plugins/mapr/util/general.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"33fd8eebacc6904cf3377f220d8df3c43d87c784","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    with instance.remote() as r:"},{"line_number":94,"context_line":"        path \u003d \u0027/tmp/%s.sh\u0027 % uuidutils.generate_uuid()"},{"line_number":95,"context_line":"        script \u003d utils.get_file_text("},{"line_number":96,"context_line":"            script, \u0027sahara_plugin_mapr\u0027).decode(\u0027utf-8\u0027) % kwargs"},{"line_number":97,"context_line":"        r.write_file_to(path, script, run_as_root\u003d(run_as \u003d\u003d \u0027root\u0027))"},{"line_number":98,"context_line":"        r.execute_command(_run_as(run_as, \u0027chmod +x %s\u0027 % path))"},{"line_number":99,"context_line":"        r.execute_command(_run_as(run_as, \u0027%s %s\u0027 % (path, \u0027 \u0027.join(args))),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_2967904f","line":96,"updated":"2019-08-05 13:14:18.000000000","message":"I\u0027ve got a \n    b\u0027  File \"/usr/lib/python3.6/site-packages/sahara_plugin_mapr/plugins/mapr/util/general.py\", line 96, in run_script\u0027\n    b\"    script, \u0027sahara_plugin_mapr\u0027).decode(\u0027utf-8\u0027) % kwargs\"\n    b\"AttributeError: \u0027str\u0027 object has no attribute \u0027decode\u0027\"","commit_id":"f6527169051eba3f3326c2d112ca7c49254aebdc"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"0b9e7c4ba6e50c45633fb3408a1a2919331c7b7e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    with instance.remote() as r:"},{"line_number":94,"context_line":"        path \u003d \u0027/tmp/%s.sh\u0027 % uuidutils.generate_uuid()"},{"line_number":95,"context_line":"        script \u003d utils.get_file_text("},{"line_number":96,"context_line":"            script, \u0027sahara_plugin_mapr\u0027).decode(\u0027utf-8\u0027) % kwargs"},{"line_number":97,"context_line":"        r.write_file_to(path, script.encode(\u0027utf-8\u0027),"},{"line_number":98,"context_line":"                        run_as_root\u003d(run_as \u003d\u003d \u0027root\u0027))"},{"line_number":99,"context_line":"        r.execute_command(_run_as(run_as, \u0027chmod +x %s\u0027 % path))"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_ac446348","line":96,"updated":"2019-08-13 12:30:59.000000000","message":"I still an error:\n\n    b\"Creating cluster failed for the following reason(s): An error occurred in thread \u0027wrapped-execution\u0027: \u0027str\u0027 object has no attribute \u0027decode\u0027\"\n    b\u0027Traceback (most recent call last):\u0027\n    b\u0027  File \"/usr/lib/python3.6/site-packages/sahara/context.py\", line 167, in _wrapper\u0027\n    b\u0027    func(*args, **kwargs)\u0027\n    b\u0027  File \"/usr/lib/python3.6/site-packages/sahara_plugin_mapr/plugins/mapr/util/event_log.py\", line 52, in wrapped\u0027\n    b\u0027    raise exception\u0027\n    b\u0027  File \"/usr/lib/python3.6/site-packages/sahara_plugin_mapr/plugins/mapr/util/event_log.py\", line 47, in wrapped\u0027\n    b\u0027    result \u003d function(*args, **kwargs)\u0027\n    b\u0027  File \"/usr/lib/python3.6/site-packages/sahara_plugin_mapr/plugins/mapr/base/base_cluster_configurer.py\", line 381, in install_mapr_repos\u0027\n    b\u0027    distro_name, **cluster_context.mapr_repos)\u0027\n    b\u0027  File \"/usr/lib/python3.6/site-packages/sahara_plugin_mapr/plugins/mapr/util/general.py\", line 96, in run_script\u0027\n    b\"    script, \u0027sahara_plugin_mapr\u0027).decode(\u0027utf-8\u0027) % kwargs\"\n    b\"AttributeError: \u0027str\u0027 object has no attribute \u0027decode\u0027\"","commit_id":"71cbd238578a9e6aa1d05785b7b47a35f752eaa8"}]}