)]}'
{"doc/source/user/spark-plugin.rst":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c32ed9a9f7ed56dd0e1ed24cd438c6ea27c3ab7d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"   * - 2.3"},{"line_number":28,"context_line":"     - Ubuntu 16.04"},{"line_number":29,"context_line":"     - sahara-image-pack"},{"line_number":30,"context_line":"     - 2.3.0"},{"line_number":31,"context_line":"     - based on CDH 5.11"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_17c9e176","line":29,"updated":"2019-02-11 18:59:44.000000000","message":"The other plugins were both methods are supported describe both:\nhttps://docs.openstack.org/sahara-plugin-cdh/latest/user/cdh-plugin.html\nhttps://docs.openstack.org/sahara-plugin-ambari/latest/user/ambari-plugin.html","commit_id":"4b4bd63b8becbf291fae910ed630aa0de39c7bd3"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"3dfc4dbcdc00545c279d05087d5b0710638131bf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"       (build parameter)"},{"line_number":25,"context_line":"     - Notes"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"   * - 2.3"},{"line_number":28,"context_line":"     - Ubuntu 16.04"},{"line_number":29,"context_line":"     - sahara-image-pack, sahara-image-create"},{"line_number":30,"context_line":"     - 2.3.0"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fdfeff1_6bbeeaae","line":27,"updated":"2019-02-15 13:57:13.000000000","message":"We need two new lines, because the \"Version (build parameter)\" field is different between sahara-image-pack and sahara-image-create.\npack: 2.3; sie: 2.3.0\npack: 2.2; sie: 2.2.0\n\nSee for example here:\nhttps://docs.openstack.org/sahara-plugin-ambari/latest/user/ambari-plugin.html\n\n(we may also want to mention the additional parameter which forces a specific version in the notes of the pack-related lines)","commit_id":"a65bc731485ad1202663d916ca4a22d38771dc2a"}],"sahara_plugin_spark/plugins/spark/resources/images/common/add_jar":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"140f75c1fa36fb686046776c8284265ea3ce9d33","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [ $test_only -eq 0 ]; then"},{"line_number":9,"context_line":"    mkdir -p $HDFS_LIB_DIR"},{"line_number":10,"context_line":"    wget -O $HDFS_LIB_DIR/$HADOOP_SWIFT_JAR_NAME $swift_url"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":13,"context_line":"        echo -e \"Could not download Swift Hadoop FS implementation.\\nAborting\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_29b865c6","line":10,"updated":"2019-02-08 21:01:40.000000000","message":"s/wget -O/curl -sS -o/","commit_id":"d463cf58f3a70260211077771ae0957a89556195"}],"sahara_plugin_spark/plugins/spark/resources/images/common/install_extjs":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"140f75c1fa36fb686046776c8284265ea3ce9d33","unresolved":false,"context_lines":[{"line_number":8,"context_line":"extjs_folder\u003d\"${extjs_basepath%.*}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"setup_extjs() {"},{"line_number":11,"context_line":"    wget -O $extjs_archive $EXTJS_DOWNLOAD_URL"},{"line_number":12,"context_line":"    mkdir -p $EXTJS_DESTINATION_DIR"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_09b561cd","line":11,"updated":"2019-02-08 21:01:40.000000000","message":"s/wget -O/curl -sS -o/","commit_id":"d463cf58f3a70260211077771ae0957a89556195"}],"sahara_plugin_spark/plugins/spark/resources/images/common/manipulate_s3":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"7a054b19c4bdc4a566a0ea1dc370326b610fd854","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"SPARK_JARS_DIR_PATH\u003d\"/opt/spark/jars\""},{"line_number":4,"context_line":"HADOOP_TOOLS_DIR_PATH\u003d\"/opt/hadoop/share/hadoop/tools/lib\""},{"line_number":5,"context_line":"HADOOP_COMMON_DIR_PATH\u003d\"/opt/hadoop/share/hadoop/common/lib\""},{"line_number":6,"context_line":"SPARK_HADOOP_DL\u003d\"hadoop2.7\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# For both Spark and Vanilla plugins:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_66769c09","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":27},"updated":"2019-02-08 19:49:15.000000000","message":"not used","commit_id":"d463cf58f3a70260211077771ae0957a89556195"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"7a054b19c4bdc4a566a0ea1dc370326b610fd854","unresolved":false,"context_lines":[{"line_number":5,"context_line":"HADOOP_COMMON_DIR_PATH\u003d\"/opt/hadoop/share/hadoop/common/lib\""},{"line_number":6,"context_line":"SPARK_HADOOP_DL\u003d\"hadoop2.7\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# For both Spark and Vanilla plugins:"},{"line_number":10,"context_line":"# (The s3a driver in hadoop-aws 2.6.5 is too buggy to be redeemed)"},{"line_number":11,"context_line":"# The hadoop-aws and aws-java-sdk libraries are missing here, but we"},{"line_number":12,"context_line":"# cannot copy them from the Hadoop folder on-disk due to"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_a66c8436","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":37},"updated":"2019-02-08 19:49:15.000000000","message":"comment not needed (it\u0027s just Spark)","commit_id":"d463cf58f3a70260211077771ae0957a89556195"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"7a054b19c4bdc4a566a0ea1dc370326b610fd854","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# For both Spark and Vanilla plugins:"},{"line_number":10,"context_line":"# (The s3a driver in hadoop-aws 2.6.5 is too buggy to be redeemed)"},{"line_number":11,"context_line":"# The hadoop-aws and aws-java-sdk libraries are missing here, but we"},{"line_number":12,"context_line":"# cannot copy them from the Hadoop folder on-disk due to"},{"line_number":13,"context_line":"# version/patching issues"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_c6674851","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":66},"updated":"2019-02-08 19:49:15.000000000","message":"because we are only building versions of Spark where $SPARK_HADOOP_DL is already higher than 2.6, this comment is outdated and not needed","commit_id":"d463cf58f3a70260211077771ae0957a89556195"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"140f75c1fa36fb686046776c8284265ea3ce9d33","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# The hadoop-aws and aws-java-sdk libraries are missing here, but we"},{"line_number":12,"context_line":"# cannot copy them from the Hadoop folder on-disk due to"},{"line_number":13,"context_line":"# version/patching issues"},{"line_number":14,"context_line":"wget https://tarballs.openstack.org/sahara-extra/dist/common-artifacts/hadoop-aws-2.7.3.jar -O $SPARK_JARS_DIR_PATH/hadoop-aws.jar"},{"line_number":15,"context_line":"wget http://central.maven.org/maven2/com/amazonaws/aws-java-sdk/1.7.4/aws-java-sdk-1.7.4.jar -O $SPARK_JARS_DIR_PATH/aws-java-sdk.jar"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_69c50d3c","line":14,"updated":"2019-02-08 21:01:40.000000000","message":"curl -sS ... -o","commit_id":"d463cf58f3a70260211077771ae0957a89556195"}],"sahara_plugin_spark/plugins/spark/resources/images/image.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ea30e1c25701f916f3dfca55694dc522e90915d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"arguments:"},{"line_number":2,"context_line":"  plugin_version:"},{"line_number":3,"context_line":"    description: The version of Spark to install. Defaults to 2.2.1"},{"line_number":4,"context_line":"    default: 2.2.1"},{"line_number":5,"context_line":"    choices:"},{"line_number":6,"context_line":"      - 2.2.1"},{"line_number":7,"context_line":"      - 2.2.0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_36e842e0","line":4,"updated":"2019-02-15 17:46:49.000000000","message":"I think I asked also in the original review, but I didn\u0027t find the answer: what about 2.3.x?","commit_id":"6784247d85051f0c29d8ab9516f31665421468c8"}]}