)]}'
{"specs/liberty/recommend-configuration.rst":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"a3d8f3a654e902769e7c6b52cc22e290899c591a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"most important configurations in dependency cluster specification:"},{"line_number":29,"context_line":"available disk space, ram, cpu, and so on. Such calculator already"},{"line_number":30,"context_line":"implemented in Ambari (see [1] and [2]), and we can use it as well. We should"},{"line_number":31,"context_line":"have ability to switch off autoconfiguration and if user also manually"},{"line_number":32,"context_line":"configured some hadoop config, autoconfiguration also will not be applied."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The following list of configs will be configured, using formulas from [1] and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_87c4b092","line":31,"updated":"2015-04-22 19:23:41.000000000","message":"\"switch off autoconfiguration\" is mentioned below too, under REST api.\n\nIf this is a default that applies to cluster creation, can we just set \"sahara.autoconfigure \u003d False\" in a cluster config, and default it to True? In that case there is no REST change (beyond the config)\n\nFor the client, it could be an arg like --noautoconfig\n\nIs this what you were thinking, or something else?","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"4dfbe5bd4fb38e9e3f4e687a173f0bcd1618acef","unresolved":false,"context_lines":[{"line_number":28,"context_line":"most important configurations in dependency cluster specification:"},{"line_number":29,"context_line":"available disk space, ram, cpu, and so on. Such calculator already"},{"line_number":30,"context_line":"implemented in Ambari (see [1] and [2]), and we can use it as well. We should"},{"line_number":31,"context_line":"have ability to switch off autoconfiguration and if user also manually"},{"line_number":32,"context_line":"configured some hadoop config, autoconfiguration also will not be applied."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The following list of configs will be configured, using formulas from [1] and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_2d9ca568","line":31,"in_reply_to":"bab921fb_87c4b092","updated":"2015-04-22 20:17:02.000000000","message":"Hm, looks nice. As we create cluster from json, there is no sense --noautoconfig, just set this appropriate value in json.","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"00e3e9e45059353c4bdac5fe6b11e48c0bc2989b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* mapreduce.reduce.memory.mb"},{"line_number":45,"context_line":"* mapreduce.map.java.opts"},{"line_number":46,"context_line":"* mapreduce.reduce.java.opts"},{"line_number":47,"context_line":"* mapreduce.task.io.sort.mb"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dac4157f_35234ba9","line":47,"updated":"2015-04-22 16:23:57.000000000","message":"when autoconfiguration is enabled, these values will be modified in the workflow.xml?","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"43c005e97ec48469be521db0c03d4c35fbb3223c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* mapreduce.reduce.memory.mb"},{"line_number":45,"context_line":"* mapreduce.map.java.opts"},{"line_number":46,"context_line":"* mapreduce.reduce.java.opts"},{"line_number":47,"context_line":"* mapreduce.task.io.sort.mb"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_12c7bc13","line":47,"in_reply_to":"bab921fb_673e3cba","updated":"2015-04-22 20:04:03.000000000","message":"ah, right. that makes sense.","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"a3d8f3a654e902769e7c6b52cc22e290899c591a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* mapreduce.reduce.memory.mb"},{"line_number":45,"context_line":"* mapreduce.map.java.opts"},{"line_number":46,"context_line":"* mapreduce.reduce.java.opts"},{"line_number":47,"context_line":"* mapreduce.task.io.sort.mb"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_673e3cba","line":47,"in_reply_to":"dac4157f_35234ba9","updated":"2015-04-22 19:23:41.000000000","message":"Mike, these are cluster creation configs, I believe. They affect the service. I think  you *can* set them in a job, but not sure how many of them would have an effect on a service that is already running.","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"6e0b109e8dc74ce04cff8ef09fc7f60f776b5d0a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"REST API impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_07140bf3","line":57,"updated":"2015-04-23 08:14:31.000000000","message":"I think should add new column in DB.","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"05bc87d834d72efb577362cef2a47c9a1be536fe","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"REST API impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_ba9c4d6a","line":57,"in_reply_to":"bab921fb_07140bf3","updated":"2015-04-23 11:54:07.000000000","message":"Done","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"9b2d42e48c6b6f4016b6293e0672d437d4d9d65e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"REST API impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_e7d117fd","line":57,"in_reply_to":"bab921fb_07140bf3","updated":"2015-04-23 08:24:39.000000000","message":"you mean \"auto config\" with Boolean type? it\u0027s not clear, really.","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"1ec621c3e358745c6015643041e560249f0d5e29","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"REST API impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_a74e7fbf","line":57,"in_reply_to":"bab921fb_e7d117fd","updated":"2015-04-23 08:31:17.000000000","message":"yes, exactly.","commit_id":"7b578fa4bbe86de959533d58d28861670bd6b0f4"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"5cd919fb9c1fa6161776fa2bfc3bea1b965bfd78","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  HDP 2.0.6;"},{"line_number":118,"context_line":"* Provide ability to switch off autoconfiguration via UI;"},{"line_number":119,"context_line":"* Provide ability to switch off autoconfiguration via saharaclient."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dependencies"},{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3acd31a7_51304c01","line":120,"updated":"2015-05-01 17:16:59.000000000","message":"Should the UI hide the \"autoconfig\" checkbox for plugins that do not support \"autoconfig\"?  ie: Spark, Storm?\n\nIf so, it might be useful to have a a call available to the UI that will get supported optional features.\n\nOr, is this autoconfig option going to be just another part of the configs supplied by the plugin (and will automatically appear on the config page)?","commit_id":"1d5b6a9fc240ec59b5dbb32794d1edc6e83e9060"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"3f453a57f487e8c48a7f736882b24ae25d964c2a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  HDP 2.0.6;"},{"line_number":118,"context_line":"* Provide ability to switch off autoconfiguration via UI;"},{"line_number":119,"context_line":"* Provide ability to switch off autoconfiguration via saharaclient."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dependencies"},{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a0c5dc1_84d817f1","line":120,"in_reply_to":"3acd31a7_51304c01","updated":"2015-05-12 09:36:55.000000000","message":"I think, that it\u0027s good idea to just ignore checkbox for unsupported plugins. Otherwise, we need new endpoint about supported plugins","commit_id":"1d5b6a9fc240ec59b5dbb32794d1edc6e83e9060"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"fce4558a255ec50993ea8a59e6fd963839a4d402","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Need to add new checkbox which will allow to swith off autoconfiguration from"},{"line_number":96,"context_line":"Horizon during cluster creation/scaling. If plugin doesn\u0027t support autoconfig"},{"line_number":97,"context_line":"this checkbox will be ignored."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Implementation"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_f63f77d4","line":97,"updated":"2015-05-12 14:59:09.000000000","message":"maybe if the plugin doesn\u0027t support autoconfig the checkbox could be disabled?","commit_id":"8ff2570dbb85e1ebd4a9367a77666424071f8de0"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"b10d8ad16727349589b0122eca46d8c7c9ea2b56","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Need to add new checkbox which will allow to swith off autoconfiguration from"},{"line_number":96,"context_line":"Horizon during cluster creation/scaling. If plugin doesn\u0027t support autoconfig"},{"line_number":97,"context_line":"this checkbox will be ignored."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Implementation"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_8268c788","line":97,"in_reply_to":"9a0c5dc1_f63f77d4","updated":"2015-05-13 14:51:15.000000000","message":"Done","commit_id":"8ff2570dbb85e1ebd4a9367a77666424071f8de0"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"fab6783940c156c99a666e0bd0e75deb88d8bf7f","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Need to add new checkbox which will allow to swith off autoconfiguration from"},{"line_number":96,"context_line":"Horizon during cluster creation/scaling. If plugin doesn\u0027t support autoconfig"},{"line_number":97,"context_line":"this checkbox will be ignored."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Implementation"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_ac06461e","line":97,"in_reply_to":"9a0c5dc1_f63f77d4","updated":"2015-05-12 19:07:28.000000000","message":"Not sure about this. In that case it became too complicated, I think. We will need new endpoint to get supported plugins, and so on. I think, that we can document that feature don\u0027t works for few plugins.","commit_id":"8ff2570dbb85e1ebd4a9367a77666424071f8de0"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"f22c8088956084792f253886ae0c0f775128e85e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"It\u0027s required to add new column ``use_autoconfig`` to cluster object in DB."},{"line_number":61,"context_line":"By default ``use_autoconfig`` will be ``True``. If ``use_autoconfig`` is"},{"line_number":62,"context_line":"``False``, then we will not use autoconfiguration during cluster creation."},{"line_number":63,"context_line":"If all configs from list above is not configured manually and"},{"line_number":64,"context_line":"``use_autoconfig`` is ``True``, then we will autoconfigure configs from list"},{"line_number":65,"context_line":"above."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a0c5dc1_0f274eb7","line":63,"updated":"2015-05-13 20:51:00.000000000","message":"Based on my understanding from the code CR, I think this sentence is clearer as:\n\n\"If none of the configs from the list above are configured manually ...\"\n\nSo if a user sets 1, they are responsible for all. That is the intent so far ...\n\nbut why not auto configure ANY from the list that have NOT been specified?  If the user really wants control, they can set the autoconfigure flag to False and set only the ones they choose.\n\nThat way, I could manually set one or two parameters, leave use_autoconfig set to True, and let Sahara recommend the ones from the list that I have not specified.","commit_id":"d68447eb44947aa99c0a22f843155fde01ddb5a7"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"5f672bc7c7551a5286645da7e24f0e8ed789f900","unresolved":false,"context_lines":[{"line_number":60,"context_line":"It\u0027s required to add new column ``use_autoconfig`` to cluster object in DB."},{"line_number":61,"context_line":"By default ``use_autoconfig`` will be ``True``. If ``use_autoconfig`` is"},{"line_number":62,"context_line":"``False``, then we will not use autoconfiguration during cluster creation."},{"line_number":63,"context_line":"If all configs from list above is not configured manually and"},{"line_number":64,"context_line":"``use_autoconfig`` is ``True``, then we will autoconfigure configs from list"},{"line_number":65,"context_line":"above."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a016987_1552e967","line":63,"in_reply_to":"9a0c5dc1_0f274eb7","updated":"2015-05-15 08:56:45.000000000","message":"Hi Trevor. Your idea is good, but I see two problems with this idea.\n\n1) User will not know, which value will be provided for some config during autoconfiguration\n\n2) For example, we have 8 autocofigurable configs. User want to set 2 configs out of this 8 configs manually, for 1 config we want to use default value, \nand for other 5 provided via autoconfiguration. But as result for config, for which user wants default value we will get value, provided via autoconfiguration, because it will not be pushed to cluster.cluster_configs data.\n\nSo, in that case I would prefer current proposal - just switch off autoconfig if some value is provided manually","commit_id":"d68447eb44947aa99c0a22f843155fde01ddb5a7"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"ce510fcbdfeb672fa16ce3944c5475f1820603c7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"---------------------------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Need to add new checkbox which will allow to swith off autoconfiguration from"},{"line_number":96,"context_line":"Horizon during cluster creation/scaling. If plugin doesn\u0027t support autoconfig"},{"line_number":97,"context_line":"this checkbox will not be displayed. We can use ``_info`` field at [3] for"},{"line_number":98,"context_line":"this purpose."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3afb71cf_857bf58b","line":96,"updated":"2015-06-09 12:27:49.000000000","message":"How Horizon will understand that plugin doesn\u0027t support it?","commit_id":"a1dd21f24cda10ba075f5cf8dd939cfa6c58651f"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"3bea1c499b1591ee83e34d23d450a926d3645a86","unresolved":false,"context_lines":[{"line_number":93,"context_line":"---------------------------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Need to add new checkbox which will allow to swith off autoconfiguration from"},{"line_number":96,"context_line":"Horizon during cluster creation/scaling. If plugin doesn\u0027t support autoconfig"},{"line_number":97,"context_line":"this checkbox will not be displayed. We can use ``_info`` field at [3] for"},{"line_number":98,"context_line":"this purpose."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3afb71cf_9a38ebf0","line":96,"in_reply_to":"3afb71cf_857bf58b","updated":"2015-06-09 14:12:33.000000000","message":"Added some info about that","commit_id":"a1dd21f24cda10ba075f5cf8dd939cfa6c58651f"},{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"f25e1990801c86ba8d83d5619f088f9c3e1e74a3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"-----------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"It\u0027s required to add new column ``use_autoconfig`` to cluster object in DB."},{"line_number":61,"context_line":"By default ``use_autoconfig`` will be ``True``. If ``use_autoconfig`` is"},{"line_number":62,"context_line":"``False``, then we will not use autoconfiguration during cluster creation."},{"line_number":63,"context_line":"If none of the configs from the list above are configured manually and"},{"line_number":64,"context_line":"``use_autoconfig`` is ``True``, then we will autoconfigure configs from list"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3afb71cf_2a2d0295","line":61,"updated":"2015-06-10 07:18:48.000000000","message":"It really bothers me that we setup this parameter to True by default. I think it\u0027s not necessary for Sahara to force current users with auto configuration. Users who already have their predefined sahara cluster and node group templates and then just after upgrade....wow... he has a set of new auto-defined parameters which he didn\u0027t care before.","commit_id":"051cdc8168a17ec6f1be29358d021de9e130d521"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"d4004a47be4287b27988e5b8e81dd818be7eccec","unresolved":false,"context_lines":[{"line_number":67,"context_line":"REST API impact"},{"line_number":68,"context_line":"---------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Need to support of switch on autoconfiguration."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Other end user impact"},{"line_number":73,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3afb71cf_d99effb7","line":70,"updated":"2015-06-11 15:53:33.000000000","message":"We were discussing, that it\u0027ll be great to support exposing info about list of the configs that will be auto-tuned through the plugin/specific_version API. What do you think about adding it here? It\u0027ll be great to show end users on the Horizon side the list of configs that\u0027ll be tuned.","commit_id":"7fa9ec7345b372afc1fb8d9efea210975cbbc592"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"edde19214dbfd5a4b512b12340bfe466b3aec5cb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"REST API impact"},{"line_number":68,"context_line":"---------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Need to support of switch on autoconfiguration."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Other end user impact"},{"line_number":73,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3afb71cf_956723ea","line":70,"in_reply_to":"3afb71cf_d99effb7","updated":"2015-06-11 18:22:29.000000000","message":"Please, see 98 - 101","commit_id":"7fa9ec7345b372afc1fb8d9efea210975cbbc592"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"e7b9fb7f8a2af43a5ebf16d57a77960635c8c055","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Now users manually should configure most important hadoop configs. We can"},{"line_number":21,"context_line":"provide advices about cluster configuration and automatically configure"},{"line_number":22,"context_line":"few configs."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Proposed change"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa32b979_940ddfe9","line":22,"updated":"2015-06-19 04:06:08.000000000","message":"i think this could be better crafted instead of a repeat of the abstract. basically i would like to see why this is a problem, for example \"the configurations are complicated and not all users know them, we can recommend some basic configs that will improve user experience...\".","commit_id":"807b5cbb3fba5edb0b0bfacfa04f179e6a92d599"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"e7b9fb7f8a2af43a5ebf16d57a77960635c8c055","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* mapreduce.task.io.sort.mb"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Also as a simple example we can autoconfigure ``dfs.replication`` if amout of"},{"line_number":49,"context_line":"``datanodes`` less than default value."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Also it\u0027s required to add new plugin SPI method ``recommend_configs`` which"},{"line_number":52,"context_line":"will autoconfigure cluster configs."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa32b979_d4d5a71b","line":49,"updated":"2015-06-19 04:06:08.000000000","message":"should this mention checking against the cluster validation for number of datanodes, or can we allow the cluster to just fail validation in that case?","commit_id":"807b5cbb3fba5edb0b0bfacfa04f179e6a92d599"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"c417b2502aba8b3128a338df0858d75bc63da704","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_b36ee794","line":72,"updated":"2015-06-19 13:34:06.000000000","message":"What happens if we have some configs manually set and autoconfig \u003d\u003d True?","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"ca3ae40500a146cdf4444c80bef24ca1f178ee18","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_efe58da3","line":72,"in_reply_to":"fa32b979_006bf785","updated":"2015-06-25 09:01:12.000000000","message":"Ethan, I don\u0027t think that raising exception (error) is a good idea. For example, that will broke all templates that was created before this change. But for current approach we still can use all templates as well.\n\nAs a solution, we can add some description for checkbox, like following: (This checkbox enables autoconfiguration for some configs, but if you manually configured some options, it may switch off autonconfiguration for cluster)","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"88e4553747be62958f651857a3bb9816d230d4f0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_ee9c845f","line":72,"in_reply_to":"fa32b979_33f2d770","updated":"2015-06-19 13:53:42.000000000","message":"I get that, my question is if the user sets some configurations but not all and set autoconfig as True, does the whole configuration comes from autoconfig or it just fill the gaps?","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"462f5f369cde75559193c6a59f9e0039bc4f0ade","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_006bf785","line":72,"in_reply_to":"fa32b979_3e23fe59","updated":"2015-06-24 19:42:00.000000000","message":"Should we return an error to the user if any of the above configs are set manually and ``use_autoconfig`` is ``True``? It seems like this might be confusing otherwise; the user might expect the configs he/she set to be implemented.\n\nDon\u0027t think this is worth a -1, and the spec looks good (as do some of the patches), but it\u0027s worth thinking about.","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"75340eb90ad39f219999906af1e9255ad1cfe86e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_e8f63c5c","line":72,"in_reply_to":"fa32b979_48fba87b","updated":"2015-06-23 16:22:57.000000000","message":"If I will create cluster from UI, I cannot use default value as user-input. That is general reason for that.","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"5056aea36291e94c30ea73c83a450255495471cf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_48fba87b","line":72,"in_reply_to":"fa32b979_93c7c711","updated":"2015-06-23 16:18:20.000000000","message":"Ok. So the user will need to configure the whole thing if he wants to set just a single configuration. I don\u0027t really like that. I think that the autoconfig should fill the gaps (complete what the user left blank)","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"6fae3f0c4a040d007d79a7da88c439f56b87b8ec","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_33f2d770","line":72,"in_reply_to":"fa32b979_b36ee794","updated":"2015-06-19 13:42:28.000000000","message":"See up, it\u0027s written that \"If none of the configs from the list above are\nconfigured manually and ``use_autoconfig`` is ``True``, then we will\nautoconfigure configs from list above\"","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"64460af3d0d840dd9ee2f4ac7bbffdebdabc087a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_3e23fe59","line":72,"in_reply_to":"fa32b979_e8f63c5c","updated":"2015-06-23 16:52:02.000000000","message":"Ok, got it.","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"33d75e2b361e6bea6eb69f75221b40bb9d99e317","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_93c7c711","line":72,"in_reply_to":"fa32b979_ee9c845f","updated":"2015-06-23 02:34:06.000000000","message":"Telles, we will not use autoconfiguration at this case.","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"dab176ebe27d23f178d303ba147f68a30804d491","unresolved":false,"context_lines":[{"line_number":69,"context_line":"during cluster creation. If none of the configs from the list above are"},{"line_number":70,"context_line":"configured manually and ``use_autoconfig`` is ``True``, then we will"},{"line_number":71,"context_line":"autoconfigure configs from list above. Same behaviour will be used for"},{"line_number":72,"context_line":"node_groups configs autoconfiguration."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_3fcfa780","line":72,"in_reply_to":"fa32b979_ee9c845f","updated":"2015-06-22 21:58:14.000000000","message":"from looking at the code review, i think that in this case it will prefer the autoconfig over the previously defined config, but i\u0027m not 100% sure on that.\n\nis this accurate Vitaly?","commit_id":"1b0303e1bb8da2d908b1ba07238168b5e48b9cfd"}]}